- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Catching Exceptions without any notice

by Aliaksei Syrel

Thanks for feedback :) Indeed, this is a nice case to learn from. That piece of code was written when I just started working with pharo after coming from Java world. Purpose of that catch, as mentioned by Nicolai, is indeed to ignore late initialized objects. For example, imagine a Morph with height that is equal to owner's height. In this case one would write in #initialize: initialize self height: [ :morph | morph owner height ]. After setting an object as a new height, it gets evaluated and in case of example before throws DNU because owner is obviously still nil. Trying to improve overall readability I decided to ignore all errors in that kind of blocks instead of putting ifNil:ifNotNil: in hundred places. Also, I could not imagine that Warning is actually an Exception and exception (in its common sense) is an Error. However, I had in mind that later that kind of code smell should be replaced at least by custom error handler, like we have now in spotter that catches all errors allowing not buggy processors to do their work. Btw, in first versions of spotter it was the same: it catched exception instead of error but more experienced colleges suggested to not do it like that. Nevertheless, later I realized that blocks are evil, and instead of trying to work with nils it's much easier and cleaner to just put an assertion. As a hotfix, I will replace Exception to Error tomorrow. (bad, but still...) Don't hesitate to post code smells, at least we can make jokes of them :) Cheers Alex On Mar 30, 2016 1:34 PM, "Nicolai Hess" <nicolaihess(a)gmail.com> wrote: > Please don't do this: > > updateHeight > "no need to care about height, when it's logic is not customized" > self layout isHeightCustom ifFalse: [ ^ self ]. > [ self bounds: (self brickBounds withHeight: self customHeight) ] > on: Exception > do: [ "just skip and do nothing" ] > > This makes debugging GLM/Brick ui/layout code with "self haltOnce" > impossible. > see > GLMBrickGeometryTrait>>#updateHeight > GLMBrickGeometryTrait>>#updateWidth > > And if you log out the raised exception, you see some calls to > not initialized fonts and a ZeroDevide and some more errors. > The above catch, catches and hides wrong / to late initialized objects. >

April 1, 2016

Re: [Pharo-dev] Catching Exceptions without any notice

by Igor Stasenko

On 1 April 2016 at 09:53, Tudor Girba <tudor(a)tudorgirba.com> wrote: > Hi, > > Nice to hear from you Igor. I am glad to see you around here. > > Hi, Doru. Yeah, i am considering whether i want to return to things i left, or not. So, expect more of my acid sarcasm in future. Maybe :) > I do not see how your quote applies to the current case given that the > original authors did not leave anywhere, but perhaps it was a joke, and I > did not get it. > > We all will leave sooner or later. The only what matters is what we left behind :) > Cheers, > Doru > > > > On Apr 1, 2016, at 5:54 AM, Igor Stasenko <siguctua(a)gmail.com> wrote: > > > > A perfect example of careless programming. > > "I'll do it my way, and if it causing any problems, i don't care and i > will just ignore them. And it's not my problem anyways, i went to something > else already, since this part is works and DONE" > > :) > > > > On 30 March 2016 at 14:33, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > Please don't do this: > > > > updateHeight > > "no need to care about height, when it's logic is not customized" > > self layout isHeightCustom ifFalse: [ ^ self ]. > > [ self bounds: (self brickBounds withHeight: self customHeight) ] > > on: Exception > > do: [ "just skip and do nothing" ] > > > > This makes debugging GLM/Brick ui/layout code with "self haltOnce" > impossible. > > see > > GLMBrickGeometryTrait>>#updateHeight > > GLMBrickGeometryTrait>>#updateWidth > > > > And if you log out the raised exception, you see some calls to > > not initialized fonts and a ZeroDevide and some more errors. > > The above catch, catches and hides wrong / to late initialized objects. > > > > > > > > -- > > Best regards, > > Igor Stasenko. > > -- > www.tudorgirba.com > www.feenk.com > > "No matter how many recipes we know, we still value a chef." > > > > > > > > > -- Best regards, Igor Stasenko.

April 1, 2016

Re: [Pharo-dev] Catching Exceptions without any notice

by Igor Stasenko

On 1 April 2016 at 21:52, stepharo <stepharo(a)free.fr> wrote: > Hi > > I do not think that aliaksei is not taking care. > He is working a lot to make sure that Pharo will have a future from the UI > perspective. He is spending all his free time > on Bloc and what he is doing is massive. He rewrote the AthensCairoBack > end to optimise it for Bloc local coordinates. > I'm sure that if someone would have propose some help to him he would have > gladly accepted. > > I personnaly thank him for all the energy that he is putting into Bloc. > The talk at PharoDays was showing really nice results. > Bloc is really getting to be really nice and change the face of Pharo for > the next decades so we should encourage people doing > Bloc! > > So instead of bashing someone, I would prefer that we help him. > Yes Pharo has some code that we do not like and I have my own list. Now > the best things to do is to > improve code review and to fix when we see something wrong. > > Hi, Stef. No, it is not about whether you care about things you do or not. It is about approach. If you done something, that good indication that you care about it, isn't? But there's many ways how you doing something. I am sorry, i won't stop bashing approaches like this piece of code demonstrating. It was not a first time you seen my reaction on such piece of code (we seen that before, exactly related to "on:do: nothing" before), and i don't think you shall be surprised that my reaction is unchanged :) My take on this: on-do-nothing pattern is good only for one thing: for bug hunting and putting temporary kludges in code in order to find the root of problem. Once problem is solved, you shall remove this.. as well as any 'Transcript show:' , 'Halt once' and stuff like that. On-do-nothing really don't belongs to category of any production code that pretends to be a good quality one. Stef > > > Le 1/4/16 05:54, Igor Stasenko a Ã©crit : > > A perfect example of careless programming. > "I'll do it my way, and if it causing any problems, i don't care and i > will just ignore them. And it's not my problem anyways, i went to something > else already, since this part is works and DONE" > :) > > On 30 March 2016 at 14:33, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > >> Please don't do this: >> >> updateHeight >> "no need to care about height, when it's logic is not customized" >> self layout isHeightCustom ifFalse: [ ^ self ]. >> [ self bounds: (self brickBounds withHeight: self customHeight) ] >> on: Exception >> do: [ "just skip and do nothing" ] >> >> This makes debugging GLM/Brick ui/layout code with "self haltOnce" >> impossible. >> see >> GLMBrickGeometryTrait>>#updateHeight >> GLMBrickGeometryTrait>>#updateWidth >> >> And if you log out the raised exception, you see some calls to >> not initialized fonts and a ZeroDevide and some more errors. >> The above catch, catches and hides wrong / to late initialized objects. >> > > > > -- > Best regards, > Igor Stasenko. > > > -- Best regards, Igor Stasenko.

April 1, 2016

Re: [Pharo-dev] Catching Exceptions without any notice

by stepharo

Hi I do not think that aliaksei is not taking care. He is working a lot to make sure that Pharo will have a future from the UI perspective. He is spending all his free time on Bloc and what he is doing is massive. He rewrote the AthensCairoBack end to optimise it for Bloc local coordinates. I'm sure that if someone would have propose some help to him he would have gladly accepted. I personnaly thank him for all the energy that he is putting into Bloc. The talk at PharoDays was showing really nice results. Bloc is really getting to be really nice and change the face of Pharo for the next decades so we should encourage people doing Bloc! So instead of bashing someone, I would prefer that we help him. Yes Pharo has some code that we do not like and I have my own list. Now the best things to do is to improve code review and to fix when we see something wrong. Stef Le 1/4/16 05:54, Igor Stasenko a Ã©crit : > A perfect example of careless programming. > "I'll do it my way, and if it causing any problems, i don't care and i > will just ignore them. And it's not my problem anyways, i went to > something else already, since this part is works and DONE" > :) > > On 30 March 2016 at 14:33, Nicolai Hess <nicolaihess(a)gmail.com > <mailto:nicolaihess@gmail.com>> wrote: > > Please don't do this: > > updateHeight > "no need to care about height, when it's logic is not customized" > self layout isHeightCustom ifFalse: [ ^ self ]. > [ self bounds: (self brickBounds withHeight: self customHeight) ] > on: Exception > do: [ "just skip and do nothing" ] > > This makes debugging GLM/Brick ui/layout code with "self haltOnce" > impossible. > see > GLMBrickGeometryTrait>>#updateHeight > GLMBrickGeometryTrait>>#updateWidth > > And if you log out the raised exception, you see some calls to > not initialized fonts and a ZeroDevide and some more errors. > The above catch, catches and hides wrong / to late initialized > objects. > > > > > -- > Best regards, > Igor Stasenko.

April 1, 2016

Re: [Pharo-dev] [ANN] OS-Linux-CentOS

by stepharo

Hi torsten I'm trying to understand what you are doing? Are you use OSSubprocess? We will have one student starting to work on replacing bash scripts by pharo :) Stef Le 31/3/16 18:31, Torsten Bergmann a Ã©crit : > Hi, > > the OS-xxx series with (so far) > > - OS-Windows > - OS-Linux-Ubuntu > - OS-Unix > - OS-Raspbian > > now has a new member called "OS-Linux-CentOS" which is more or less an adopted/customized > pendant to "OS-Linux-Ubuntu". > > Project page is at http://www.smalltalkhub.com/#!/~OS/OS-Linux-CentOS > > Ready for Pharo 5. As ever you can load from Catalog tool or directly by entering "CentOS" > into the Spotter search tool. > > Enjoy the video: > > https://www.youtube.com/watch?v=nAwtVeoll_k > > Bye > T. > > >

April 1, 2016

[Pharo5] [Issue tracker] Acton needed: Check issues tagged Pharo5

by Marcus Denker

Hi, The plan is to release Pharo5 soon (End of April, if possible). We have now 144 issues tagged for Pharo5, 41 of those âmust fixâ or higher. We need to go though all the 144 issues and decide: âIs this bug to bad that it does not allow for a release?â If not, we should move it to milestone âLaterâ. https://pharo.fogbugz.com/f/filters/125/5-0-All It would be good if either the original submitter or people involved in the discussion of those issues would have a look and help with taking this decision. (And of course, if you have potentialy show stopping bugs that are not in the list, this is the time to add themâ¦) Marcus

April 1, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50673 Home: https://github.com/pharo-project/pharo-core

April 1, 2016

[pharo-project/pharo-core] a263af: 50673

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: a263afdfbce0dd993f80824f2fe504bd6ca11a20 https://github.com/pharo-project/pharo-core/commit/a263afdfbce0dd993f80824f… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-04-01 (Fri, 01 Apr 2016) Changed paths: A Athens-Cairo.package/AthensCairoCanvas.class/instance/private/primSetDashesLengths_count_offset_.st M Athens-Cairo.package/AthensCairoCanvas.class/instance/private/primSetLineCap_.st M Athens-Cairo.package/AthensCairoCanvas.class/instance/private/primSetLineJoin_.st M Athens-Cairo.package/AthensCairoCanvas.class/instance/private/primSetLineWidth_.st A Athens-Cairo.package/AthensCairoCanvas.class/instance/private/primSetSource_.st M Athens-Cairo.package/AthensCairoMatrix.class/instance/transformations/translateBy_.st M Athens-Cairo.package/AthensCairoPatternPaint.class/instance/drawing/athensLoadOn_.st M Athens-Cairo.package/AthensCairoPatternPaint.class/instance/drawing/loadOnCairoCanvas_.st M Athens-Cairo.package/AthensCairoPatternPaint.class/instance/primitives/primSetSourceOn_.st M Athens-Cairo.package/AthensCairoStrokePaint.class/instance/private/prepareForDrawingOn_.st M Athens-Cairo.package/AthensCairoStrokePaint.class/instance/private/setDashesOn_.st R Athens-Cairo.package/AthensCairoSurface.class/class/library path/ffiLibraryName.st R Athens-Cairo.package/TCairoLibrary.class/class/library path/nbLibraryNameOrHandle.st M ConfigurationOfAthens.package/ConfigurationOfAthens.class/instance/symbolic versions/stable_.st A ConfigurationOfAthens.package/ConfigurationOfAthens.class/instance/versions/version391_.st A ConfigurationOfAthens.package/ConfigurationOfAthens.class/instance/versions/version392_.st M Metacello-GitBasedRepository.package/MCGitBasedNetworkRepository.class/class/initialization/initialize.st A Metacello-GitHub.package/MCGitHubRepository.class/class/initialization/initialize.st R Metacello-GitHub.package/MCGitHubRepository.class/class/initialize-release/initialize.st R Metacello-GitHub.package/MCGitHubRepository.class/class/initialize-release/release.st M Metacello-GitHub.package/MCGitHubRepository.class/instance/private/downloadJSONTags.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50672.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50673.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50672.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50673.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50673 17887 Update startup of metacello to use the session manager https://pharo.fogbugz.com/f/cases/17887 17922 Update Athens 3.9.2 https://pharo.fogbugz.com/f/cases/17922 http://files.pharo.org/image/50/50673.zip

April 1, 2016

Re: [Pharo-dev] Catching Exceptions without any notice

by Tudor Girba

Hi, Nice to hear from you Igor. I am glad to see you around here. I do not see how your quote applies to the current case given that the original authors did not leave anywhere, but perhaps it was a joke, and I did not get it. Cheers, Doru > On Apr 1, 2016, at 5:54 AM, Igor Stasenko <siguctua(a)gmail.com> wrote: > > A perfect example of careless programming. > "I'll do it my way, and if it causing any problems, i don't care and i will just ignore them. And it's not my problem anyways, i went to something else already, since this part is works and DONE" > :) > > On 30 March 2016 at 14:33, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > Please don't do this: > > updateHeight > "no need to care about height, when it's logic is not customized" > self layout isHeightCustom ifFalse: [ ^ self ]. > [ self bounds: (self brickBounds withHeight: self customHeight) ] > on: Exception > do: [ "just skip and do nothing" ] > > This makes debugging GLM/Brick ui/layout code with "self haltOnce" impossible. > see > GLMBrickGeometryTrait>>#updateHeight > GLMBrickGeometryTrait>>#updateWidth > > And if you log out the raised exception, you see some calls to > not initialized fonts and a ZeroDevide and some more errors. > The above catch, catches and hides wrong / to late initialized objects. > > > > -- > Best regards, > Igor Stasenko. -- www.tudorgirba.com www.feenk.com "No matter how many recipes we know, we still value a chef."

April 1, 2016

Re: [Pharo-dev] Catching Exceptions without any notice

by Igor Stasenko

A perfect example of careless programming. "I'll do it my way, and if it causing any problems, i don't care and i will just ignore them. And it's not my problem anyways, i went to something else already, since this part is works and DONE" :) On 30 March 2016 at 14:33, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > Please don't do this: > > updateHeight > "no need to care about height, when it's logic is not customized" > self layout isHeightCustom ifFalse: [ ^ self ]. > [ self bounds: (self brickBounds withHeight: self customHeight) ] > on: Exception > do: [ "just skip and do nothing" ] > > This makes debugging GLM/Brick ui/layout code with "self haltOnce" > impossible. > see > GLMBrickGeometryTrait>>#updateHeight > GLMBrickGeometryTrait>>#updateWidth > > And if you log out the raised exception, you see some calls to > not initialized fonts and a ZeroDevide and some more errors. > The above catch, catches and hides wrong / to late initialized objects. > -- Best regards, Igor Stasenko.

April 1, 2016