- Pharo-dev - lists.pharo.org

Merging refactoring changes

by Peter UhnÃ¡k

Is it possible to merge changesets? For example when I am creating a new class and adding a new instance variable, I would like to see it as one change set, not two. Similarly if I am overriding a method twice, it would be good to see only what actually gets applied. For example ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ " Sandbox removeFromSystem. " (model := RBNamespace new) name: 'ChangeSet'. r1 := RBAddClassRefactoring model: model addClass: #Sandbox superclass: Object subclasses: #() category: #Sandbox. r1 primitiveExecute. r2 := RBAddInstanceVariableRefactoring model: model variable: 'attr' class: #Sandbox. r2 primitiveExecute. r3 := RBAddMethodRefactoring model: model addMethod: 'attr' toClass: #Sandbox inProtocols: 'accessing'. r3 transform. r4 := RBAddMethodRefactoring model: model addMethod: 'attr ^ attr' toClass: #Sandbox inProtocols: 'accessing'. r4 transform. (ChangesBrowser changes: model changes changes) open. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I will get four changes â But the second (top right) could be merged into the first one, and the third one (bottom left) is superfluous. So ideally I would like to have â Is it possible to merge it in such a way? Thanks, Peter

April 16, 2016

GTDebugger shortcuts usability

by Peter UhnÃ¡k

Hi, I'm getting fed-up with GTDebugger shortcuts since they are completely random. Can we have them more meaningful and/or somehow visible? For now I ended up overriding the labels so I can at least see them... but doing this is also stupid, because I still have to look at them since I cannot remember random shortcuts. â 1. can we unify the shift vs ctrl+shift nonsense? (I'm using linux btw) 2. can we use the default shortcuts pattern where one of the letters is underlined? Peter

April 16, 2016

Re: [Pharo-dev] RBRefactoring docs

by Jan van de Sandt

Hi, I think this is the original documentation: http://www.refactory.com/tools/refactoring-browser Jan. On Sat, Apr 16, 2016 at 5:42 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > Hi, > > is there any documentation for RBRefactoring? > Since there are not even class comments the only thing I found is judging > from tests. > > Thanks, > Peter >

April 16, 2016

Re: [Pharo-dev] RBRefactoring docs

by stepharo

>> Hi, >> >> is there any documentation for RBRefactoring? > > Yes, there is, with examples and all. It used to be a chapter in one > of the Pharo books, but it seems to have vanished. > > I forked one of the books to be able to recover the refactoring chapter. I would be good to push the comment back in the class. >> Since there are not even class comments the only thing I found is >> judging from tests. > > That one also helps. Yes and we should improve them. > > Thierry > >> Thanks, >> Peter > > >

April 16, 2016

Re: [Pharo-dev] RBRefactoring docs

by Thierry Goubier

Le 16/04/2016 17:42, Peter UhnÃ¡k a Ã©crit : > Hi, > > is there any documentation for RBRefactoring? Yes, there is, with examples and all. It used to be a chapter in one of the Pharo books, but it seems to have vanished. I forked one of the books to be able to recover the refactoring chapter. > Since there are not even class comments the only thing I found is > judging from tests. That one also helps. Thierry > Thanks, > Peter

April 16, 2016

RBRefactoring docs

by Peter UhnÃ¡k

Hi, is there any documentation for RBRefactoring? Since there are not even class comments the only thing I found is judging from tests. Thanks, Peter

April 16, 2016

Re: [Pharo-dev] Missing #removeDuplicates

by stepharo

Le 16/4/16 15:12, Nicolai Hess a Ã©crit : > > > 2016-04-16 14:50 GMT+02:00 Werner Kassens <wkassens(a)libello.com > <mailto:wkassens@libello.com>>: > > perhaps it is a speed question? using pharo4.0 (with polymath): > a:=DhbVector new: 50 random: 20. > b:=a copy asOrderedCollection . > Smalltalk garbageCollect . > [ b removeDuplicates]bench. "'47,004 per second'" > b:=a copy asArray. > Smalltalk garbageCollect . > [ b asSet asArray ]bench. "'27,249 per second'" > werner > > > the advantage for removeDuplicates ( and maybe the reason it was > implemented) is, it > preserves the order. this would be an argument in favor of having it in addition to avoid double iteration. Now people may also want to use OrderedSet. Stef > > > On 04/16/2016 09:01 AM, stepharo wrote: > > And I do not see why removeDuplicates is less ugly than asSet > asArray. > Just that it is doing two passes. > > Stef > > Le 15/4/16 23:57, Yuriy Tymchuk a Ã©crit : > > > On 11 Apr 2016, at 09:06, Nicolai Hess > <<mailto:nicolaihess@gmail.com > <mailto:nicolaihess@gmail.com>>nicolaihess(a)gmail.com > <mailto:nicolaihess@gmail.com>> wrote: > > > > 2016-04-10 8:55 GMT+02:00 Volkert > <<mailto:volkert@komponentenwerkstatt.de > <mailto:volkert@komponentenwerkstatt.de>>volkert(a)komponentenwerkstatt.de > <mailto:volkert@komponentenwerkstatt.de>>: > > Sorry. i meant AthensSkatch ;-) It is a nice demo > about using athens. > > http://smalltalkhub.com/#!/~NicolaiHess/AthensSketch > <http://smalltalkhub.com/#%21/%7ENicolaiHess/AthensSketch> > > <http://smalltalkhub.com/#%21/%7ENicolaiHess/AthensSketch> > > > > > > Hi Volkert, > I just replaced > #removeDuplicates with > #asSet > (this should work now). > > > I think that it would be nice to have removeDuplicates. > Because > sometimes you need to end up with ordered collection and > then you need > to do something like `obj asSet asArray` and it is ugly. > > Uko > > > (and replaced some deprecated on:send:to: calls (for > Announcements) with > when:send:to: > > in the latest version. > > > Nicolai > > > > > On 10.04.2016 07:42, stepharo wrote: > > > > Le 9/4/16 22:36, Volkert a Ã©crit : > > What happens to > OrderedCollection>>removeDuplicates in > Pharo 5.0? In Pharo 4.0 it was part of a > Package > "GroupManager"? > > > It was probably badly implemented or only used > in group > manager (whose code was terrible) and we > cleaned it. > Now we could reintroduce it but in the right > place and with > tests. > > It breaks the nice Package "AthensScratch" > in Pharo 5.0 > > > what is athenscracth? > > > BW. > Volkert > > > > > > > > > > >

April 16, 2016

Re: [Pharo-dev] Missing #removeDuplicates

by Werner Kassens

yes, that _is_ occasionally an advantage. werner On 04/16/2016 03:12 PM, Nicolai Hess wrote: > > > 2016-04-16 14:50 GMT+02:00 Werner Kassens <wkassens(a)libello.com > <mailto:wkassens@libello.com>>: > > perhaps it is a speed question? using pharo4.0 (with polymath): > a:=DhbVector new: 50 random: 20. > b:=a copy asOrderedCollection . > Smalltalk garbageCollect . > [ b removeDuplicates]bench. "'47,004 per second'" > b:=a copy asArray. > Smalltalk garbageCollect . > [ b asSet asArray ]bench. "'27,249 per second'" > werner > > > the advantage for removeDuplicates ( and maybe the reason it was > implemented) is, it > preserves the order. > > > On 04/16/2016 09:01 AM, stepharo wrote: > > And I do not see why removeDuplicates is less ugly than asSet > asArray. > Just that it is doing two passes. > > Stef > > Le 15/4/16 23:57, Yuriy Tymchuk a Ã©crit : > > > On 11 Apr 2016, at 09:06, Nicolai Hess > <<mailto:nicolaihess@gmail.com > <mailto:nicolaihess@gmail.com>>nicolaihess(a)gmail.com > <mailto:nicolaihess@gmail.com>> wrote: > > > > 2016-04-10 8:55 GMT+02:00 Volkert > <<mailto:volkert@komponentenwerkstatt.de > <mailto:volkert@komponentenwerkstatt.de>>volkert(a)komponentenwerkstatt.de > <mailto:volkert@komponentenwerkstatt.de>>: > > Sorry. i meant AthensSkatch ;-) It is a nice demo > about using athens. > > http://smalltalkhub.com/#!/~NicolaiHess/AthensSketch > > <http://smalltalkhub.com/#%21/%7ENicolaiHess/AthensSketch> > > > > > Hi Volkert, > I just replaced > #removeDuplicates with > #asSet > (this should work now). > > > I think that it would be nice to have removeDuplicates. Because > sometimes you need to end up with ordered collection and > then you need > to do something like `obj asSet asArray` and it is ugly. > > Uko > > > (and replaced some deprecated on:send:to: calls (for > Announcements) with > when:send:to: > > in the latest version. > > > Nicolai > > > > > On 10.04.2016 07:42, stepharo wrote: > > > > Le 9/4/16 22:36, Volkert a Ã©crit : > > What happens to > OrderedCollection>>removeDuplicates in > Pharo 5.0? In Pharo 4.0 it was part of a > Package > "GroupManager"? > > > It was probably badly implemented or only used > in group > manager (whose code was terrible) and we > cleaned it. > Now we could reintroduce it but in the right > place and with > tests. > > It breaks the nice Package "AthensScratch" > in Pharo 5.0 > > > what is athenscracth? > > > BW. > Volkert > > > > > > > > > > >

April 16, 2016

Re: [Pharo-dev] Missing #removeDuplicates

by Nicolai Hess

2016-04-16 14:50 GMT+02:00 Werner Kassens <wkassens(a)libello.com>: > perhaps it is a speed question? using pharo4.0 (with polymath): > a:=DhbVector new: 50 random: 20. > b:=a copy asOrderedCollection . > Smalltalk garbageCollect . > [ b removeDuplicates]bench. "'47,004 per second'" > b:=a copy asArray. > Smalltalk garbageCollect . > [ b asSet asArray ]bench. "'27,249 per second'" > werner > the advantage for removeDuplicates ( and maybe the reason it was implemented) is, it preserves the order. > > On 04/16/2016 09:01 AM, stepharo wrote: > >> And I do not see why removeDuplicates is less ugly than asSet asArray. >> Just that it is doing two passes. >> >> Stef >> >> Le 15/4/16 23:57, Yuriy Tymchuk a Ã©crit : >> >>> >>> On 11 Apr 2016, at 09:06, Nicolai Hess >>>> <<mailto:nicolaihess@gmail.com>nicolaihess(a)gmail.com> wrote: >>>> >>>> >>>> >>>> 2016-04-10 8:55 GMT+02:00 Volkert >>>> <<mailto:volkert@komponentenwerkstatt.de> >>>> volkert(a)komponentenwerkstatt.de>: >>>> >>>> Sorry. i meant AthensSkatch ;-) It is a nice demo about using >>>> athens. >>>> >>>> http://smalltalkhub.com/#!/~NicolaiHess/AthensSketch >>>> <http://smalltalkhub.com/#%21/%7ENicolaiHess/AthensSketch> >>>> >>>> >>>> >>>> >>>> Hi Volkert, >>>> I just replaced >>>> #removeDuplicates with >>>> #asSet >>>> (this should work now). >>>> >>> >>> I think that it would be nice to have removeDuplicates. Because >>> sometimes you need to end up with ordered collection and then you need >>> to do something like `obj asSet asArray` and it is ugly. >>> >>> Uko >>> >>> >>>> (and replaced some deprecated on:send:to: calls (for Announcements) with >>>> when:send:to: >>>> >>>> in the latest version. >>>> >>>> >>>> Nicolai >>>> >>>> >>>> >>>> >>>> On 10.04.2016 07:42, stepharo wrote: >>>> >>>> >>>> >>>> Le 9/4/16 22:36, Volkert a Ã©crit : >>>> >>>> What happens to OrderedCollection>>removeDuplicates in >>>> Pharo 5.0? In Pharo 4.0 it was part of a Package >>>> "GroupManager"? >>>> >>>> >>>> It was probably badly implemented or only used in group >>>> manager (whose code was terrible) and we cleaned it. >>>> Now we could reintroduce it but in the right place and with >>>> tests. >>>> >>>> It breaks the nice Package "AthensScratch" in Pharo 5.0 >>>> >>>> >>>> what is athenscracth? >>>> >>>> >>>> BW. >>>> Volkert >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >> >

April 16, 2016

Re: [Pharo-dev] Missing #removeDuplicates

by Werner Kassens

perhaps it is a speed question? using pharo4.0 (with polymath): a:=DhbVector new: 50 random: 20. b:=a copy asOrderedCollection . Smalltalk garbageCollect . [ b removeDuplicates]bench. "'47,004 per second'" b:=a copy asArray. Smalltalk garbageCollect . [ b asSet asArray ]bench. "'27,249 per second'" werner On 04/16/2016 09:01 AM, stepharo wrote: > And I do not see why removeDuplicates is less ugly than asSet asArray. > Just that it is doing two passes. > > Stef > > Le 15/4/16 23:57, Yuriy Tymchuk a Ã©crit : >> >>> On 11 Apr 2016, at 09:06, Nicolai Hess >>> <<mailto:nicolaihess@gmail.com>nicolaihess(a)gmail.com> wrote: >>> >>> >>> >>> 2016-04-10 8:55 GMT+02:00 Volkert >>> <<mailto:volkert@komponentenwerkstatt.de>volkert(a)komponentenwerkstatt.de>: >>> >>> Sorry. i meant AthensSkatch ;-) It is a nice demo about using athens. >>> >>> http://smalltalkhub.com/#!/~NicolaiHess/AthensSketch >>> <http://smalltalkhub.com/#%21/%7ENicolaiHess/AthensSketch> >>> >>> >>> >>> Hi Volkert, >>> I just replaced >>> #removeDuplicates with >>> #asSet >>> (this should work now). >> >> I think that it would be nice to have removeDuplicates. Because >> sometimes you need to end up with ordered collection and then you need >> to do something like `obj asSet asArray` and it is ugly. >> >> Uko >> >>> >>> (and replaced some deprecated on:send:to: calls (for Announcements) with >>> when:send:to: >>> >>> in the latest version. >>> >>> >>> Nicolai >>> >>> >>> >>> >>> On 10.04.2016 07:42, stepharo wrote: >>> >>> >>> >>> Le 9/4/16 22:36, Volkert a Ã©crit : >>> >>> What happens to OrderedCollection>>removeDuplicates in >>> Pharo 5.0? In Pharo 4.0 it was part of a Package >>> "GroupManager"? >>> >>> >>> It was probably badly implemented or only used in group >>> manager (whose code was terrible) and we cleaned it. >>> Now we could reintroduce it but in the right place and with >>> tests. >>> >>> It breaks the nice Package "AthensScratch" in Pharo 5.0 >>> >>> >>> what is athenscracth? >>> >>> >>> BW. >>> Volkert >>> >>> >>> >>> >>> >>> >>> >> >

April 16, 2016