- Pharo-dev - lists.pharo.org

Fwd: [pharo-project/pharo-core] 6ece95: 60104

by Nicolai Hess

I don't know what change is responsible, but Pharo 60104 as two ui-processes (this causes strange rendering artefacts) ---------- Forwarded message ---------- From: GitHub <noreply(a)github.com> Date: 2016-06-22 10:03 GMT+02:00 Subject: [Pharo-dev] [pharo-project/pharo-core] 6ece95: 60104 To: pharo-dev(a)lists.pharo.org Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 6ece95dfc5016cf3c09f06433e6e94dba5919ebd https://github.com/pharo-project/pharo-core/commit/6ece95dfc5016cf3c09f0643… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-06-22 (Wed, 22 Jun 2016) Changed paths: A AST-Core.package/RBParseErrorNode.class/instance/accessing/name.st M ConfigurationOfEpicea.package/ConfigurationOfEpicea.class/instance/tags/stable_.st A ConfigurationOfEpicea.package/ConfigurationOfEpicea.class/instance/versions/version793p6_.st M EpiceaBrowsers.package/EpDisplayMorphVisitor.class/instance/initialization/ initialize.st M EpiceaBrowsers.package/EpLostChangesDetector.class/definition.st M Refactoring-Tests-Critics.package/RBSmalllintTest.class/instance/tests/testBadMessage.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/ script60103.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/ script60104.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/ update60103.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/ update60104.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Tools.package/MessageBrowser.class/instance/initialization/initializePresenter.st A Spec-Tools.package/MessageBrowser.class/instance/private/installIconStylerFor_.st A Spec-Tools.package/MessageBrowser.class/instance/private/isMethodDefinition_.st Log Message: ----------- 60104 18551 RBSmalllintTest>>#testBadMessage is failing https://pharo.fogbugz.com/f/cases/18551 18558 MNU on deselecting message browser entry https://pharo.fogbugz.com/f/cases/18558 18559 OCASTSemanticAnalyzer calls "name" on RBParseErrorNode https://pharo.fogbugz.com/f/cases/18559 18561 DNU when EpLostChangesDetector opens browser in non-interactive mode https://pharo.fogbugz.com/f/cases/18561 http://files.pharo.org/image/60/60104.zip

June 22, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60104 Home: https://github.com/pharo-project/pharo-core

June 22, 2016

[pharo-project/pharo-core] 6ece95: 60104

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 6ece95dfc5016cf3c09f06433e6e94dba5919ebd https://github.com/pharo-project/pharo-core/commit/6ece95dfc5016cf3c09f0643… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-06-22 (Wed, 22 Jun 2016) Changed paths: A AST-Core.package/RBParseErrorNode.class/instance/accessing/name.st M ConfigurationOfEpicea.package/ConfigurationOfEpicea.class/instance/tags/stable_.st A ConfigurationOfEpicea.package/ConfigurationOfEpicea.class/instance/versions/version793p6_.st M EpiceaBrowsers.package/EpDisplayMorphVisitor.class/instance/initialization/initialize.st M EpiceaBrowsers.package/EpLostChangesDetector.class/definition.st M Refactoring-Tests-Critics.package/RBSmalllintTest.class/instance/tests/testBadMessage.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60103.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60104.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60103.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60104.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Tools.package/MessageBrowser.class/instance/initialization/initializePresenter.st A Spec-Tools.package/MessageBrowser.class/instance/private/installIconStylerFor_.st A Spec-Tools.package/MessageBrowser.class/instance/private/isMethodDefinition_.st Log Message: ----------- 60104 18551 RBSmalllintTest>>#testBadMessage is failing https://pharo.fogbugz.com/f/cases/18551 18558 MNU on deselecting message browser entry https://pharo.fogbugz.com/f/cases/18558 18559 OCASTSemanticAnalyzer calls "name" on RBParseErrorNode https://pharo.fogbugz.com/f/cases/18559 18561 DNU when EpLostChangesDetector opens browser in non-interactive mode https://pharo.fogbugz.com/f/cases/18561 http://files.pharo.org/image/60/60104.zip

June 22, 2016

Re: [Pharo-dev] NonInteractiveUIManager vs. Epicea

by stepharo

Le 22/6/16 Ã 00:23, Holger Freyther a Ã©crit : > Hi, > > would fogbugz be the better place for reports like this? It looks like the introduction of Epicea has broken my use of headless images? > > Should >>#initialize use "Smalltalk ui theme" instead of "UIManager default theme"? Both loosk terrible. but Smalltalk ui theme is really a bad idea. We should really remove this cancer XXX ff zz If a tool need a theme, then it should have an instance variable theme and this instance var should be well initialized. This pattern sucks! Stef > > > NonInteractiveUIManager>>theme > NonInteractiveUIManager(Object)>>doesNotUnderstand: #theme > EpDisplayMorphVisitor>>initialize > EpDisplayMorphVisitor class(Behavior)>>new > EpEntryItem>>displayWidget > [ :item | item displayWidget ] in EpLogBrowser>>initializeItemsModel in Block: [ :item | item displayWidget ] > BlockClosure>>cull: > BlockClosure>>cull:cull: > TreeModel>>wrapItem: > [ :node | self wrapItem: node content ] in TreeModel>>initialize in Block: [ :node | self wrapItem: node content ] > [ :node :cont | self rowMorphGetSelector value: node ] in SpecTreeColumn(MorphTreeColumn)>>rowMorphGetterBlock in Block: [ :node :cont | self rowMorphGetSelector value: no...etc... > SpecTreeColumn>>rowMorphFor: > [ :col | > | v | > v := col rowMorphFor: complexContents. > controls add: v. > col -> v ] in MorphTreeNodeMorph>>buildRowMorph in Block: [ :col | ... > OrderedCollection>>collect: > MorphTreeNodeMorph>>buildRowMorph > MorphTreeNodeMorph>>initRow > MorphTreeNodeMorph>>initWithContents:prior:forList:indentLevel: > [ :item :idx | > priorMorph := self indentingItemClass new > initWithContents: item > prior: priorMorph > forList: self > indentLevel: newIndent. > firstAddition ifNil: [ firstAddition := priorMorph ]. > morphList add: priorMorph. > "Was this row expanded ? if true -> expand it > again " > ((item hasEquivalentIn: expandedItems) or: [ priorMorph isExpanded ]) > ifTrue: [ priorMorph isExpanded: true. > priorMorph > addChildrenForList: self > addingTo: morphList > withExpandedItems: expandedItems ] ] in MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: in Block: [ :item :idx | ... > OrderedCollection(SequenceableCollection)>>withIndexDo: > OrderedCollection(SequenceableCollection)>>doWithIndex: > MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: > MorphTreeMorph>>addSubmorphsFromNodeList:previouslyExpanded: > MorphTreeMorph>>addSubmorphsFromNodeList > MorphTreeMorph>>buildContents > MorphicTreeAdapter>>buildWidget > MorphicTreeAdapter(AbstractAdapter)>>adapt: > SpecInterpreter>>actionToPerformWithSelector:arguments: > SpecInterpreter>>performNextSelectorAndIncrementIndex > SpecInterpreter>>interpretASpec:selector: > SpecInterpreter>>interpretASpec:model:selector: > SpecInterpreter class>>private_interpretASpec:model:selector: >

June 22, 2016

Re: [Pharo-dev] Easy to use execution counter with Icon in Editor

by Tudor Girba

Hi, > On Jun 22, 2016, at 4:23 AM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > > > > On Tue, Jun 21, 2016 at 5:47 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote: > He he! I love these goodies. > > > Yes, me too. This little things make the "IDE" look more "proffesional" and more welcoming to newbies as they are used to that in others environments. I think that with these abilities we start to surpass what exists in other environments. Remember that this addition takes a few lines of code. In other environments, this would take a whole plugin with orders of magnitude more code. Our environment is disruptive, at least in this regard. Cheers, Doru > > Doru > > > > On Jun 21, 2016, at 5:45 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > > > Hi, > > > > In the 60#103 there will be a new kind of âWatcherâ: an execution-counter. > > > > Using the âsuggestionâ menu one can add a counter to any AST node. > > After, the editor shows a (c) Icon. Mouse over â> current state of the counter is shown. > > > > Of course, UI is just a stand-in and could be *much* better. But from a debug > > perspective, it already should be quite useful to get a feel of how often something > > gets executed. > > > > Henrik suggest this as a demo (and an example of how to install a Counter without using > > the UI): > > > > ExecutionCounter installOn: (RubParagraphDecorator >> #doesNotUnderstand:) ast > > > > Marcus > > -- > www.tudorgirba.com > www.feenk.com > > "Quality cannot be an afterthought." > > > > > > -- > Mariano > http://marianopeck.wordpress.com -- www.tudorgirba.com www.feenk.com "Every thing has its own flow."

June 22, 2016

Re: [Pharo-dev] NonInteractiveUIManager vs. Epicea

by Martin Dias

Thanks for reporting... I created the case and propose a fast fix: https://pharo.fogbugz.com/f/cases/18561/DNU-when-EpLostChangesDetector-open… Despite my "quick fix" avoids the DNU, we should discuss what should happen when there are lost changes in non.interactive mode. I think EpLostChangesDetector should only perform its detection. What'd be the right test to do? "Smalltalk isInteractive"? Martin On Tue, Jun 21, 2016 at 8:50 PM, Ben Coman <btc(a)openinworld.com> wrote: > On Wed, Jun 22, 2016 at 6:23 AM, Holger Freyther <holger(a)freyther.de> > wrote: > > Hi, > > > > would fogbugz be the better place for reports like this? > > Yes. But it might get less immediate attention than you need. If > something breaks your workflow, its *also* good to raise attention on > the mail list, and follow up with a link to the Fogbugz issue if you > didn't create one already. > > cheers -ben > > > It looks like the introduction of Epicea has broken my use of headless > images? > > > > Should >>#initialize use "Smalltalk ui theme" instead of "UIManager > default theme"? > > > > > > NonInteractiveUIManager>>theme > > NonInteractiveUIManager(Object)>>doesNotUnderstand: #theme > > EpDisplayMorphVisitor>>initialize > > EpDisplayMorphVisitor class(Behavior)>>new > > EpEntryItem>>displayWidget > > [ :item | item displayWidget ] in EpLogBrowser>>initializeItemsModel in > Block: [ :item | item displayWidget ] > > BlockClosure>>cull: > > BlockClosure>>cull:cull: > > TreeModel>>wrapItem: > > [ :node | self wrapItem: node content ] in TreeModel>>initialize in > Block: [ :node | self wrapItem: node content ] > > [ :node :cont | self rowMorphGetSelector value: node ] in > SpecTreeColumn(MorphTreeColumn)>>rowMorphGetterBlock in Block: [ :node > :cont | self rowMorphGetSelector value: no...etc... > > SpecTreeColumn>>rowMorphFor: > > [ :col | > > | v | > > v := col rowMorphFor: complexContents. > > controls add: v. > > col -> v ] in MorphTreeNodeMorph>>buildRowMorph in Block: [ :col | ... > > OrderedCollection>>collect: > > MorphTreeNodeMorph>>buildRowMorph > > MorphTreeNodeMorph>>initRow > > MorphTreeNodeMorph>>initWithContents:prior:forList:indentLevel: > > [ :item :idx | > > priorMorph := self indentingItemClass new > > initWithContents: item > > prior: priorMorph > > forList: self > > indentLevel: newIndent. > > firstAddition ifNil: [ firstAddition := priorMorph ]. > > morphList add: priorMorph. > > "Was this row expanded ? if true -> expand it > > again " > > ((item hasEquivalentIn: expandedItems) or: [ priorMorph isExpanded ]) > > ifTrue: [ priorMorph isExpanded: true. > > priorMorph > > addChildrenForList: self > > addingTo: morphList > > withExpandedItems: expandedItems ] ] in > MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: in Block: [ > :item :idx | ... > > OrderedCollection(SequenceableCollection)>>withIndexDo: > > OrderedCollection(SequenceableCollection)>>doWithIndex: > > MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: > > MorphTreeMorph>>addSubmorphsFromNodeList:previouslyExpanded: > > MorphTreeMorph>>addSubmorphsFromNodeList > > MorphTreeMorph>>buildContents > > MorphicTreeAdapter>>buildWidget > > MorphicTreeAdapter(AbstractAdapter)>>adapt: > > SpecInterpreter>>actionToPerformWithSelector:arguments: > > SpecInterpreter>>performNextSelectorAndIncrementIndex > > SpecInterpreter>>interpretASpec:selector: > > SpecInterpreter>>interpretASpec:model:selector: > > SpecInterpreter class>>private_interpretASpec:model:selector: > >

June 22, 2016

Re: [Pharo-dev] Easy to use execution counter with Icon in Editor

by Mariano Martinez Peck

On Tue, Jun 21, 2016 at 5:47 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote: > He he! I love these goodies. > > Yes, me too. This little things make the "IDE" look more "proffesional" and more welcoming to newbies as they are used to that in others environments. > Doru > > > > On Jun 21, 2016, at 5:45 PM, Marcus Denker <marcus.denker(a)inria.fr> > wrote: > > > > Hi, > > > > In the 60#103 there will be a new kind of âWatcherâ: an > execution-counter. > > > > Using the âsuggestionâ menu one can add a counter to any AST node. > > After, the editor shows a (c) Icon. Mouse over â> current state of the > counter is shown. > > > > Of course, UI is just a stand-in and could be *much* better. But from a > debug > > perspective, it already should be quite useful to get a feel of how > often something > > gets executed. > > > > Henrik suggest this as a demo (and an example of how to install a > Counter without using > > the UI): > > > > ExecutionCounter installOn: (RubParagraphDecorator >> > #doesNotUnderstand:) ast > > > > Marcus > > -- > www.tudorgirba.com > www.feenk.com > > "Quality cannot be an afterthought." > > > -- Mariano http://marianopeck.wordpress.com

June 22, 2016

Re: [Pharo-dev] bloc status update: june 2016

by Sean P. DeNigris

Tudor Girba-2 wrote > Here is a brief update on the status of Bloc. Thanks! Tudor Girba-2 wrote > your feedback is important As we've imagined and experimented with the UI of our future, I've felt very strongly that it's essential for the world to be built up from building blocks which make few assumptions other than their communication protocol and can be easily plugged in and out by a courageous user. A test case for this, which opens up many exciting possibilities (imagine I want to control time in my space e.g. run a simulation at 10x speed...), would be to have a world within a world. I dabbled with this idea a bit in Morphic, but quickly became frustrated because Morphic makes too many assumptions e.g. relying on globals and hardcoded classes. The last time I tried this in Bloc, the result of the discussion was that Alain said that this should be conceptually possible, but that I should be patient (http://forum.world.st/Bloc-Space-within-a-Space-td4877474.html) Are we any closer to this dream? ----- Cheers, Sean -- View this message in context: http://forum.world.st/bloc-status-update-june-2016-tp4901988p4902319.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

June 22, 2016

Re: [Pharo-dev] NonInteractiveUIManager vs. Epicea

by Ben Coman

On Wed, Jun 22, 2016 at 6:23 AM, Holger Freyther <holger(a)freyther.de> wrote: > Hi, > > would fogbugz be the better place for reports like this? Yes. But it might get less immediate attention than you need. If something breaks your workflow, its *also* good to raise attention on the mail list, and follow up with a link to the Fogbugz issue if you didn't create one already. cheers -ben > It looks like the introduction of Epicea has broken my use of headless images? > > Should >>#initialize use "Smalltalk ui theme" instead of "UIManager default theme"? > > > NonInteractiveUIManager>>theme > NonInteractiveUIManager(Object)>>doesNotUnderstand: #theme > EpDisplayMorphVisitor>>initialize > EpDisplayMorphVisitor class(Behavior)>>new > EpEntryItem>>displayWidget > [ :item | item displayWidget ] in EpLogBrowser>>initializeItemsModel in Block: [ :item | item displayWidget ] > BlockClosure>>cull: > BlockClosure>>cull:cull: > TreeModel>>wrapItem: > [ :node | self wrapItem: node content ] in TreeModel>>initialize in Block: [ :node | self wrapItem: node content ] > [ :node :cont | self rowMorphGetSelector value: node ] in SpecTreeColumn(MorphTreeColumn)>>rowMorphGetterBlock in Block: [ :node :cont | self rowMorphGetSelector value: no...etc... > SpecTreeColumn>>rowMorphFor: > [ :col | > | v | > v := col rowMorphFor: complexContents. > controls add: v. > col -> v ] in MorphTreeNodeMorph>>buildRowMorph in Block: [ :col | ... > OrderedCollection>>collect: > MorphTreeNodeMorph>>buildRowMorph > MorphTreeNodeMorph>>initRow > MorphTreeNodeMorph>>initWithContents:prior:forList:indentLevel: > [ :item :idx | > priorMorph := self indentingItemClass new > initWithContents: item > prior: priorMorph > forList: self > indentLevel: newIndent. > firstAddition ifNil: [ firstAddition := priorMorph ]. > morphList add: priorMorph. > "Was this row expanded ? if true -> expand it > again " > ((item hasEquivalentIn: expandedItems) or: [ priorMorph isExpanded ]) > ifTrue: [ priorMorph isExpanded: true. > priorMorph > addChildrenForList: self > addingTo: morphList > withExpandedItems: expandedItems ] ] in MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: in Block: [ :item :idx | ... > OrderedCollection(SequenceableCollection)>>withIndexDo: > OrderedCollection(SequenceableCollection)>>doWithIndex: > MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: > MorphTreeMorph>>addSubmorphsFromNodeList:previouslyExpanded: > MorphTreeMorph>>addSubmorphsFromNodeList > MorphTreeMorph>>buildContents > MorphicTreeAdapter>>buildWidget > MorphicTreeAdapter(AbstractAdapter)>>adapt: > SpecInterpreter>>actionToPerformWithSelector:arguments: > SpecInterpreter>>performNextSelectorAndIncrementIndex > SpecInterpreter>>interpretASpec:selector: > SpecInterpreter>>interpretASpec:model:selector: > SpecInterpreter class>>private_interpretASpec:model:selector:

June 21, 2016

Re: [Pharo-dev] NonInteractiveUIManager vs. Epicea

by Yuriy Tymchuk

yay, thanks. I wanted to report this but forgot > On 22 Jun 2016, at 00:27, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > I spotted the same problem todayâ¦ yes, fogbugz is better place :) > > Esteban > >> On 22 Jun 2016, at 00:23, Holger Freyther <holger(a)freyther.de> wrote: >> >> Hi, >> >> would fogbugz be the better place for reports like this? It looks like the introduction of Epicea has broken my use of headless images? >> >> Should >>#initialize use "Smalltalk ui theme" instead of "UIManager default theme"? >> >> >> NonInteractiveUIManager>>theme >> NonInteractiveUIManager(Object)>>doesNotUnderstand: #theme >> EpDisplayMorphVisitor>>initialize >> EpDisplayMorphVisitor class(Behavior)>>new >> EpEntryItem>>displayWidget >> [ :item | item displayWidget ] in EpLogBrowser>>initializeItemsModel in Block: [ :item | item displayWidget ] >> BlockClosure>>cull: >> BlockClosure>>cull:cull: >> TreeModel>>wrapItem: >> [ :node | self wrapItem: node content ] in TreeModel>>initialize in Block: [ :node | self wrapItem: node content ] >> [ :node :cont | self rowMorphGetSelector value: node ] in SpecTreeColumn(MorphTreeColumn)>>rowMorphGetterBlock in Block: [ :node :cont | self rowMorphGetSelector value: no...etc... >> SpecTreeColumn>>rowMorphFor: >> [ :col | >> | v | >> v := col rowMorphFor: complexContents. >> controls add: v. >> col -> v ] in MorphTreeNodeMorph>>buildRowMorph in Block: [ :col | ... >> OrderedCollection>>collect: >> MorphTreeNodeMorph>>buildRowMorph >> MorphTreeNodeMorph>>initRow >> MorphTreeNodeMorph>>initWithContents:prior:forList:indentLevel: >> [ :item :idx | >> priorMorph := self indentingItemClass new >> initWithContents: item >> prior: priorMorph >> forList: self >> indentLevel: newIndent. >> firstAddition ifNil: [ firstAddition := priorMorph ]. >> morphList add: priorMorph. >> "Was this row expanded ? if true -> expand it >> again " >> ((item hasEquivalentIn: expandedItems) or: [ priorMorph isExpanded ]) >> ifTrue: [ priorMorph isExpanded: true. >> priorMorph >> addChildrenForList: self >> addingTo: morphList >> withExpandedItems: expandedItems ] ] in MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: in Block: [ :item :idx | ... >> OrderedCollection(SequenceableCollection)>>withIndexDo: >> OrderedCollection(SequenceableCollection)>>doWithIndex: >> MorphTreeMorph>>addMorphsTo:from:withExpandedItems:atLevel: >> MorphTreeMorph>>addSubmorphsFromNodeList:previouslyExpanded: >> MorphTreeMorph>>addSubmorphsFromNodeList >> MorphTreeMorph>>buildContents >> MorphicTreeAdapter>>buildWidget >> MorphicTreeAdapter(AbstractAdapter)>>adapt: >> SpecInterpreter>>actionToPerformWithSelector:arguments: >> SpecInterpreter>>performNextSelectorAndIncrementIndex >> SpecInterpreter>>interpretASpec:selector: >> SpecInterpreter>>interpretASpec:model:selector: >> SpecInterpreter class>>private_interpretASpec:model:selector: > >

June 21, 2016