- Pharo-dev - lists.pharo.org

[Pharo 9.0] Build #275: Small cleanups in BorderedMorph

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #275 was: FAILURE. The Pull Request #6274 was integrated: "Small cleanups in BorderedMorph" Pull request url: https://github.com/pharo-project/pharo/pull/6274 Issue Url: https://github.com/pharo-project/pharo/issues/6273 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 1, 2020

Re: [Pharo-dev] FullBlockClosure - How to create one...

by Sean P. DeNigris

Eliot Miranda-2 wrote > (FullBlockClosure receiver: nil outerContext: nil method: blockMethod > copiedValues: nil) value: 1 value: 2 Cool! We're getting closer, but in Pharo8 FullBlockClosure DNU #receiver:outerContext:method:copiedValues: I tried to adapt it to Pharo's API, but the following crashes the VM: blockMethod := [:a :b| a < b] method. (FullBlockClosure outerContext: nil startpc: nil numArgs: 2 copiedValues: nil) compiledBlock: blockMethod; value: 1 value: 2 ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

May 1, 2020

Re: [Pharo-dev] FullBlockClosure - How to create one...

by Sean P. DeNigris

Max Leske wrote > You *need* an outer context. This is the very point of my experimentation! Why? It wreaks havoc on naive Fuel users when serialized blocks can't be materialized. In the case of clean blocks, the outer context is irrelevant from the user perspective. What I'm trying to figure out is where this requirement comes from and whether it can be removed, at least for clean blocks. This seems to be the raison d'Ãªtre of FullBlockClosure. It's class comment: A FullBlockClosure is a closure that can be independent of any outerContext if desired. It has its own method (currently reusing the startpc inst var) and its own receiver. outerContext can be either a MethodContext/Context or nil. Unfortunately, I'm having trouble creating one to play with. It seems that maybe the FullBlockClosure concept is a bit unfinished? I ask this both because BlockClosure still exists in addition to FullBlockClosure (IIUC I thought the Full one was a replacement) and because I found the following posts which talk about future work e.g. for clean blocks: - https://clementbera.wordpress.com/2016/06/27/fullblockclosure-design/ - https://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/2016-September/… - (More about Sista) http://wiki.squeak.org/squeak/6589 - (general FullBlock... description) http://wiki.squeak.org/squeak/6610 ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

May 1, 2020

Re: [Pharo-dev] FullBlockClosure - How to create one...

by Eliot Miranda

you might want to adapt this change set into a package, to rename BlockClosure's startups inst var to startpcOrMethod to clear up confusion. On Fri, May 1, 2020 at 9:49 AM Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > Hi Max, > > On Thu, Apr 30, 2020 at 11:51 PM Max Leske <maxleske(a)gmail.com> wrote: > >> Hi Sean, >> >> You *need* an outer context. See Context>>cleanCopy, which Fuel uses to >> serialize blocks. >> > > One does *not* need an outer context. An outer context of nil should be > fine, provided that the block never attempts an up-arrow return. > > > | blockMethod | > blockMethod := [:a :b| a < b] method. > (FullBlockClosure receiver: nil outerContext: nil method: blockMethod > copiedValues: nil) value: 1 value: 2 > > So one needs to use FullBlockClosure > class>>receiver:outerContext:method:copiedValues: and one can supply nil > for the outerContext provided that the block does not do an up-arrow return. > > >> Cheers, >> Max >> >> On 1 May 2020, at 3:23, Sean P. DeNigris wrote: >> >> What am I not understanding about FullBlockClosure? >> >> I have a clean block that I'd like to turn into a FullBlockClosure so >> that I >> can serialize it without dragging (unneeded methods) into my object graph. >> However, documentation and in-image example usages seem severely limited. >> Here was one experiment that ended with a primitive failure. It seems >> like a >> receiver is needed and it can't be a dummy value (see commented "receiver: >> 1"). But what would the receiver be in the absence of an outer context?! >> >> aBlockClosure := [ :a :b | 1 + a + b ]. >> fbc := (FullBlockClosure >> outerContext: nil >> startpc: aBlockClosure startpc >> numArgs: aBlockClosure argumentCount >> copiedValues: Array new) "receiver: 1; yourself". >> >> fbc value: 2 value: 3. "PrimitiveFailed: primitive #value:value: in >> FullBlockClosure failed" >> >> >> >> ----- >> Cheers, >> Sean >> -- >> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >> >> > > -- > _,,,^..^,,,_ > best, Eliot > -- _,,,^..^,,,_ best, Eliot

May 1, 2020

Re: [Pharo-dev] FullBlockClosure - How to create one...

by Eliot Miranda

Hi Max, On Thu, Apr 30, 2020 at 11:51 PM Max Leske <maxleske(a)gmail.com> wrote: > Hi Sean, > > You *need* an outer context. See Context>>cleanCopy, which Fuel uses to > serialize blocks. > One does *not* need an outer context. An outer context of nil should be fine, provided that the block never attempts an up-arrow return. | blockMethod | blockMethod := [:a :b| a < b] method. (FullBlockClosure receiver: nil outerContext: nil method: blockMethod copiedValues: nil) value: 1 value: 2 So one needs to use FullBlockClosure class>>receiver:outerContext:method:copiedValues: and one can supply nil for the outerContext provided that the block does not do an up-arrow return. > Cheers, > Max > > On 1 May 2020, at 3:23, Sean P. DeNigris wrote: > > What am I not understanding about FullBlockClosure? > > I have a clean block that I'd like to turn into a FullBlockClosure so that > I > can serialize it without dragging (unneeded methods) into my object graph. > However, documentation and in-image example usages seem severely limited. > Here was one experiment that ended with a primitive failure. It seems like > a > receiver is needed and it can't be a dummy value (see commented "receiver: > 1"). But what would the receiver be in the absence of an outer context?! > > aBlockClosure := [ :a :b | 1 + a + b ]. > fbc := (FullBlockClosure > outerContext: nil > startpc: aBlockClosure startpc > numArgs: aBlockClosure argumentCount > copiedValues: Array new) "receiver: 1; yourself". > > fbc value: 2 value: 3. "PrimitiveFailed: primitive #value:value: in > FullBlockClosure failed" > > > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html > > -- _,,,^..^,,,_ best, Eliot

May 1, 2020

Re: [Pharo-dev] FullBlockClosure - How to create one...

by Eliot Miranda

Hi Sean, > On Apr 30, 2020, at 7:36 PM, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > ï»¿What am I not understanding about FullBlockClosure? > > I have a clean block that I'd like to turn into a FullBlockClosure so that I > can serialize it without dragging (unneeded methods) into my object graph. > However, documentation and in-image example usages seem severely limited. > Here was one experiment that ended with a primitive failure. It seems like a > receiver is needed and it can't be a dummy value (see commented "receiver: > 1"). But what would the receiver be in the absence of an outer context?! > > aBlockClosure := [ :a :b | 1 + a + b ]. > fbc := (FullBlockClosure > outerContext: nil > startpc: aBlockClosure startpc > numArgs: aBlockClosure argumentCount > copiedValues: Array new) "receiver: 1; yourself". FullBlockClosure doesnât have a startpc. Because it has its own method its startpc is implicit, just like a normal method. Iâm on my phone now, so I donât know what the creation method is off hand. But if you look at how Context implements the FullBlockClosure value primitives in doPrimitive:... you should find it. > > fbc value: 2 value: 3. "PrimitiveFailed: primitive #value:value: in > FullBlockClosure failed" > > > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >

May 1, 2020

Re: [Pharo-dev] FullBlockClosure - How to create one...

by Max Leske

Hi Sean, You *need* an outer context. See Context>>cleanCopy, which Fuel uses to serialize blocks. Cheers, Max On 1 May 2020, at 3:23, Sean P. DeNigris wrote: > What am I not understanding about FullBlockClosure? > > I have a clean block that I'd like to turn into a FullBlockClosure so that I > can serialize it without dragging (unneeded methods) into my object graph. > However, documentation and in-image example usages seem severely limited. > Here was one experiment that ended with a primitive failure. It seems like a > receiver is needed and it can't be a dummy value (see commented "receiver: > 1"). But what would the receiver be in the absence of an outer context?! > > aBlockClosure := [ :a :b | 1 + a + b ]. > fbc := (FullBlockClosure > outerContext: nil > startpc: aBlockClosure startpc > numArgs: aBlockClosure argumentCount > copiedValues: Array new) "receiver: 1; yourself". > > fbc value: 2 value: 3. "PrimitiveFailed: primitive #value:value: in > FullBlockClosure failed" > > > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

May 1, 2020

FullBlockClosure - How to create one...

by Sean P. DeNigris

What am I not understanding about FullBlockClosure? I have a clean block that I'd like to turn into a FullBlockClosure so that I can serialize it without dragging (unneeded methods) into my object graph. However, documentation and in-image example usages seem severely limited. Here was one experiment that ended with a primitive failure. It seems like a receiver is needed and it can't be a dummy value (see commented "receiver: 1"). But what would the receiver be in the absence of an outer context?! aBlockClosure := [ :a :b | 1 + a + b ]. fbc := (FullBlockClosure outerContext: nil startpc: aBlockClosure startpc numArgs: aBlockClosure argumentCount copiedValues: Array new) "receiver: 1; yourself". fbc value: 2 value: 3. "PrimitiveFailed: primitive #value:value: in FullBlockClosure failed" ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

May 1, 2020

[Pharo 9.0] Build #274: Removing classes from ChangeSorter throws DNU

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #274 was: FAILURE. The Pull Request #6261 was integrated: "Removing classes from ChangeSorter throws DNU" Pull request url: https://github.com/pharo-project/pharo/pull/6261 Issue Url: https://github.com/pharo-project/pharo/issues/6260 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

April 30, 2020

[Pharo 9.0] Build #273: Lint cleanup #isZipArchive:

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #273 was: FAILURE. The Pull Request #6263 was integrated: "Lint cleanup #isZipArchive:" Pull request url: https://github.com/pharo-project/pharo/pull/6263 Issue Url: https://github.com/pharo-project/pharo/issues/6262 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

April 30, 2020