- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60178 Home: https://github.com/pharo-project/pharo-core

Aug. 11, 2016

[pharo-project/pharo-core] 805c1f: 60178

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 805c1f4605d99d43429841a61132297564b7d455 https://github.com/pharo-project/pharo-core/commit/805c1f4605d99d43429841a6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-11 (Thu, 11 Aug 2016) Changed paths: M Collections-Strings.package/Symbol.class/class/initialization/initialize.st M Multilingual-Languages.package/LanguageEnvironment.class/class/initialization/initialize.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60177.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60178.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60177.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60178.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M System-SessionManager.package/SessionManager.class/class/accessing/default.st Log Message: ----------- 60178 18907 Prevent LanguageEnvironment sublclasses to be in startup list https://pharo.fogbugz.com/f/cases/18907 18906 SessionManager default should store the new instance when no default defined https://pharo.fogbugz.com/f/cases/18906 18908 Prevent Symbol subclasses to be in startup list https://pharo.fogbugz.com/f/cases/18908 http://files.pharo.org/image/60/60178.zip

Aug. 11, 2016

Re: [Pharo-dev] request for improvements in GTInspector or debugger

by Nicolai Hess

2016-08-11 13:44 GMT+02:00 Christophe Demarey <christophe.demarey(a)inria.fr>: > Hi, > > > Le 10 aoÃ»t 2016 Ã 14:11, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : > > > > Hi Stef, > > > > I agree with what you say in this mail, and I am not sure where this is > not the case. > > > By example, it is not available in a String presentation of GTInspector. > This one always forces me to go to the raw presentation and use the comment. > Would it be possible to use global shortcuts in String presentation > (cmd+B, cmd+M, cmd+N, etc.)? > > Christophe > You could change GLMMorphicRubricTextRenderer>>#morph to act with smalltalk comment mode morph ^ RubScrolledTextMorph new getSelectionSelector: #primarySelectionInterval; color: Smalltalk ui theme backgroundColor; textColor: Smalltalk ui theme textColor; textFont: StandardFonts defaultFont; model: textModel; beForSmalltalkComment; yourself. This way, it behaves like the comment pane in Nautilus, it renders the text as "text" with the default font, no menu, but allows the common code mode shortcuts cmd+b cmd+M, ( and some that doesn't make sense for every selection, like cmd+i for inspect).

Aug. 11, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Christophe Demarey

Hi Nicolai Good idea! I like it and it works well. I now wonder if it should not be enabled as default. For that, maybe the highlight should be styled a bit (e.g. lighter colors) to do not perturb the user when not really needed but still easy to see. Another idea would be to show it only if you press a key while mouse over (e.g shift). thanks > Le 10 aoÃ»t 2016 Ã 16:48, Nicolai Hess <nicolaihess(a)gmail.com> a Ã©crit : > > I opened an issue > > 18901 <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> Highlight message send selector on mouse over > > with an experimental implementation. > > Just load the slice, enable the setting: > RubAbstractTextArea highlightMessageSend: true. > > Now open a code editor (nautilus/MessageBrowser) and > move the mouse over a message send. > > Or evaluate this code, it opens a text editor on a method, where it is difficult > to see which part of the code belongs to which method: > > evaluate: > TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) sourceCode;openWithSpec. > > > feedback welcome. > > nicolai

Aug. 11, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60177 Home: https://github.com/pharo-project/pharo-core

Aug. 11, 2016

[pharo-project/pharo-core] 5629b4: 60177

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 5629b450873d783ac4d8d59ebb420003837720a0 https://github.com/pharo-project/pharo-core/commit/5629b450873d783ac4d8d59e… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-11 (Thu, 11 Aug 2016) Changed paths: R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60176.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60177.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60176.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60177.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A System-CommandLine-TextSupport.package/extension/Color/instance/closestXTermPixelValue.st A System-CommandLine-TextSupport.package/extension/VTermOutputDriver/instance/background256_.st A System-CommandLine-TextSupport.package/extension/VTermOutputDriver/instance/color256_.st A System-CommandLine-TextSupport.package/extension/VTermOutputDriver/instance/color256_background_.st M Text-Core.package/extension/VTermOutputDriver/class/printText_.st M Tool-Base.package/AbstractTool.class/class/private/requestProtocolNameFor_initialAnswer_.st Log Message: ----------- 60177 18909 Monkey broken because System-CommandLine-TextSupport unloaded in 60164 https://pharo.fogbugz.com/f/cases/18909 18866 Rename protocol window title is ambiguous https://pharo.fogbugz.com/f/cases/18866 http://files.pharo.org/image/60/60177.zip

Aug. 11, 2016

Re: [Pharo-dev] request for improvements in GTInspector or debugger

by Christophe Demarey

Hi, > Le 10 aoÃ»t 2016 Ã 14:11, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : > > Hi Stef, > > I agree with what you say in this mail, and I am not sure where this is not the case. By example, it is not available in a String presentation of GTInspector. This one always forces me to go to the raw presentation and use the comment. Would it be possible to use global shortcuts in String presentation (cmd+B, cmd+M, cmd+N, etc.)? Christophe

Aug. 11, 2016

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by stepharo

tx Bernhard. Indeed this is a nice suggestion. Le 10/8/16 Ã 20:41, Bernhard Pieber a Ã©crit : > And this is how it works in VA Smalltalk. The default shortcut to expand the abbreviations used there is Shift-Space. See this excellent video by the late James Robertson: https://www.youtube.com/watch?v=TY_rJ3G0Tn4 > > If the same default abbreviations were used as in VA Smalltalk, this would be even cooler. No need to relearn. > > Cheers, > Bernhard > >> Am 03.08.2016 um 10:56 schrieb Ben Coman <btc(a)openinworld.com>: >> >> On Wed, Aug 3, 2016 at 4:36 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >>> I will just re-post my first answer: >>> >>> if reintroduce them means reintroduce them hardcoded as before, then Iâm >>> complete against it and I WILL NOT integrate such solution. >>> Iâm sorry for being so strong here, but previous implementation was lame and >>> we need to get rid of them. >>> >>> Now, I understand people are used to use those bindings and also some others >>> (no idea which ones because I never used themâ¦ for me ocompletion is good >>> enoughâ¦ but those are tastes). So I would be very happy to integrate a >>> generic way to define keybindings and outputs (which is already there, with >>> keymapping, but I mean an editor or something), and I would be very happy to >>> integrate a default configuration (which of course, will include >>> #ifTrue:/##ifFalse:) >> I would guess code expansions could be many and varied between >> different individuals, and quickly consume available keyboard >> shortcuts. Perhaps a generic mechanism would be single shortcut for >> "code expansion" which processes the letters preceding the cursor. >> For example, using shortcut <ctrl-e> for code expansion and typing... >> >> itf<ctrl-e> >> >> ==> ifTrue: [ ] ifFalse: [ ] >> >> The could be an interface to define these code expansions - initially >> at least on a purely personal basis. >> >>> And this is not really for adding a new feature. This shortcut already (always :) ) existed >> With a single shortcut for code expansion, perhaps a few other >> existing combinations could be freed up. >> >> cheers -ben >> >>> Esteban >>> >>> On 03 Aug 2016, at 10:30, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: >>> >>> >>> 2016-08-03 10:27 GMT+02:00 Guille Polito <guillermopolito(a)gmail.com>: >>>> I'm also against. >>>> >>>> - They take a place in the shortcuts that prevents others to use it >>>> - If lazy people really needs this, the code completion should be >>>> enhanced. This is a code completion concern... >>> >>> +1 >>> >>> > >

Aug. 10, 2016

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by Bernhard Pieber

And this is how it works in VA Smalltalk. The default shortcut to expand the abbreviations used there is Shift-Space. See this excellent video by the late James Robertson: https://www.youtube.com/watch?v=TY_rJ3G0Tn4 If the same default abbreviations were used as in VA Smalltalk, this would be even cooler. No need to relearn. Cheers, Bernhard > Am 03.08.2016 um 10:56 schrieb Ben Coman <btc(a)openinworld.com>: > > On Wed, Aug 3, 2016 at 4:36 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >> I will just re-post my first answer: >> >> if reintroduce them means reintroduce them hardcoded as before, then Iâm >> complete against it and I WILL NOT integrate such solution. >> Iâm sorry for being so strong here, but previous implementation was lame and >> we need to get rid of them. >> >> Now, I understand people are used to use those bindings and also some others >> (no idea which ones because I never used themâ¦ for me ocompletion is good >> enoughâ¦ but those are tastes). So I would be very happy to integrate a >> generic way to define keybindings and outputs (which is already there, with >> keymapping, but I mean an editor or something), and I would be very happy to >> integrate a default configuration (which of course, will include >> #ifTrue:/##ifFalse:) > > I would guess code expansions could be many and varied between > different individuals, and quickly consume available keyboard > shortcuts. Perhaps a generic mechanism would be single shortcut for > "code expansion" which processes the letters preceding the cursor. > For example, using shortcut <ctrl-e> for code expansion and typing... > > itf<ctrl-e> > > ==> ifTrue: [ ] ifFalse: [ ] > > The could be an interface to define these code expansions - initially > at least on a purely personal basis. > >> And this is not really for adding a new feature. This shortcut already (always :) ) existed > > With a single shortcut for code expansion, perhaps a few other > existing combinations could be freed up. > > cheers -ben > >> >> Esteban >> >> On 03 Aug 2016, at 10:30, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: >> >> >> 2016-08-03 10:27 GMT+02:00 Guille Polito <guillermopolito(a)gmail.com>: >>> >>> I'm also against. >>> >>> - They take a place in the shortcuts that prevents others to use it >>> - If lazy people really needs this, the code completion should be >>> enhanced. This is a code completion concern... >> >> >> +1 >> >> >

Aug. 10, 2016

Re: [Pharo-dev] GT-Spotter dive in shortcut

by Tudor Girba

Oh man :). Ok I think got it now. Thanks for the patience. I see the confusion: the agreement was that we will override the shortcut in the Spotter text-input. So, letâs go for this. The layering thing was supposed to be a separate issue. Cheers, Doru > On Aug 10, 2016, at 12:05 AM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > 2016-08-09 23:36 GMT+02:00 Tudor Girba <tudor(a)tudorgirba.com>: > Hi, > > > On Aug 9, 2016, at 11:31 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > > > > > 2016-08-09 22:53 GMT+02:00 Tudor Girba <tudor(a)tudorgirba.com>: > > Hi, > > > > > On Aug 9, 2016, at 10:48 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > > > > > > > > > 2016-08-09 18:12 GMT+02:00 Tudor Girba <tudor(a)tudorgirba.com>: > > > Hi, > > > > > > > > > > > Hey Doru, > > > > about what "two issues" are we talking? My only issue for now is, > > > > what shortcut shold we use for moving the cursor forward/backward word. Even if we introduce a new layer, at some point in time you need to > > > > define: If the user types the CTRL+LEFT -key, even if we call it differently, some action happens, dive-out or move-backward-word ? > > > > At the moment (on windows) you can use both to move word-by-word: > > > > ctrl+left/right and alt+left/right, because this is how it is defined in rubrics action/cmdaction map. > > > > > > > > If we want to clean this up and use the kmdispatcher registration, I think we don't want to use both ctr and alt again, right? > > > > So, someone has to take the decision. > > > > I myself would prefer > > > > ctrl+left/right because this is what (all) many other programs are using on windows. Fine. But recently Spotter changed its > > > > dive in / dive out shortcut to use ctrl+left/right. > > > > Therefor I am asking you, why, and whether we want to keep it or not. If we want to keep it, we may > > > > - just overwrite the binding for the textfield -> not good, I think, you wouldn't be able to do word-by-word movements in the textfield anymore > > > > - overwrite the binding and use another binding for word-by-word moving, but just in spotters text field > > > > Or we revert that change and use the old shortcuts again. > > > > (And what to use for mac and linux?) > > > > > > > > but I am getting really tired of asking, and will do something else instead. > > > > > > The short answer: we will override the keybinding in the text morph for now. This will mean that we cannot move word by word in the text field using #control, but it will be consistent with all other platforms. Could you open an issue for this, please? > > > > > > > > > consistens on all platforms may not be the expectation for all users. Some users only working on a windows platform may want to have consistent behavior for all tools (applications). > > > > Well, you wanted a decision :). > > > > > > > On top of that, we will externalize all GTSpotter shortcuts through settings: > > > https://pharo.fogbugz.com/f/cases/18455/Spotter-shortcuts-should-be-externa… > > > > > > I really don't know why that. > > > > Because we do not have a generic KMDispatcher mechanism :). > > > > yes and it does not make much sense as not all shortcuts are handled by the kmdispatcher, thats why cleaning this > > up and I think it would be better to do this instead of implementing yet another only-for-this-tool solution. > > Ok. What should I do? > > > > > We don't need a way to make Spotter shortcuts configurable, but *all* shortcuts. > > > That is why I try to move all shortcut definitions to the kmdispatcher, but it yet again took 2 month just to discuss what shortcut to use for cursor movement. > > > > I am not sure I understand. Was this me that stalled the discussion? If yes, it was not intentional. Is there anything I can do about this subject? > > > > The whole discussion, the me: "hey, what shortcut to use?" you:"hey we have a great idea, just let us add some new layers" :( > > I think I miss something because I do not see how the layers have anything to do with the cursor movement. Or do you mean for diving in Spotter? I still think that the layers idea is a relevant one and does not conflict with anything we talked about here. > > Ok once again. > ctrl+arrow and meta+arrow both do cursor movements in rubrik, but it is registered on the action/cmd-map (RubTextEditor>>defaultCommandKeymapping) > ctrl+arrow do dive-in/dive-out in spotter, this is registered on spotters window, and this takes precedence over rubrics crtrl+Arrow handling because : > > 1. kmdispatcher looks in rubrics editor kmregistry -> no action > 2. kmdispatcher looks in rubrics morph kmregistry -> no action > .... up the morphs owner chain until it reaches spotter > x. kmdispatcher looks in spotters window morph kmregistry -> Action! Dive-in / Dive-out > > Now! If I move ctrl+Arrow shortcut registration for cursor movement from rubrics action/-cmd-map to its kmdispatcher registration, the following happens > 1. kmdispatcher looks in rubrics editor kmregistry -> Action ! move the cursor > > -> no spotter dive-in/dive-out anymore :-( > > two solutions: > use a different shortcut for cursor movement (that is what I aksed in this thread, and why I opened issue 18432) > use a different shortcut for spotter (this is why I started this thread and asked why this was changed at all) > overwrite spotters shortcut registration (just like now, but not on spotters window, but on the text field (I opened now a fogbugz issue 18900)) > > anyway, you said, you want to wait with changing spotters shortcut registration until we have the new layers, therefore I can only wait until that > happens. > > > > > In any case, I did not mean to confuse anyone. Please take the lead concerning the KMDispatcher and I can review if you want. > > Doru > > > > > Cheers, > > Doru > > > > > > > > > > Long answer: As explained before, the shortcut changed in the process of making all shortcuts uniform when Guille introduced #meta instead of #command (like it was before). The thing is that currently: > > > - #command means #alt on Win and #command on Mac, and > > > - #meta means #control on Win and #command on Mac. > > > > > > But, #command should be a low level key, not a portable one. It should not have a meaning on Windows, because the key does not exist on that platform. > > > > > > Moving to make keybindings uniform is a good thing, but only having #meta is not enough for situation like the one you mention. That is why I am proposing to introduce a #secondaryMeta as a platform-independent modifier that would mean #alt on Win and #control on Mac. We could use that one more consistently. Is this a better explanation? > > > > > > Cheers, > > > Doru > > > > > > > > > -- > > > www.tudorgirba.com > > > www.feenk.com > > > > > > "Presenting is storytelling." > > > > -- > > www.tudorgirba.com > > www.feenk.com > > > > "One cannot do more than one can do." > > -- > www.tudorgirba.com > www.feenk.com > > "When people care, great things can happen." -- www.tudorgirba.com www.feenk.com "Problem solving efficiency grows with the abstractness level of problem understanding."

Aug. 10, 2016