- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] missing message pattern in pharo 5.0 gives misleading error message:

by Nicolai Hess

2016-08-12 20:30 GMT+02:00 Dale Henrichs <dale.henrichs(a)gemtalksystems.com>: > `'|' expected` is not the error message I would expect when the message > pattern is missing from a method and I try to accept in browser: > > > | text | > text '|' expected ->:= self requestPassword > ifTrue: [ UIManager default requestPassword: self prompt ] > ifFalse: [ UIManager default request: self prompt initialAnswer: > self template ]. > ^ (text isNil or: [ text isEmpty ]) > ifTrue: [ nil ] > ifFalse: [ text ] > > The highlighter was also confused turning red at the `->` instead at the > very beginning of the method ... > yeah, this is a funny one. I onced debugged the parser to find out why that's happening. Can you spot why this is a valid method : | text | | ^ text :) > > Dale > >

Aug. 12, 2016

missing message pattern in pharo 5.0 gives misleading error message:

by Dale Henrichs

`'|' expected` is not the error message I would expect when the message pattern is missing from a method and I try to accept in browser: | text | text '|' expected ->:= self requestPassword ifTrue: [ UIManager default requestPassword: self prompt ] ifFalse: [ UIManager default request: self prompt initialAnswer: self template ]. ^ (text isNil or: [ text isEmpty ]) ifTrue: [ nil ] ifFalse: [ text ] The highlighter was also confused turning red at the `->` instead at the very beginning of the method ... Dale

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-12 19:31 GMT+02:00 stepharo <stepharo(a)free.fr>: > I like the idea to use shift to activate it. > > Ok, I 'll can change it. > Le 12/8/16 Ã 19:19, Nicolai Hess a Ã©crit : > > > > 2016-08-12 19:09 GMT+02:00 stepharo <stepharo(a)free.fr>: > >> Hi nicolai >> >> It is nice. I would not put the border in black. >> >> What is needed to integrate it. >> > I put the issue to "Resolved ", so the monkey can check. > The background color is the same as for "secondary selection" and the > border color is the same "muchDarker". > > Of course, we can integrate it and change the color later. > > > >> Stef >> Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : >> >> I opened an issue >> >> 18901 >> <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> >> Highlight message send selector on mouse over >> >> with an experimental implementation. >> >> Just load the slice, enable the setting: >> RubAbstractTextArea highlightMessageSend: true. >> >> Now open a code editor (nautilus/MessageBrowser) and >> move the mouse over a message send. >> >> Or evaluate this code, it opens a text editor on a method, where it is >> difficult >> to see which part of the code belongs to which method: >> >> evaluate: >> TextModel new beForCode; aboutToStyle:true;behavior: >> MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) >> sourceCode;openWithSpec. >> >> >> feedback welcome. >> >> nicolai >> >> >> > >

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by stepharo

I like the idea to use shift to activate it. Le 12/8/16 Ã 19:19, Nicolai Hess a Ã©crit : > > > 2016-08-12 19:09 GMT+02:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > Hi nicolai > > It is nice. I would not put the border in black. > > What is needed to integrate it. > > I put the issue to "Resolved ", so the monkey can check. > The background color is the same as for "secondary selection" and the > border color is the same "muchDarker". > > Of course, we can integrate it and change the color later. > > Stef > > Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : >> I opened an issue >> >> 18901 >> <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> >> Highlight message send selector on mouse over >> >> with an experimental implementation. >> >> Just load the slice, enable the setting: >> RubAbstractTextArea highlightMessageSend: true. >> >> Now open a code editor (nautilus/MessageBrowser) and >> move the mouse over a message send. >> >> Or evaluate this code, it opens a text editor on a method, where >> it is difficult >> to see which part of the code belongs to which method: >> >> evaluate: >> TextModel new beForCode; aboutToStyle:true;behavior: >> MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) >> sourceCode;openWithSpec. >> >> >> feedback welcome. >> >> nicolai > >

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-12 19:09 GMT+02:00 stepharo <stepharo(a)free.fr>: > Hi nicolai > > It is nice. I would not put the border in black. > > What is needed to integrate it. > I put the issue to "Resolved ", so the monkey can check. The background color is the same as for "secondary selection" and the border color is the same "muchDarker". Of course, we can integrate it and change the color later. > Stef > Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : > > I opened an issue > > 18901 > <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> > Highlight message send selector on mouse over > > with an experimental implementation. > > Just load the slice, enable the setting: > RubAbstractTextArea highlightMessageSend: true. > > Now open a code editor (nautilus/MessageBrowser) and > move the mouse over a message send. > > Or evaluate this code, it opens a text editor on a method, where it is > difficult > to see which part of the code belongs to which method: > > evaluate: > TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) > sourceCode;openWithSpec. > > > feedback welcome. > > nicolai > > >

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by stepharo

Hi nicolai It is nice. I would not put the border in black. What is needed to integrate it. Stef Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : > I opened an issue > > 18901 > <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> > Highlight message send selector on mouse over > > with an experimental implementation. > > Just load the slice, enable the setting: > RubAbstractTextArea highlightMessageSend: true. > > Now open a code editor (nautilus/MessageBrowser) and > move the mouse over a message send. > > Or evaluate this code, it opens a text editor on a method, where it > is difficult > to see which part of the code belongs to which method: > > evaluate: > TextModel new beForCode; aboutToStyle:true;behavior: > MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) > sourceCode;openWithSpec. > > > feedback welcome. > > nicolai

Aug. 12, 2016

Re: [Pharo-dev] request for improvements in GTInspector or debugger

by Tudor Girba

Hi, We will change the presentation for String to use the new one :) Doru > On Aug 12, 2016, at 9:23 AM, Christophe Demarey <christophe.demarey(a)inria.fr> wrote: > > Hi Doru, > > Will the new presentation be the default one? > If the new presentation will not be the default presentation for a String, it wonât be useful as we can already use the raw presentation. > >> Le 12 aoÃ»t 2016 Ã 06:22, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : >> >> Hi, >> >> Nice one. >> >> But, I do not want to change the default text presentation. Instead I would add another presentation. We can call it pharoText. Could you please open an issue for this? >> >> Doru >> >> >>> On Aug 11, 2016, at 2:12 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >>> >>> >>> >>> 2016-08-11 13:44 GMT+02:00 Christophe Demarey <christophe.demarey(a)inria.fr>: >>> Hi, >>> >>>> Le 10 aoÃ»t 2016 Ã 14:11, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : >>>> >>>> Hi Stef, >>>> >>>> I agree with what you say in this mail, and I am not sure where this is not the case. >>> >>> >>> By example, it is not available in a String presentation of GTInspector. This one always forces me to go to the raw presentation and use the comment. >>> Would it be possible to use global shortcuts in String presentation (cmd+B, cmd+M, cmd+N, etc.)? >>> >>> Christophe >>> >>> >>> You could change >>> GLMMorphicRubricTextRenderer>>#morph to act with smalltalk comment mode >>> >>> morph >>> ^ RubScrolledTextMorph new >>> getSelectionSelector: #primarySelectionInterval; >>> color: Smalltalk ui theme backgroundColor; >>> textColor: Smalltalk ui theme textColor; >>> textFont: StandardFonts defaultFont; >>> model: textModel; >>> beForSmalltalkComment; >>> yourself. >>> >>> >>> This way, it behaves like the comment pane in Nautilus, it renders the text as "text" with the default font, no menu, but allows the common code mode shortcuts >>> cmd+b cmd+M, ( and some that doesn't make sense for every selection, like cmd+i for inspect). >>> >>> >> >> -- >> www.tudorgirba.com >> www.feenk.com >> >> "Quality cannot be an afterthought." >> >> > > -- www.tudorgirba.com www.feenk.com "The coherence of a trip is given by the clearness of the goal."

Aug. 12, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60179 Home: https://github.com/pharo-project/pharo-core

Aug. 12, 2016

[pharo-project/pharo-core] 631a5a: 60179

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 631a5a977701f9d2a35dad5c42fba3a9bd70d000 https://github.com/pharo-project/pharo-core/commit/631a5a977701f9d2a35dad5c… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-12 (Fri, 12 Aug 2016) Changed paths: M AST-Core.package/RBArrayNode.class/instance/matching/match_inContext_.st A AST-Tests-Core.package/RBParseTreeRewriterTest.class/instance/tests - to be refined/testRewriteDynamicArray.st A AST-Tests-Core.package/RBParseTreeSearcherTest.class/instance/tests - to de refined/testDynamicArrayStatements.st M Kernel.package/AdditionalMethodState.class/instance/accessing/at_ifAbsentPut_.st M Kernel.package/AdditionalMethodState.class/instance/accessing/at_put_.st A Kernel.package/AdditionalMethodState.class/instance/properties-compatibility/propertyValueAt_.st A Kernel.package/AdditionalMethodState.class/instance/properties-compatibility/propertyValueAt_ifAbsent_.st A Kernel.package/AdditionalMethodState.class/instance/properties/propertyAt_.st A Kernel.package/AdditionalMethodState.class/instance/properties/propertyAt_ifAbsent_.st R Kernel.package/AdditionalMethodState.class/instance/properties/propertyValueAt_.st R Kernel.package/AdditionalMethodState.class/instance/properties/propertyValueAt_ifAbsent_.st M Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/hasProperty_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_ifAbsentPut_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_ifAbsent_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_put_.st R Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyValueAt_.st R Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyValueAt_ifAbsent_.st R Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyValueAt_put_.st M Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/removeProperty_.st M Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/removeProperty_ifAbsent_.st A Kernel.package/CompiledMethod.class/instance/accessing-properties - compatibility/propertyValueAt_.st A Kernel.package/CompiledMethod.class/instance/accessing-properties - compatibility/propertyValueAt_ifAbsent_.st A Kernel.package/CompiledMethod.class/instance/accessing-properties - compatibility/propertyValueAt_put_.st M Kernel.package/Deprecation.class/README.md M Reflectivity.package/extension/CompiledMethod/instance/reflectiveMethod.st M Reflectivity.package/extension/CompiledMethod/instance/reflectiveMethod_.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60178.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60179.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60178.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60179.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/extension/CompiledMethod/instance/saveTemp_.st M Slot.package/extension/CompiledMethod/instance/savedTemps.st Log Message: ----------- 60179 18910 MNU: OrderedCollection>>parent: when trying to rewrite a tree with RBParseTreeRewriter https://pharo.fogbugz.com/f/cases/18910 18911 unify property API of CompiledMethod with all the others (Class, AST...) https://pharo.fogbugz.com/f/cases/18911 18912 update comment Deprecation https://pharo.fogbugz.com/f/cases/18912 http://files.pharo.org/image/60/60179.zip

Aug. 12, 2016

Re: [Pharo-dev] request for improvements in GTInspector or debugger

by Christophe Demarey

Hi Doru, Will the new presentation be the default one? If the new presentation will not be the default presentation for a String, it wonât be useful as we can already use the raw presentation. > Le 12 aoÃ»t 2016 Ã 06:22, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : > > Hi, > > Nice one. > > But, I do not want to change the default text presentation. Instead I would add another presentation. We can call it pharoText. Could you please open an issue for this? > > Doru > > >> On Aug 11, 2016, at 2:12 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >> >> >> >> 2016-08-11 13:44 GMT+02:00 Christophe Demarey <christophe.demarey(a)inria.fr>: >> Hi, >> >>> Le 10 aoÃ»t 2016 Ã 14:11, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : >>> >>> Hi Stef, >>> >>> I agree with what you say in this mail, and I am not sure where this is not the case. >> >> >> By example, it is not available in a String presentation of GTInspector. This one always forces me to go to the raw presentation and use the comment. >> Would it be possible to use global shortcuts in String presentation (cmd+B, cmd+M, cmd+N, etc.)? >> >> Christophe >> >> >> You could change >> GLMMorphicRubricTextRenderer>>#morph to act with smalltalk comment mode >> >> morph >> ^ RubScrolledTextMorph new >> getSelectionSelector: #primarySelectionInterval; >> color: Smalltalk ui theme backgroundColor; >> textColor: Smalltalk ui theme textColor; >> textFont: StandardFonts defaultFont; >> model: textModel; >> beForSmalltalkComment; >> yourself. >> >> >> This way, it behaves like the comment pane in Nautilus, it renders the text as "text" with the default font, no menu, but allows the common code mode shortcuts >> cmd+b cmd+M, ( and some that doesn't make sense for every selection, like cmd+i for inspect). >> >> > > -- > www.tudorgirba.com > www.feenk.com > > "Quality cannot be an afterthought." > >

Aug. 12, 2016