- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Cycles lost on startup

by Nicolai Hess

2016-09-06 11:47 GMT+02:00 Henrik Nergaard <henrik.nergaard(a)uia.no>: > Rewriting the implementation of #initSelectorTable to: > > > > SelectorTable := WeakSet withAll: (CompiledMethod allInstances collect: > [:m | m selector] as: IdentitySet). > > > > Makes it 20ms faster, so it looks like there is some overhead when using > WeakSet compared to first use a normal set to remove duplicates. > > > > Another possibility could be to store the selectors in an > IdentityDictionary as #selector->count which keep track of how many users > of a selector there is itself, instead of using a WeakArray. > > > > Best regards, > > Henrik > Maybe we can just move the rebuilding to the image shutdown instead of the image startup ? > > > *From:* Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] *On Behalf > Of *Nicolai Hess > *Sent:* Monday, September 5, 2016 7:52 PM > *To:* Pharo Development List <pharo-dev(a)lists.pharo.org> > *Subject:* Re: [Pharo-dev] Cycles lost on startup > > > > > > > > 2016-09-05 18:37 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > > Hi All, > > > > we are simulating a full block Pharo image derived from Pharo 6. On > startup we see a very sad loss of cycles due to a very slow rebuild of the > selector table in Symbol class. Why is this done at each startup? Here is > the stack: > > > > 16r107154 M ByteString class(ProtoObject)>identityHash 16r786AE8: a(n) > ByteString class > > 16r10716C M ByteString class(Object)>hash 16r786AE8: a(n) ByteString > class > > 16r10718C M ByteSymbol(String)>hash 16rE6A5C8: a(n) ByteSymbol > > 16r1071B0 M WeakSet>scanForEmptySlotFor: 16r26B968: a(n) WeakSet > > 16r1071DC M WeakSet>noCheckNoGrowFillFrom: 16r26B968: a(n) WeakSet > > 16r1071FC M WeakSet>growTo: 16r26B968: a(n) WeakSet > > 16r10721C M WeakSet>grow 16r26B968: a(n) WeakSet > > 16r107234 M WeakSet(HashedCollection)>fullCheck 16r26B968: a(n) WeakSet > > 16r10724C M WeakSet(HashedCollection)>atNewIndex:put: 16r26B968: a(n) > WeakSet > > 16r107274 M WeakSet>add: 16r26B968: a(n) WeakSet > > 16r107294 M [] in Symbol class>(nil) 16r1D319A8: a(n) Symbol class > > 16r1072B8 M Array(SequenceableCollection)>do: 16r3C17370: a(n) Array > > 16r1072E8 I CompiledMethod class(Behavior)>allInstancesDo: 16r164E260: > a(n) CompiledMethod class > > 16r10730C I Symbol class>initSelectorTable 16r1D319A8: a(n) Symbol class > > 16r10732C I Symbol class>selectorTable 16r1D319A8: a(n) Symbol class > > 16r107350 I Symbol class>internSelector: 16r1D319A8: a(n) Symbol class > > 16r10737C I CompiledMethod>selector: 16r26AB58: a(n) CompiledMethod > > 16r1073A4 I IRMethod>generate: 16r25A030: a(n) IRMethod > > 16r1073CC I FFICalloutMethodBuilder>generateMethodFromSpec: 16r255580: > a(n) FFICalloutMethodBuilder > > 16r1073F0 I FFICalloutMethodBuilder>generate 16r255580: a(n) > FFICalloutMethodBuilder > > 16r1030C8 I FFICalloutMethodBuilder>build: 16r255580: a(n) > FFICalloutMethodBuilder > > 16r1030F4 I FFICalloutAPI>function:module: 16r255568: a(n) FFICalloutAPI > > 16r10311C I UnixEnvironment(Object)>ffiCall:module: 16r3816180: a(n) > UnixEnvironment > > 16r103144 I UnixEnvironment(OSEnvironment)>getEnv: 16r3816180: a(n) > UnixEnvironment > > 16r103168 I UnixEnvironment(OSEnvironment)>at:ifAbsent: 16r3816180: > a(n) UnixEnvironment > > 16r10318C M [] in MacOSResolver>(nil) 16r241170: a(n) MacOSResolver > > 16r1031A4 M FullBlockClosure(BlockClosure)>on:do: 16r2553F0: a(n) > FullBlockClosure > > 16r1031D0 I MacOSResolver(PlatformResolver)> > directoryFromEnvVariableNamed:or: 16r241170: a(n) MacOSResolver > > 16r1031F8 I MacOSResolver(PlatformResolver)>directoryFromEnvVariableNamed: > 16r241170: a(n) MacOSResolver > > 16r10321C I MacOSResolver>home 16r241170: a(n) MacOSResolver > > 16r10323C I MacOSResolver>userLibrary 16r241170: a(n) MacOSResolver > > 16r103254 M MacOSResolver>userApplicationSupport 16r241170: a(n) > MacOSResolver > > 16r10326C M MacOSResolver(FileSystemResolver)>resolve: 16r241170: a(n) > MacOSResolver > > 16r103288 M SystemResolver(FileSystemResolver)>unknownOrigin: > 16r240D30: a(n) SystemResolver > > 16r1032A4 M SystemResolver(FileSystemResolver)>resolve: 16r240D30: a(n) > SystemResolver > > 16r1032C4 M InteractiveResolver>unknownOrigin: 16r240CF0: a(n) > InteractiveResolver > > 16r1032E4 M [] in InteractiveResolver>(nil) 16r240CF0: a(n) > InteractiveResolver > > 16r103300 M IdentityDictionary(Dictionary)>at:ifAbsent: 16r240D00: a(n) > IdentityDictionary > > 16r103320 M InteractiveResolver>resolve: 16r240CF0: a(n) > InteractiveResolver > > 16r10333C M FileLocator>resolve 16r255258: a(n) FileLocator > > 16r103354 M FileLocator(AbstractFileReference)>exists 16r255258: a(n) > FileLocator > > 16r10337C M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener > > 16r103398 M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener > > 16r1033B0 M FullBlockClosure(BlockClosure)>on:do: 16r255190: a(n) > FullBlockClosure > > 16r1033D0 M FullBlockClosure(BlockClosure)>ifError: 16r255190: a(n) > FullBlockClosure > > 16r1033EC M PharoFilesOpener>ignoreIfFail: 16rE79FD8: a(n) > PharoFilesOpener > > 16r102188 M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener > > 16r1021AC M Array(SequenceableCollection)>do: 16r2495E8: a(n) Array > > 16r1021DC I PharoFilesOpener>openSources:forImage: 16rE79FD8: a(n) > PharoFilesOpener > > 16r102204 I PharoFilesOpener>openSources 16rE79FD8: a(n) PharoFilesOpener > > 16r102228 I PharoFilesOpener>sourcesFileOrNil 16rE79FD8: a(n) > PharoFilesOpener > > 16r10224C I SourceFileArray>ensureOpen 16r8AA128: a(n) SourceFileArray > > 16r10226C I SmalltalkImage>openSourceFiles 16rA58A28: a(n) SmalltalkImage > > 16r10228C I SmalltalkImage class>startUp: 16rFDA6A8: a(n) SmalltalkImage > class > > 16r1022A8 M ClassSessionHandler>startup: 16r8B8978: a(n) > ClassSessionHandler > > 16r1022C8 M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession > > 16r1022EC M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession > > 16r102304 M FullBlockClosure(BlockClosure)>on:do: 16r245640: a(n) > FullBlockClosure > > 16r102328 M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession > > 16r10234C M Array(SequenceableCollection)>do: 16r1A47B8: a(n) Array > > 16r102370 I WorkingSession>runList:do: 16r1A45D0: a(n) WorkingSession > > 16r102398 I WorkingSession>runStartup: 16r1A45D0: a(n) WorkingSession > > 16r1023BC I WorkingSession>start: 16r1A45D0: a(n) WorkingSession > > 16r1023E8 I SessionManager>snapshot:andQuit: 16r17AA950: a(n) > SessionManager > > > > You'll see that Symbol class>selectorTable calls Symbol class> > initSelectorTable which then calls CompiledMethod class(Behavior)>allInstancesDo: > to enumerate over all methods. This takes a significant amount of time, > even on a fast machine. For example, on a 2.%GHz machine this takes about > 70 milliseconds. That's a /lot/ of time to squander on startup. And it > will grow the larger the image is. > > > > Hm, I didn't thought about that. > > > > > > The selector table seems to be discarded on shut-down, which seems > pointless. If one wants to recompute the table then before or after > methods are added or removed seems like a better choice, not on every image > startup. > > > > I think I wanted to be on the save side and just discard on shutdown and > rebuild on startup to be sure to have the correct set of selector symbols. > > > > > > In around 2000 we were able to startup VisualWorks images in about 40 > milliseconds on the hardware available at the time. I hope someone > reconsiders this code and a avoids recomputing the selector table on each > startup. > > > > I will take a look and try to find a better way. > > nicolai > > > > _,,,^..^,,,_ > > best, Eliot > > >

Sept. 6, 2016

Re: [Pharo-dev] ConfigurationOfFlatGTCollaborate is broken in catalog

by Esteban Lorenzano

you canât you want me to remove it? > On 06 Sep 2016, at 12:10, Juraj Kubelka <juraj.kubelka(a)icloud.com> wrote: > > How can I remove it? > > -- > Juraj Kubelka > >> El 6 sept 2016, a las 4:21, Esteban Lorenzano <estebanlm(a)gmail.com> escribiÃ³: >> >> Please fix. >> >> most probably is because you do not have a correct config, which means: a baseline (even if not used), a version and a symbolic version #stable. >> >> Esteban >

Sept. 6, 2016

Re: [Pharo-dev] ConfigurationOfFlatGTCollaborate is broken in catalog

by Juraj Kubelka

How can I remove it? -- Juraj Kubelka > El 6 sept 2016, a las 4:21, Esteban Lorenzano <estebanlm(a)gmail.com> escribiÃ³: > > Please fix. > > most probably is because you do not have a correct config, which means: a baseline (even if not used), a version and a symbolic version #stable. > > Esteban

Sept. 6, 2016

Re: [Pharo-dev] Cycles lost on startup

by Henrik Nergaard

Rewriting the implementation of #initSelectorTable to: SelectorTable := WeakSet withAll: (CompiledMethod allInstances collect: [:m | m selector] as: IdentitySet). Makes it 20ms faster, so it looks like there is some overhead when using WeakSet compared to first use a normal set to remove duplicates. Another possibility could be to store the selectors in an IdentityDictionary as #selector->count which keep track of how many users of a selector there is itself, instead of using a WeakArray. Best regards, Henrik From: Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] On Behalf Of Nicolai Hess Sent: Monday, September 5, 2016 7:52 PM To: Pharo Development List <pharo-dev(a)lists.pharo.org> Subject: Re: [Pharo-dev] Cycles lost on startup 2016-09-05 18:37 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com<mailto:eliot.miranda@gmail.com>>: Hi All, we are simulating a full block Pharo image derived from Pharo 6. On startup we see a very sad loss of cycles due to a very slow rebuild of the selector table in Symbol class. Why is this done at each startup? Here is the stack: 16r107154 M ByteString class(ProtoObject)>identityHash 16r786AE8: a(n) ByteString class 16r10716C M ByteString class(Object)>hash 16r786AE8: a(n) ByteString class 16r10718C M ByteSymbol(String)>hash 16rE6A5C8: a(n) ByteSymbol 16r1071B0 M WeakSet>scanForEmptySlotFor: 16r26B968: a(n) WeakSet 16r1071DC M WeakSet>noCheckNoGrowFillFrom: 16r26B968: a(n) WeakSet 16r1071FC M WeakSet>growTo: 16r26B968: a(n) WeakSet 16r10721C M WeakSet>grow 16r26B968: a(n) WeakSet 16r107234 M WeakSet(HashedCollection)>fullCheck 16r26B968: a(n) WeakSet 16r10724C M WeakSet(HashedCollection)>atNewIndex:put: 16r26B968: a(n) WeakSet 16r107274 M WeakSet>add: 16r26B968: a(n) WeakSet 16r107294 M [] in Symbol class>(nil) 16r1D319A8: a(n) Symbol class 16r1072B8 M Array(SequenceableCollection)>do: 16r3C17370: a(n) Array 16r1072E8 I CompiledMethod class(Behavior)>allInstancesDo: 16r164E260: a(n) CompiledMethod class 16r10730C I Symbol class>initSelectorTable 16r1D319A8: a(n) Symbol class 16r10732C I Symbol class>selectorTable 16r1D319A8: a(n) Symbol class 16r107350 I Symbol class>internSelector: 16r1D319A8: a(n) Symbol class 16r10737C I CompiledMethod>selector: 16r26AB58: a(n) CompiledMethod 16r1073A4 I IRMethod>generate: 16r25A030: a(n) IRMethod 16r1073CC I FFICalloutMethodBuilder>generateMethodFromSpec: 16r255580: a(n) FFICalloutMethodBuilder 16r1073F0 I FFICalloutMethodBuilder>generate 16r255580: a(n) FFICalloutMethodBuilder 16r1030C8 I FFICalloutMethodBuilder>build: 16r255580: a(n) FFICalloutMethodBuilder 16r1030F4 I FFICalloutAPI>function:module: 16r255568: a(n) FFICalloutAPI 16r10311C I UnixEnvironment(Object)>ffiCall:module: 16r3816180: a(n) UnixEnvironment 16r103144 I UnixEnvironment(OSEnvironment)>getEnv: 16r3816180: a(n) UnixEnvironment 16r103168 I UnixEnvironment(OSEnvironment)>at:ifAbsent: 16r3816180: a(n) UnixEnvironment 16r10318C M [] in MacOSResolver>(nil) 16r241170: a(n) MacOSResolver 16r1031A4 M FullBlockClosure(BlockClosure)>on:do: 16r2553F0: a(n) FullBlockClosure 16r1031D0 I MacOSResolver(PlatformResolver)>directoryFromEnvVariableNamed:or: 16r241170: a(n) MacOSResolver 16r1031F8 I MacOSResolver(PlatformResolver)>directoryFromEnvVariableNamed: 16r241170: a(n) MacOSResolver 16r10321C I MacOSResolver>home 16r241170: a(n) MacOSResolver 16r10323C I MacOSResolver>userLibrary 16r241170: a(n) MacOSResolver 16r103254 M MacOSResolver>userApplicationSupport 16r241170: a(n) MacOSResolver 16r10326C M MacOSResolver(FileSystemResolver)>resolve: 16r241170: a(n) MacOSResolver 16r103288 M SystemResolver(FileSystemResolver)>unknownOrigin: 16r240D30: a(n) SystemResolver 16r1032A4 M SystemResolver(FileSystemResolver)>resolve: 16r240D30: a(n) SystemResolver 16r1032C4 M InteractiveResolver>unknownOrigin: 16r240CF0: a(n) InteractiveResolver 16r1032E4 M [] in InteractiveResolver>(nil) 16r240CF0: a(n) InteractiveResolver 16r103300 M IdentityDictionary(Dictionary)>at:ifAbsent: 16r240D00: a(n) IdentityDictionary 16r103320 M InteractiveResolver>resolve: 16r240CF0: a(n) InteractiveResolver 16r10333C M FileLocator>resolve 16r255258: a(n) FileLocator 16r103354 M FileLocator(AbstractFileReference)>exists 16r255258: a(n) FileLocator 16r10337C M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener 16r103398 M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener 16r1033B0 M FullBlockClosure(BlockClosure)>on:do: 16r255190: a(n) FullBlockClosure 16r1033D0 M FullBlockClosure(BlockClosure)>ifError: 16r255190: a(n) FullBlockClosure 16r1033EC M PharoFilesOpener>ignoreIfFail: 16rE79FD8: a(n) PharoFilesOpener 16r102188 M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener 16r1021AC M Array(SequenceableCollection)>do: 16r2495E8: a(n) Array 16r1021DC I PharoFilesOpener>openSources:forImage: 16rE79FD8: a(n) PharoFilesOpener 16r102204 I PharoFilesOpener>openSources 16rE79FD8: a(n) PharoFilesOpener 16r102228 I PharoFilesOpener>sourcesFileOrNil 16rE79FD8: a(n) PharoFilesOpener 16r10224C I SourceFileArray>ensureOpen 16r8AA128: a(n) SourceFileArray 16r10226C I SmalltalkImage>openSourceFiles 16rA58A28: a(n) SmalltalkImage 16r10228C I SmalltalkImage class>startUp: 16rFDA6A8: a(n) SmalltalkImage class 16r1022A8 M ClassSessionHandler>startup: 16r8B8978: a(n) ClassSessionHandler 16r1022C8 M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession 16r1022EC M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession 16r102304 M FullBlockClosure(BlockClosure)>on:do: 16r245640: a(n) FullBlockClosure 16r102328 M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession 16r10234C M Array(SequenceableCollection)>do: 16r1A47B8: a(n) Array 16r102370 I WorkingSession>runList:do: 16r1A45D0: a(n) WorkingSession 16r102398 I WorkingSession>runStartup: 16r1A45D0: a(n) WorkingSession 16r1023BC I WorkingSession>start: 16r1A45D0: a(n) WorkingSession 16r1023E8 I SessionManager>snapshot:andQuit: 16r17AA950: a(n) SessionManager You'll see that Symbol class>selectorTable calls Symbol class> initSelectorTable which then calls CompiledMethod class(Behavior)>allInstancesDo: to enumerate over all methods. This takes a significant amount of time, even on a fast machine. For example, on a 2.%GHz machine this takes about 70 milliseconds. That's a /lot/ of time to squander on startup. And it will grow the larger the image is. Hm, I didn't thought about that. The selector table seems to be discarded on shut-down, which seems pointless. If one wants to recompute the table then before or after methods are added or removed seems like a better choice, not on every image startup. I think I wanted to be on the save side and just discard on shutdown and rebuild on startup to be sure to have the correct set of selector symbols. In around 2000 we were able to startup VisualWorks images in about 40 milliseconds on the hardware available at the time. I hope someone reconsiders this code and a avoids recomputing the selector table on each startup. I will take a look and try to find a better way. nicolai _,,,^..^,,,_ best, Eliot

Sept. 6, 2016

Re: [Pharo-dev] ConfigurationOfIconFactory is broken in catalog

by Peter UhnÃ¡k

Thanks, I'll take a look at it. It would be nice if there was some validator against which I can run the the configuration to see if it correct (so you don't have to manually test it and inform people). (e.g. instead of comitting to metarepo some web/cli registration (aka npm/...) that would tell me that my code is bad) Peter On Tue, Sep 6, 2016 at 9:21 AM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > Please fix. > > most probably is because you do not have a correct config, which means: a > baseline (even if not used), a version and a symbolic version #stable. > > Esteban >

Sept. 6, 2016

Re: [Pharo-dev] Cycles lost on startup

by Esteban Lorenzano

> On 05 Sep 2016, at 19:52, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > 2016-09-05 18:37 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com <mailto:eliot.miranda@gmail.com>>: > Hi All, > > we are simulating a full block Pharo image derived from Pharo 6. On startup we see a very sad loss of cycles due to a very slow rebuild of the selector table in Symbol class. Why is this done at each startup? Here is the stack: > > 16r107154 M ByteString class(ProtoObject)>identityHash 16r786AE8: a(n) ByteString class > 16r10716C M ByteString class(Object)>hash 16r786AE8: a(n) ByteString class > 16r10718C M ByteSymbol(String)>hash 16rE6A5C8: a(n) ByteSymbol > 16r1071B0 M WeakSet>scanForEmptySlotFor: 16r26B968: a(n) WeakSet > 16r1071DC M WeakSet>noCheckNoGrowFillFrom: 16r26B968: a(n) WeakSet > 16r1071FC M WeakSet>growTo: 16r26B968: a(n) WeakSet > 16r10721C M WeakSet>grow 16r26B968: a(n) WeakSet > 16r107234 M WeakSet(HashedCollection)>fullCheck 16r26B968: a(n) WeakSet > 16r10724C M WeakSet(HashedCollection)>atNewIndex:put: 16r26B968: a(n) WeakSet > 16r107274 M WeakSet>add: 16r26B968: a(n) WeakSet > 16r107294 M [] in Symbol class>(nil) 16r1D319A8: a(n) Symbol class > 16r1072B8 M Array(SequenceableCollection)>do: 16r3C17370: a(n) Array > 16r1072E8 I CompiledMethod class(Behavior)>allInstancesDo: 16r164E260: a(n) CompiledMethod class > 16r10730C I Symbol class>initSelectorTable 16r1D319A8: a(n) Symbol class > 16r10732C I Symbol class>selectorTable 16r1D319A8: a(n) Symbol class > 16r107350 I Symbol class>internSelector: 16r1D319A8: a(n) Symbol class > 16r10737C I CompiledMethod>selector: 16r26AB58: a(n) CompiledMethod > 16r1073A4 I IRMethod>generate: 16r25A030: a(n) IRMethod > 16r1073CC I FFICalloutMethodBuilder>generateMethodFromSpec: 16r255580: a(n) FFICalloutMethodBuilder > 16r1073F0 I FFICalloutMethodBuilder>generate 16r255580: a(n) FFICalloutMethodBuilder > 16r1030C8 I FFICalloutMethodBuilder>build: 16r255580: a(n) FFICalloutMethodBuilder > 16r1030F4 I FFICalloutAPI>function:module: 16r255568: a(n) FFICalloutAPI > 16r10311C I UnixEnvironment(Object)>ffiCall:module: 16r3816180: a(n) UnixEnvironment > 16r103144 I UnixEnvironment(OSEnvironment)>getEnv: 16r3816180: a(n) UnixEnvironment > 16r103168 I UnixEnvironment(OSEnvironment)>at:ifAbsent: 16r3816180: a(n) UnixEnvironment > 16r10318C M [] in MacOSResolver>(nil) 16r241170: a(n) MacOSResolver > 16r1031A4 M FullBlockClosure(BlockClosure)>on:do: 16r2553F0: a(n) FullBlockClosure > 16r1031D0 I MacOSResolver(PlatformResolver)>directoryFromEnvVariableNamed:or: 16r241170: a(n) MacOSResolver > 16r1031F8 I MacOSResolver(PlatformResolver)>directoryFromEnvVariableNamed: 16r241170: a(n) MacOSResolver > 16r10321C I MacOSResolver>home 16r241170: a(n) MacOSResolver > 16r10323C I MacOSResolver>userLibrary 16r241170: a(n) MacOSResolver > 16r103254 M MacOSResolver>userApplicationSupport 16r241170: a(n) MacOSResolver > 16r10326C M MacOSResolver(FileSystemResolver)>resolve: 16r241170: a(n) MacOSResolver > 16r103288 M SystemResolver(FileSystemResolver)>unknownOrigin: 16r240D30: a(n) SystemResolver > 16r1032A4 M SystemResolver(FileSystemResolver)>resolve: 16r240D30: a(n) SystemResolver > 16r1032C4 M InteractiveResolver>unknownOrigin: 16r240CF0: a(n) InteractiveResolver > 16r1032E4 M [] in InteractiveResolver>(nil) 16r240CF0: a(n) InteractiveResolver > 16r103300 M IdentityDictionary(Dictionary)>at:ifAbsent: 16r240D00: a(n) IdentityDictionary > 16r103320 M InteractiveResolver>resolve: 16r240CF0: a(n) InteractiveResolver > 16r10333C M FileLocator>resolve 16r255258: a(n) FileLocator > 16r103354 M FileLocator(AbstractFileReference)>exists 16r255258: a(n) FileLocator > 16r10337C M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener > 16r103398 M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener > 16r1033B0 M FullBlockClosure(BlockClosure)>on:do: 16r255190: a(n) FullBlockClosure > 16r1033D0 M FullBlockClosure(BlockClosure)>ifError: 16r255190: a(n) FullBlockClosure > 16r1033EC M PharoFilesOpener>ignoreIfFail: 16rE79FD8: a(n) PharoFilesOpener > 16r102188 M [] in PharoFilesOpener>(nil) 16rE79FD8: a(n) PharoFilesOpener > 16r1021AC M Array(SequenceableCollection)>do: 16r2495E8: a(n) Array > 16r1021DC I PharoFilesOpener>openSources:forImage: 16rE79FD8: a(n) PharoFilesOpener > 16r102204 I PharoFilesOpener>openSources 16rE79FD8: a(n) PharoFilesOpener > 16r102228 I PharoFilesOpener>sourcesFileOrNil 16rE79FD8: a(n) PharoFilesOpener > 16r10224C I SourceFileArray>ensureOpen 16r8AA128: a(n) SourceFileArray > 16r10226C I SmalltalkImage>openSourceFiles 16rA58A28: a(n) SmalltalkImage > 16r10228C I SmalltalkImage class>startUp: 16rFDA6A8: a(n) SmalltalkImage class > 16r1022A8 M ClassSessionHandler>startup: 16r8B8978: a(n) ClassSessionHandler > 16r1022C8 M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession > 16r1022EC M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession > 16r102304 M FullBlockClosure(BlockClosure)>on:do: 16r245640: a(n) FullBlockClosure > 16r102328 M [] in WorkingSession>(nil) 16r1A45D0: a(n) WorkingSession > 16r10234C M Array(SequenceableCollection)>do: 16r1A47B8: a(n) Array > 16r102370 I WorkingSession>runList:do: 16r1A45D0: a(n) WorkingSession > 16r102398 I WorkingSession>runStartup: 16r1A45D0: a(n) WorkingSession > 16r1023BC I WorkingSession>start: 16r1A45D0: a(n) WorkingSession > 16r1023E8 I SessionManager>snapshot:andQuit: 16r17AA950: a(n) SessionManager > > You'll see that Symbol class>selectorTable calls Symbol class> initSelectorTable which then calls CompiledMethod class(Behavior)>allInstancesDo: to enumerate over all methods. This takes a significant amount of time, even on a fast machine. For example, on a 2.%GHz machine this takes about 70 milliseconds. That's a /lot/ of time to squander on startup. And it will grow the larger the image is. > > Hm, I didn't thought about that. me neither. I think this is wrong behaviourâ¦ we need to check why it happens, but it smells bad. Esteban > > > The selector table seems to be discarded on shut-down, which seems pointless. If one wants to recompute the table then before or after methods are added or removed seems like a better choice, not on every image startup. > > I think I wanted to be on the save side and just discard on shutdown and rebuild on startup to be sure to have the correct set of selector symbols. > > > > In around 2000 we were able to startup VisualWorks images in about 40 milliseconds on the hardware available at the time. I hope someone reconsiders this code and a avoids recomputing the selector table on each startup. > > I will take a look and try to find a better way. > > > nicolai > > _,,,^..^,,,_ > best, Eliot

Sept. 6, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60205 Home: https://github.com/pharo-project/pharo-core

Sept. 6, 2016

[pharo-project/pharo-core] 061111: 60205

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 0611115ec3cc6b998c38c058ba2a55a36b73cc2f https://github.com/pharo-project/pharo-core/commit/0611115ec3cc6b998c38c058… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M ConfigurationOfFlatQA.package/ConfigurationOfFlatQA.class/instance/symbolic versions/stable_.st A ConfigurationOfFlatQA.package/ConfigurationOfFlatQA.class/instance/versions/versionv3%5F2%5F6_.st R QualityAssistant.package/QASettings.class/class/accessing/uniqueInstance.st R QualityAssistant.package/QASettings.class/class/cleanup/cleanUp.st R QualityAssistant.package/QASettings.class/class/properties/spotterExtMethods.st R QualityAssistant.package/QASettings.class/class/settings-accessing/inspectorPluggin.st R QualityAssistant.package/QASettings.class/class/settings-accessing/inspectorPluggin_.st R QualityAssistant.package/QASettings.class/class/settings-accessing/spotterPlugin.st R QualityAssistant.package/QASettings.class/class/settings-accessing/spotterPlugin_.st R QualityAssistant.package/QASettings.class/class/settings-definition/inspectorPlugginSettingsOn_.st R QualityAssistant.package/QASettings.class/class/settings-definition/spotterPluginSettingsOn_.st M QualityAssistant.package/QASettings.class/definition.st R QualityAssistant.package/QASettings.class/instance/accessing/inspectorPluggin.st R QualityAssistant.package/QASettings.class/instance/accessing/inspectorPluggin_.st R QualityAssistant.package/QASettings.class/instance/accessing/spotterPlugin.st R QualityAssistant.package/QASettings.class/instance/accessing/spotterPlugin_.st R QualityAssistant.package/QASettings.class/instance/initialization/initialize.st R QualityAssistant.package/extension/CompiledMethod/instance/glmSourcePresentationIn_.st R QualityAssistant.package/extension/CompiledMethod/instance/spotterQACritiquesFor_.st R QualityAssistant.package/extension/GTSpotterExtensionSettings/class/Behavior%5FspotterQACritiquesFor.st R QualityAssistant.package/extension/GTSpotterExtensionSettings/class/Behavior%5FspotterQACritiquesFor_.st R QualityAssistant.package/extension/GTSpotterExtensionSettings/class/CompiledMethod%5FspotterQACritiquesFor.st R QualityAssistant.package/extension/GTSpotterExtensionSettings/class/CompiledMethod%5FspotterQACritiquesFor_.st R QualityAssistant.package/extension/GTSpotterExtensionSettings/class/TraitBehavior%5FspotterQACritiquesFor.st R QualityAssistant.package/extension/GTSpotterExtensionSettings/class/TraitBehavior%5FspotterQACritiquesFor_.st R QualityAssistant.package/extension/RBProgramNode/instance/glmSourcePresentationIn_.st R QualityAssistant.package/extension/TBehavior/instance/glmSourcePresentationIn_.st R QualityAssistant.package/extension/TBehavior/instance/spotterQACritiquesFor_.st A QualityAssistantRecording.package/ManifestQualityAssistantRecording.class/README.md A QualityAssistantRecording.package/ManifestQualityAssistantRecording.class/class/release/preUnload.st A QualityAssistantRecording.package/ManifestQualityAssistantRecording.class/definition.st M QualityAssistantRecording.package/QAEventCollector.class/class/actions/recordMeta.st A Renraku.package/ManifestRenraku.class/README.md A Renraku.package/ManifestRenraku.class/class/release/preUnload.st A Renraku.package/ManifestRenraku.class/definition.st M Renraku.package/ReInvocationSequenceRule.class/instance/running/postCheck_forCriticsDo_.st M Renraku.package/ReInvocationSequenceRule.class/instance/running/preCheck_forCriticsDo_.st M Renraku.package/ReLaterInvocationCritic.class/README.md M Renraku.package/ReLaterInvocationCritic.class/class/instance creation/basicNew.st M Renraku.package/ReMissingMethodCritic.class/README.md M Renraku.package/ReMissingMethodCritic.class/class/instance creation/basicNew.st M Renraku.package/RePriorInvocationCritic.class/README.md M Renraku.package/RePriorInvocationCritic.class/class/instance creation/basicNew.st M Renraku.package/ReRuleManager.class/instance/accessing/excludedRuleNames.st A Renraku.package/ReSettings.class/class/properties/spotterExtMethods.st A Renraku.package/ReSettings.class/class/settings-accessing/inspectorPluggin.st A Renraku.package/ReSettings.class/class/settings-accessing/inspectorPluggin_.st A Renraku.package/ReSettings.class/class/settings-accessing/spotterPlugin.st A Renraku.package/ReSettings.class/class/settings-accessing/spotterPlugin_.st A Renraku.package/ReSettings.class/class/settings-definition/inspectorPlugginSettingsOn_.st A Renraku.package/ReSettings.class/class/settings-definition/spotterPluginSettingsOn_.st M Renraku.package/ReSettings.class/definition.st A Renraku.package/ReSettings.class/instance/accessing/inspectorPluggin.st A Renraku.package/ReSettings.class/instance/accessing/inspectorPluggin_.st A Renraku.package/ReSettings.class/instance/accessing/spotterPlugin.st A Renraku.package/ReSettings.class/instance/accessing/spotterPlugin_.st M Renraku.package/ReSettings.class/instance/initialization/initialize.st M Renraku.package/ReStringBasedCritic.class/README.md M Renraku.package/ReStringBasedCritic.class/class/instance creation/basicNew.st M Renraku.package/ReTransformationCritic.class/README.md M Renraku.package/ReTransformationCritic.class/class/instance creation/basicNew.st M Renraku.package/ReTrivialCritic.class/README.md A Renraku.package/extension/CompiledMethod/instance/glmSourcePresentationIn_.st A Renraku.package/extension/GTSpotterExtensionSettings/class/Object%5FspotterRePropertiesFor.st A Renraku.package/extension/GTSpotterExtensionSettings/class/Object%5FspotterRePropertiesFor_.st M Renraku.package/extension/Object/instance/gtInspectorEProportiesIn_.st A Renraku.package/extension/Object/instance/spotterRePropertiesFor_.st A Renraku.package/extension/RBProgramNode/instance/glmSourcePresentationIn_.st A Renraku.package/extension/TBehavior/instance/glmSourcePresentationIn_.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60204.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60205.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60204.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60205.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/UnlimitedInstanceVariableSlot.class/instance/class building/layoutChanged_.st Log Message: ----------- 60205 19042 QA 3.2.6 https://pharo.fogbugz.com/f/cases/19042 19043 UnlimtedIvar slot: fix a #name deprecation side effect https://pharo.fogbugz.com/f/cases/19043 http://files.pharo.org/image/60/60205.zip

Sept. 6, 2016

ConfigurationiOfGitHelp is broken in catalog

by Esteban Lorenzano

Please fix. most probably is because you do not have a correct config, which means: a baseline (even if not used), a version and a symbolic version #stable. Esteban

Sept. 6, 2016

ConfigurationOfFlatGTCollaborate is broken in catalog

by Esteban Lorenzano

Please fix. most probably is because you do not have a correct config, which means: a baseline (even if not used), a version and a symbolic version #stable. Esteban

Sept. 6, 2016