- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] About icon: and iconNamed:

by stepharo

I started to enhance GLMAction that way (GLMGenericAction new) title: 'Cut'; action: [ :aPresentation | aPresentation cut ]; iconName: #smallCutIcon; shortcut: $x; withSeparatorBefore; yourself. Le 12/10/16 Ã 20:33, stepharo a Ã©crit : > > > > Le 12/10/16 Ã 20:09, Denis Kudriashov a Ã©crit : >> >> 2016-10-12 20:06 GMT+02:00 stepharo <stepharo(a)free.fr >> <mailto:stepharo@free.fr>>: >> >> In fact I do not really like iconNamed: as a name for a setter >> (for menu items and settings) >> May be it should be iconSelector: or buildIconNamed: >> because else we will confuse iconNamed: which returns an icon >> and iconNamed: that just sets the selector to retrieve the selector. >> >> What do you think? >> >> >> maybe #icon*Name:?* > > *I see yes. I will think and change again all my fixes. > Stef > *

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by stepharo

Le 12/10/16 Ã 20:09, Denis Kudriashov a Ã©crit : > > 2016-10-12 20:06 GMT+02:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > In fact I do not really like iconNamed: as a name for a setter > (for menu items and settings) > May be it should be iconSelector: or buildIconNamed: > because else we will confuse iconNamed: which returns an icon and > iconNamed: that just sets the selector to retrieve the selector. > > What do you think? > > > maybe #icon*Name:?* *I see yes. I will think and change again all my fixes. Stef *

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by Denis Kudriashov

2016-10-12 20:06 GMT+02:00 stepharo <stepharo(a)free.fr>: > In fact I do not really like iconNamed: as a name for a setter (for menu > items and settings) > May be it should be iconSelector: or buildIconNamed: > because else we will confuse iconNamed: which returns an icon and > iconNamed: that just sets the selector to retrieve the selector. > > What do you think? > maybe #icon*Name:?*

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by stepharo

Le 12/10/16 Ã 15:25, Denis Kudriashov a Ã©crit : > > 2016-10-12 15:01 GMT+02:00 Peter Uhnak <i.uhnak(a)gmail.com > <mailto:i.uhnak@gmail.com>>: > > Because ThemeIcons may not be the only place from which you draw > icons, and because programming with strings doesn't scale. > > > It is not programming with strings. Most users of icons (I really > think all of them) are only specify name and really don't care how > retrieve them. Yes so this is why we could have menuOn: aBuilder "Specify the menu used when writing text." <contextMenu> <RubLineNumberMenu> (aBuilder item: #'Find...' translated) keyText: 'f'; selector: #find; icon: MyIconFactory mywonderfulIcon or menuOn: aBuilder "Specify the menu used when writing text." <contextMenu> <RubLineNumberMenu> (aBuilder item: #'Find...' translated) keyText: 'f'; selector: #find; buildIconNamed: #smallFindIcon

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by stepharo

In fact I do not really like iconNamed: as a name for a setter (for menu items and settings) May be it should be iconSelector: or buildIconNamed: because else we will confuse iconNamed: which returns an icon and iconNamed: that just sets the selector to retrieve the selector. What do you think? Le 12/10/16 Ã 13:25, stepharo a Ã©crit : > Hi glamourers and other > > Hi > > I'm currently enhancing the API of Settings to propose to the users to > pass not an icon but an icon named so that all the clients are not > force to use. See below. > > Now it would be great if Glamour could do the same. > > Doru and Andrei? > > > menuOn: aBuilder > "Specify the menu used when writing text." > <contextMenu> > <RubLineNumberMenu> > (aBuilder item: #'Find...' translated) > keyText: 'f'; > selector: #find; > icon: (Smalltalk ui icons iconNamed: #smallFindIcon) > > ====> > > menuOn: aBuilder > "Specify the menu used when writing text." > <contextMenu> > <RubLineNumberMenu> > (aBuilder item: #'Find...' translated) > keyText: 'f'; > selector: #find; > iconNamed: #smallFindIcon > > > Stef > > > >

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by stepharo

Le 12/10/16 Ã 14:28, Denis Kudriashov a Ã©crit : > Hi Stef. > > It is really good idea. And it makes me think why we ask users for > real icon Form and not just name? > > We could say any component which shows icons should be created with > concrete ThemeIcons ("Smalltalk ui icons" by default) to retrieve > actual form by name. And users should always specify icon names > instead of forms. I think that tools should be parametrized with an icon provider object. Stef > > What you think? > > > 2016-10-12 13:25 GMT+02:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > Hi glamourers and other > > Hi > > I'm currently enhancing the API of Settings to propose to the > users to pass not an icon but an icon named so that all the > clients are not force to use. See below. > > Now it would be great if Glamour could do the same. > > Doru and Andrei? > > > menuOn: aBuilder > "Specify the menu used when writing text." > <contextMenu> > <RubLineNumberMenu> > (aBuilder item: #'Find...' translated) > keyText: 'f'; > selector: #find; > icon: (Smalltalk ui icons iconNamed: #smallFindIcon) > > ====> > > menuOn: aBuilder > "Specify the menu used when writing text." > <contextMenu> > <RubLineNumberMenu> > (aBuilder item: #'Find...' translated) > keyText: 'f'; > selector: #find; > iconNamed: #smallFindIcon > > > Stef > > > >

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by Denis Kudriashov

2016-10-12 15:01 GMT+02:00 Peter Uhnak <i.uhnak(a)gmail.com>: > Because ThemeIcons may not be the only place from which you draw icons, > and because programming with strings doesn't scale. > It is not programming with strings. Most users of icons (I really think all of them) are only specify name and really don't care how retrieve them.

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by Peter Uhnak

Also regarding `#smallFindIcon asIcon`, there are many places where we can enter icons (e.g. Spec), so once we make a choice for Settings we should modify it there too. Peter On Wed, Oct 12, 2016 at 03:01:26PM +0200, Peter Uhnak wrote: > On Wed, Oct 12, 2016 at 02:28:44PM +0200, Denis Kudriashov wrote: > > Hi Stef. > > > > It is really good idea. And it makes me think why we ask users for real > > icon Form and not just name? > > Because ThemeIcons may not be the only place from which you draw icons, and because programming with strings doesn't scale. > > In any case, assuming we can easily customize the icon retrieval (with the default being Smalltalk ui icons), then I have no problems with this. > > Btw, there was a push to use also `#smallFindIcon asIcon`, I am not sure if this is possible in Pharo 6. (this is nice and short for standard icons, but cannot be customized, which is sometimes problem). > > Pharo > > > > > We could say any component which shows icons should be created with > > concrete ThemeIcons ("Smalltalk ui icons" by default) to retrieve actual > > form by name. And users should always specify icon names instead of forms. > > > > What you think? > > > > > > > > > 2016-10-12 13:25 GMT+02:00 stepharo <stepharo(a)free.fr>: > > > > > Hi glamourers and other > > > > > > Hi > > > > > > I'm currently enhancing the API of Settings to propose to the users to > > > pass not an icon but an icon named so that all the clients are not force to > > > use. See below. > > > > > > Now it would be great if Glamour could do the same. > > > > > > Doru and Andrei? > > > > > > > > > menuOn: aBuilder > > > "Specify the menu used when writing text." > > > <contextMenu> > > > <RubLineNumberMenu> > > > (aBuilder item: #'Find...' translated) > > > keyText: 'f'; > > > selector: #find; > > > icon: (Smalltalk ui icons iconNamed: #smallFindIcon) > > > > > > ====> > > > > > > menuOn: aBuilder > > > "Specify the menu used when writing text." > > > <contextMenu> > > > <RubLineNumberMenu> > > > (aBuilder item: #'Find...' translated) > > > keyText: 'f'; > > > selector: #find; > > > iconNamed: #smallFindIcon > > > > > > > > > Stef > > > > > > > > > > > >

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by Peter Uhnak

On Wed, Oct 12, 2016 at 02:28:44PM +0200, Denis Kudriashov wrote: > Hi Stef. > > It is really good idea. And it makes me think why we ask users for real > icon Form and not just name? Because ThemeIcons may not be the only place from which you draw icons, and because programming with strings doesn't scale. In any case, assuming we can easily customize the icon retrieval (with the default being Smalltalk ui icons), then I have no problems with this. Btw, there was a push to use also `#smallFindIcon asIcon`, I am not sure if this is possible in Pharo 6. (this is nice and short for standard icons, but cannot be customized, which is sometimes problem). Pharo > > We could say any component which shows icons should be created with > concrete ThemeIcons ("Smalltalk ui icons" by default) to retrieve actual > form by name. And users should always specify icon names instead of forms. > > What you think? > > > 2016-10-12 13:25 GMT+02:00 stepharo <stepharo(a)free.fr>: > > > Hi glamourers and other > > > > Hi > > > > I'm currently enhancing the API of Settings to propose to the users to > > pass not an icon but an icon named so that all the clients are not force to > > use. See below. > > > > Now it would be great if Glamour could do the same. > > > > Doru and Andrei? > > > > > > menuOn: aBuilder > > "Specify the menu used when writing text." > > <contextMenu> > > <RubLineNumberMenu> > > (aBuilder item: #'Find...' translated) > > keyText: 'f'; > > selector: #find; > > icon: (Smalltalk ui icons iconNamed: #smallFindIcon) > > > > ====> > > > > menuOn: aBuilder > > "Specify the menu used when writing text." > > <contextMenu> > > <RubLineNumberMenu> > > (aBuilder item: #'Find...' translated) > > keyText: 'f'; > > selector: #find; > > iconNamed: #smallFindIcon > > > > > > Stef > > > > > > > >

Oct. 12, 2016

Re: [Pharo-dev] About icon: and iconNamed:

by Denis Kudriashov

Hi Stef. It is really good idea. And it makes me think why we ask users for real icon Form and not just name? We could say any component which shows icons should be created with concrete ThemeIcons ("Smalltalk ui icons" by default) to retrieve actual form by name. And users should always specify icon names instead of forms. What you think? 2016-10-12 13:25 GMT+02:00 stepharo <stepharo(a)free.fr>: > Hi glamourers and other > > Hi > > I'm currently enhancing the API of Settings to propose to the users to > pass not an icon but an icon named so that all the clients are not force to > use. See below. > > Now it would be great if Glamour could do the same. > > Doru and Andrei? > > > menuOn: aBuilder > "Specify the menu used when writing text." > <contextMenu> > <RubLineNumberMenu> > (aBuilder item: #'Find...' translated) > keyText: 'f'; > selector: #find; > icon: (Smalltalk ui icons iconNamed: #smallFindIcon) > > ====> > > menuOn: aBuilder > "Specify the menu used when writing text." > <contextMenu> > <RubLineNumberMenu> > (aBuilder item: #'Find...' translated) > keyText: 'f'; > selector: #find; > iconNamed: #smallFindIcon > > > Stef > > > >

Oct. 12, 2016