- Pharo-dev - lists.pharo.org

some little static analysis with great impact

by stepharo

Hi I often end up forgetting a period. printOn: aStream super printOn: aStream. aStream nextPutAll: ' "' aStream nextPutAll: contents. aStream nextPutAll: '" '. And statically the system could see it with a simple heuristics: if the message as the same name as self, super, a tmp or an argument May be there is a missing period. Could the compiler get this analysis? Stef

Nov. 3, 2016

AST-Nodes API

by stepharo

Hi I would love to get a more regular API for the AST Nodes. Point 1 For example I would love to have leftBar -> leftBarToken to make sure that we see immediately the fact that we do not get a node. for example RBValueNode subclass: #RBArrayNode instanceVariableNames: 'left right statements periods' classVariableNames: '' package: 'AST-Core-Nodes' is not really good since I have to remember "oh yes left = { Point 2 Apparently it is implied that we always get nodes so now when I get a methodNode messageNode receiver -> node to get the text messageNode receiver I have no idea. While working on pharodoc (it is just great) I faced the problem that I really like to know what I'm manipulating and there is a difference between an expression (text) and an expression node. So what is the convention? I would prefer to have xxxNode each time I want to get a node.

Nov. 3, 2016

Re: [Pharo-dev] why RBComment is not called RBCommentNode

by stepharo

Because like that we have a correct and nice hierarchy and all the nodes inherits from it and we can have a nice visitor and make assumption about the root. Regularity is nice and it helps controlling complexity. Why a comment could not have a parent? Stef Le 3/11/16 Ã 14:53, John Brant a Ã©crit : > Why convert it to a node? It has no affect on the running code. > > > John Brant > >> On Nov 3, 2016, at 8:23 AM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >> >> >> >> 2016-11-03 13:41 GMT+01:00 stepharo <stepharo(a)free.fr>: >> Hi marcus et al >> >> why RBComment is not called RBCommentNode and why it is not a subclass of RBNode? >> >> Stef >> >> >> >> RBComment wasn't part of the original RefactoringBrowser, it only had a "comments" instance variable on its nodes. >> This was refactored out to its own RBComment class (I think). But no "real" AST-Node class. >> >> +1 for converting this into a real AST node. >> > >

Nov. 3, 2016

Re: [Pharo-dev] why RBComment is not called RBCommentNode

by John Brant

Why convert it to a node? It has no affect on the running code. John Brant > On Nov 3, 2016, at 8:23 AM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > 2016-11-03 13:41 GMT+01:00 stepharo <stepharo(a)free.fr>: > Hi marcus et al > > why RBComment is not called RBCommentNode and why it is not a subclass of RBNode? > > Stef > > > > RBComment wasn't part of the original RefactoringBrowser, it only had a "comments" instance variable on its nodes. > This was refactored out to its own RBComment class (I think). But no "real" AST-Node class. > > +1 for converting this into a real AST node. >

Nov. 3, 2016

Re: [Pharo-dev] why RBComment is not called RBCommentNode

by Nicolai Hess

2016-11-03 13:41 GMT+01:00 stepharo <stepharo(a)free.fr>: > Hi marcus et al > > why RBComment is not called RBCommentNode and why it is not a subclass of > RBNode? > > Stef > > > RBComment wasn't part of the original RefactoringBrowser, it only had a "comments" instance variable on its nodes. This was refactored out to its own RBComment class (I think). But no "real" AST-Node class. +1 for converting this into a real AST node.

Nov. 3, 2016

Re: [Pharo-dev] roundTo: strange behavior

by stepharo

Ok at least we should change the comment to point to printShowingDecimalPlaces: 1.19 printShowingDecimalPlaces: 1 STf Le 2/11/16 Ã 17:31, Nicolas Cellier a Ã©crit : > Last thing, I'm not sure it's a good idea to deprecate round: > round: has been added to overcome the rounding problems of roundTo: > If we deprecate round:, then users will fallback to roundTo: and won't > get correctly rounded Floats... > > Thus my original question: why is there a round in python, ruby etc... > There must be other applications than just printing (we said financial > is one). > > 2016-11-02 14:40 GMT+01:00 werner kassens <wkassens(a)libello.com > <mailto:wkassens@libello.com>>: > > yes Martin, i get that point and i already reacted to it, i > occasionally want to calculate something with a rounded float, not > print it: apart from my harley i normally use _metric screws which > come in decimal steps. <friendly grin> let's end that discussion, > we are going around in circles. > werner > > > On 11/02/2016 02:48 AM, Martin McClure wrote: > > Hi Werner, > Thanks for your comments. I posted the analysis because I did the > analysis (and thought some others might want to see it), and I > did the > analysis because I wanted to find out whether that answer was > right. > Some Smalltalks are pretty bad in similar areas of Float handling. > > > But aside from all the fine points, if you want a > floating-point number > to "look" nice and human-readable, > (x asFraction roundTo:(1/10))asFloat > will work, but I still recommend not rounding the number > itself, but > rounding the printing of the number. This is not a Pharo > thing, it's an > any-language-with-floats thing. In C you have printf, etc. In > Pharo, you > can use for instance: > > 1.19 printShowingDecimalPlaces: 1 ==> '1.2' > > This makes it easier for someone reading the code to see the > intent. > > Regards, > > -Martin > > > > >

Nov. 3, 2016

why RBComment is not called RBCommentNode

by stepharo

Hi marcus et al why RBComment is not called RBCommentNode and why it is not a subclass of RBNode? Stef

Nov. 3, 2016

Re: [Pharo-dev] Help needed with case 19236

by stepharo

Super cool. Stef Le 3/11/16 Ã 13:26, Denis Kudriashov a Ã©crit : > > 2016-11-02 20:03 GMT+01:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > >> But it leads to incompatibility for old images. > If people use Spec and we update spec = no problem :) > > > Yes Spec is updated by this. > And now it is fix to include

Nov. 3, 2016

Re: [Pharo-dev] Help needed with case 19236

by Denis Kudriashov

2016-11-02 20:03 GMT+01:00 stepharo <stepharo(a)free.fr>: > But it leads to incompatibility for old images. > > If people use Spec and we update spec = no problem :) Yes Spec is updated by this. And now it is fix to include

Nov. 3, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60276 Home: https://github.com/pharo-project/pharo-core

Nov. 3, 2016