- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Nautilus with inline QA?

by Yuriy Tymchuk

I think that I will start with having it disabled at the beginning. Because the current implementation of icon annotator does not work for classes and it is not asynchronous which means that for large classes and maybe for some methods it may be not efficient. Oh yes, and letâs not forget about the package-critiquesâ¦ Uko > On 1 Dec 2016, at 10:19, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > So: active by default, opening a the box in preferences.

Dec. 1, 2016

Re: [Pharo-dev] Nautilus with inline QA?

by Yuriy Tymchuk

You just need to add method annotateRubricText: self sourceTextModel to the end of AbstractNautilusUI>>#addIconStyle Definitely this is greatly possible because Markus has nice implementation of these icon annotations. Uko > On 1 Dec 2016, at 14:45, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > > 2016-12-01 14:44 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com <mailto:dionisiydk@gmail.com>>: > yes, the critiques are inlined. In fact I just needed to add 1 line of code, a the solution used in the MessageBrowser can be reused. > > Could you show this line? > > Full method will be better :)

Dec. 1, 2016

Re: [Pharo-dev] Set internal array size

by Henrik Nergaard

The Set implementation requires the array to have a size > 0. (Set basicNew initialize: 0) add: #x "Error Zero Devide" Best regards, Henrik -----Original Message----- From: Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] On Behalf Of Christophe Demarey Sent: Thursday, December 1, 2016 3:42 PM To: Pharo Development List <pharo-dev(a)lists.pharo.org> Subject: Re: [Pharo-dev] Set internal array size > Le 1 dÃ©c. 2016 Ã 15:04, Marcus Denker <marcus.denker(a)inria.fr> a Ã©crit : > > The idea that a set is always created with a minimal size is because we always add at least some elements not always. You know in some cases 80% of the time, your instances will have an empty Set and with some values for the remaining 20%. If you check in Moose, you should find a lot this pattern.

Dec. 1, 2016

Re: [Pharo-dev] Set internal array size

by Christophe Demarey

> Le 1 dÃ©c. 2016 Ã 15:04, Marcus Denker <marcus.denker(a)inria.fr> a Ã©crit : > > The idea that a set is always created with a minimal size is because we always add at least some elements not always. You know in some cases 80% of the time, your instances will have an empty Set and with some values for the remaining 20%. If you check in Moose, you should find a lot this pattern.

Dec. 1, 2016

Re: [Pharo-dev] Set internal array size

by Marcus Denker

The idea that a set is always created with a minimal size is because we always add at least some elements to them. We at some point increased that size (from 3 to 5?). The difference comes from Set sizeFor: 1 ==> 7 HashedCollection>>#sizeFor: has a special case for small (<4) elements, while the one of Set does not. Which is odd. Marcus > On 1 Dec 2016, at 14:39, Christophe Demarey <christophe.demarey(a)inria.fr> wrote: > > Thanks for this great explanation Henrik. > Nevertheless, my question is still valid. Why Set new will give me an internal array of 5 elements while Set new: 1 will give me an internal array of 7 elements? > Shouldnât Set new give an internal of 7 elements as it looks like the minimal array size for a set? > Also I would expect Set new: 0 to give me an empty internal array. It explicitly ask an empty Set. A further call to #add: will increase its size as expected. > > >> Le 1 dÃ©c. 2016 Ã 13:25, Henrik Nergaard <henrik.nergaard(a)uia.no <mailto:henrik.nergaard@uia.no>> a Ã©crit : >> >> Hashed collections keep a portion of the available memory empty (usually 25%) as a partition mechanism to increase lookup speed. >> >> âNormal arrayâ >> | col | >> >> col := Smalltalk allClassesAndTraits asArray. >> >> [ col includes: 8; includes: Morph ] bench. "'366.853 per second'" >> >> âNormal set ~75% loadâ >> | set | >> >> set := Smalltalk allClassesAndTraits asSet. >> >> [ set includes: 8; includes: Morph ] bench. "'4,700,967 per second'" >> >> >> âSet forced to have ~100% loadâ >> | array fullLoadSet | >> >> array := Smalltalk allClassesAndTraits asSet asArray , #(nil). >> fullLoadSet:= Set basicNew. >> fullLoadSet >> instVarNamed: #array put: array; >> instVarNamed: #tally put: array size. >> >> [ fullLoadSet includes: 8; includes: Morph ] bench. "'215.157 per second'" >> >> >> Best regards, >> Henrik >> >> >> From: Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org <mailto:pharo-dev-bounces@lists.pharo.org>] On Behalf Of Christophe Demarey >> Sent: Thursday, December 1, 2016 11:49 AM >> To: Pharo Development List <pharo-dev(a)lists.pharo.org <mailto:pharo-dev@lists.pharo.org>> >> Subject: [Pharo-dev] Set internal array size >> >> Hi, >> >> I just discovered a funny thing. >> If you create a Set with Set new, you will get a Set with an internal array of 5 elements (hardcoded in Set class>>#new). >> If you ask explicitly a Set for one or no element: Set new: 0 (or a number between 0 and 5), you will get an internal array of 7 elements. >> This behavior is a bit strange. Either we always need at least 7 elements and we need to update Set class>>#new, either the method Set class>>#sizeFor: should be updated. >> >> WDYT? >> >> Christophe >

Dec. 1, 2016

Re: [Pharo-dev] Nautilus with inline QA?

by Denis Kudriashov

2016-12-01 14:44 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > yes, the critiques are inlined. In fact I just needed to add 1 line of >> code, a the solution used in the MessageBrowser can be reused. > > > Could you show this line? Full method will be better :)

Dec. 1, 2016

Re: [Pharo-dev] [Pharo-users] Pharo 5 and retina displays in 2016?

by Tim Mackinnon

To give people a better view of this - here is the Pharo image next to the mail client (Iâm not sure if the screen captures really do it justice as when you scale them down in a picture everything looks fine - however if I zoom into that bottom corner in a second image it might make it more obvious). I think this has been a problem brewing for a while, but if most contributors donât have retina screens (although they are getting much more common now) then I guess it goes unnoticed. I suspect in the next few years, as people start replacing machines - it will gain more visibility. I find it quite distracting when switching from mail or other apps to Pharo and then you notice the fuzziness. Maybe if you spend a few hours in the code you might adjust. Tim The following is the bottom corner zoom in to show what I mean by fuzzy: > On 30 Nov 2016, at 23:53, Stephan Eggermont <stephan(a)stack.nl> wrote: > > On 30/11/16 20:32, Sven Van Caekenberghe wrote: >> Maybe, but the thing is, you are looking at it half size, in some >> sense, when it is on a Retina display. Anyway, to me, it is OK, but >> my eyes are no longer what they used to be. I can imagine young >> people being more sensitive to it. > > Nah, it just is blurry. I've played a bit with krono's vm, and it is > a very noticable difference. Much better readable and less tiring. > And you mostly only notice when trying to go back from HiDPI to low. > > Stephan > >

Dec. 1, 2016

Re: [Pharo-dev] Nautilus with inline QA?

by Denis Kudriashov

2016-12-01 10:12 GMT+01:00 Yuriy Tymchuk <yuriy.tymchuk(a)me.com>: > yes, the critiques are inlined. In fact I just needed to add 1 line of > code, a the solution used in the MessageBrowser can be reused. Could you show this line?

Dec. 1, 2016

Re: [Pharo-dev] Set internal array size

by Christophe Demarey

Thanks for this great explanation Henrik. Nevertheless, my question is still valid. Why Set new will give me an internal array of 5 elements while Set new: 1 will give me an internal array of 7 elements? Shouldnât Set new give an internal of 7 elements as it looks like the minimal array size for a set? Also I would expect Set new: 0 to give me an empty internal array. It explicitly ask an empty Set. A further call to #add: will increase its size as expected. > Le 1 dÃ©c. 2016 Ã 13:25, Henrik Nergaard <henrik.nergaard(a)uia.no> a Ã©crit : > > Hashed collections keep a portion of the available memory empty (usually 25%) as a partition mechanism to increase lookup speed. > > âNormal arrayâ > | col | > > col := Smalltalk allClassesAndTraits asArray. > > [ col includes: 8; includes: Morph ] bench. "'366.853 per second'" > > âNormal set ~75% loadâ > | set | > > set := Smalltalk allClassesAndTraits asSet. > > [ set includes: 8; includes: Morph ] bench. "'4,700,967 per second'" > > > âSet forced to have ~100% loadâ > | array fullLoadSet | > > array := Smalltalk allClassesAndTraits asSet asArray , #(nil). > fullLoadSet:= Set basicNew. > fullLoadSet > instVarNamed: #array put: array; > instVarNamed: #tally put: array size. > > [ fullLoadSet includes: 8; includes: Morph ] bench. "'215.157 per second'" > > > Best regards, > Henrik > > > From: Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] On Behalf Of Christophe Demarey > Sent: Thursday, December 1, 2016 11:49 AM > To: Pharo Development List <pharo-dev(a)lists.pharo.org> > Subject: [Pharo-dev] Set internal array size > > Hi, > > I just discovered a funny thing. > If you create a Set with Set new, you will get a Set with an internal array of 5 elements (hardcoded in Set class>>#new). > If you ask explicitly a Set for one or no element: Set new: 0 (or a number between 0 and 5), you will get an internal array of 7 elements. > This behavior is a bit strange. Either we always need at least 7 elements and we need to update Set class>>#new, either the method Set class>>#sizeFor: should be updated. > > WDYT? > > Christophe

Dec. 1, 2016

Re: [Pharo-dev] [Pharo-users] Pharo 5 and retina displays in 2016?

by Stephan Eggermont

On 01/12/16 08:18, Sven Van Caekenberghe wrote: > From a distance (not knowing anything about it), it seems that HDi > support was considered not important. Else more people would work on > it to fix its teething problems, no ? No, it was consider very important, second only to spur (64). Stephan

Dec. 1, 2016