- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] b3b972: 60325

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: b3b972c39e017ffbb7cc32479356f6d86423799a https://github.com/pharo-project/pharo-core/commit/b3b972c39e017ffbb7cc3247… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: A OpalCompiler-Core.package/AbstractCompiler.class/instance/accessing/requestorScopeClass_.st M OpalCompiler-Core.package/CCompilationContext.class/definition.st A OpalCompiler-Core.package/CCompilationContext.class/instance/accessing/requestorScopeClass.st A OpalCompiler-Core.package/CCompilationContext.class/instance/accessing/requestorScopeClass_.st M OpalCompiler-Core.package/CCompilationContext.class/instance/accessing/scope.st M OpalCompiler-Core.package/CompilationContext.class/definition.st A OpalCompiler-Core.package/CompilationContext.class/instance/accessing/requestorScopeClass.st A OpalCompiler-Core.package/CompilationContext.class/instance/accessing/requestorScopeClass_.st M OpalCompiler-Core.package/CompilationContext.class/instance/accessing/scope.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60324.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60325.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60324.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60325.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st R Spec-Examples.package/CustomerStatisfaction.class/README.md R Spec-Examples.package/CustomerStatisfaction.class/class/example/example.st R Spec-Examples.package/CustomerStatisfaction.class/class/example/exampleDialog.st R Spec-Examples.package/CustomerStatisfaction.class/class/example/exampleNewLayout.st R Spec-Examples.package/CustomerStatisfaction.class/class/specs/defaultSpec.st R Spec-Examples.package/CustomerStatisfaction.class/class/specs/layout.st R Spec-Examples.package/CustomerStatisfaction.class/definition.st R Spec-Examples.package/CustomerStatisfaction.class/instance/accessing/buttonBad.st R Spec-Examples.package/CustomerStatisfaction.class/instance/accessing/buttonHappy.st R Spec-Examples.package/CustomerStatisfaction.class/instance/accessing/buttonNeutral.st R Spec-Examples.package/CustomerStatisfaction.class/instance/accessing/screen.st R Spec-Examples.package/CustomerStatisfaction.class/instance/accessing/title.st R Spec-Examples.package/CustomerStatisfaction.class/instance/initialization/initializePresenter.st R Spec-Examples.package/CustomerStatisfaction.class/instance/initialization/initializeWidgets.st R Spec-Examples.package/DynamicalPopup.class/README.md R Spec-Examples.package/DynamicalPopup.class/class/example/exampleAlternativeToolbar.st R Spec-Examples.package/DynamicalPopup.class/class/example/exampleDefaultToolbar.st R Spec-Examples.package/DynamicalPopup.class/definition.st R Spec-Examples.package/DynamicalPopup.class/instance/initialization/alternativeToolbar.st R Spec-Examples.package/DynamicalPopup.class/instance/initialization/defaultToolbarConfiguration.st R Spec-Examples.package/DynamicalPopup.class/instance/initialization/dynamicLayout.st R Spec-Examples.package/DynamicalPopup.class/instance/initialization/initialExtent.st R Spec-Examples.package/DynamicalPopup.class/instance/initialization/initializeWidgets.st R Spec-Examples.package/ManifestSpecExamples.class/README.md R Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleClassNotReferencedRuleV1FalsePositive.st R Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleCollectionMessagesToExternalObjectRuleV1FalsePositive.st R Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleLongMethodsRuleV1FalsePositive.st R Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleSentNotImplementedRuleV1FalsePositive.st R Spec-Examples.package/ManifestSpecExamples.class/definition.st R Spec-Examples.package/ModelList.class/README.md R Spec-Examples.package/ModelList.class/class/examples/example.st R Spec-Examples.package/ModelList.class/class/specs/defaultSpec.st R Spec-Examples.package/ModelList.class/definition.st R Spec-Examples.package/ModelList.class/instance/accessing/list.st R Spec-Examples.package/ModelList.class/instance/api-events/whenSelectedItemChanged_.st R Spec-Examples.package/ModelList.class/instance/api/title.st R Spec-Examples.package/ModelList.class/instance/initialization/initializeWidgets.st R Spec-Examples.package/ProtocolBrowser.class/README.md R Spec-Examples.package/ProtocolBrowser.class/class/examples/example.st R Spec-Examples.package/ProtocolBrowser.class/class/specs/defaultSpec.st R Spec-Examples.package/ProtocolBrowser.class/definition.st R Spec-Examples.package/ProtocolBrowser.class/instance/accessing/text.st R Spec-Examples.package/ProtocolBrowser.class/instance/accessing/viewer.st R Spec-Examples.package/ProtocolBrowser.class/instance/api/initialExtent.st R Spec-Examples.package/ProtocolBrowser.class/instance/api/title.st R Spec-Examples.package/ProtocolBrowser.class/instance/initialization/initializePresenter.st R Spec-Examples.package/ProtocolBrowser.class/instance/initialization/initializeWidgets.st R Spec-Examples.package/ProtocolList.class/README.md R Spec-Examples.package/ProtocolList.class/class/examples/example.st R Spec-Examples.package/ProtocolList.class/class/specs/defaultSpec.st R Spec-Examples.package/ProtocolList.class/definition.st R Spec-Examples.package/ProtocolList.class/instance/accessing/label.st R Spec-Examples.package/ProtocolList.class/instance/accessing/protocols.st R Spec-Examples.package/ProtocolList.class/instance/api-events/whenSelectedItemChanged_.st R Spec-Examples.package/ProtocolList.class/instance/api/displayBlock_.st R Spec-Examples.package/ProtocolList.class/instance/api/items_.st R Spec-Examples.package/ProtocolList.class/instance/api/label_.st R Spec-Examples.package/ProtocolList.class/instance/api/resetSelection.st R Spec-Examples.package/ProtocolList.class/instance/api/title.st R Spec-Examples.package/ProtocolList.class/instance/initialization/initializeWidgets.st R Spec-Examples.package/ProtocolViewer.class/README.md R Spec-Examples.package/ProtocolViewer.class/class/examples/example.st R Spec-Examples.package/ProtocolViewer.class/class/specs/defaultSpec.st R Spec-Examples.package/ProtocolViewer.class/definition.st R Spec-Examples.package/ProtocolViewer.class/instance/accessing/events.st R Spec-Examples.package/ProtocolViewer.class/instance/accessing/models.st R Spec-Examples.package/ProtocolViewer.class/instance/accessing/protocols.st R Spec-Examples.package/ProtocolViewer.class/instance/api-events/whenClassChanged_.st R Spec-Examples.package/ProtocolViewer.class/instance/api-events/whenEventChangedDo_.st R Spec-Examples.package/ProtocolViewer.class/instance/api-events/whenProtocolChangedDo_.st R Spec-Examples.package/ProtocolViewer.class/instance/api/resetEventSelection.st R Spec-Examples.package/ProtocolViewer.class/instance/api/resetProtocolSelection.st R Spec-Examples.package/ProtocolViewer.class/instance/api/title.st R Spec-Examples.package/ProtocolViewer.class/instance/initialization/initializePresenter.st R Spec-Examples.package/ProtocolViewer.class/instance/initialization/initializeWidgets.st R Spec-Examples.package/ProtocolViewer.class/instance/private/methodsIn_for_.st M Spec-PolyWidgets.package/InputWidget.class/definition.st R Spec-PolyWidgets.package/ManifestSpecPolyWidgets.class/README.md R Spec-PolyWidgets.package/ManifestSpecPolyWidgets.class/definition.st M Spec-PolyWidgets.package/MethodToolbar.class/definition.st A Spec-PolyWidgets.package/SelectEntity.class/README.md A Spec-PolyWidgets.package/SelectEntity.class/class/example/example.st A Spec-PolyWidgets.package/SelectEntity.class/class/specs/defaultSpec.st A Spec-PolyWidgets.package/SelectEntity.class/definition.st A Spec-PolyWidgets.package/SelectEntity.class/instance/accessing/entityText.st A Spec-PolyWidgets.package/SelectEntity.class/instance/accessing/entityText_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/accessing/selectEntity.st A Spec-PolyWidgets.package/SelectEntity.class/instance/accessing/selectEntity_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api-events/whenDisplaySymbolChanged_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api-events/whenEntityChanged_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api-events/whenGhostTextChanged_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api-events/whenPossibleEntitiesChanged_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api-events/whenSelectDialogChanged_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/displaySymbol.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/displaySymbol_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/entity.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/entity_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/ghostText.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/ghostText_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/possibleEntities.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/possibleEntities_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/selectDialog.st A Spec-PolyWidgets.package/SelectEntity.class/instance/api/selectDialog_.st A Spec-PolyWidgets.package/SelectEntity.class/instance/entryCompletion/entitiesEntryCompletion.st A Spec-PolyWidgets.package/SelectEntity.class/instance/initialization/initialize.st A Spec-PolyWidgets.package/SelectEntity.class/instance/initialization/initializePresenter.st A Spec-PolyWidgets.package/SelectEntity.class/instance/initialization/initializeValueHolders.st A Spec-PolyWidgets.package/SelectEntity.class/instance/initialization/initializeWidgets.st R Spec-SelectEntity.package/SelectEntity.class/README.md R Spec-SelectEntity.package/SelectEntity.class/class/example/example.st R Spec-SelectEntity.package/SelectEntity.class/class/specs/defaultSpec.st R Spec-SelectEntity.package/SelectEntity.class/definition.st R Spec-SelectEntity.package/SelectEntity.class/instance/accessing/entityText.st R Spec-SelectEntity.package/SelectEntity.class/instance/accessing/entityText_.st R Spec-SelectEntity.package/SelectEntity.class/instance/accessing/selectEntity.st R Spec-SelectEntity.package/SelectEntity.class/instance/accessing/selectEntity_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api-events/whenDisplaySymbolChanged_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api-events/whenEntityChanged_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api-events/whenGhostTextChanged_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api-events/whenPossibleEntitiesChanged_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api-events/whenSelectDialogChanged_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/displaySymbol.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/displaySymbol_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/entity.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/entity_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/ghostText.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/ghostText_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/possibleEntities.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/possibleEntities_.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/selectDialog.st R Spec-SelectEntity.package/SelectEntity.class/instance/api/selectDialog_.st R Spec-SelectEntity.package/SelectEntity.class/instance/entryCompletion/entitiesEntryCompletion.st R Spec-SelectEntity.package/SelectEntity.class/instance/initialization/initialize.st R Spec-SelectEntity.package/SelectEntity.class/instance/initialization/initializePresenter.st R Spec-SelectEntity.package/SelectEntity.class/instance/initialization/initializeValueHolders.st R Spec-SelectEntity.package/SelectEntity.class/instance/initialization/initializeWidgets.st R Spec-Tests.package/CustomerStatisfactionTest.class/README.md R Spec-Tests.package/CustomerStatisfactionTest.class/definition.st R Spec-Tests.package/CustomerStatisfactionTest.class/instance/running/classToTest.st R Spec-Tests.package/CustomerStatisfactionTest.class/instance/tests/testExampleDialog.st R Spec-Tests.package/CustomerStatisfactionTest.class/instance/tests/testExampleNewLayout.st R Spec-Tests.package/DynamicalPopupTest.class/README.md R Spec-Tests.package/DynamicalPopupTest.class/definition.st R Spec-Tests.package/DynamicalPopupTest.class/instance/running/classToTest.st R Spec-Tests.package/DynamicalPopupTest.class/instance/tests/testExampleAlternativeToolbar.st R Spec-Tests.package/DynamicalPopupTest.class/instance/tests/testExampleDefaultToolbar.st R Spec-Tests.package/ModelListTest.class/README.md R Spec-Tests.package/ModelListTest.class/definition.st R Spec-Tests.package/ModelListTest.class/instance/running/classToTest.st R Spec-Tests.package/ProtocolBrowserTest.class/README.md R Spec-Tests.package/ProtocolBrowserTest.class/definition.st R Spec-Tests.package/ProtocolBrowserTest.class/instance/running/classToTest.st R Spec-Tests.package/ProtocolListTest.class/README.md R Spec-Tests.package/ProtocolListTest.class/definition.st R Spec-Tests.package/ProtocolListTest.class/instance/running/classToTest.st R Spec-Tests.package/ProtocolViewerTest.class/README.md R Spec-Tests.package/ProtocolViewerTest.class/definition.st R Spec-Tests.package/ProtocolViewerTest.class/instance/running/classToTest.st Log Message: ----------- 60325 19464 Clean up Spec-PolyWidgets and Spec-SelectEntity https://pharo.fogbugz.com/f/cases/19464 19462 Remove all classes of BuildUIWithSpec and BuildUIWithSpec-Reuse https://pharo.fogbugz.com/f/cases/19462 19460 Make requestor Scope pluggable https://pharo.fogbugz.com/f/cases/19460 http://files.pharo.org/image/60/60325.zip

Dec. 14, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60325 Home: https://github.com/pharo-project/pharo-core

Dec. 14, 2016

Re: [Pharo-dev] inconsistent FileLocator behavior

by Denis Kudriashov

2016-12-14 12:05 GMT+01:00 Ben Coman <btc(a)openinworld.com>: > But perhaps all those extensions for different file types should be a > trait to not repeat ourselves? > Problem with trait that you could not add it as class extension. Now you could package your GT support as separate package. But with trait it is not possible. It would be really nice feature by the way

Dec. 14, 2016

Re: [Pharo-dev] inconsistent FileLocator behavior

by Ben Coman

On Wed, Dec 14, 2016 at 6:18 PM, Peter Uhnak <i.uhnak(a)gmail.com> wrote: > It is polymorphic, but the usability suffers (at least for me). > > Imagine that I want to pick a path to specific file - for example > something in Downloads folder. > > If I don't have the full path at my hand, I open the playground and type > > FileLocator home asFileReference -> I see all the contents, > then I can add `/ 'Downloads' -> again, I see all the contents, > etc. > > If I don't resolve it immediately, I won't see neither the final file, nor > will I see if I made a mistake along the way. > Do you mean FileLocator should have a gtInspector*Extension like FileReference, like copying #gtInspectorItemsIn: ? But perhaps all those extensions for different file types should be a trait to not repeat ourselves? cheers -ben > > Also how is `FileLocator home` any more or less specific than `FileLocator > D`? Neither is guaranteed to be the same (or even exist) for all users. > > Peter > > > > On Wed, Dec 14, 2016 at 10:25:08AM +0100, Nicolai Hess wrote: > > 2016-12-14 10:13 GMT+01:00 Peter Uhnak <i.uhnak(a)gmail.com>: > > > > > Hi, > > > > > > is there a reason why FileLocator behaves like this? > > > > > > FileLocator home -> FileLocator({home}) > > > FileLocator D -> FileReference(D:\) > > > > > > Especially the first one (this also applies to #temp and others), > > > is there a benefit in returning FileLocator instead of the path? > Because > > > now I always end up doing > > > FileLocator home asFileReference, which feels superfluous. > > > > > > > In what situation do you need to call #asFileReference ? because I > thought > > a FileLocator should behave like a FileReference (implementingthe same > api). > > > > > > > > > > What is the use case that you don't want to resolve it yet? > > > > > > Thanks, > > > Peter > > > > > > > > > > >

Dec. 14, 2016

Re: [Pharo-dev] inconsistent FileLocator behavior

by Peter Uhnak

It is polymorphic, but the usability suffers (at least for me). Imagine that I want to pick a path to specific file - for example something in Downloads folder. If I don't have the full path at my hand, I open the playground and type FileLocator home asFileReference -> I see all the contents, then I can add `/ 'Downloads' -> again, I see all the contents, etc. If I don't resolve it immediately, I won't see neither the final file, nor will I see if I made a mistake along the way. Also how is `FileLocator home` any more or less specific than `FileLocator D`? Neither is guaranteed to be the same (or even exist) for all users. Peter On Wed, Dec 14, 2016 at 10:25:08AM +0100, Nicolai Hess wrote: > 2016-12-14 10:13 GMT+01:00 Peter Uhnak <i.uhnak(a)gmail.com>: > > > Hi, > > > > is there a reason why FileLocator behaves like this? > > > > FileLocator home -> FileLocator({home}) > > FileLocator D -> FileReference(D:\) > > > > Especially the first one (this also applies to #temp and others), > > is there a benefit in returning FileLocator instead of the path? Because > > now I always end up doing > > FileLocator home asFileReference, which feels superfluous. > > > > In what situation do you need to call #asFileReference ? because I thought > a FileLocator should behave like a FileReference (implementingthe same api). > > > > > > What is the use case that you don't want to resolve it yet? > > > > Thanks, > > Peter > > > > > >

Dec. 14, 2016

Re: [Pharo-dev] The Iceberg TechTalk recording

by Glenn CavarlÃ©

Thanks Esteban and Nicolas for sharing the recording! Glenn. ----- Glenn CavarlÃ© -- View this message in context: http://forum.world.st/The-Iceberg-TechTalk-recording-tp4926824p4926867.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Dec. 14, 2016

Re: [Pharo-dev] inconsistent FileLocator behavior

by Sven Van Caekenberghe

> On 14 Dec 2016, at 10:13, Peter Uhnak <i.uhnak(a)gmail.com> wrote: > > Hi, > > is there a reason why FileLocator behaves like this? > > FileLocator home -> FileLocator({home}) > FileLocator D -> FileReference(D:\) > > Especially the first one (this also applies to #temp and others), > is there a benefit in returning FileLocator instead of the path? Because now I always end up doing > FileLocator home asFileReference, which feels superfluous. > > What is the use case that you don't want to resolve it yet? I think the idea is that the first one is like $HOME, i.e. it can be different on different machines/contexts. It is a higher level abstraction that can resolve to different concrete directories. To work with these more abstract file references you just use them. (FileLocator temp / 'foo.txt') ensureCreateFile. (FileLocator temp / 'foo.txt') fullPath. Conversions happen when needed. At least, this is how I think FileSystem was designed. > Thanks, > Peter > >

Dec. 14, 2016

Re: [Pharo-dev] inconsistent FileLocator behavior

by Denis Kudriashov

Hi 2016-12-14 10:13 GMT+01:00 Peter Uhnak <i.uhnak(a)gmail.com>: > Hi, > > is there a reason why FileLocator behaves like this? > > FileLocator home -> FileLocator({home}) > FileLocator D -> FileReference(D:\) > > Especially the first one (this also applies to #temp and others), > is there a benefit in returning FileLocator instead of the path? Because > now I always end up doing > FileLocator home asFileReference, which feels superfluous. > Why you need this conversion? They should be polymorphic. Idea that FileLocator gives you kind of virtual path which is independent of image location and could be resolved differently when you move your image. And message #D gives you concrete file reference because it is not virtual, it is concrete resolved path. There is also message #resolve to get actual file reference from locator.

Dec. 14, 2016

Re: [Pharo-dev] inconsistent FileLocator behavior

by Nicolai Hess

2016-12-14 10:13 GMT+01:00 Peter Uhnak <i.uhnak(a)gmail.com>: > Hi, > > is there a reason why FileLocator behaves like this? > > FileLocator home -> FileLocator({home}) > FileLocator D -> FileReference(D:\) > > Especially the first one (this also applies to #temp and others), > is there a benefit in returning FileLocator instead of the path? Because > now I always end up doing > FileLocator home asFileReference, which feels superfluous. > In what situation do you need to call #asFileReference ? because I thought a FileLocator should behave like a FileReference (implementingthe same api). > > What is the use case that you don't want to resolve it yet? > > Thanks, > Peter > > >

Dec. 14, 2016

Re: [Pharo-dev] inconsistent FileLocator behavior

by Nicolai Hess

2016-12-14 10:13 GMT+01:00 Peter Uhnak <i.uhnak(a)gmail.com>: > Hi, > > is there a reason why FileLocator behaves like this? > > FileLocator home -> FileLocator({home}) > FileLocator D -> FileReference(D:\) > > Especially the first one (this also applies to #temp and others), > is there a benefit in returning FileLocator instead of the path? Because > now I always end up doing > FileLocator home asFileReference, which feels superfluous. > > What is the use case that you don't want to resolve it yet? > > Thanks, > Peter > > > >From the FileLocator class comment: "I am a late-bound reference. "

Dec. 14, 2016