- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Memory leaks

by Sven Van Caekenberghe

> On 30 Jan 2017, at 22:57, Alexandre Bergel <alexandre.bergel(a)me.com> wrote: > > Hi! > > It looks like that we are currently suffering memory leaks. That is a bit strong a statement. Maybe some IDE UI stuff might sometimes hold onto something too long. > In march 2015 it was said in the mailing list: > > -=-=-=-=-=-=-=-= > I also tried this: > > 1. Create a dummy class: > Object subclass: #AAA > instanceVariableNames: 'x' > classVariableNames: '' > category: 'AAA'. > > 2. Open a Playground and do it and go on this: > a := #AAA asClass new. And why would you do that ? You assign to a workspace variable, hence your object is held in the scope of the Playground. So whenever the Playground gets retained by some other object, like an announcement, event or whatever, your object get retained too. I am 100% sure that if you do 1e6 timesRepeat: [ #AAA asClass new ]. 3 timesRepeat: [ Smalltalk garbageCollect ]. #AAA asClass allInstances isEmpty. => true > 3. In the second pane go on "self" > > 4. Close the Playground > > 5. Execute: > 3 timesRepeat: [ Smalltalk garbageCollect ]. > > 6. Check: > #AAA asClass allInstances. > > 7. Repeat if necessary, and after a while, the result after step 6 is not empty. > -=-=-=-=-=-=-=-= > > The problem is still present. > Looking at the pointers > > There was an object reference crawler no? I remember someone worked on this? I tried sending #pointersTo but I without much success on identifying the cause of this leak. > > Any idea? > > Cheers, > Alexandre > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > >

Jan. 30, 2017

Re: [Pharo-dev] Two listener sockets on same port

by Denis Kudriashov

2017-01-30 22:19 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > Yes, I check. If port is busy then localPort will be different And I cover it in TCPServer with test

Jan. 30, 2017

Memory leaks

by Alexandre Bergel

Hi! It looks like that we are currently suffering memory leaks. In march 2015 it was said in the mailing list: -=-=-=-=-=-=-=-= I also tried this: 1. Create a dummy class: Object subclass: #AAA instanceVariableNames: 'x' classVariableNames: '' category: 'AAA'. 2. Open a Playground and do it and go on this: a := #AAA asClass new. 3. In the second pane go on "self" 4. Close the Playground 5. Execute: 3 timesRepeat: [ Smalltalk garbageCollect ]. 6. Check: #AAA asClass allInstances. 7. Repeat if necessary, and after a while, the result after step 6 is not empty. -=-=-=-=-=-=-=-= The problem is still present. Looking at the pointers There was an object reference crawler no? I remember someone worked on this? I tried sending #pointersTo but I without much success on identifying the cause of this leak. Any idea? Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Jan. 30, 2017

Re: [Pharo-dev] Two listener sockets on same port

by Denis Kudriashov

2017-01-30 21:30 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > > > > In #isListening code I see extra condition "self serverSocket localPort > = self port". Could you explain what case it is covered? > > IIRC, the idea was that if you bind/listen unsuccessfully, that condition > is not true, but again, it was a long time ago, and maybe is not bullet > proof. Yes, I check. If port is busy then localPort will be different

Jan. 30, 2017

Re: [Pharo-dev] Two listener sockets on same port

by Sven Van Caekenberghe

> On 30 Jan 2017, at 21:13, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > > 2017-01-30 20:25 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > Well, you should do your utmost best to prevent the situation in the first place (use startup/shutdown behaviour correctly). > > I remember I had those problems a lot in the beginning of Zn, especially when running tests that sometimes failed. > > Have you seen Zn's #isListening ? I think that was written to catch the case you described, but I am not sure it is 100% rock solid. > > Yes. This is exactly how I fix my case. > But this post is about general problem which I think is very critical. > > In #isListening code I see extra condition "self serverSocket localPort = self port". Could you explain what case it is covered? IIRC, the idea was that if you bind/listen unsuccessfully, that condition is not true, but again, it was a long time ago, and maybe is not bullet proof.

Jan. 30, 2017

Re: [Pharo-dev] Two listener sockets on same port

by Denis Kudriashov

2017-01-30 20:25 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > Well, you should do your utmost best to prevent the situation in the first > place (use startup/shutdown behaviour correctly). > > I remember I had those problems a lot in the beginning of Zn, especially > when running tests that sometimes failed. > > Have you seen Zn's #isListening ? I think that was written to catch the > case you described, but I am not sure it is 100% rock solid. > Yes. This is exactly how I fix my case. But this post is about general problem which I think is very critical. In #isListening code I see extra condition "self serverSocket localPort = self port". Could you explain what case it is covered?

Jan. 30, 2017

Re: [Pharo-dev] Two listener sockets on same port

by Sven Van Caekenberghe

Well, you should do your utmost best to prevent the situation in the first place (use startup/shutdown behaviour correctly). I remember I had those problems a lot in the beginning of Zn, especially when running tests that sometimes failed. Have you seen Zn's #isListening ? I think that was written to catch the case you described, but I am not sure it is 100% rock solid. Have you seen the other methods of queries protocol of Socket ? > On 30 Jan 2017, at 18:23, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > Hi, > > I remember in past there was some reports about it. And now I was a victim of this problem which is very difficult to debug. > > Pharo allows to start two listener sockets on same port. You will not see any error. State of both sockets will be identical. "socket isValid, socket status" will be always correct for both instances. > You can play with sockets with following code: > (socket := Socket newTCP) > setOption: 'TCP_NODELAY' value: 1; > setOption: 'SO_SNDBUF' value: 4096; > setOption: 'SO_RCVBUF' value: 4096. > socket listenOn: 40424 backlogSize: 32. > > When many listener sockets are created. Only first will receive connections. So first server will work. But others will not with no way to know why. > > But more dramatical scenario is when first socket becomes collected as garbage which will destroy it. > In this case You will be completely confusing why your single instance in image is not working. > Such case is of course some bug in how you manage sockets. But that's the problem: > It is now impossible to debug such cases. > > Can we fix it? Is it possible to signal error when socket is not really listen? > > Best regards, > Denis

Jan. 30, 2017

Re: [Pharo-dev] Pharo 6 release status

by Guillermo Polito

On Mon, Jan 30, 2017 at 5:49 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > Hi all, > > as announced, for the Pharo 6 release we set milestone of almost all low > priority issues to "Later". If you feel that some of the postponed issues > you reported are important and needs to be fixed before the release, please > change the milestone back to Pharo 6. > Bah, not only... If there is no code available for the fix, even it it says "Pharo 6" it cannot be integrated... > > All issues where it was possible to decide were tagged as ExistedInPharo5 > or NewInPharo6. The priority of most of the cases tagged as ExistedInPharo5 > were decreased to priority "Fix if time". If you think think that some of > these issues must be fixed for the next release, please increase their > priority. Otherwise such issues will be marked as "Later" before the > release. > > Again, increasing the priority does not magically fix the issues. > If you have a lot of subscribed issues, sorry for the noise in your inbox. > Thanks :P > > We have now 153 open issues for Pharo 6. > 48 issues are now with priority "Must fix" or higher. > We hope in release date on the 1st of April. > > Cheers, > -- Pavel > > >

Jan. 30, 2017

Re: [Pharo-dev] [Ann] PharmIDE: Pharo remote IDE to develop farm of Pharo images remotely

by Denis Kudriashov

2017-01-30 13:36 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > 2017-01-30 13:14 GMT+01:00 Norbert Hartl <norbert(a)hartl.name>: > >> Unfortunately I couldn't test it because I installed the PharmIDE on my >> linux machine and it does not work. When starting the image a listening >> port is opened but 5 seconds later the port closes automatically. Has >> anyone tested it on a linux machine? > > > I am working on it. It happens when server starts from command line. > Probably I do something wrong in my TCPServer implementation. > Zinc server works fine. So I have example where there is no problems. > Ok. It is fixed now. Just load stable version. Reason was related to my post about two listener sockets. TCPServer is registered on startup list and it recreates listener socket when image resumes. >From command line it happens twice. First instance is created from command line handler which registers it on startup list. But when command line is evaluated Pharo start process startup list which lead to duplicated socket creation. Now TCPServer handles it properly.

Jan. 30, 2017

Two listener sockets on same port

by Denis Kudriashov

Hi, I remember in past there was some reports about it. And now I was a victim of this problem which is very difficult to debug. Pharo allows to start two listener sockets on same port. You will not see any error. State of both sockets will be identical. "socket isValid, socket status" will be always correct for both instances. You can play with sockets with following code: (socket := Socket newTCP) setOption: 'TCP_NODELAY' value: 1; setOption: 'SO_SNDBUF' value: 4096; setOption: 'SO_RCVBUF' value: 4096. socket listenOn: 40424 backlogSize: 32. When many listener sockets are created. Only first will receive connections. So first server will work. But others will not with no way to know why. But more dramatical scenario is when first socket becomes collected as garbage which will destroy it. In this case You will be completely confusing why your single instance in image is not working. Such case is of course some bug in how you manage sockets. But that's the problem: It is now impossible to debug such cases. Can we fix it? Is it possible to signal error when socket is not really listen? Best regards, Denis

Jan. 30, 2017