- Pharo-dev - lists.pharo.org

FastTableModel switched from default single-select to multi

by Stephan Eggermont

Breaking all code that expects selectedItem to be not-nil. Is that wanted behaviour? I noticed it broke SpecGenerator. I have no strong opinion on this, and welcome all Spec progress. Stephan

Feb. 12, 2017

Nice library looking for clever developers for little chat and lovely documentation

by stepharong

Hi guys I realized that value: valueWithPossibleArguments: cull: and others supernice messages do not have the method comments they deserved. cull: anArg ^numArgs = 0 ifTrue: [self value] ifFalse: [self value: anArg] => I started https://pharo.fogbugz.com/f/cases/19689/Add-method-comments-to-cool-block-m… cull: anArg "Execute the receiver with one or zero arguments depending on the receiver number of required arguments." "([ 12 ] cull: 13) >>> 12 " "([:x | x + 12] cull: 3) >>> 15 " ^numArgs = 0 ifTrue: [self value] ifFalse: [self value: anArg] Any takers? because it would be really nice to say to newcomers that our core libraries are super cool. Stef

Feb. 12, 2017

Re: [Pharo-dev] [QA] Re: GLMAction and PharoShortcut

by stepharong

For the record we were discussing with denis to have a hierarchy of command each one encapsulating its shortcut and other. Now it should work for calypso and we will remove Nautilus in 70. But the problem is all the places where shortcuts are hardcoded and we will have to work on them. Now I'm not saying that we should not do anything now to fix the current problem. I just mention our current thoughts. Stef > Le 12/02/2017 Ã 11:53, Ben Coman a Ã©crit : >> >> Well spotted. They should be consistent. I guess the next questions >> are; >> * Does Glamour convert cross platform Meta-x definitions to platform >> specific in its rendering? Or are the Ctrl-xx hard coded? > > GLMAction comes with a method to render a print representation of shor > tcut, but it is not its responsibility to do so. It is the short cut > responsibility, so other widget can also use the same and consistent > print representation. > > The responsability should go to instance of KMModifiedKeyCombination, > not sure about that though. > > The way the modifier is selected in the GLamour looks strange, why not > using the modifier instance? > > >> * If the former, can Spec be made to do the same conversion for its >> rendering? >> * Or do we prefer to refer to the general Meta-x throughout the UI? > > > The way short cuts are rendered in menu or tool tip is not consistent. > In Nautilus you have for example: 'Ctrl + A', in debugger it is rendered > 'ctrl+a' for Ctrl-a or 'ctrl+shift+a' for Ctrl-A. > In playground you can see both depending on you are viewing a menu or a > button tool tip. > > Now I see another place where short cut gets a print representation: > MorphicMenuItemAdapter>>shortcutText > > > -- Using Opera's mail client: http://www.opera.com/mail/

Feb. 12, 2017

Re: [Pharo-dev] inspector performance improvement

by phil＠highoctane.be

Any chance for this to run on a 5.0? Phil On Sun, Feb 12, 2017 at 3:13 PM, stepharong <stepharong(a)free.fr> wrote: > Great job!!!! > It feels lot snappier :) > Now it is a real pleasure to navigate objects. > This is nice to see that you are paying attention because the engine is > getting faster and this is important > that the tools do not eat all the power by accident. > Tx a lot > > > On Sat, 11 Feb 2017 21:31:56 +0100, Tudor Girba <tudor(a)tudorgirba.com> > wrote: > > Hi, >> >> Andrei and Alex did a great job at improving the performance and >> scalability of the inspector. >> >> There are a couple of main improvements: >> - Added FastTable support for the Raw presentation for all objects. This >> implied completing the support for the tree presentation binding to fast >> table. >> - Moved the Items presentation for collections to FastTable. >> - Improved the rendering of Glamour to no longer rely on the default >> Morph>>#adoptPaneColor. It turns out that using adoptPaneColor triggers a >> relayout of the morph, even if it is not visible. We extended PanelMorph in >> the context of Glamour with a less needy logic. >> >> I will not tell you how fast it is. I would rather want you to play with >> it :). >> >> The change is already in the Moose image. It is not yet in Pharo, but it >> will be soon. In the meantime you can be load it in Pharo 6 like this: >> >> Gofer new >> smalltalkhubUser: 'Moose' project: 'GToolkit'; >> package: 'ConfigurationOfGToolkitCore'; >> load. >> (#ConfigurationOfGToolkitCore asClass project version: #stable) >> load >> >> To play with it, try this with both the current version and the new one >> and the Spec Inspector if you want (just make sure you save the image >> beforehand): >> >> collection := (1 to: 100000000) asArray. >> [collection inspect] timeToRun. >> >> collection := (1 to: 100000000). >> [collection inspect] timeToRun. >> >> (for these two ones notice that Items do not appear at all in the old >> implementation) >> >> [World inspect] timeToRun. >> >> >> There are still a couple of issues open, such as the sorting of the >> columns. We would need your help with testing this, and report possible >> missing issues. >> >> Cheers, >> Doru >> >> >> -- >> www.tudorgirba.com >> www.feenk.com >> >> "Obvious things are difficult to teach." >> >> >> >> >> >> > > -- > Using Opera's mail client: http://www.opera.com/mail/ > >

Feb. 12, 2017

[QA] Re: GLMAction and PharoShortcut

by Hilaire

Le 12/02/2017 Ã 11:53, Ben Coman a Ã©crit : > > Well spotted. They should be consistent. I guess the next questions are; > * Does Glamour convert cross platform Meta-x definitions to platform > specific in its rendering? Or are the Ctrl-xx hard coded? GLMAction comes with a method to render a print representation of shor tcut, but it is not its responsibility to do so. It is the short cut responsibility, so other widget can also use the same and consistent print representation. The responsability should go to instance of KMModifiedKeyCombination, not sure about that though. The way the modifier is selected in the GLamour looks strange, why not using the modifier instance? > * If the former, can Spec be made to do the same conversion for its > rendering? > * Or do we prefer to refer to the general Meta-x throughout the UI? The way short cuts are rendered in menu or tool tip is not consistent. In Nautilus you have for example: 'Ctrl + A', in debugger it is rendered 'ctrl+a' for Ctrl-a or 'ctrl+shift+a' for Ctrl-A. In playground you can see both depending on you are viewing a menu or a button tool tip. Now I see another place where short cut gets a print representation: MorphicMenuItemAdapter>>shortcutText -- Dr. Geo http://drgeo.eu

Feb. 12, 2017

Re: [Pharo-dev] Pharo wiki

by stepharong

remember that we have this http://pharo.gemtalksystems.com stef On Sat, 11 Feb 2017 23:22:11 +0100, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > I try to use StackOverflow documentation to document some Pharo stuff. > Itâs very limited, but it has all the collaborative stuff from > StackOverflow, so somehow I believe there is less effort needed to > >manage permissions. > > Uko > >> On 10 Feb 2017, at 21:14, philippe.back(a)highoctane.be >> <philippe.back(a)gmail.com> wrote: >> >> I miss the Squeak wiki Pharo style. >> >> Phil >> >> Le 10 fÃ©vr. 2017 19:06, "Esteban A. Maringolo" <emaringolo(a)gmail.com> a >> Ã©crit : >>> 2017-02-10 14:59 GMT-03:00 phil(a)highoctane.be <phil(a)highoctane.be>: >>>> Mass adoption and hyper reduced friction to get people on board. >>>> >>>> For me: I have 10+ slack teams in my slack client and there is really >>>> no >>>> point in having more clients on the desktop. >>> >>> +1 to this. This is key. >>> >>> Maybe what we're missing is a simple wiki to collect the shared >>> knowledge, recipes, and other stuff. >>> >>> >>> Esteban A. Maringolo >>> > -- Using Opera's mail client: http://www.opera.com/mail/

Feb. 12, 2017

Re: [Pharo-dev] inspector performance improvement

by stepharong

Great job!!!! It feels lot snappier :) Now it is a real pleasure to navigate objects. This is nice to see that you are paying attention because the engine is getting faster and this is important that the tools do not eat all the power by accident. Tx a lot On Sat, 11 Feb 2017 21:31:56 +0100, Tudor Girba <tudor(a)tudorgirba.com> wrote: > Hi, > > Andrei and Alex did a great job at improving the performance and > scalability of the inspector. > > There are a couple of main improvements: > - Added FastTable support for the Raw presentation for all objects. This > implied completing the support for the tree presentation binding to fast > table. > - Moved the Items presentation for collections to FastTable. > - Improved the rendering of Glamour to no longer rely on the default > Morph>>#adoptPaneColor. It turns out that using adoptPaneColor triggers > a relayout of the morph, even if it is not visible. We extended > PanelMorph in the context of Glamour with a less needy logic. > > I will not tell you how fast it is. I would rather want you to play with > it :). > > The change is already in the Moose image. It is not yet in Pharo, but it > will be soon. In the meantime you can be load it in Pharo 6 like this: > > Gofer new > smalltalkhubUser: 'Moose' project: 'GToolkit'; > package: 'ConfigurationOfGToolkitCore'; > load. > (#ConfigurationOfGToolkitCore asClass project version: #stable) load > > To play with it, try this with both the current version and the new one > and the Spec Inspector if you want (just make sure you save the image > beforehand): > > collection := (1 to: 100000000) asArray. > [collection inspect] timeToRun. > > collection := (1 to: 100000000). > [collection inspect] timeToRun. > > (for these two ones notice that Items do not appear at all in the old > implementation) > > [World inspect] timeToRun. > > > There are still a couple of issues open, such as the sorting of the > columns. We would need your help with testing this, and report possible > missing issues. > > Cheers, > Doru > > > -- > www.tudorgirba.com > www.feenk.com > > "Obvious things are difficult to teach." > > > > > -- Using Opera's mail client: http://www.opera.com/mail/

Feb. 12, 2017

Re: [Pharo-dev] GLMAction and PharoShortcut

by Ben Coman

On Sun, Feb 12, 2017 at 6:32 PM, Hilaire <hilaire(a)drgeo.eu> wrote: > Hi, > > While writing these tooltips for the debugger, it seems to me some > refactoring is needed in the use of Pharo shortcut: > https://pharo.fogbugz.com/f/cases/19684/GLMAction-and- > PharoShortcut-need-refactoring > > because the current situation to have Glamour tk rendering short cut as > 'Ctrl-A' then Spec as 'Meta-A' > > Any opinion on the topic. > Well spotted. They should be consistent. I guess the next questions are; * Does Glamour convert cross platform Meta-x definitions to platform specific in its rendering? Or are the Ctrl-xx hard coded? * If the former, can Spec be made to do the same conversion for its rendering? * Or do we prefer to refer to the general Meta-x throughout the UI? cheers -ben

Feb. 12, 2017

Context stack semantics (was Re: GTDebugger variables table)

by Ben Coman

On Fri, Feb 3, 2017 at 11:33 AM, Ben Coman <btc(a)openinworld.com> wrote: > > On Fri, Feb 3, 2017 at 10:21 AM, Ben Coman <btc(a)openinworld.com> wrote: >> >> Or maybe it [Stack] would be better as a tab of thisContext's next pane. >> > > Actually you can try this now... > > Context>>stackValueMap > | stackValues stackDepth| > stackValues := OrderedCollection new. > stackDepth := self basicSize min: 21. > (stackDepth to: 1 by: -1) do: [ :index | > |key| > key := (index = stackDepth) ifTrue: ['Top'] ifFalse: [(stackDepth - index + > 1) asString]. > stackValues add: (key -> (self basicAt: index)) > ]. > ^stackValues > > Context>>gtInspectorStackValuesIn: composite > <gtInspectorPresentationOrder: 40> > | stackValues | > stackValues := self stackValues. > ^ (composite table) > title: 'Stack'; > display: [ self stackValueMap ]; > column: 'Depth' evaluated: [ :assoc | assoc key ] width: 50; > column: 'Item' evaluated: [ :assoc | GTObjectPrinter new > asTruncatedTextFrom: assoc value ] > > > I'm not sure whether the #stackValueMap is an appropriate name. Perhaps it > should be #methodStackValueMap or something else? Similar for the tab name. A couple of times already I've missed not having this in fresh Images. Since its simple and low impact I hoping to add it for Pharo 6, but I'd like to check the semantics are right As a comparison, what I understand of C lang is it has only one stack (per thread) for: * execution flow return to caller's next statement * function parameters * function local variables So C kind of combines call stack and variable stack.. In Pharo, the top pane of the debugger shows a stack of Contexts as returned by "thisContext stack" which is effectively is for * execution flow return to caller's next statement And from what I learnt writing #stackValueMap above it seems , that each Context has its own stack for: * function parameters * function local variables * calculations / parameter marshalling for message sends So how should the second stack be referred to? Any of the following? * methodStackValues? * contextStackValues? * valueStack? * stackValues? and btw I wonder if Context>>stack would be better named Context>>callStack Here is my current refinement of the methods... Context>>stackValues | stackValues stackDepth| stackValues := OrderedCollection new. stackDepth := self basicSize min: 21. (stackDepth to: 1 by: -1) do: [ :index | stackValues add: (self basicAt: index) ]. ^stackValues Context>>composite <gtInspectorPresentationOrder: 30> |stackValues| stackValues := self stackValues. ^ composite table title: 'Value Stack'; display: [ :aCollection | [(1 to: stackValues size) collect: [ :index | index -> (stackValues at: index) ]] on:Error do:[#()]]; beMultiple; column: 'Index' evaluated: [ :assoc | (assoc key = 1 ifTrue: ['Top'] ifFalse: [ assoc key asString ])] width: 50; column: 'Item' evaluated: [ :assoc | GTObjectPrinter new asTruncatedTextFrom: assoc value ]; send: [ :result | result isNil ifTrue: [ nil ] ifFalse: [ result value size = 1 ifTrue: [result anyOne value] ifFalse: [self species withAll: (result collect: [:each | each value])]]]; showOnly: 50 cheers -ben

Feb. 12, 2017

GLMAction and PharoShortcut

by Hilaire

Hi, While writing these tooltips for the debugger, it seems to me some refactoring is needed in the use of Pharo shortcut: https://pharo.fogbugz.com/f/cases/19684/GLMAction-and-PharoShortcut-need-re… because the current situation to have Glamour tk rendering short cut as 'Ctrl-A' then Spec as 'Meta-A' Any opinion on the topic. Hilaire -- Dr. Geo http://drgeo.eu

Feb. 12, 2017