- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60408 Home: https://github.com/pharo-project/pharo-core

Feb. 22, 2017

[pharo-project/pharo-core] 1cdbba: 60408

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 1cdbbada9ba7c8879e9bd2b67d83d2b6fa8e2021 https://github.com/pharo-project/pharo-core/commit/1cdbbada9ba7c8879e9bd2b6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M BaselineOfIDE.package/BaselineOfIDE.class/instance/baseline/baseline_.st M BaselineOfIDE.package/BaselineOfIDE.class/instance/baseline/groups_.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/README.md A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/class/as yet unclassified/ignoredDependencies.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/class/meta-data - dependency analyser/packageName.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/definition.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/README.md A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/classesToInitializeWithDependencies.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/classesToInitializeWithNoDependency.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/initializeClasses.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/runInitializeOnClasses_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/loadPackage_from_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/loadSUnitPackage.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/loadTestPackages.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/reloadBootstrapPackages.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/repository.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/public api/initializeCommandLineHandlerAndErrorHandling.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/public api/run.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/public api/runStartup.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/ignoredTests.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/runTests.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/runTestsOn_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/testClassesFrom_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/testPackages.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/applyPatches.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/fixPharoClassInstallerMethodCopying.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/fixSetInitialCodeFormatter.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/fixUpdateInstancesOfSpecialClasses.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/definition.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/README.md A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/class/accessing/caseFolding.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/class/accessing/data.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/class/initializing/initializeUnicodeClass.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/definition.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60407.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60408.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60407.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60408.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 60408 19743 Fix Refactoring-Tests-Group in BaselineOfIDE https://pharo.fogbugz.com/f/cases/19743 19744 integrate PharoBootstrap-Initialization https://pharo.fogbugz.com/f/cases/19744 http://files.pharo.org/image/60/60408.zip

Feb. 22, 2017

Re: [Pharo-dev] WeakValueDictionary: shouldn't be "absent" after GC?

by Guillermo Polito

I trust your native english advice :) On Wed, Feb 22, 2017 at 2:11 PM, Ben Coman <btc(a)openinworld.com> wrote: > On Wed, Feb 22, 2017 at 8:52 PM, Guillermo Polito > <guillermopolito(a)gmail.com> wrote: > > > > > > On Wed, Feb 22, 2017 at 12:57 AM, Martin Dias <tinchodias(a)gmail.com> > wrote: > >> > >> Hi all > >> > >> Phil: > >> I'm sorry, didn't get what you point with the code snippet. The copy of > >> the Symbol is the same instance, that I think it's nto GCed. > >> > >> Guille: > >> Yes, I knew the internals of the WeakValueDictionary but asked about the > >> API. > > > > > > Ah, ok, I only understood that you did not get why it was like that. :) > > > >> > >> What I don't know is about using WeakRegistry > > > > > > This is just needed to do the cleanup of the expired associations. > > > >> > >> and Ephemerons. > > > > > > This is a completely different thing. There is an EphemeronRegistry in > the > > image, but it does not propose at:/at:ifAbsent: messages. It just holds > > Ephemerons. > > > >> I'll check WeakKeyDictionary. > > > > > > If you need to hold weakly the values, then this is not what you're > looking > > for, isn't it? > > > >> > >> > >> I understand the idea of "explicit control of magic", but not sure if I > >> understand concretely. Do you mean to implement something like > >> WeakValueDictionary>>register which will not be executed by > #initialize, so > >> the user can decide to register. Am I right? > > > > > > Yep. I would even call it: > > > > registerForCleanup > > > > Like that it is explicit that you're doing it, and that it may incur into > > some performance degradation of the entire system. > > > >> > >> > >> Denis: > >> +1 WeakSet behavior is really confusing! In thte case of > >> WeakValueDictionary I didn't check for inconsistencies but was only > annoyed > >> but it's behavior. > >> > >> Guille and Denis: > >> Instead of using SetElement or cleaning up the empty > >> WeakValueAssociations, what I first thought is to internally consider an > >> association with nil as absent. I mean, modify or override some methods > soem > >> when there is an WeakValueAssociation with value == nil it considers > it's > >> absent. Concretely, I'd expect: > > > > > > Well, the idea of the SetElement is that you may want to have `nil` as a > > valid value in your dictionary. Otherwise, you cannot do: > > > > WeakValueDictionary new > > at: 'key' put: nil; > > at: 'key' --> error??? > > > > We can discuss if it is useful or not, but as with sets, before people > used > > to check if the inserted element was nil beforehand to have the expected > > behavior... > > > >> > >> | dictionary | > >> dictionary := WeakValueDictionary with: 'hello' -> 'world' copy. > >> Smalltalk garbageCollect. > >> { > >> dictionary values includes: nil. ---> false > >> dictionary at: 'hello'. ---> NotFound signal > >> dictionary at: 'hello' ifAbsent: [ 'absent' ]. ---> 'absent' > >> dictionary at: 'hello' ifAbsentPut: [ 'put' ]. ---> 'put' > >> } > > > > > > I agree that we may review the API. At least #at:, #at:ifAbsent: and > > #at:ifAbsentPut: should behave similarly. > > > > In any case, we could see how to improve EphemeronRegistry or even > implement > > an EphemericDictionary that would replace the WeakValueDictionary. > > btw, Would EmphemeralDictionary be an acceptable name? It has a nicer > sound to it. > cheers -ben > > > > > > >> > >> > >> It's better if I give some context. Look this simplified version of my > use > >> case: > >> > >> MyUI>> > >> morphAt: key > >> cache ifNil: [ cache := WeakValueDictionary new ]. > >> ^ cache at: key ifPresent: [:cachedValueOrNil | cachedValueOrNil > >> ifNotNil: [ cachedValueOrNil ] ifNil: [ cache at: entryReference put: > (self > >> newMorph: key) ] ] ifAbsent: [ cache at: entryReference put: (self > newMorph: > >> key) ] > >> > >> I'd like to only send #newMorph: in ifAbsent: and to avoid the > >> ifNotNil:ifNil: > >> Like this: > >> > >> morphAt: key > >> cache ifNil: [ cache := WeakValueDictionary new ]. > >> ^ cache at: key ifAbsent: [ cache at: entryReference put: (self > newMorph: > >> key) ] > >> > >> :-) > >> > >> MartÃn > > > > > >

Feb. 22, 2017

Re: [Pharo-dev] WeakValueDictionary: shouldn't be "absent" after GC?

by Ben Coman

On Wed, Feb 22, 2017 at 8:52 PM, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > > > On Wed, Feb 22, 2017 at 12:57 AM, Martin Dias <tinchodias(a)gmail.com> wrote: >> >> Hi all >> >> Phil: >> I'm sorry, didn't get what you point with the code snippet. The copy of >> the Symbol is the same instance, that I think it's nto GCed. >> >> Guille: >> Yes, I knew the internals of the WeakValueDictionary but asked about the >> API. > > > Ah, ok, I only understood that you did not get why it was like that. :) > >> >> What I don't know is about using WeakRegistry > > > This is just needed to do the cleanup of the expired associations. > >> >> and Ephemerons. > > > This is a completely different thing. There is an EphemeronRegistry in the > image, but it does not propose at:/at:ifAbsent: messages. It just holds > Ephemerons. > >> I'll check WeakKeyDictionary. > > > If you need to hold weakly the values, then this is not what you're looking > for, isn't it? > >> >> >> I understand the idea of "explicit control of magic", but not sure if I >> understand concretely. Do you mean to implement something like >> WeakValueDictionary>>register which will not be executed by #initialize, so >> the user can decide to register. Am I right? > > > Yep. I would even call it: > > registerForCleanup > > Like that it is explicit that you're doing it, and that it may incur into > some performance degradation of the entire system. > >> >> >> Denis: >> +1 WeakSet behavior is really confusing! In thte case of >> WeakValueDictionary I didn't check for inconsistencies but was only annoyed >> but it's behavior. >> >> Guille and Denis: >> Instead of using SetElement or cleaning up the empty >> WeakValueAssociations, what I first thought is to internally consider an >> association with nil as absent. I mean, modify or override some methods soem >> when there is an WeakValueAssociation with value == nil it considers it's >> absent. Concretely, I'd expect: > > > Well, the idea of the SetElement is that you may want to have `nil` as a > valid value in your dictionary. Otherwise, you cannot do: > > WeakValueDictionary new > at: 'key' put: nil; > at: 'key' --> error??? > > We can discuss if it is useful or not, but as with sets, before people used > to check if the inserted element was nil beforehand to have the expected > behavior... > >> >> | dictionary | >> dictionary := WeakValueDictionary with: 'hello' -> 'world' copy. >> Smalltalk garbageCollect. >> { >> dictionary values includes: nil. ---> false >> dictionary at: 'hello'. ---> NotFound signal >> dictionary at: 'hello' ifAbsent: [ 'absent' ]. ---> 'absent' >> dictionary at: 'hello' ifAbsentPut: [ 'put' ]. ---> 'put' >> } > > > I agree that we may review the API. At least #at:, #at:ifAbsent: and > #at:ifAbsentPut: should behave similarly. > > In any case, we could see how to improve EphemeronRegistry or even implement > an EphemericDictionary that would replace the WeakValueDictionary. btw, Would EmphemeralDictionary be an acceptable name? It has a nicer sound to it. cheers -ben > >> >> >> It's better if I give some context. Look this simplified version of my use >> case: >> >> MyUI>> >> morphAt: key >> cache ifNil: [ cache := WeakValueDictionary new ]. >> ^ cache at: key ifPresent: [:cachedValueOrNil | cachedValueOrNil >> ifNotNil: [ cachedValueOrNil ] ifNil: [ cache at: entryReference put: (self >> newMorph: key) ] ] ifAbsent: [ cache at: entryReference put: (self newMorph: >> key) ] >> >> I'd like to only send #newMorph: in ifAbsent: and to avoid the >> ifNotNil:ifNil: >> Like this: >> >> morphAt: key >> cache ifNil: [ cache := WeakValueDictionary new ]. >> ^ cache at: key ifAbsent: [ cache at: entryReference put: (self newMorph: >> key) ] >> >> :-) >> >> MartÃn > >

Feb. 22, 2017

Re: [Pharo-dev] WeakValueDictionary: shouldn't be "absent" after GC?

by Guillermo Polito

On Wed, Feb 22, 2017 at 12:57 AM, Martin Dias <tinchodias(a)gmail.com> wrote: > Hi all > > Phil: > I'm sorry, didn't get what you point with the code snippet. The copy of > the Symbol is the same instance, that I think it's nto GCed. > > Guille: > Yes, I knew the internals of the WeakValueDictionary but asked about the > API. > Ah, ok, I only understood that you did not get why it was like that. :) > What I don't know is about using WeakRegistry > This is just needed to do the cleanup of the expired associations. > and Ephemerons. > This is a completely different thing. There is an EphemeronRegistry in the image, but it does not propose at:/at:ifAbsent: messages. It just holds Ephemerons. I'll check WeakKeyDictionary. > If you need to hold weakly the values, then this is not what you're looking for, isn't it? > > I understand the idea of "explicit control of magic", but not sure if I > understand concretely. Do you mean to implement something like > WeakValueDictionary>>register which will not be executed by #initialize, > so the user can decide to register. Am I right? > Yep. I would even call it: registerForCleanup Like that it is explicit that you're doing it, and that it may incur into some performance degradation of the entire system. > > Denis: > +1 WeakSet behavior is really confusing! In thte case of > WeakValueDictionary I didn't check for inconsistencies but was only annoyed > but it's behavior. > > Guille and Denis: > Instead of using SetElement or cleaning up the empty > WeakValueAssociations, what I first thought is to internally consider an > association with nil as absent. I mean, modify or override some methods > soem when there is an WeakValueAssociation with value == nil it considers > it's absent. Concretely, I'd expect: > Well, the idea of the SetElement is that you may want to have `nil` as a valid value in your dictionary. Otherwise, you cannot do: WeakValueDictionary new at: 'key' put: nil; at: 'key' --> error??? We can discuss if it is useful or not, but as with sets, before people used to check if the inserted element was nil beforehand to have the expected behavior... > | dictionary | > dictionary := WeakValueDictionary with: 'hello' -> 'world' copy. > Smalltalk garbageCollect. > { > dictionary values includes: nil. *---> false * > dictionary at: 'hello'. * ---> NotFound signal* > dictionary at: 'hello' ifAbsent: [ 'absent' ].* ---> 'absent'* > dictionary at: 'hello' ifAbsentPut: [ 'put' ]. *---> 'put'* > } > I agree that we may review the API. At least #at:, #at:ifAbsent: and #at:ifAbsentPut: should behave similarly. In any case, we could see how to improve EphemeronRegistry or even implement an EphemericDictionary that would replace the WeakValueDictionary. > > It's better if I give some context. Look this simplified version of my use > case: > > MyUI>> > morphAt: key > cache ifNil: [ cache := WeakValueDictionary new ]. > ^ cache at: key ifPresent: [:cachedValueOrNil | cachedValueOrNil > ifNotNil: [ cachedValueOrNil ] ifNil: [ cache at: entryReference put: (self > newMorph: key) ] ] ifAbsent: [ cache at: entryReference put: (self > newMorph: key) ] > > I'd like to only send #newMorph: in ifAbsent: and to avoid the > ifNotNil:ifNil: > Like this: > > morphAt: key > cache ifNil: [ cache := WeakValueDictionary new ]. > ^ cache at: key ifAbsent: [ cache at: entryReference put: (self > newMorph: key) ] > > :-) > > MartÃn >

Feb. 22, 2017

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50770 Home: https://github.com/pharo-project/pharo-core

Feb. 22, 2017

[pharo-project/pharo-core] ce58da: 50770

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: ce58da19a7bf246ed72435d9d7d797017329a271 https://github.com/pharo-project/pharo-core/commit/ce58da19a7bf246ed72435d9… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: A Komitter.package/KomitFtpRemote.class/README.md A Komitter.package/KomitFtpRemote.class/definition.st A Komitter.package/extension/MCFtpRepository/instance/koRemote.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50769.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50770.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50769.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50770.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50770 19738 MCFtpRepository does not understand #koRemote https://pharo.fogbugz.com/f/cases/19738 http://files.pharo.org/image/50/50770.zip

Feb. 22, 2017

UnixOSProcessPlugin and accessing C array out of bounds

by Holger Freyther

Hi Esteban, while building packages for OBS and going the compile warnings (one of the nice things of newer compilers is the increased diagnostic) I noticed this: [ 196s] /usr/src/packages/BUILD/src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c:4525:20: warning: iteration 64u invokes undefined behavior [-Waggressive-loop-optimizations] [ 196s] if ((semaIndices[sigNum]) > 0) { [ 196s] ^ [ 196s] /usr/src/packages/BUILD/src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c:4524:9: note: containing loop [ 196s] while (sigNum <= (signalArraySize())) { while (sigNum <= (signalArraySize())) { if ((semaIndices[sigNum]) > 0) { setSignalNumberhandler(sigNum, (originalSignalHandlers())[sigNum]); } sigNum += 1; } semaIndices has signalArraySize()/NSIG number of entries and is zero based, it is being accessed with sigNum==NSIG which means one entry beyond the memory of the array? Can you confirm this? restoreDefaultSignalHandlers "Restore signal handlers to their original behaviors." | sigNum | <returnTypeC: 'void'> semaIndices = nil "nil if in interpreter simulation" ifFalse: [sigNum := 1. [sigNum <= self signalArraySize] whileTrue: [((semaIndices at: sigNum) > 0) ifTrue: [self setSignalNumber: sigNum handler: (self originalSignalHandlers at: sigNum).]. sigNum := sigNum + 1]] So it is one based but the array doesn't have an extra element to make it work? How is this normally handled in slang code? holger

Feb. 22, 2017

[pharo-project/pharo-core] 520559: 60407

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 5205592c2e3b9004a89c41315e6fcd5e7dee155e https://github.com/pharo-project/pharo-core/commit/5205592c2e3b9004a89c4131… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M Refactoring-Core.package/RBExtractMethodRefactoring.class/instance/transforming/extractMethod.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60406.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60407.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60406.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60407.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Tool-Catalog.package/CatalogProject.class/instance/installing/installStableVersion.st Log Message: ----------- 60407 19736 Catalog should use Metacello API instead of Gofer for Configuration installation https://pharo.fogbugz.com/f/cases/19736 19446 Extract Method is broken https://pharo.fogbugz.com/f/cases/19446 http://files.pharo.org/image/60/60407.zip

Feb. 22, 2017

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60407 Home: https://github.com/pharo-project/pharo-core

Feb. 22, 2017