- Pharo-dev - lists.pharo.org

UnixOSProcessPlugin and accessing C array out of bounds

by Holger Freyther

Hi Esteban, while building packages for OBS and going the compile warnings (one of the nice things of newer compilers is the increased diagnostic) I noticed this: [ 196s] /usr/src/packages/BUILD/src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c:4525:20: warning: iteration 64u invokes undefined behavior [-Waggressive-loop-optimizations] [ 196s] if ((semaIndices[sigNum]) > 0) { [ 196s] ^ [ 196s] /usr/src/packages/BUILD/src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c:4524:9: note: containing loop [ 196s] while (sigNum <= (signalArraySize())) { while (sigNum <= (signalArraySize())) { if ((semaIndices[sigNum]) > 0) { setSignalNumberhandler(sigNum, (originalSignalHandlers())[sigNum]); } sigNum += 1; } semaIndices has signalArraySize()/NSIG number of entries and is zero based, it is being accessed with sigNum==NSIG which means one entry beyond the memory of the array? Can you confirm this? restoreDefaultSignalHandlers "Restore signal handlers to their original behaviors." | sigNum | <returnTypeC: 'void'> semaIndices = nil "nil if in interpreter simulation" ifFalse: [sigNum := 1. [sigNum <= self signalArraySize] whileTrue: [((semaIndices at: sigNum) > 0) ifTrue: [self setSignalNumber: sigNum handler: (self originalSignalHandlers at: sigNum).]. sigNum := sigNum + 1]] So it is one based but the array doesn't have an extra element to make it work? How is this normally handled in slang code? holger

Feb. 22, 2017

[pharo-project/pharo-core] 520559: 60407

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 5205592c2e3b9004a89c41315e6fcd5e7dee155e https://github.com/pharo-project/pharo-core/commit/5205592c2e3b9004a89c4131… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M Refactoring-Core.package/RBExtractMethodRefactoring.class/instance/transforming/extractMethod.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60406.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60407.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60406.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60407.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Tool-Catalog.package/CatalogProject.class/instance/installing/installStableVersion.st Log Message: ----------- 60407 19736 Catalog should use Metacello API instead of Gofer for Configuration installation https://pharo.fogbugz.com/f/cases/19736 19446 Extract Method is broken https://pharo.fogbugz.com/f/cases/19446 http://files.pharo.org/image/60/60407.zip

Feb. 22, 2017

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60407 Home: https://github.com/pharo-project/pharo-core

Feb. 22, 2017

Spotter - menu items

by Ben Coman

I happened to be Spotting for image saveXXX methods and at the top of results is #Menu + Save + Save as... + Save and quit Now what would be really nice is if the code pane showed the implementation of the menu item. Usually I resort to using Halos to inspect the menu item morph to view its implementation. On a slightly separate point, it feels awkward clicking Save in the Spotter search, since there is no visual feedback anything happened. I had to go back and experiment by choosing [Save as] to understand that clicking it actually executed it. Perhaps executing a menu item from Spotter could #inform: us that a menu item was executed. This is in spite that choosing [Save] from the World menu doesn't provide any feedback. I think that conforms to expected behaviour, but most other Spotter results only browse, not execute. Actually how many other Spotter extensions execute something? It is maybe potentially dangerous that it behaves differently to other results, and clicking on it (e.g. trying to expand it like other results) causes side effects. Perhaps the code pane showing the menu item implementation could have <Execute> and <Debug> buttons above it. cheers -ben

Feb. 22, 2017

Re: [Pharo-dev] WeakValueDictionary: shouldn't be "absent" after GC?

by Martin Dias

On Tue, Feb 21, 2017 at 8:57 PM, Martin Dias <tinchodias(a)gmail.com> wrote: > Hi all > > Phil: > I'm sorry, didn't get what you point with the code snippet. The copy of > the Symbol is the same instance, that I think it's nto GCed. > > Guille: > Yes, I knew the internals of the WeakValueDictionary but asked about the > API. What I don't know is about using WeakRegistry and Ephemerons. I'll > check WeakKeyDictionary. > > I understand the idea of "explicit control of magic", but not sure if I > understand concretely. Do you mean to implement something like > WeakValueDictionary>>register which will not be executed by #initialize, > so the user can decide to register. Am I right? > > Denis: > +1 WeakSet behavior is really confusing! In thte case of > WeakValueDictionary I didn't check for inconsistencies but was only annoyed > but it's behavior. > > Guille and Denis: > Instead of using SetElement or cleaning up the empty > WeakValueAssociations, what I first thought is to internally consider an > association with nil as absent. I mean, modify or override some methods > soem when there is an WeakValueAssociation with value == nil it considers > it's absent. Concretely, I'd expect: > > | dictionary | > dictionary := WeakValueDictionary with: 'hello' -> 'world' copy. > Smalltalk garbageCollect. > { > dictionary values includes: nil. *---> false * > dictionary at: 'hello'. * ---> NotFound signal* > dictionary at: 'hello' ifAbsent: [ 'absent' ].* ---> 'absent'* > dictionary at: 'hello' ifAbsentPut: [ 'put' ]. *---> 'put'* > } > > > It's better if I give some context. Look this simplified version of my use > case: > > MyUI>> > morphAt: key > cache ifNil: [ cache := WeakValueDictionary new ]. > ^ cache at: key ifPresent: [:cachedValueOrNil | cachedValueOrNil > ifNotNil: [ cachedValueOrNil ] ifNil: [ cache at: entryReference put: (self > newMorph: key) ] ] ifAbsent: [ cache at: entryReference put: (self > newMorph: key) ] > > I'd like to only send #newMorph: in ifAbsent: and to avoid the > ifNotNil:ifNil: > Like this: > > morphAt: key > cache ifNil: [ cache := WeakValueDictionary new ]. > ^ cache at: key ifAbsent: [ cache at: entryReference put: (self > newMorph: key) ] > > Bah, better: morphAt: key cache ifNil: [ cache := WeakValueDictionary new ]. ^ cache at: key ifAbsentPut: [ self newMorph: key ] > :-) > > MartÃn >

Feb. 21, 2017

Re: [Pharo-dev] WeakValueDictionary: shouldn't be "absent" after GC?

by Martin Dias

Hi all Phil: I'm sorry, didn't get what you point with the code snippet. The copy of the Symbol is the same instance, that I think it's nto GCed. Guille: Yes, I knew the internals of the WeakValueDictionary but asked about the API. What I don't know is about using WeakRegistry and Ephemerons. I'll check WeakKeyDictionary. I understand the idea of "explicit control of magic", but not sure if I understand concretely. Do you mean to implement something like WeakValueDictionary>>register which will not be executed by #initialize, so the user can decide to register. Am I right? Denis: +1 WeakSet behavior is really confusing! In thte case of WeakValueDictionary I didn't check for inconsistencies but was only annoyed but it's behavior. Guille and Denis: Instead of using SetElement or cleaning up the empty WeakValueAssociations, what I first thought is to internally consider an association with nil as absent. I mean, modify or override some methods soem when there is an WeakValueAssociation with value == nil it considers it's absent. Concretely, I'd expect: | dictionary | dictionary := WeakValueDictionary with: 'hello' -> 'world' copy. Smalltalk garbageCollect. { dictionary values includes: nil. *---> false * dictionary at: 'hello'. * ---> NotFound signal* dictionary at: 'hello' ifAbsent: [ 'absent' ].* ---> 'absent'* dictionary at: 'hello' ifAbsentPut: [ 'put' ]. *---> 'put'* } It's better if I give some context. Look this simplified version of my use case: MyUI>> morphAt: key cache ifNil: [ cache := WeakValueDictionary new ]. ^ cache at: key ifPresent: [:cachedValueOrNil | cachedValueOrNil ifNotNil: [ cachedValueOrNil ] ifNil: [ cache at: entryReference put: (self newMorph: key) ] ] ifAbsent: [ cache at: entryReference put: (self newMorph: key) ] I'd like to only send #newMorph: in ifAbsent: and to avoid the ifNotNil:ifNil: Like this: morphAt: key cache ifNil: [ cache := WeakValueDictionary new ]. ^ cache at: key ifAbsent: [ cache at: entryReference put: (self newMorph: key) ] :-) MartÃn

Feb. 21, 2017

Re: [Pharo-dev] Catalog loading in Spotter

by Stephan Eggermont

On 21/02/17 12:26, Torsten Bergmann wrote: > As there were no further objections I guess we should do the following steps as a compromise: I didn't like having the catalog in spotter at all. The current setting was fine for me. Stephan

Feb. 21, 2017

[JOB] looking for Smalltalk/Java dual skills in France

by Babel

We're looking for a Smalltalk/Java developer to strengthen a framework-oriented team dedicated to maintenance and development in the insurance domain. Skills required : - french speaking (fluent) - significant experience in Smalltalk - significant experience in Java - autonomous person - team-spirit Location : Poitou-Charentes, France Ready availablity Proposal open to freelancer, but not mandatory. If you are not a freelancer but interested, we will offer you to join a cooperative of developers. For more information, contact us asap : contact ait babel doot coop -- View this message in context: http://forum.world.st/JOB-looking-for-Smalltalk-Java-dual-skills-in-France-… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Feb. 21, 2017

Re: [Pharo-dev] Is Moz2D ready for Android?

by ClÃ©ment Bera

Hey Denis. Basically, does firefox work in Android ? Yes. Therefore, Moz2D can be built for Android. Moz2D uses internally one of these 2 libraries: Cairo or Skia. Cairo is supposed to be working on Android. Skia works for sure on Android as it has been the default graphic framework there since the beginning. I don't see builds online for Moz2D and Android, Moz2D is used both in Firefox and Servo, and both work in Android. Anyway it's not clear anyone is checking builds of Moz2D are passing any tests outside of Firefox and Servo. On Tue, Feb 21, 2017 at 4:00 PM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > Hi. > > It is just theoretical question to know. > Is Android supported by Moz2D library? > And how difficult would be compile necessary plugins for Bloc on Android? > > Best regards, > Denis >

Feb. 21, 2017

Is Moz2D ready for Android?

by Denis Kudriashov

Hi. It is just theoretical question to know. Is Android supported by Moz2D library? And how difficult would be compile necessary plugins for Bloc on Android? Best regards, Denis

Feb. 21, 2017