- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Current working directory

by Ben Coman

On Wed, May 17, 2017 at 7:38 PM, Rajula Vineet <Vineet.Reddy(a)iiitb.org> wrote: > Hi all, > > I am working on improving pharo command line as a part of my GSoC project. I > have been looking at different current working directory implementations. I > have written a blog post > <https://vineetreddy.wordpress.com/2017/05/17/pwd-vs-getcwd/> on it. It > would be of great help, if you can take a look and give your feedback. > > Rajula I'm not sure what value you might gain from it, but it may be interesting to review... https://github.com/lattera/freebsd/blob/master/bin/pwd/pwd.c (FreeBSD is better to review at since its license is more permissive than Linux) ----- Back when I was using Pharo on Windows, I was involved in some discussions regarding the semantics of working directories. These weren't brought to a conclusion and remain open questions... FileSystem on Windows should maintain per drive current working directory https://pharo.fogbugz.com/f/cases/13094 Windows FileSystem '\test\bar' not an absolute path http://forum.world.st/Windows-FileSystem-test-bar-not-an-absolute-path-td47… Strange Validation with issue 15820 http://forum.world.st/Strange-Validation-with-issue-15820-td4845673.html#a4… ----- Finally some grammar feedback... where you say... Implementation: buffer:= String new:100. better might be... Usage: buffer:= String new:100. The implementation would be the method above it ?? cheers -ben

May 17, 2017

Re: [Pharo-dev] Command line save and quit

by Max Leske

> On 17 May 2017, at 15:23, Damien Pollet <damien.pollet(a)gmail.com> wrote: > > On 17 May 2017 at 14:34, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: > > (self hasOption: 'save') > > ifTrue: [ Smalltalk snapshot: true andQuit: false ]. > > (self hasOption: 'quit') > > ifTrue: [ self exitSuccess ]. > > Yes, I think so. But you have to be careful there. Imagine that you first save with "Smalltalk snapshot: true andQuit: false" and then you check for 'quit' and send #exitSuccess. > > But in this version the lookup for option quit is done again when the images wakes up. Compare to the version originally copied by Subbu: > > | quit | > quit := self commandLine hasOption: 'quit'. > (self commandLine hasOption: 'save') > ifTrue: [ Smalltalk snapshot: true andQuit: quit ]. > quit > ifTrue: [ self exitSuccess ]. > > Here I'm guessing if you --save --quit then the image will get saved, and next time it wakes up, enters the second conditional and #exitSuccessâ¦ confusing :/ Very. When I look at this code, without going into the image and look, I would say that it will lead to exactly what I described: the image will start and exit again immediately. > > -- > Damien Pollet > type less, do more [ | ] http://people.untyped.org/damien.pollet <http://people.untyped.org/damien.pollet>

May 17, 2017

Re: [Pharo-dev] Command line save and quit

by Damien Pollet

On 17 May 2017 at 14:34, Max Leske <maxleske(a)gmail.com> wrote: > > (self hasOption: 'save') > > ifTrue: [ Smalltalk snapshot: true andQuit: false ]. > > (self hasOption: 'quit') > > ifTrue: [ self exitSuccess ]. > > Yes, I think so. But you have to be careful there. Imagine that you first > save with "Smalltalk snapshot: true andQuit: false" and then you check for > 'quit' and send #exitSuccess. But in this version the lookup for option quit is done again when the images wakes up. Compare to the version originally copied by Subbu: | quit | quit := self commandLine hasOption: 'quit'. (self commandLine hasOption: 'save') ifTrue: [ Smalltalk snapshot: true andQuit: quit ]. quit ifTrue: [ self exitSuccess ]. Here I'm guessing if you --save --quit then the image will get saved, and next time it wakes up, enters the second conditional and #exitSuccessâ¦ confusing :/ -- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet

May 17, 2017

Re: [Pharo-dev] Current working directory

by K K Subbu

On Wednesday 17 May 2017 05:08 PM, Rajula Vineet wrote: > Hi all, > > I am working on improving pharo command line as a part of my GSoC project. I > have been looking at different current working directory implementations. I > have written a blog post > <https://vineetreddy.wordpress.com/2017/05/17/pwd-vs-getcwd/> on it. It > would be of great help, if you can take a look and give your feedback. Vineet, Don't depend on getenv(). It is the parent (e.g. sh) which sets PWD to the current working directory before exec-ing your program. When a child process is spawned, the parent can decide not to pass this down to child. e.g. $ env -u PWD ./try Or, if the child process changes its working directory using chdir(), PWD will not change. e.g. --- try.c --- #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include <limits.h> int main(int argc, char *argv[]) { char cwd[PATH_MAX]; for(;;) { if (getcwd(cwd, sizeof(cwd)) != NULL) printf("getcwd: %s\n", cwd); else perror("getcwd() error"); printf("PWD: %s\n", getenv("PWD")); if (argv[1]) { printf("chdir %s\n", argv[1]); chdir(argv[1]); argc--; argv++; } else break; } return 0; } ------- Regards .. Subbu

May 17, 2017

Re: [Pharo-dev] Current working directory

by phil＠highoctane.be

Definitely. I read that you had a crash and you didn't know why. It is a good idea to run pharo under gdb so you can do a bt (backtrace) and see where it bombed. You can inspect parameters etc. Usually this is revealing of the problem when I do like that. Check http://stackoverflow.com/questions/6121094/how-do-i-run-a-program-with-comm… Like gdb -ex=r --args pharo-vm/pharo Pharo.image (not sure this is all right, but you'll figure it out). I also like to use a debug or assert VM so that I get all debugging symbols information. Alternatively, connect to a running Pharo with gdb -p PID I usually do that from something like Code::Blocks with an assert VM + source code around for whatever library I am trying to use from UFFI. Works nicely. Especially when you put a breakpoint before a crashing site, allowing you to see the stackframes etc. With gdb command line, it is worth knowing about frames: http://www.delorie.com/gnu/docs/gdb/gdb_44.html Namaste, Phil On Wed, May 17, 2017 at 2:08 PM, Guillermo Polito <guillermopolito(a)gmail.com > wrote: > Thanks Rajula :) > > This is cool! > > On Wed, May 17, 2017 at 1:38 PM, Rajula Vineet <Vineet.Reddy(a)iiitb.org> > wrote: > >> Hi all, >> >> I am working on improving pharo command line as a part of my GSoC >> project. I >> have been looking at different current working directory implementations. >> I >> have written a blog post >> <https://vineetreddy.wordpress.com/2017/05/17/pwd-vs-getcwd/> on it. It >> would be of great help, if you can take a look and give your feedback. >> >> Rajula >> >> >> >> -- >> View this message in context: http://forum.world.st/Current- >> working-directory-tp4947453.html >> Sent from the Pharo Smalltalk Developers mailing list archive at >> Nabble.com. >> >> > > > -- > > > > Guille Polito > > > Research Engineer > > French National Center for Scientific Research - *http://www.cnrs.fr* > <http://www.cnrs.fr> > > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >

May 17, 2017

Re: [Pharo-dev] Command line save and quit

by Max Leske

> On 17 May 2017, at 14:24, K K Subbu <kksubbu.ml(a)gmail.com> wrote: > > On Wednesday 17 May 2017 05:12 PM, Max Leske wrote: >> Yes. #exitSuccess does a bit more: >> 1. return an exit code to the command line >> 2. print a message >> 3. check if the session has changed >> 4. allows for overriding and special handling of the Exit exception. >> >> You should not assume that nobody needs that :) > > Thanks for the quick clarification. I am trying to understand the difference between using quit and save/quit. exitSuccess never gets called when both options "--save --quit" are given. Shouldn't the code handle this case as well: > > (self hasOption: 'save') > ifTrue: [ Smalltalk snapshot: true andQuit: false ]. > (self hasOption: 'quit') > ifTrue: [ self exitSuccess ]. Yes, I think so. But you have to be careful there. Imagine that you first save with "Smalltalk snapshot: true andQuit: false" and then you check for 'quit' and send #exitSuccess. What will happen after the next startup is that the execution will arrive at the *same point*. It will check 'quit' and exit as before, you will not be able to get back in to the image. You should definitely try playing around with that, just be sure to make a copy of your image first :) Cheers, Max > > Regards .. Subbu >

May 17, 2017

Re: [Pharo-dev] Command line save and quit

by K K Subbu

On Wednesday 17 May 2017 05:12 PM, Max Leske wrote: > Yes. #exitSuccess does a bit more: > 1. return an exit code to the command line > 2. print a message > 3. check if the session has changed > 4. allows for overriding and special handling of the Exit exception. > > You should not assume that nobody needs that :) Thanks for the quick clarification. I am trying to understand the difference between using quit and save/quit. exitSuccess never gets called when both options "--save --quit" are given. Shouldn't the code handle this case as well: (self hasOption: 'save') ifTrue: [ Smalltalk snapshot: true andQuit: false ]. (self hasOption: 'quit') ifTrue: [ self exitSuccess ]. Regards .. Subbu

May 17, 2017

Re: [Pharo-dev] Current working directory

by Guillermo Polito

Thanks Rajula :) This is cool! On Wed, May 17, 2017 at 1:38 PM, Rajula Vineet <Vineet.Reddy(a)iiitb.org> wrote: > Hi all, > > I am working on improving pharo command line as a part of my GSoC project. > I > have been looking at different current working directory implementations. I > have written a blog post > <https://vineetreddy.wordpress.com/2017/05/17/pwd-vs-getcwd/> on it. It > would be of great help, if you can take a look and give your feedback. > > Rajula > > > > -- > View this message in context: http://forum.world.st/Current- > working-directory-tp4947453.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > > -- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

May 17, 2017

Re: [Pharo-dev] Command line save and quit

by Max Leske

> On 17 May 2017, at 13:29, K K Subbu <kksubbu.ml(a)gmail.com> wrote: > > Hi, > > STCommandLineHandler>>#end is defined as: > --- > | quit | > quit := self commandLine hasOption: 'quit'. > (self commandLine hasOption: 'save') > ifTrue: [ Smalltalk snapshot: true andQuit: quit ]. > quit > ifTrue: [ self exitSuccess ]. > --- > Can this be simplified to: > > ^Smalltalk snapshot: (self hasOption: 'save') > andQuit: (self hasOption: 'quit') > > Is it necessary to call exitSuccess when only '--quit' is given? Yes. #exitSuccess does a bit more: 1. return an exit code to the command line 2. print a message 3. check if the session has changed 4. allows for overriding and special handling of the Exit exception. You should not assume that nobody needs that :) Cheers, Max > > Regards .. Subbu >

May 17, 2017

Current working directory

by Rajula Vineet

Hi all, I am working on improving pharo command line as a part of my GSoC project. I have been looking at different current working directory implementations. I have written a blog post <https://vineetreddy.wordpress.com/2017/05/17/pwd-vs-getcwd/> on it. It would be of great help, if you can take a look and give your feedback. Rajula -- View this message in context: http://forum.world.st/Current-working-directory-tp4947453.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

May 17, 2017