- Pharo-dev - lists.pharo.org

Iceberg ?

by Stephane Ducasse

On mac with latest pharo vm and latest pharo 60 Metacello new baseline: 'Bloc'; repository: 'github://pharo-graphics/Bloc/src'; load:#core Then I got LGit_GIT_ERROR no ssh-agent suitable credentials found

May 21, 2017

Iceberg help

by Stephane Ducasse

So I tried to use iceberg to contribute to bloc I entered git@github.com:ducasse/pharo-graphics/Bloc.git and git@github.com:ducasse/pharo-graphics/Bloc and iceberg tells me that there is a parse error?????? Then I tried

May 21, 2017

[ Bloc ] Some questions

by Stephane Ducasse

Hi Several questions on bloc - Would it make sense to rename BlElement into BlGraphicalElement? - Could we rename drawPathOnSpartCanvas: -> drawOn:? or drawPathOn: - What is the difference between a shapeFactory and a Geometry? - Does a Geometry can build path too? I saw that the Factory is in Sparta while the Geometry in Bloc I thought because of buildPathOnSpartaCanvas: aCanvas within: aBounds - Why the ShapeFactory does not delegate its logic to the Geometry object? - Why BlGeometryElement is not called BlGeometricalElement? - How a BlLine relates to a BlLineElement? BlLineElement >> defaultGeometry ^ BlLine new Would it not be better to have an instance variable like that we do not force extender to only use inheritance? With an instance variable and setter We could do BlLineElement new geometry: MyBlLine new.

May 21, 2017

Re: [Pharo-dev] Git, FileTree/Cypress, missing Traits comments

by Thierry Goubier

Hi Ben, There is two Traits tests in the FileTree repository, and they pass (both under filetree and under gitfiletree) even if I notice that you can load the test package fine, but you get a DNU when browsing that package from the test repository inspector. The tests classes are MCFileTreeLoaderTraitsTest and MCGitFileTreeLoaderTraitsTest, and the test repository is at: https://github.com/dalehenrich/filetree/tree/pharo5.0/tests/testRepositorie…. Would you be interested in checking if the Squeak bug applies, adding an additional test to confirm or infirm with a pull request? Regards, Thierry Le 21/05/2017 Ã 05:12, Ben Coman a Ã©crit : > Is this of concern for Pharo...? "Pull requests on GitHub where the > Trait comments get removed (because they were not loaded with the > package in the first place)." > > http://forum.world.st/Re-The-Inbox-System-jr-919-mcz-td4941798.html#none > > http://forum.world.st/The-Inbox-System-jr-919-mcz-td4933985.html > > cheers -ben >

May 21, 2017

Re: [Pharo-dev] Launcher and Pharo 6 Errors on Mac

by Sean P. DeNigris

Sean P. DeNigris wrote > On image start, I get "PrimitiveFailed: primitive #createDirectory: in > MacStore failed" for > /private/var/folders/fv/8j408sn92bb59k5ggw8cd3kc0000gn/T/AppTranslocation/4EF86F92-66D6-4944-8B30-FBCD96118FCC/d/Pharo.app/Contents/Resources/pharo-local > > When I try to Quit, I get "PrimitiveFailed: primitive #primSize: in > MultiByteFileStream failed" from `SourceFiles changesFileStream size` Bump. Is this not happening for anyone else? Is there a more canonical way to download latest Launcher? Pharo 6? ----- Cheers, Sean -- View this message in context: http://forum.world.st/Launcher-and-Pharo-6-Errors-on-Mac-tp4947652p4947731.… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

May 21, 2017

Git, FileTree/Cypress, missing Traits comments

by Ben Coman

Is this of concern for Pharo...? "Pull requests on GitHub where the Trait comments get removed (because they were not loaded with the package in the first place)." http://forum.world.st/Re-The-Inbox-System-jr-919-mcz-td4941798.html#none http://forum.world.st/The-Inbox-System-jr-919-mcz-td4933985.html cheers -ben

May 21, 2017

Re: [Pharo-dev] QualityImprovements assured by tests

by Yuriy Tymchuk

I think that the most important question is: did we integrate some code with these issues in pharo 6? Because definitely everyone is lazy to go and fix issues, but we should not integrate the new ones (especially when we have monkey checking that stuff). Uko > On 20 May 2017, at 14:13, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: > > I agree with you. > This is why I worked on the auto categoriser. then I improve the categorizer inside the image. > Now I have a tool to analyse the categories but no time and I did not want to break everything > but we could push some rules. > > if people would have published slices on such issues I'm quite sure that we would have integrated them, now the question > is that it takes time and we were focused on other urgent tasks. > > Stef > > > On Sat, May 20, 2017 at 12:25 AM, Torsten Bergmann <astares(a)gmx.de <mailto:astares@gmx.de>> wrote: > Hi, > > One year later we are close to a final release for Pharo 6 and either with Pharo 6 or upcoming Pharo 7 > I would really like to see some checks that ensure a quality image and tests who keep us all more > disciplined in the future. > > Because: > > 1. We should not have undocumented classes: > > (Object allSubclasses select: [:cls| cls hasComment not ]) > > but we have a lot in Pharo 6 now since we introduced new packages in this release iteration > > 2. We should not have class instance variables in uppercase but: > > (Object allSubclasses select: [:cls| cls isMeta]) select: [:cls| cls > instVarNames anySatisfy: [:n | n first isUppercase]] > > is not empty - although this was already discussed back in 2008 (!), see > http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/2008-November/00… <http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/2008-November/00…> > > 3. We should not have uncategorized methods but: > > (Object allSubclasses select: [:cls| (cls selectorsInProtocol: Protocol unclassified) notEmpty ]) > > we still have them. > > 4. I've seen methods with unused temporary variables. Dont know about unused ivars or other. > > 5. add you own here ... > > I know this is often boring to comment or categorize - but we should do our homework as we wanted to > better compared to the past. Also if the base image is not following rules how should we expect others > to provide quality packages on top of it? > > IMHO we should raise the bar. Either in Pharo 6 or in early Pharo 7. We can fix these once and for > all AND assure with unit tests that we keep the standard image on this quality level. > > Thx > T. > > > > >

May 20, 2017

Re: [Pharo-dev] [ bloc]'Pulse loop must be running in order to request a pulse'

by Stephane Ducasse

Thanks! On Sat, May 20, 2017 at 3:01 PM, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > https://github.com/pharo-graphics/Bloc/issues/20 > > Cheers, > Alex > > On 20 May 2017 at 14:58, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > >> Hi Stef, >> >> Yes, sometimes that might happen. >> However, there is silver bullet: >> >> BlUniverse reset >> >> Cheers, >> Alex >> >> On May 20, 2017 2:09 PM, "Stephane Ducasse" <stepharo.self(a)gmail.com> >> wrote: >> >> I wanted to work on the bloc booklet and >> when I reopen my image I get >> >> 'Pulse loop must be running in order to request a pulse' >> >> >> >

May 20, 2017

Re: [Pharo-dev] [ bloc]'Pulse loop must be running in order to request a pulse'

by Aliaksei Syrel

https://github.com/pharo-graphics/Bloc/issues/20 Cheers, Alex On 20 May 2017 at 14:58, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > Hi Stef, > > Yes, sometimes that might happen. > However, there is silver bullet: > > BlUniverse reset > > Cheers, > Alex > > On May 20, 2017 2:09 PM, "Stephane Ducasse" <stepharo.self(a)gmail.com> > wrote: > > I wanted to work on the bloc booklet and > when I reopen my image I get > > 'Pulse loop must be running in order to request a pulse' > > >

May 20, 2017

Re: [Pharo-dev] [ bloc]'Pulse loop must be running in order to request a pulse'

by Aliaksei Syrel

Hi Stef, Yes, sometimes that might happen. However, there is silver bullet: BlUniverse reset Cheers, Alex On May 20, 2017 2:09 PM, "Stephane Ducasse" <stepharo.self(a)gmail.com> wrote: I wanted to work on the bloc booklet and when I reopen my image I get 'Pulse loop must be running in order to request a pulse'

May 20, 2017