- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Doing a pull request

by Esteban Lorenzano

Iâm sorry but I will need to intervine here :) While it may look complicated /now/, it is because we are still fixing Pharo7 to work, who has a problem right now because since is bootstrapped it does not keeps any version infoâ¦ then is complicated to calculate the diffs. But we are going to fix this. Now, this is how the process will work once released: 0. You will have to have a fork of pharo (this is like that and is âzeroâ because you doit once) 1. You will clone pharo, using iceberg. This can be achieved two ways a) by cloning if is first time. b) by adding it if you already have this clone. Most people will end using this option. 2. work on fix/change 3. commit/push to your repo 4. do a Pull Request once finished. done. As you can see, this is very easyâ¦ Pavel showed an overcomplicated process that is just a workaround until we fix the problem I mentioned :) > On 15 Jun 2017, at 15:40, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > > Thanks pavel, I'll copy paste it in the README :) I will not copy and paste all that in the README. It will not remain... cheers, Esteban > > On Thu, Jun 15, 2017 at 10:43 AM, Rajula Vineet <Vineet.Reddy(a)iiitb.org <mailto:Vineet.Reddy@iiitb.org>> wrote: > @abergel I was looking for some basic guidelines for example: creating a new > branch with the issue name, having the issue number and name while > submitting a PR. Something like this. > > @Subbu I have forked it, but I haven`t made a new branch I will do it. > Thanks for the tips. > > @Pavel Thank you very much. This is what I was looking out for. > > Rajula > > > > > > > -- > View this message in context: http://forum.world.st/Doing-a-pull-request-tp4951443p4951485.html <http://forum.world.st/Doing-a-pull-request-tp4951443p4951485.html> > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. > > > > > -- > > Guille Polito > > Research Engineer > French National Center for Scientific Research - http://www.cnrs.fr <http://www.cnrs.fr/> > > > Web: http://guillep.github.io <http://guillep.github.io/> > Phone: +33 06 52 70 66 13

June 15, 2017

Re: [Pharo-dev] Doing a pull request

by Guillermo Polito

Thanks pavel, I'll copy paste it in the README :) On Thu, Jun 15, 2017 at 10:43 AM, Rajula Vineet <Vineet.Reddy(a)iiitb.org> wrote: > @abergel I was looking for some basic guidelines for example: creating a > new > branch with the issue name, having the issue number and name while > submitting a PR. Something like this. > > @Subbu I have forked it, but I haven`t made a new branch I will do it. > Thanks for the tips. > > @Pavel Thank you very much. This is what I was looking out for. > > Rajula > > > > > > > -- > View this message in context: http://forum.world.st/Doing-a-pull-request- > tp4951443p4951485.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > > -- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

June 15, 2017

Re: [Pharo-dev] Pharo in a read-only environment survey

by Guillermo Polito

:) On Thu, Jun 15, 2017 at 3:32 PM, JÃ©rÃ©mie Regnault < jeremie.regnault(a)outlook.com> wrote: > Hi, I'm working on Pharo deployment in a read-only environment, and I > want to know what behavior you want Pharo to adopt. If you could take > 5-10 minutes to fill my survey, it would be nice : > https://goo.gl/forms/8S7w4079NDfBrsVu1 > > Thank you, > > -- > JÃ©rÃ©mie Regnault > > -- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

June 15, 2017

Pharo in a read-only environment survey

by JÃ©rÃ©mie Regnault

Hi, I'm working on Pharo deployment in a read-only environment, and I want to know what behavior you want Pharo to adopt. If you could take 5-10 minutes to fill my survey, it would be nice : https://goo.gl/forms/8S7w4079NDfBrsVu1 Thank you, -- JÃ©rÃ©mie Regnault

June 15, 2017

Re: [Pharo-dev] Doing a pull request

by Rajula Vineet

@abergel I was looking for some basic guidelines for example: creating a new branch with the issue name, having the issue number and name while submitting a PR. Something like this. @Subbu I have forked it, but I haven`t made a new branch I will do it. Thanks for the tips. @Pavel Thank you very much. This is what I was looking out for. Rajula -- View this message in context: http://forum.world.st/Doing-a-pull-request-tp4951443p4951485.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

June 15, 2017

Re: [Pharo-dev] Doing a pull request

by Pavel Krivanek

Hi, we still do not have official guidelines but this should help you: 1) you need own fork of pharo-project/pharo repository 2) clone pharo-project/pharo into directory named "pharo-core" in your working directory. You can do it from Iceberg (Clone repository) or by this script: Iceberg enableMetacelloIntegration: true. target := 'pharo-core' asFileReference ensureCreateDirectory. repository := IceRepositoryCreator new remote: (IceRemote url: 'git@github.com:pharo-project/pharo.git'); location: target; subdirectory:'src'; createRepository. repository backend checkoutBranch: 'master'. repository addRemote: (IceRemote name: 'myFork' url: 'git(a)github.com: yourGitHubAccount/pharo.git'). repository register. Do not forget to change your fork URL. If you will do it from Iceberg, you need to add remote manually. 3) set your fork remote as default push remote 4) create issue on FogBugz. You will obtain issue number e.g. 12345 5) in repository context menu in Iceberg and do Pharo-Create new branch from FogBugz issue, you will enter the issue number and the dialog wil fill the full branch name 6) do you changes and commit (and push) them to your fork repository 7) in repository context menu in Iceberg do: Pharo-Create pull request. Login, by default the title will be set to the branch name, let it be, comment is not needed. "From" will be your fork and your issue branch. "To" will be pharo-project/pharo and "development" branch 8) as soon as you create the pull request, add URL to this pull request to the FogBugz issue and mark it as resolved (fix review needed). You need not to do it exactly this way, e.g. you can create the pull request from Github web interface, but the pull request name must contain the the issue number. And your issue must contain link to the pull request. Cheers, -- Pavel 2017-06-14 16:55 GMT+02:00 Rajula Vineet <Vineet.Reddy(a)iiitb.org>: > Hi, > > I am a GSoC student working on enhancing pharo command line interface. I > was > wondering if there is a procedure to make a pull request to the Github > repo. > It would be really helpful if someone can explain the right way of doing a > Pull Request. Thanks in advance. > > Rajula > > > > -- > View this message in context: http://forum.world.st/Doing-a- > pull-request-tp4951443.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

June 15, 2017

Re: [Pharo-dev] Doing a pull request

by K K Subbu

On Wednesday 14 June 2017 08:25 PM, Rajula Vineet wrote: > Hi, > > I am a GSoC student working on enhancing pharo command line interface. I was > wondering if there is a procedure to make a pull request to the Github repo. > It would be really helpful if someone can explain the right way of doing a > Pull Request. Thanks in advance. Have you already forked the upstream project in github (aka base) and created a topic branch in your fork (aka head) to hold your changes? Please post them here or in Discord chat if you need detailed help. Follow the steps in : https://help.github.com/articles/creating-a-pull-request-from-a-fork/ Git jargon may be quite intimidating ;-) for first timers, but the procedure is really simple. Just remember to start with the "Pull Request" on the *base branch* and not your fork. Regards .. Subbu

June 15, 2017

Re: [Pharo-dev] Doing a pull request

by Alexandre Bergel

Hi Rajula, What do you mean? A pull-request is typically done via the GitHub interface. What do you need exactly? Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > On Jun 14, 2017, at 10:55 AM, Rajula Vineet <Vineet.Reddy(a)iiitb.org> wrote: > > Hi, > > I am a GSoC student working on enhancing pharo command line interface. I was > wondering if there is a procedure to make a pull request to the Github repo. > It would be really helpful if someone can explain the right way of doing a > Pull Request. Thanks in advance. > > Rajula > > > > -- > View this message in context: http://forum.world.st/Doing-a-pull-request-tp4951443.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

June 14, 2017

Re: [Pharo-dev] Extra shortcut modifier opposite to #meta

by Guillermo Polito

But meta does also present problems in linux, doesn't it? I mean, meta in linux and windows means Ctrl. That means that overriding meta+arrows will break the Ctrl+arrows text navigation. What am I missing? I don't think that alternativeMeta means something useful. And I believe in this topic that there are no magic solutions. Spotter should define for each platform shortcuts that do not override text navigation, or, as in other applications, text navigation should have precedence over spotter actions. For example, moving tabs in Chrome is - Mac: Ctrl+tab or Command+alt+arrows. - Windows and linux: Ctrl+tab or Ctrl+pagedown Guille On Wed, Jun 14, 2017 at 4:50 PM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > 2017-06-14 16:34 GMT+02:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > >> >> I not found anything implemented. Let's do it in Pharo 7. >> > > But maybe I not found other solution in thread. In Calypso I will use > left/right+alt shortcut for navigation. What other applications use for > this purpose? > -- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

June 14, 2017

Doing a pull request

by Rajula Vineet

Hi, I am a GSoC student working on enhancing pharo command line interface. I was wondering if there is a procedure to make a pull request to the Github repo. It would be really helpful if someone can explain the right way of doing a Pull Request. Thanks in advance. Rajula -- View this message in context: http://forum.world.st/Doing-a-pull-request-tp4951443.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

June 14, 2017