- Pharo-dev - lists.pharo.org

[Pharo-project] why removing testhex?

by StÃ©phane Ducasse

Hi serge why did you remove testHex? BTW I did not receive your nice license agreement

June 3, 2008

Re: {Spam?} [Pharo-project] Some questions on how to help

by StÃ©phane Ducasse

On Jun 2, 2008, at 11:06 PM, Bill Schwab wrote: > Norbert, > > I have also noted the "return nil on error" in parsers, and (my > current > mission) streams. IMHO, these decisions were questionable before > structured exception handling, and are all the more unfortunate > now. My > preference would be to create something like #readFrom:onError: and > then > re-write #readFrom: in terms of it, raising an error inside the block. > Failing to do that risks intermittent downstream failures due to > "unexpected" garbage values. I like my bad news early, and in > context. Yes this is true that we should get rid of code that predate exception such as default block returning values > Skipping to the end of your message, I am hopeful that Pharo will not > suffer from Squeak's barriers to adoption of good code, but I cannot > promise same. It is probably best to start small and ask up-front > whether people want what you propose. I suspect you will find that > good > work will be included in Pharo. Yes and again writing tests and running them.... :) > > > Bill > > > > > Wilhelm K. Schwab, Ph.D. > University of Florida > Department of Anesthesiology > PO Box 100254 > Gainesville, FL 32610-0254 > > Email: bschwab(a)anest.ufl.edu > Tel: (352) 846-1285 > FAX: (352) 392-7029 > > >>>> norbert(a)hartl.name 6/2/2008 2:28:15 PM >>> > Hi, > > I really appreciate the existence of the pharo project. For > me I declared it as a good starting point for me to dive > into the deeper waters of squeak/pharo. My biggest problem > is that I do not know how exactly things have to be done. > I don't want to just submit changes without to know if the > worth it. > > A little story. I started last week to toy around with the > newest pharo release. On the web site I read that all tests > green is a primary goal. So I started to let the test runner > run all tests. After having some trouble I found a failing > test in NumberParsingTest. The test is failing because the > test case expects Number>>readFrom: to throw an error if a > number couldn't be parsed. Searchig the ST80 book I found > nothing about Number>>readFrom:. Searching the web I found > a thread on squeak-dev from january where the outcome was: > > - readFrom: returns 0 on unsuccesful read attempt to satisfy > the parser (sounds like some history thing) > - readExactlyFrom: does throw an error an unsuccesful read > attempt. And it utilizes sqNumberParser > > So what to do? I tried to be least aggressive and fixed the > test case to use readExactlyFrom: (and then splitting the > test case into two because the test does different things). > Not thinking first I would have asked a lot of questions on > this list: > > - Do we want to preserve the current readFrom: ? > - Should we integrate sqNumberParser completely avoiding > mulitple implementations? > - Is it only me having slightly problems having a class > Number which uses a class SqNumberParser instead of > integrating the code into the Number hierarchy? > > Is there a way to get this questions answered without generating > a lot of noise on the list? > > Other questions: > > - I scanned the image for obsolete references and found some. I > don't know how to deal with it in an update. Using > > ServerDirectory resetServers. > FileServices removeObsolete. > PackageOrganizer default unregisterPackageNamed: > 'FlexibleVocabularies' > > I have removed all obsolete references but one. How is this > integrated into the upstream? > > - Trying to solve the last obsolete references I found an obsolete > class referenced in PasteUpMorph. The method which referenced it > is PasteUpMorph>>isSafeToServe. The method is in category > Nebraska. I thought Nebraska has been removed from the system. > Thinking that I would have removed all methods of this category > but one because they have no senders. > One method transferRemoteServerFrom: is referenced from > Project>>enter: returningFlag revert: revertFlag saveForRevert: > saveForRevert > Is it ok to rip this call out (by trying to understand what it > does in class Project ;) ) > > > Some words of advice would be helpful to get a feeling about those > things. I don't have a problem preparing some stuff and put it into > the Inbox. A problem would be to have a patch rejected without > explanation :) > > Norbert > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 2, 2008

Re: [Pharo-project] Lots of modifications waiting in PharoInbox

by StÃ©phane Ducasse

lukas helped but indeed may be when marcus is back from PhD last effort. I will try to take some times with alex to show him before the end of the week. Now what would help is that some people have a look at the changes proposed. Stef On Jun 2, 2008, at 11:01 PM, Serge Stinckwich wrote: > There is now a lots of package modifications waiting in the inbox. > Is Stef the only one to integrate the changes inside Pharo ? > > -- > Serge Stinckwich > http://blog.doesnotunderstand.org/ > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 2, 2008

[Pharo-project] Fwd: New update

by StÃ©phane Ducasse

> > > > 0006834: Delay class>>timeoutSemaphore:afterMSecs: doesn't. > Description The implementation for Delay > class>>timeoutSemaphore:afterMSecs: doesn't even use its first > parameter, so it can't do what it says it does. > > This method should be deprecated or removed entirely. > Additional Information + tests > > + obsolete references identified by norbert > > Stef > > >

June 2, 2008

Re: {Spam?} [Pharo-project] Some questions on how to help

by Bill Schwab

Norbert, I have also noted the "return nil on error" in parsers, and (my current mission) streams. IMHO, these decisions were questionable before structured exception handling, and are all the more unfortunate now. My preference would be to create something like #readFrom:onError: and then re-write #readFrom: in terms of it, raising an error inside the block. Failing to do that risks intermittent downstream failures due to "unexpected" garbage values. I like my bad news early, and in context. Skipping to the end of your message, I am hopeful that Pharo will not suffer from Squeak's barriers to adoption of good code, but I cannot promise same. It is probably best to start small and ask up-front whether people want what you propose. I suspect you will find that good work will be included in Pharo. Bill Wilhelm K. Schwab, Ph.D. University of Florida Department of Anesthesiology PO Box 100254 Gainesville, FL 32610-0254 Email: bschwab(a)anest.ufl.edu Tel: (352) 846-1285 FAX: (352) 392-7029 >>> norbert(a)hartl.name 6/2/2008 2:28:15 PM >>> Hi, I really appreciate the existence of the pharo project. For me I declared it as a good starting point for me to dive into the deeper waters of squeak/pharo. My biggest problem is that I do not know how exactly things have to be done. I don't want to just submit changes without to know if the worth it. A little story. I started last week to toy around with the newest pharo release. On the web site I read that all tests green is a primary goal. So I started to let the test runner run all tests. After having some trouble I found a failing test in NumberParsingTest. The test is failing because the test case expects Number>>readFrom: to throw an error if a number couldn't be parsed. Searchig the ST80 book I found nothing about Number>>readFrom:. Searching the web I found a thread on squeak-dev from january where the outcome was: - readFrom: returns 0 on unsuccesful read attempt to satisfy the parser (sounds like some history thing) - readExactlyFrom: does throw an error an unsuccesful read attempt. And it utilizes sqNumberParser So what to do? I tried to be least aggressive and fixed the test case to use readExactlyFrom: (and then splitting the test case into two because the test does different things). Not thinking first I would have asked a lot of questions on this list: - Do we want to preserve the current readFrom: ? - Should we integrate sqNumberParser completely avoiding mulitple implementations? - Is it only me having slightly problems having a class Number which uses a class SqNumberParser instead of integrating the code into the Number hierarchy? Is there a way to get this questions answered without generating a lot of noise on the list? Other questions: - I scanned the image for obsolete references and found some. I don't know how to deal with it in an update. Using ServerDirectory resetServers. FileServices removeObsolete. PackageOrganizer default unregisterPackageNamed: 'FlexibleVocabularies' I have removed all obsolete references but one. How is this integrated into the upstream? - Trying to solve the last obsolete references I found an obsolete class referenced in PasteUpMorph. The method which referenced it is PasteUpMorph>>isSafeToServe. The method is in category Nebraska. I thought Nebraska has been removed from the system. Thinking that I would have removed all methods of this category but one because they have no senders. One method transferRemoteServerFrom: is referenced from Project>>enter: returningFlag revert: revertFlag saveForRevert: saveForRevert Is it ok to rip this call out (by trying to understand what it does in class Project ;) ) Some words of advice would be helpful to get a feeling about those things. I don't have a problem preparing some stuff and put it into the Inbox. A problem would be to have a patch rejected without explanation :) Norbert _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 2, 2008

[Pharo-project] Lots of modifications waiting in PharoInbox

by Serge Stinckwich

There is now a lots of package modifications waiting in the inbox. Is Stef the only one to integrate the changes inside Pharo ? -- Serge Stinckwich http://blog.doesnotunderstand.org/

June 2, 2008

[Pharo-project] Merging 6834

by StÃ©phane Ducasse

I'm merging 0006834: Delay class>>timeoutSemaphore:afterMSecs: doesn't. Description The implementation for Delay class>>timeoutSemaphore:afterMSecs: doesn't even use its first parameter, so it can't do what it says it does. This method should be deprecated or removed entirely. Additional Information + tests

June 2, 2008

Re: [Pharo-project] Some questions on how to help

by StÃ©phane Ducasse

BTW sign the license agreement! This is on this ugly wiki :) Stef On Jun 2, 2008, at 9:28 PM, Norbert Hartl wrote: > Hi, > > I really appreciate the existence of the pharo project. For > me I declared it as a good starting point for me to dive > into the deeper waters of squeak/pharo. My biggest problem > is that I do not know how exactly things have to be done. > I don't want to just submit changes without to know if the > worth it. > > A little story. I started last week to toy around with the > newest pharo release. On the web site I read that all tests > green is a primary goal. So I started to let the test runner > run all tests. After having some trouble I found a failing > test in NumberParsingTest. The test is failing because the > test case expects Number>>readFrom: to throw an error if a > number couldn't be parsed. Searchig the ST80 book I found > nothing about Number>>readFrom:. Searching the web I found > a thread on squeak-dev from january where the outcome was: > > - readFrom: returns 0 on unsuccesful read attempt to satisfy > the parser (sounds like some history thing) > - readExactlyFrom: does throw an error an unsuccesful read > attempt. And it utilizes sqNumberParser > > So what to do? I tried to be least aggressive and fixed the > test case to use readExactlyFrom: (and then splitting the > test case into two because the test does different things). > Not thinking first I would have asked a lot of questions on > this list: > > - Do we want to preserve the current readFrom: ? > - Should we integrate sqNumberParser completely avoiding > mulitple implementations? > - Is it only me having slightly problems having a class > Number which uses a class SqNumberParser instead of > integrating the code into the Number hierarchy? > > Is there a way to get this questions answered without generating > a lot of noise on the list? > > Other questions: > > - I scanned the image for obsolete references and found some. I > don't know how to deal with it in an update. Using > > ServerDirectory resetServers. > FileServices removeObsolete. > PackageOrganizer default unregisterPackageNamed: > 'FlexibleVocabularies' > > I have removed all obsolete references but one. How is this > integrated into the upstream? > > - Trying to solve the last obsolete references I found an obsolete > class referenced in PasteUpMorph. The method which referenced it > is PasteUpMorph>>isSafeToServe. The method is in category > Nebraska. I thought Nebraska has been removed from the system. > Thinking that I would have removed all methods of this category > but one because they have no senders. > One method transferRemoteServerFrom: is referenced from > Project>>enter: returningFlag revert: revertFlag saveForRevert: > saveForRevert > Is it ok to rip this call out (by trying to understand what it > does in class Project ;) ) > > > Some words of advice would be helpful to get a feeling about those > things. I don't have a problem preparing some stuff and put it into > the Inbox. A problem would be to have a patch rejected without > explanation :) > > Norbert > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 2, 2008

Re: [Pharo-project] Some questions on how to help

by StÃ©phane Ducasse

Hi norbert > Hi, > > I really appreciate the existence of the pharo project. For > me I declared it as a good starting point for me to dive > into the deeper waters of squeak/pharo. My biggest problem > is that I do not know how exactly things have to be done. > I don't want to just submit changes without to know if the > worth it. I imagine. I wanted to clean the inbox but I had to break some walls in my house this week-end. > A little story. I started last week to toy around with the > newest pharo release. On the web site I read that all tests > green is a primary goal. Yes we want that > So I started to let the test runner > run all tests. After having some trouble I found a failing > test in NumberParsingTest. The test is failing because the > test case expects Number>>readFrom: to throw an error if a > number couldn't be parsed. Searchig the ST80 book I found > nothing about Number>>readFrom:. Searching the web I found > a thread on squeak-dev from january where the outcome was: > > - readFrom: returns 0 on unsuccesful read attempt to satisfy > the parser (sounds like some history thing) > - readExactlyFrom: does throw an error an unsuccesful read > attempt. And it utilizes sqNumberParser > > So what to do? I tried to be least aggressive and fixed the > test case to use readExactlyFrom: (and then splitting the > test case into two because the test does different things). > Not thinking first I would have asked a lot of questions on > this list: > > - Do we want to preserve the current readFrom: ? > - Should we integrate sqNumberParser completely avoiding > mulitple implementations? > - Is it only me having slightly problems having a class > Number which uses a class SqNumberParser instead of > integrating the code into the Number hierarchy? > > Is there a way to get this questions answered without generating > a lot of noise on the list? I do not know. :) Now for Number related issues I would - have a look at the fix nicolas produced - ask him - discuss that on this mailing-list and also on the squeak-dev mailing-lis > Other questions: > > - I scanned the image for obsolete references and found some. I > don't know how to deal with it in an update. Using > > ServerDirectory resetServers. > FileServices removeObsolete. > PackageOrganizer default unregisterPackageNamed: > 'FlexibleVocabularies' > > I have removed all obsolete references but one. How is this > integrated into the upstream? Excellent. For this you can send a cs or simply state it to the mailing-list I will include the expressions in the next release scripts. > - Trying to solve the last obsolete references I found an obsolete > class referenced in PasteUpMorph. The method which referenced it > is PasteUpMorph>>isSafeToServe. The method is in category > Nebraska. I thought Nebraska has been removed from the system. Yes but apparently this method was not well-categorized. > Thinking that I would have removed all methods of this category > but one because they have no senders. > One method transferRemoteServerFrom: is referenced from > Project>>enter: returningFlag revert: revertFlag saveForRevert: > saveForRevert > Is it ok to rip this call out (by trying to understand what it > does in class Project ;) ) I have the impression :) > Some words of advice would be helpful to get a feeling about those > things. I don't have a problem preparing some stuff and put it into > the Inbox. A problem would be to have a patch rejected without > explanation :) Sure. My advice is - tests if it make sense - stepwise - careful - discussion on the mailing-list so that other people can have a look and comment. I think that the communication is really key. So reviewing other fixes can really help everybody. So if you go and check the changes in the inbox and comment on them, we will all gain from that. Last time marcus fixes some refs I let. But at the end been two times 2 eyes fixed the problems and we made progress. > > > Norbert > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 2, 2008

[Pharo-project] Some questions on how to help

by Norbert Hartl

Hi, I really appreciate the existence of the pharo project. For me I declared it as a good starting point for me to dive into the deeper waters of squeak/pharo. My biggest problem is that I do not know how exactly things have to be done. I don't want to just submit changes without to know if the worth it. A little story. I started last week to toy around with the newest pharo release. On the web site I read that all tests green is a primary goal. So I started to let the test runner run all tests. After having some trouble I found a failing test in NumberParsingTest. The test is failing because the test case expects Number>>readFrom: to throw an error if a number couldn't be parsed. Searchig the ST80 book I found nothing about Number>>readFrom:. Searching the web I found a thread on squeak-dev from january where the outcome was: - readFrom: returns 0 on unsuccesful read attempt to satisfy the parser (sounds like some history thing) - readExactlyFrom: does throw an error an unsuccesful read attempt. And it utilizes sqNumberParser So what to do? I tried to be least aggressive and fixed the test case to use readExactlyFrom: (and then splitting the test case into two because the test does different things). Not thinking first I would have asked a lot of questions on this list: - Do we want to preserve the current readFrom: ? - Should we integrate sqNumberParser completely avoiding mulitple implementations? - Is it only me having slightly problems having a class Number which uses a class SqNumberParser instead of integrating the code into the Number hierarchy? Is there a way to get this questions answered without generating a lot of noise on the list? Other questions: - I scanned the image for obsolete references and found some. I don't know how to deal with it in an update. Using ServerDirectory resetServers. FileServices removeObsolete. PackageOrganizer default unregisterPackageNamed: 'FlexibleVocabularies' I have removed all obsolete references but one. How is this integrated into the upstream? - Trying to solve the last obsolete references I found an obsolete class referenced in PasteUpMorph. The method which referenced it is PasteUpMorph>>isSafeToServe. The method is in category Nebraska. I thought Nebraska has been removed from the system. Thinking that I would have removed all methods of this category but one because they have no senders. One method transferRemoteServerFrom: is referenced from Project>>enter: returningFlag revert: revertFlag saveForRevert: saveForRevert Is it ok to rip this call out (by trying to understand what it does in class Project ;) ) Some words of advice would be helpful to get a feeling about those things. I don't have a problem preparing some stuff and put it into the Inbox. A problem would be to have a patch rejected without explanation :) Norbert

June 2, 2008