- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Behaviour>>hash is missing!

by Oscar Nierstrasz

What was his fix? How can I tell what was changed? Is Behaviour>>hash missing in your image too? I don't trust anything anymore. - on On Jun 10, 2008, at 10:13 PM, StÃ©phane Ducasse wrote: > Marcus should have a look since this is fix he reverted. > > Stef > > On Jun 10, 2008, at 10:04 PM, Oscar Nierstrasz wrote: > >> >> These tests are fine in Squeak 3.9 too. >> >> Further investigation reveals that Behaviour>>hash is missing in >> Pharo! >> >> So hash reverts to Object>>hash, which sends Object>>identityHash. >> >> In Pharo: >> >> Array hash --> 2455 >> Object identityHash --> 2274 >> >> In Squeak: >> >> Array hash --> 259007228 >> Object identityHash --> 2274 >> >> Looks like someone removed >> >> Behaviour>>hash >> ^ self name hash >> >> - on >> >> On Jun 10, 2008, at 9:43 PM, StÃ©phane Ducasse wrote: >> >>> Excellent! >>> may be this is the hash of class that changed. Marcus retrochanged >>> the hash behavior that we harvested in 3.9. >>> And may be in 3.10 they changed class hash too. >>> >>> Now I do not know if in 3.9 these tests were broken. >>> >>> Stef >>> >>> On Jun 10, 2008, at 9:32 PM, Oscar Nierstrasz wrote: >>> >>>> >>>> OK, I investigated more deeply. >>>> >>>> It appears that SequenceableCollection>>hash behaves differently >>>> in Pharo and Squeak 3.10. >>>> >>>> Squeak: >>>> >>>> #(1) hash --> 22516953 >>>> >>>> Pharo: >>>> >>>> #(1) hash --> 61541560 >>>> >>>> Since DateAndTime>>hash is ultimately implemented in terms of >>>> Array>>hash (inherited from SequenceableCollection), this test >>>> fails. >>>> >>>> Not yet sure why these two behave differently ... >>>> >>>> Already the first line (self species hash) is different: >>>> >>>> Squeak: >>>> >>>> Array hash --> 259007228 >>>> >>>> Pharo: >>>> >>>> Array hash --> 2455 >>>> >>>> - on >>>> >>>> On Jun 10, 2008, at 6:34 PM, StÃ©phane Ducasse wrote: >>>> >>>>> We checked with lukas what is strange is that the same tests are >>>>> green in 3.10. >>>>> >>>>> Stef >>>>> >>>>> On Jun 10, 2008, at 3:48 PM, Oscar Nierstrasz wrote: >>>>> >>>>>> >>>>>> I have posted some patches to the inbox to make the Kernel >>>>>> Number tests run, and in the Issues page I propose to delete a >>>>>> bunch of nonsensical testHash tests. With these changes the >>>>>> Kernel tests should all be green. >>>>>> >>>>>> - on >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] Behaviour>>hash is missing!

by StÃ©phane Ducasse

Marcus should have a look since this is fix he reverted. Stef On Jun 10, 2008, at 10:04 PM, Oscar Nierstrasz wrote: > > These tests are fine in Squeak 3.9 too. > > Further investigation reveals that Behaviour>>hash is missing in > Pharo! > > So hash reverts to Object>>hash, which sends Object>>identityHash. > > In Pharo: > > Array hash --> 2455 > Object identityHash --> 2274 > > In Squeak: > > Array hash --> 259007228 > Object identityHash --> 2274 > > Looks like someone removed > > Behaviour>>hash > ^ self name hash > > - on > > On Jun 10, 2008, at 9:43 PM, StÃ©phane Ducasse wrote: > >> Excellent! >> may be this is the hash of class that changed. Marcus retrochanged >> the hash behavior that we harvested in 3.9. >> And may be in 3.10 they changed class hash too. >> >> Now I do not know if in 3.9 these tests were broken. >> >> Stef >> >> On Jun 10, 2008, at 9:32 PM, Oscar Nierstrasz wrote: >> >>> >>> OK, I investigated more deeply. >>> >>> It appears that SequenceableCollection>>hash behaves differently >>> in Pharo and Squeak 3.10. >>> >>> Squeak: >>> >>> #(1) hash --> 22516953 >>> >>> Pharo: >>> >>> #(1) hash --> 61541560 >>> >>> Since DateAndTime>>hash is ultimately implemented in terms of >>> Array>>hash (inherited from SequenceableCollection), this test >>> fails. >>> >>> Not yet sure why these two behave differently ... >>> >>> Already the first line (self species hash) is different: >>> >>> Squeak: >>> >>> Array hash --> 259007228 >>> >>> Pharo: >>> >>> Array hash --> 2455 >>> >>> - on >>> >>> On Jun 10, 2008, at 6:34 PM, StÃ©phane Ducasse wrote: >>> >>>> We checked with lukas what is strange is that the same tests are >>>> green in 3.10. >>>> >>>> Stef >>>> >>>> On Jun 10, 2008, at 3:48 PM, Oscar Nierstrasz wrote: >>>> >>>>> >>>>> I have posted some patches to the inbox to make the Kernel >>>>> Number tests run, and in the Issues page I propose to delete a >>>>> bunch of nonsensical testHash tests. With these changes the >>>>> Kernel tests should all be green. >>>>> >>>>> - on >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] Behaviour>>hash is missing!

by Oscar Nierstrasz

These tests are fine in Squeak 3.9 too. Further investigation reveals that Behaviour>>hash is missing in Pharo! So hash reverts to Object>>hash, which sends Object>>identityHash. In Pharo: Array hash --> 2455 Object identityHash --> 2274 In Squeak: Array hash --> 259007228 Object identityHash --> 2274 Looks like someone removed Behaviour>>hash ^ self name hash - on On Jun 10, 2008, at 9:43 PM, StÃ©phane Ducasse wrote: > Excellent! > may be this is the hash of class that changed. Marcus retrochanged > the hash behavior that we harvested in 3.9. > And may be in 3.10 they changed class hash too. > > Now I do not know if in 3.9 these tests were broken. > > Stef > > On Jun 10, 2008, at 9:32 PM, Oscar Nierstrasz wrote: > >> >> OK, I investigated more deeply. >> >> It appears that SequenceableCollection>>hash behaves differently in >> Pharo and Squeak 3.10. >> >> Squeak: >> >> #(1) hash --> 22516953 >> >> Pharo: >> >> #(1) hash --> 61541560 >> >> Since DateAndTime>>hash is ultimately implemented in terms of >> Array>>hash (inherited from SequenceableCollection), this test fails. >> >> Not yet sure why these two behave differently ... >> >> Already the first line (self species hash) is different: >> >> Squeak: >> >> Array hash --> 259007228 >> >> Pharo: >> >> Array hash --> 2455 >> >> - on >> >> On Jun 10, 2008, at 6:34 PM, StÃ©phane Ducasse wrote: >> >>> We checked with lukas what is strange is that the same tests are >>> green in 3.10. >>> >>> Stef >>> >>> On Jun 10, 2008, at 3:48 PM, Oscar Nierstrasz wrote: >>> >>>> >>>> I have posted some patches to the inbox to make the Kernel Number >>>> tests run, and in the Issues page I propose to delete a bunch of >>>> nonsensical testHash tests. With these changes the Kernel tests >>>> should all be green. >>>> >>>> - on >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] Who is working on which tests? Why are there new, broken tests?

by StÃ©phane Ducasse

No problem. Stef On Jun 10, 2008, at 9:51 PM, Oscar Nierstrasz wrote: > > Very strange. > > I updated earlier today and did not get Integer>>hex. Now it is > there. > > Of course your implementation is better since it reuses existing > functionality. > > Gremlins are definitely at work here ;-) > > Sorry for the confusion, though I really do not understand why my > image stayed out of sync and now it is ok. > > - on > > On Jun 10, 2008, at 9:35 PM, Oscar Nierstrasz wrote: > >> >> Wow. >> >> I took pharo0.1-10032-7075dev08.06.1 and updated it. There is no >> Integer>>hex there. >> >> Damien, can you help? It looks like the pharo-dev image is somehow >> out of sync. >> >> I will try both again now. >> >> - on >> >> On Jun 10, 2008, at 9:21 PM, StÃ©phane Ducasse wrote: >> >>> Hi oscar >>> >>> I took the pharo image Pharo0.1-10028-2008-05-24 available on the >>> pharo web site >>> and did an update. >>> >>> and there is >>> Integer>>hex >>> ^ self printStringBase: 16 >>> >>> I checked the version and it is from 25 of may >>> >>> Stef >>> >>>> >>>> Hi Stef, >>>> >>>> I loaded a fresh pharo-dev image and updated everything. Then >>>> the testHex tests failed, so I fixed them. >>>> >>>> Can you please tell me which implementors of hex you find in your >>>> image? >>>> >>>> I only find Character>>hex and Float>>hex. I had to implement >>>> Integer>>hex myself. >>>> >>>> - on >>>> >>>> On Jun 10, 2008, at 6:38 PM, StÃ©phane Ducasse wrote: >>>> >>>>> testHex >>>>> self assert: $a hex '61' = '61'. >>>>> self assert: Character space hex = '20' >>>>> >>>>> is green on my image >>>>> >>>>> as well as this one >>>>> >>>>> testHex >>>>> self assert: 0 hex = '0'. >>>>> self assert: 12 hex = 'C'. >>>>> self assert: 1234 hex = '4D2'. >>>>> >>>>> They are red in yours? >>>>> >>>>> Stef >>>>> >>>>> >>>>> On Jun 10, 2008, at 4:00 PM, Oscar Nierstrasz wrote: >>>>> >>>>>> >>>>>> Well, I thought we would start to fix the existing broken tests >>>>>> before adding new broken tests. >>>>>> >>>>>> I would also be very happy to see some comments when someone >>>>>> adds a new broken test, so I know what the plan is. >>>>>> >>>>>> Now I added an implementation of Integer>>hex, for example, but >>>>>> I am not so sure why we need this. >>>>>> Ain't too many senders. An easier fix would have been to remove >>>>>> the broken test. >>>>>> >>>>>> Cheers, >>>>>> - on >>>>>> >>>>>> On Jun 10, 2008, at 15:53, Bill Schwab wrote: >>>>>> >>>>>>> Is your concern that the new tests are broken (which seems >>>>>>> normal to me >>>>>>> that they would start out that way), or are you objecting to >>>>>>> their being >>>>>>> included in the image? >>>>>>> >>>>>>> I can see arguments either way on the latter. If code in the >>>>>>> image is >>>>>>> wrong and a clearly correct but currently failing test >>>>>>> highlights it, >>>>>>> I'd rather be alerted to it. You are also correct that having >>>>>>> them >>>>>>> included draws attention that could easily encourage >>>>>>> duplication of >>>>>>> effort. >>>>>>> >>>>>>> Comments? >>>>>>> >>>>>>> Bill >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Wilhelm K. Schwab, Ph.D. >>>>>>> University of Florida >>>>>>> Department of Anesthesiology >>>>>>> PO Box 100254 >>>>>>> Gainesville, FL 32610-0254 >>>>>>> >>>>>>> Email: bschwab(a)anest.ufl.edu >>>>>>> Tel: (352) 846-1285 >>>>>>> FAX: (352) 392-7029 >>>>>>> >>>>>>>>>> oscar(a)iam.unibe.ch 06/10/08 8:31 AM >>> >>>>>>> >>>>>>> I looked at the wiki page >>>>>>> http://code.google.com/p/pharo/wiki/CurrentlyWorkingOn >>>>>>> but it does not say much. >>>>>>> >>>>>>> I would like to work through some tests, but I cannot find an >>>>>>> overview. >>>>>>> >>>>>>> The tests CharacterTest>>testHex and IntegerTest>>testHex are >>>>>>> broken >>>>>>> but seem to be very new. Stef, are you working on these? You >>>>>>> seem to >>>>>>> have written the tests ... >>>>>>> >>>>>>> - on >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] Who is working on which tests? Why are there new, broken tests?

by Oscar Nierstrasz

No, the pharo-dev image is ok now too. Time to go to bed. - on On Jun 10, 2008, at 9:47 PM, StÃ©phane Ducasse wrote: > aha. > may be squeakdev is based on another image or there is package that > when loading remove hex. > > Stef > > On Jun 10, 2008, at 9:35 PM, Oscar Nierstrasz wrote: > >> >> Wow. >> >> I took pharo0.1-10032-7075dev08.06.1 and updated it. There is no >> Integer>>hex there. >> >> Damien, can you help? It looks like the pharo-dev image is somehow >> out of sync. >> >> I will try both again now. >> >> - on >> >> On Jun 10, 2008, at 9:21 PM, StÃ©phane Ducasse wrote: >> >>> Hi oscar >>> >>> I took the pharo image Pharo0.1-10028-2008-05-24 available on the >>> pharo web site >>> and did an update. >>> >>> and there is >>> Integer>>hex >>> ^ self printStringBase: 16 >>> >>> I checked the version and it is from 25 of may >>> >>> Stef >>> >>>> >>>> Hi Stef, >>>> >>>> I loaded a fresh pharo-dev image and updated everything. Then >>>> the testHex tests failed, so I fixed them. >>>> >>>> Can you please tell me which implementors of hex you find in your >>>> image? >>>> >>>> I only find Character>>hex and Float>>hex. I had to implement >>>> Integer>>hex myself. >>>> >>>> - on >>>> >>>> On Jun 10, 2008, at 6:38 PM, StÃ©phane Ducasse wrote: >>>> >>>>> testHex >>>>> self assert: $a hex '61' = '61'. >>>>> self assert: Character space hex = '20' >>>>> >>>>> is green on my image >>>>> >>>>> as well as this one >>>>> >>>>> testHex >>>>> self assert: 0 hex = '0'. >>>>> self assert: 12 hex = 'C'. >>>>> self assert: 1234 hex = '4D2'. >>>>> >>>>> They are red in yours? >>>>> >>>>> Stef >>>>> >>>>> >>>>> On Jun 10, 2008, at 4:00 PM, Oscar Nierstrasz wrote: >>>>> >>>>>> >>>>>> Well, I thought we would start to fix the existing broken tests >>>>>> before adding new broken tests. >>>>>> >>>>>> I would also be very happy to see some comments when someone >>>>>> adds a new broken test, so I know what the plan is. >>>>>> >>>>>> Now I added an implementation of Integer>>hex, for example, but >>>>>> I am not so sure why we need this. >>>>>> Ain't too many senders. An easier fix would have been to remove >>>>>> the broken test. >>>>>> >>>>>> Cheers, >>>>>> - on >>>>>> >>>>>> On Jun 10, 2008, at 15:53, Bill Schwab wrote: >>>>>> >>>>>>> Is your concern that the new tests are broken (which seems >>>>>>> normal to me >>>>>>> that they would start out that way), or are you objecting to >>>>>>> their being >>>>>>> included in the image? >>>>>>> >>>>>>> I can see arguments either way on the latter. If code in the >>>>>>> image is >>>>>>> wrong and a clearly correct but currently failing test >>>>>>> highlights it, >>>>>>> I'd rather be alerted to it. You are also correct that having >>>>>>> them >>>>>>> included draws attention that could easily encourage >>>>>>> duplication of >>>>>>> effort. >>>>>>> >>>>>>> Comments? >>>>>>> >>>>>>> Bill >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Wilhelm K. Schwab, Ph.D. >>>>>>> University of Florida >>>>>>> Department of Anesthesiology >>>>>>> PO Box 100254 >>>>>>> Gainesville, FL 32610-0254 >>>>>>> >>>>>>> Email: bschwab(a)anest.ufl.edu >>>>>>> Tel: (352) 846-1285 >>>>>>> FAX: (352) 392-7029 >>>>>>> >>>>>>>>>> oscar(a)iam.unibe.ch 06/10/08 8:31 AM >>> >>>>>>> >>>>>>> I looked at the wiki page >>>>>>> http://code.google.com/p/pharo/wiki/CurrentlyWorkingOn >>>>>>> but it does not say much. >>>>>>> >>>>>>> I would like to work through some tests, but I cannot find an >>>>>>> overview. >>>>>>> >>>>>>> The tests CharacterTest>>testHex and IntegerTest>>testHex are >>>>>>> broken >>>>>>> but seem to be very new. Stef, are you working on these? You >>>>>>> seem to >>>>>>> have written the tests ... >>>>>>> >>>>>>> - on >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] Who is working on which tests? Why are there new, broken tests?

by Oscar Nierstrasz

Very strange. I updated earlier today and did not get Integer>>hex. Now it is there. Of course your implementation is better since it reuses existing functionality. Gremlins are definitely at work here ;-) Sorry for the confusion, though I really do not understand why my image stayed out of sync and now it is ok. - on On Jun 10, 2008, at 9:35 PM, Oscar Nierstrasz wrote: > > Wow. > > I took pharo0.1-10032-7075dev08.06.1 and updated it. There is no > Integer>>hex there. > > Damien, can you help? It looks like the pharo-dev image is somehow > out of sync. > > I will try both again now. > > - on > > On Jun 10, 2008, at 9:21 PM, StÃ©phane Ducasse wrote: > >> Hi oscar >> >> I took the pharo image Pharo0.1-10028-2008-05-24 available on the >> pharo web site >> and did an update. >> >> and there is >> Integer>>hex >> ^ self printStringBase: 16 >> >> I checked the version and it is from 25 of may >> >> Stef >> >>> >>> Hi Stef, >>> >>> I loaded a fresh pharo-dev image and updated everything. Then the >>> testHex tests failed, so I fixed them. >>> >>> Can you please tell me which implementors of hex you find in your >>> image? >>> >>> I only find Character>>hex and Float>>hex. I had to implement >>> Integer>>hex myself. >>> >>> - on >>> >>> On Jun 10, 2008, at 6:38 PM, StÃ©phane Ducasse wrote: >>> >>>> testHex >>>> self assert: $a hex '61' = '61'. >>>> self assert: Character space hex = '20' >>>> >>>> is green on my image >>>> >>>> as well as this one >>>> >>>> testHex >>>> self assert: 0 hex = '0'. >>>> self assert: 12 hex = 'C'. >>>> self assert: 1234 hex = '4D2'. >>>> >>>> They are red in yours? >>>> >>>> Stef >>>> >>>> >>>> On Jun 10, 2008, at 4:00 PM, Oscar Nierstrasz wrote: >>>> >>>>> >>>>> Well, I thought we would start to fix the existing broken tests >>>>> before adding new broken tests. >>>>> >>>>> I would also be very happy to see some comments when someone >>>>> adds a new broken test, so I know what the plan is. >>>>> >>>>> Now I added an implementation of Integer>>hex, for example, but >>>>> I am not so sure why we need this. >>>>> Ain't too many senders. An easier fix would have been to remove >>>>> the broken test. >>>>> >>>>> Cheers, >>>>> - on >>>>> >>>>> On Jun 10, 2008, at 15:53, Bill Schwab wrote: >>>>> >>>>>> Is your concern that the new tests are broken (which seems >>>>>> normal to me >>>>>> that they would start out that way), or are you objecting to >>>>>> their being >>>>>> included in the image? >>>>>> >>>>>> I can see arguments either way on the latter. If code in the >>>>>> image is >>>>>> wrong and a clearly correct but currently failing test >>>>>> highlights it, >>>>>> I'd rather be alerted to it. You are also correct that having >>>>>> them >>>>>> included draws attention that could easily encourage >>>>>> duplication of >>>>>> effort. >>>>>> >>>>>> Comments? >>>>>> >>>>>> Bill >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Wilhelm K. Schwab, Ph.D. >>>>>> University of Florida >>>>>> Department of Anesthesiology >>>>>> PO Box 100254 >>>>>> Gainesville, FL 32610-0254 >>>>>> >>>>>> Email: bschwab(a)anest.ufl.edu >>>>>> Tel: (352) 846-1285 >>>>>> FAX: (352) 392-7029 >>>>>> >>>>>>>>> oscar(a)iam.unibe.ch 06/10/08 8:31 AM >>> >>>>>> >>>>>> I looked at the wiki page >>>>>> http://code.google.com/p/pharo/wiki/CurrentlyWorkingOn >>>>>> but it does not say much. >>>>>> >>>>>> I would like to work through some tests, but I cannot find an >>>>>> overview. >>>>>> >>>>>> The tests CharacterTest>>testHex and IntegerTest>>testHex are >>>>>> broken >>>>>> but seem to be very new. Stef, are you working on these? You >>>>>> seem to >>>>>> have written the tests ... >>>>>> >>>>>> - on >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] Who is working on which tests? Why are there new, broken tests?

by StÃ©phane Ducasse

aha. may be squeakdev is based on another image or there is package that when loading remove hex. Stef On Jun 10, 2008, at 9:35 PM, Oscar Nierstrasz wrote: > > Wow. > > I took pharo0.1-10032-7075dev08.06.1 and updated it. There is no > Integer>>hex there. > > Damien, can you help? It looks like the pharo-dev image is somehow > out of sync. > > I will try both again now. > > - on > > On Jun 10, 2008, at 9:21 PM, StÃ©phane Ducasse wrote: > >> Hi oscar >> >> I took the pharo image Pharo0.1-10028-2008-05-24 available on the >> pharo web site >> and did an update. >> >> and there is >> Integer>>hex >> ^ self printStringBase: 16 >> >> I checked the version and it is from 25 of may >> >> Stef >> >>> >>> Hi Stef, >>> >>> I loaded a fresh pharo-dev image and updated everything. Then the >>> testHex tests failed, so I fixed them. >>> >>> Can you please tell me which implementors of hex you find in your >>> image? >>> >>> I only find Character>>hex and Float>>hex. I had to implement >>> Integer>>hex myself. >>> >>> - on >>> >>> On Jun 10, 2008, at 6:38 PM, StÃ©phane Ducasse wrote: >>> >>>> testHex >>>> self assert: $a hex '61' = '61'. >>>> self assert: Character space hex = '20' >>>> >>>> is green on my image >>>> >>>> as well as this one >>>> >>>> testHex >>>> self assert: 0 hex = '0'. >>>> self assert: 12 hex = 'C'. >>>> self assert: 1234 hex = '4D2'. >>>> >>>> They are red in yours? >>>> >>>> Stef >>>> >>>> >>>> On Jun 10, 2008, at 4:00 PM, Oscar Nierstrasz wrote: >>>> >>>>> >>>>> Well, I thought we would start to fix the existing broken tests >>>>> before adding new broken tests. >>>>> >>>>> I would also be very happy to see some comments when someone >>>>> adds a new broken test, so I know what the plan is. >>>>> >>>>> Now I added an implementation of Integer>>hex, for example, but >>>>> I am not so sure why we need this. >>>>> Ain't too many senders. An easier fix would have been to remove >>>>> the broken test. >>>>> >>>>> Cheers, >>>>> - on >>>>> >>>>> On Jun 10, 2008, at 15:53, Bill Schwab wrote: >>>>> >>>>>> Is your concern that the new tests are broken (which seems >>>>>> normal to me >>>>>> that they would start out that way), or are you objecting to >>>>>> their being >>>>>> included in the image? >>>>>> >>>>>> I can see arguments either way on the latter. If code in the >>>>>> image is >>>>>> wrong and a clearly correct but currently failing test >>>>>> highlights it, >>>>>> I'd rather be alerted to it. You are also correct that having >>>>>> them >>>>>> included draws attention that could easily encourage >>>>>> duplication of >>>>>> effort. >>>>>> >>>>>> Comments? >>>>>> >>>>>> Bill >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Wilhelm K. Schwab, Ph.D. >>>>>> University of Florida >>>>>> Department of Anesthesiology >>>>>> PO Box 100254 >>>>>> Gainesville, FL 32610-0254 >>>>>> >>>>>> Email: bschwab(a)anest.ufl.edu >>>>>> Tel: (352) 846-1285 >>>>>> FAX: (352) 392-7029 >>>>>> >>>>>>>>> oscar(a)iam.unibe.ch 06/10/08 8:31 AM >>> >>>>>> >>>>>> I looked at the wiki page >>>>>> http://code.google.com/p/pharo/wiki/CurrentlyWorkingOn >>>>>> but it does not say much. >>>>>> >>>>>> I would like to work through some tests, but I cannot find an >>>>>> overview. >>>>>> >>>>>> The tests CharacterTest>>testHex and IntegerTest>>testHex are >>>>>> broken >>>>>> but seem to be very new. Stef, are you working on these? You >>>>>> seem to >>>>>> have written the tests ... >>>>>> >>>>>> - on >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] self halt in RxParserTest>>testMatchesInwW

by StÃ©phane Ducasse

Ok I will publish a new version of the package on squeaksource stef On Jun 10, 2008, at 9:04 PM, Oscar Nierstrasz wrote: > > You har the image-meister, so you should patch it, I think. I can > only add a patch into the PharoInbox, but this is so trivial it is > easier if you just update your master image. > > - on > > On Jun 10, 2008, at 6:33 PM, StÃ©phane Ducasse wrote: > >> Yes go ahead. >> >> Stef >> >> On Jun 10, 2008, at 2:06 PM, Oscar Nierstrasz wrote: >> >>> >>> Stef, >>> >>> RxParserTest>>testMatchesInwW >>> >>> has a self halt in it dating from 2006, apparently added by you. >>> >>> I guess you should remove it ... The test runs fine otherwise. >>> >>> - on >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] KernelTests green

by StÃ©phane Ducasse

Excellent! may be this is the hash of class that changed. Marcus retrochanged the hash behavior that we harvested in 3.9. And may be in 3.10 they changed class hash too. Now I do not know if in 3.9 these tests were broken. Stef On Jun 10, 2008, at 9:32 PM, Oscar Nierstrasz wrote: > > OK, I investigated more deeply. > > It appears that SequenceableCollection>>hash behaves differently in > Pharo and Squeak 3.10. > > Squeak: > > #(1) hash --> 22516953 > > Pharo: > > #(1) hash --> 61541560 > > Since DateAndTime>>hash is ultimately implemented in terms of > Array>>hash (inherited from SequenceableCollection), this test fails. > > Not yet sure why these two behave differently ... > > Already the first line (self species hash) is different: > > Squeak: > > Array hash --> 259007228 > > Pharo: > > Array hash --> 2455 > > - on > > On Jun 10, 2008, at 6:34 PM, StÃ©phane Ducasse wrote: > >> We checked with lukas what is strange is that the same tests are >> green in 3.10. >> >> Stef >> >> On Jun 10, 2008, at 3:48 PM, Oscar Nierstrasz wrote: >> >>> >>> I have posted some patches to the inbox to make the Kernel Number >>> tests run, and in the Issues page I propose to delete a bunch of >>> nonsensical testHash tests. With these changes the Kernel tests >>> should all be green. >>> >>> - on >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008

Re: [Pharo-project] Who is working on which tests? Why are there new, broken tests?

by Oscar Nierstrasz

Wow. I took pharo0.1-10032-7075dev08.06.1 and updated it. There is no Integer>>hex there. Damien, can you help? It looks like the pharo-dev image is somehow out of sync. I will try both again now. - on On Jun 10, 2008, at 9:21 PM, StÃ©phane Ducasse wrote: > Hi oscar > > I took the pharo image Pharo0.1-10028-2008-05-24 available on the > pharo web site > and did an update. > > and there is > Integer>>hex > ^ self printStringBase: 16 > > I checked the version and it is from 25 of may > > Stef > >> >> Hi Stef, >> >> I loaded a fresh pharo-dev image and updated everything. Then the >> testHex tests failed, so I fixed them. >> >> Can you please tell me which implementors of hex you find in your >> image? >> >> I only find Character>>hex and Float>>hex. I had to implement >> Integer>>hex myself. >> >> - on >> >> On Jun 10, 2008, at 6:38 PM, StÃ©phane Ducasse wrote: >> >>> testHex >>> self assert: $a hex '61' = '61'. >>> self assert: Character space hex = '20' >>> >>> is green on my image >>> >>> as well as this one >>> >>> testHex >>> self assert: 0 hex = '0'. >>> self assert: 12 hex = 'C'. >>> self assert: 1234 hex = '4D2'. >>> >>> They are red in yours? >>> >>> Stef >>> >>> >>> On Jun 10, 2008, at 4:00 PM, Oscar Nierstrasz wrote: >>> >>>> >>>> Well, I thought we would start to fix the existing broken tests >>>> before adding new broken tests. >>>> >>>> I would also be very happy to see some comments when someone adds >>>> a new broken test, so I know what the plan is. >>>> >>>> Now I added an implementation of Integer>>hex, for example, but I >>>> am not so sure why we need this. >>>> Ain't too many senders. An easier fix would have been to remove >>>> the broken test. >>>> >>>> Cheers, >>>> - on >>>> >>>> On Jun 10, 2008, at 15:53, Bill Schwab wrote: >>>> >>>>> Is your concern that the new tests are broken (which seems >>>>> normal to me >>>>> that they would start out that way), or are you objecting to >>>>> their being >>>>> included in the image? >>>>> >>>>> I can see arguments either way on the latter. If code in the >>>>> image is >>>>> wrong and a clearly correct but currently failing test >>>>> highlights it, >>>>> I'd rather be alerted to it. You are also correct that having >>>>> them >>>>> included draws attention that could easily encourage duplication >>>>> of >>>>> effort. >>>>> >>>>> Comments? >>>>> >>>>> Bill >>>>> >>>>> >>>>> >>>>> >>>>> Wilhelm K. Schwab, Ph.D. >>>>> University of Florida >>>>> Department of Anesthesiology >>>>> PO Box 100254 >>>>> Gainesville, FL 32610-0254 >>>>> >>>>> Email: bschwab(a)anest.ufl.edu >>>>> Tel: (352) 846-1285 >>>>> FAX: (352) 392-7029 >>>>> >>>>>>>> oscar(a)iam.unibe.ch 06/10/08 8:31 AM >>> >>>>> >>>>> I looked at the wiki page >>>>> http://code.google.com/p/pharo/wiki/CurrentlyWorkingOn >>>>> but it does not say much. >>>>> >>>>> I would like to work through some tests, but I cannot find an >>>>> overview. >>>>> >>>>> The tests CharacterTest>>testHex and IntegerTest>>testHex are >>>>> broken >>>>> but seem to be very new. Stef, are you working on these? You >>>>> seem to >>>>> have written the tests ... >>>>> >>>>> - on >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 10, 2008