- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Strange bug in TraitsTest

by Norbert Hartl

Hmmm, it has something to do with the name pharo :) I checked the available images. Sapphire 10018 doesn't show up this. But Pharo 10021 does. And in 10021 there is one additional test in ClassTest testHaSharedPools Author seems to be Stephane. Do you know anything which have introduced this? Norbert On Wed, 2008-06-11 at 19:24 +0200, Norbert Hartl wrote: > If you open a test runner and select only KernelTests-ClassTest and > TraitsTests-TraitsTestCase you may find a failure > > ClassTest>>testRootsOfTheWorld > > But I don't understand fully why it appears. I had once > the chance to get a debugger on the failure (which does > usually not work on this failure) and so I know that the > rootsOfTheWorld (which is usually 3) is 6 in size containing > additionally classes C3 C4 and C6. The ones which are created > by TraitsTestCase (see my last mail "Bug for harvest"). > > They all have a superclass of nil but they aren't included > in the SystemNavigation. (conditions for being included in > the rootsOfTheWorld) > > If you press "Run selected" again the same error occurrs > while pressing "Run failures" gives you all green (ok, it > is this way in my case) > > And I can't reproduce the same in a 3.10 image. > > It seems that there is a timing problem involved. Selecting > only the two test cases I get the failure every time (or nearly). > Selecting all tests it appears only at random. > > Any hints? > > Norbert > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 11, 2008

[Pharo-project] Strange bug in TraitsTest

by Norbert Hartl

If you open a test runner and select only KernelTests-ClassTest and TraitsTests-TraitsTestCase you may find a failure ClassTest>>testRootsOfTheWorld But I don't understand fully why it appears. I had once the chance to get a debugger on the failure (which does usually not work on this failure) and so I know that the rootsOfTheWorld (which is usually 3) is 6 in size containing additionally classes C3 C4 and C6. The ones which are created by TraitsTestCase (see my last mail "Bug for harvest"). They all have a superclass of nil but they aren't included in the SystemNavigation. (conditions for being included in the rootsOfTheWorld) If you press "Run selected" again the same error occurrs while pressing "Run failures" gives you all green (ok, it is this way in my case) And I can't reproduce the same in a 3.10 image. It seems that there is a timing problem involved. Selecting only the two test cases I get the failure every time (or nearly). Selecting all tests it appears only at random. Any hints? Norbert

June 11, 2008

[Pharo-project] Bug for harvesting

by Norbert Hartl

Hi, I opened a bug a few minutes ago which you may find interesting for harvest. http://bugs.squeak.org/view.php?id=7090 Norbert

June 11, 2008

Re: [Pharo-project] Behaviour>>hash is missing!

by StÃ©phane Ducasse

Yes I have the impression that this would be a good things to do because they do not have add that much important information. On Jun 11, 2008, at 6:11 PM, Oscar Nierstrasz wrote: > > OK, so that is why all these silly testHash tests are broken. They > depend on Behaviour>>#hash to return a specific hash value. I > suggest trashing them as the tests are not robust. > > - on > > > On Jun 11, 2008, at 6:03 PM, Adrian Lienhard wrote: > >> IIRC Marcus introduced Behavior>>hash in 3.9 and later realized >> that this is not a good idea. The reason is that names of behaviors >> are not constant because when a class is deleted its name is >> changed to AnAbsolete..., which makes the name not suitable for >> hashing. >> >> Looking through ScriptLoader, #update10020 is where Behavior>>hash >> is removed again. Unfortunately the changes log is a bit unspecific >> as it mentions only: "changes from Reflectivity"... >> >> Cheers, >> Adrian >> >> On Jun 10, 2008, at 22:54 , Oscar Nierstrasz wrote: >> >>> >>> What was his fix? >>> >>> How can I tell what was changed? >>> >>> Is Behaviour>>hash missing in your image too? I don't trust >>> anything anymore. >>> >>> - on >>> >>> On Jun 10, 2008, at 10:13 PM, StÃ©phane Ducasse wrote: >>> >>>> Marcus should have a look since this is fix he reverted. >>>> >>>> Stef >>>> >>>> On Jun 10, 2008, at 10:04 PM, Oscar Nierstrasz wrote: >>>> >>>>> >>>>> These tests are fine in Squeak 3.9 too. >>>>> >>>>> Further investigation reveals that Behaviour>>hash is missing in >>>>> Pharo! >>>>> >>>>> So hash reverts to Object>>hash, which sends Object>>identityHash. >>>>> >>>>> In Pharo: >>>>> >>>>> Array hash --> 2455 >>>>> Object identityHash --> 2274 >>>>> >>>>> In Squeak: >>>>> >>>>> Array hash --> 259007228 >>>>> Object identityHash --> 2274 >>>>> >>>>> Looks like someone removed >>>>> >>>>> Behaviour>>hash >>>>> ^ self name hash >>>>> >>>>> - on >>>>> >>>>> On Jun 10, 2008, at 9:43 PM, StÃ©phane Ducasse wrote: >>>>> >>>>>> Excellent! >>>>>> may be this is the hash of class that changed. Marcus >>>>>> retrochanged the hash behavior that we harvested in 3.9. >>>>>> And may be in 3.10 they changed class hash too. >>>>>> >>>>>> Now I do not know if in 3.9 these tests were broken. >>>>>> >>>>>> Stef >>>>>> >>>>>> On Jun 10, 2008, at 9:32 PM, Oscar Nierstrasz wrote: >>>>>> >>>>>>> >>>>>>> OK, I investigated more deeply. >>>>>>> >>>>>>> It appears that SequenceableCollection>>hash behaves >>>>>>> differently in Pharo and Squeak 3.10. >>>>>>> >>>>>>> Squeak: >>>>>>> >>>>>>> #(1) hash --> 22516953 >>>>>>> >>>>>>> Pharo: >>>>>>> >>>>>>> #(1) hash --> 61541560 >>>>>>> >>>>>>> Since DateAndTime>>hash is ultimately implemented in terms of >>>>>>> Array>>hash (inherited from SequenceableCollection), this test >>>>>>> fails. >>>>>>> >>>>>>> Not yet sure why these two behave differently ... >>>>>>> >>>>>>> Already the first line (self species hash) is different: >>>>>>> >>>>>>> Squeak: >>>>>>> >>>>>>> Array hash --> 259007228 >>>>>>> >>>>>>> Pharo: >>>>>>> >>>>>>> Array hash --> 2455 >>>>>>> >>>>>>> - on >>>>>>> >>>>>>> On Jun 10, 2008, at 6:34 PM, StÃ©phane Ducasse wrote: >>>>>>> >>>>>>>> We checked with lukas what is strange is that the same tests >>>>>>>> are green in 3.10. >>>>>>>> >>>>>>>> Stef >>>>>>>> >>>>>>>> On Jun 10, 2008, at 3:48 PM, Oscar Nierstrasz wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> I have posted some patches to the inbox to make the Kernel >>>>>>>>> Number tests run, and in the Issues page I propose to delete >>>>>>>>> a bunch of nonsensical testHash tests. With these changes >>>>>>>>> the Kernel tests should all be green. >>>>>>>>> >>>>>>>>> - on >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Pharo-project mailing list >>>>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Pharo-project mailing list >>>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 11, 2008

Re: [Pharo-project] Broken tests

by StÃ©phane Ducasse

excellent! Stef On Jun 11, 2008, at 4:04 PM, Oscar Nierstrasz wrote: > > Just for phun, I ran all the tests in the Pharo image. There are > only 13 failures, 2 expected failures, and no errors! > > I have started a page to give an overview: > > http://code.google.com/p/pharo/wiki/BrokenTests > > Please update this page with an appropriate comment if you are > working on any of these (or if you fix them). > > - on > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 11, 2008

Re: [Pharo-project] New pharo-dev based on latest release

by StÃ©phane Ducasse

thanks a lot. I cleaned my mess. Stef On Jun 11, 2008, at 1:17 PM, Damien Cassou wrote: > I've just published a new pharo-dev based on 10036: > https://gforge.inria.fr/frs/download.php/4978/pharo0.1-10036dev08.06.2.zip > > -- > Damien Cassou > Peter von der AhÃ©: Â«I'm beginning to see why Gilad wished us good > luckÂ». (http://blogs.sun.com/ahe/entry/override_snafu) > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 11, 2008

Re: [Pharo-project] [ANN] New release

by StÃ©phane Ducasse

yes my mistake this interface is just crap. On Jun 11, 2008, at 1:39 PM, Oscar Nierstrasz wrote: > > Ah, I thought it *was* a pharo-dev image -- it was listed under > "pharo-dev" on the downloads page. > > http://gforge.inria.fr/frs/?group_id=1299 > > - on > > On Jun 11, 2008, at 11:12, Damien Cassou wrote: > >> On Wed, Jun 11, 2008 at 9:56 AM, Oscar Nierstrasz >> <oscar(a)iam.unibe.ch> wrote: >>> >>> Great! >>> >>> Just noticed two things: >>> >>> - Test Runner is missing from the Tools flap -- shouldn't it be >>> there? >> >> >> I think Pharo should not care about such things. Just use pharo-dev >> if >> you want a prepared pharo image for developers. >> >> -- >> Damien Cassou >> Peter von der AhÃ©: Â«I'm beginning to see why Gilad wished us good >> luckÂ». (http://blogs.sun.com/ahe/entry/override_snafu) >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 11, 2008

Re: [Pharo-project] HaveALookAt

by StÃ©phane Ducasse

I got some problems with the bootstrap. I think that it would be great to have an effort for another milestone and make it rock solid and integrated. Stef > This is an effort I started few years ago. > I loaded the it recently, and all tests but one go green. > > I will work on it, I hope soon... > > Alexandre > > > On 10 Jun 2008, at 09:58, Norbert Hartl wrote: > >> I think the link to the packages issue should point to >> >> http://www.squeaksource.com/PackagesForSqueak/ >> >> Norbert >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 11, 2008

[Pharo-project] MVC removal step2 investigations

by Alain Plantec

Hi all, below is given a minute that briefly describes what I suggest for MVC removal. It's an aggressive update especially because a lot of classes are removed. (see all *ST80* system categories before and after having applied the patch and see Controller hierarchy also) I've attached the .cs. Maybe you can make a try and give your opinion. thanks alain MVC removal step2 proposition 1 : * Object>>couldOpenInMorphic : senders updated and method set as deprecated (as for Project>>isMorphic and SystemDictionary>>isMorphic) * Remove method openAsMVC and openInMVC * ST80-Editors system category seems removeable o BitEditor, FormEditor and al : are strongly related to MVC and seems not used * ScheduledControllers : o Remove all methods which are referencing it, this leads to remove class ControlManager; o Remove ControlManager refs in SystemDictionary>>initialize and o cleanup StartUpList and ShutDownList SystemDictionary class variables with a script. * ST80-Framework system category seems removeable o View class seems removable (see ST80-Views system category point) o Then, ModalController, NoController are not referenced anymore, they can be removed o WindowingTransformation is only used by GraphicSymbolInstance which is removable (see ST80-Symbols system category point) * ST80-Views system category can be removed: o StandardSystemView>>Comment: "I represent a view that has a label above its top left corner. The text in the label identifies the kind of view. In addition to a label, I add control over the maximum and minimum size of the display box of my instance. My default controller is StandardSystemController. The elements of ScheduledControllers, the sole instance of ControlManager, are usually controllers for instances of me". o StandardSystemView hierarchy seems removable, (subclasses are ColorSystemView, ModalSystemWindowView, PluggableFileListView and ProjectView ) o MorphWorldView class removed * ST80-Pluggable Views system category o PluggableListView removed * ST80-Symbols system category seems removable o GraphicSymbol and GraphicSymbolInstance are not refed and have no instance, seems removable * WorldViewModel, MVCWiWPasteUpMorph, MorphWorldController and CautiousModel: all these classes are not used, to be removed o MorphicExtras-ST80 system category is then removed * ST80-Support system category o StandardSystemController class>>initialize removed: it only initialize unused class variables HBorderCursor, ScheduledBlueButtonMenu ScheduledBlueButtonMessages and VBorderCursor (these class variables are removed) o StandardSystemController: remove all methods that are related to view (mvc view) o StandardSystemController: class seems to be unused, therefore removed o FillInTheBlankController: class removed o ColorSystemView: class removed * ST80-Kernel-Remnants o Controller and its subclasses: remove all methods that are related to view (mvc view) o Controler: MinActivityLapse class variable seems unused o ControlManager seems removeable o ScrollController seems removeable o MouseMenuController seems removeable * Remove all view classes refs: o SelectorBrowser>>classListIndex: depends on PluggableListView o Browser>>couldBrowseAnyClass depends on PluggableListView * Kernel-ST80 Remnants o ParagraphEditor and TextMorphEditor: kept but have to be cleaned up * ST80-Pluggable Views system category removed * Preferences o removed #mvcProjectsAllowed from flags dictionary * MorphicExtras-ST80 o MorphWorldController class removed * ParagraphEditor o made direct subclass of Controller (get rid of MouseMenuController) o renoved view instance variable o TextMorphEditor is the unique ParagraphEditor subclass, maybe we should only have one class now (ParagraphEditor was more for mvc ?)

June 11, 2008

Re: [Pharo-project] Behaviour>>hash is missing!

by Oscar Nierstrasz

OK, so that is why all these silly testHash tests are broken. They depend on Behaviour>>#hash to return a specific hash value. I suggest trashing them as the tests are not robust. - on On Jun 11, 2008, at 6:03 PM, Adrian Lienhard wrote: > IIRC Marcus introduced Behavior>>hash in 3.9 and later realized that > this is not a good idea. The reason is that names of behaviors are > not constant because when a class is deleted its name is changed to > AnAbsolete..., which makes the name not suitable for hashing. > > Looking through ScriptLoader, #update10020 is where Behavior>>hash > is removed again. Unfortunately the changes log is a bit unspecific > as it mentions only: "changes from Reflectivity"... > > Cheers, > Adrian > > On Jun 10, 2008, at 22:54 , Oscar Nierstrasz wrote: > >> >> What was his fix? >> >> How can I tell what was changed? >> >> Is Behaviour>>hash missing in your image too? I don't trust >> anything anymore. >> >> - on >> >> On Jun 10, 2008, at 10:13 PM, StÃ©phane Ducasse wrote: >> >>> Marcus should have a look since this is fix he reverted. >>> >>> Stef >>> >>> On Jun 10, 2008, at 10:04 PM, Oscar Nierstrasz wrote: >>> >>>> >>>> These tests are fine in Squeak 3.9 too. >>>> >>>> Further investigation reveals that Behaviour>>hash is missing in >>>> Pharo! >>>> >>>> So hash reverts to Object>>hash, which sends Object>>identityHash. >>>> >>>> In Pharo: >>>> >>>> Array hash --> 2455 >>>> Object identityHash --> 2274 >>>> >>>> In Squeak: >>>> >>>> Array hash --> 259007228 >>>> Object identityHash --> 2274 >>>> >>>> Looks like someone removed >>>> >>>> Behaviour>>hash >>>> ^ self name hash >>>> >>>> - on >>>> >>>> On Jun 10, 2008, at 9:43 PM, StÃ©phane Ducasse wrote: >>>> >>>>> Excellent! >>>>> may be this is the hash of class that changed. Marcus >>>>> retrochanged the hash behavior that we harvested in 3.9. >>>>> And may be in 3.10 they changed class hash too. >>>>> >>>>> Now I do not know if in 3.9 these tests were broken. >>>>> >>>>> Stef >>>>> >>>>> On Jun 10, 2008, at 9:32 PM, Oscar Nierstrasz wrote: >>>>> >>>>>> >>>>>> OK, I investigated more deeply. >>>>>> >>>>>> It appears that SequenceableCollection>>hash behaves >>>>>> differently in Pharo and Squeak 3.10. >>>>>> >>>>>> Squeak: >>>>>> >>>>>> #(1) hash --> 22516953 >>>>>> >>>>>> Pharo: >>>>>> >>>>>> #(1) hash --> 61541560 >>>>>> >>>>>> Since DateAndTime>>hash is ultimately implemented in terms of >>>>>> Array>>hash (inherited from SequenceableCollection), this test >>>>>> fails. >>>>>> >>>>>> Not yet sure why these two behave differently ... >>>>>> >>>>>> Already the first line (self species hash) is different: >>>>>> >>>>>> Squeak: >>>>>> >>>>>> Array hash --> 259007228 >>>>>> >>>>>> Pharo: >>>>>> >>>>>> Array hash --> 2455 >>>>>> >>>>>> - on >>>>>> >>>>>> On Jun 10, 2008, at 6:34 PM, StÃ©phane Ducasse wrote: >>>>>> >>>>>>> We checked with lukas what is strange is that the same tests >>>>>>> are green in 3.10. >>>>>>> >>>>>>> Stef >>>>>>> >>>>>>> On Jun 10, 2008, at 3:48 PM, Oscar Nierstrasz wrote: >>>>>>> >>>>>>>> >>>>>>>> I have posted some patches to the inbox to make the Kernel >>>>>>>> Number tests run, and in the Issues page I propose to delete >>>>>>>> a bunch of nonsensical testHash tests. With these changes >>>>>>>> the Kernel tests should all be green. >>>>>>>> >>>>>>>> - on >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Pharo-project mailing list >>>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>>> >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 11, 2008