- Pharo-dev - lists.pharo.org

[Pharo-project] about ensuring file closing

by StÃ©phane Ducasse

Hi I would like to get your thoughts on the following: Following the blog of ramon and his code in sandstoneDB which extends dataStream as follows: Here is a typical example: fileNamed: aName do: aBlock | file | file := self fileNamed: aName. ^ file ifNil: [ nil ] ifNotNil: [ [ aBlock value: file ] ensure: [ file close ] ] fileNamed: aString "Here is the way to use DataStream and ReferenceStream: rr := ReferenceStream fileNamed: 'test.obj'. rr nextPut: <your object>. rr close. better use: fileNamed:do: " | strm | strm := self on: (FileStream fileNamed: aString). "will be binary" strm byteStream setFileTypeToObject. "Type and Creator not to be text, so can attach correctly to an email msg" ^ strm There is similar pattern in FileStream detectFile: aBlock do: anotherBlock | file | file := aBlock value. ^ file ifNil: [ nil ] ifNotNil: [ [anotherBlock value: file] ensure: [file close]] fileNamed: fileName ^ self concreteStream fileNamed: (self fullName: fileName) fileNamed: fileName do: aBlock "Avi Bryant says, ''This idiom is quite common in other languages that make heavy use of closures (i.e. Lisp (with-file 'foo' (f) ...) and Ruby (File.open('foo'){| f|...})). It's time Squeak had it, too.'' Returns the result of aBlock." ^ self detectFile: [ self fileNamed: fileName ] do: aBlock I have a question: - would not be better to even wrap the on: into the first block of the ensure: message? - do we have to close a file even if its creation failed? Stef

July 15, 2008

[Pharo-project] Re: New features in OB-Enhancements

by David RÃ¶thlisberger

As Pharo also uses OB-Enhancements for its class browser, I want to forward this email about recent additions to the OB-Enhancements package. Cheers, David > Hello, > > I recently added a couple of new features that people wanted to see in OB-Enhancements: > > - More icons for packages, classes and methods; for a comprehensive list of icons > please have a look at http://smallwiki.unibe.ch/hermion/icons. > > - Searches in mercury panel are now better integrated in the smart groups. For > instance, you directly go to the result when there is only one search result, also > for implementors/senders searches and for 'wild' searches (eg. 'OBCol*'). > > - In the first column, next to the switches 'packages' and 'smart groups' you also > find a 'hierarchy' switch that allows you to see the hierarchy of a selected class > and the packages in which this class has been defined or extended. This behaves > similar as in the VW-browser. > > - Commands to define a selected method as an extension method of a given class, or to > define this method as an extension method for a given package in the local class, are > available > > - When adding a package to a smart group, you now also see the class categories of > this package in the smart group view > > - If a package is not stored in any Monticello repository yet, there is a command > that allows you to initially import this local package in a repository to be defined. > > - On the top of the package column you now always see those five packages that have > been modified recently in your image. This is very useful to quickly browse to the > packages in which you are currently working. You then see all existing packages below > these five in an alphabetical order of course. > > - I also did some minor stuff, such as fixing defects, renaming or reordering some > menu actions to be consistent throughout the browser, etc. > > > I'd be glad to find some people willing to test these enhancements and to give me > feedback. I'm sure that there are still little issues here and there, and maybe you > think that some stuff should be done in a different manner. I'm very open to > incorporate any of your suggestions. > > To test these changes, you need the following packages: > > OmniBrowser-dr.413 > OB-Standard-dr.340 > OB-Morphic-dr.49 > OB-Enhancements-dr.183 > > > Cheers, > David > _______________________________________________ > ob-dev mailing list > ob-dev(a)wiresong.ca > http://mail.wiresong.ca/mailman/listinfo/ob-dev

July 15, 2008

Re: [Pharo-project] BrowseTest change in inbox

by Adrian Lienhard

ok, can you update your package with the class and create an issue in the tracker? Like this we can push it into the next update. Cheers, Adrian On Jul 15, 2008, at 14:16 , Alexandre Bergel wrote: > This test was not that bad actually. > Maybe it should be reintroduced. > > Cheers, > Alexandre > > > On 15 Jul 2008, at 12:13, Adrian Lienhard wrote: > >> Ok, I found the package that removed the class: >> >> ------------ >> Name: Tools-stephane.ducasse.83 >> Author: stephane.ducasse >> Time: 25 May 2008, 6:51:03 pm >> UUID: 0fd56f49-c138-4e05-850d-ed5c8f2ac9d6 >> Ancestors: Tools-stephane.ducasse.82 >> removed tests that open the old browsers and checked if the right >> item was selected. >> ------------ >> >> I assume Stef had a good reason to remove it. >> Alex, shall I remove your package from the inbox or do you want to >> check with Stef first? >> >> Cheers, >> Adrian >> >> On Jul 15, 2008, at 11:23 , Alexandre Bergel wrote: >> >>> I just checked. >>> Obviously someone removed BrowseTest. This class was present in a >>> 2008-05-24 image. >>> This aims at sending #browse to an arbitrary object and asserting >>> that a window opens. >>> >>> How comes that a test class disappear ? >>> >>> Cheers, >>> Alexandre >>> >>> >>> On 14 Jul 2008, at 21:42, Adrian Lienhard wrote: >>> >>>> Hi Alex, >>>> >>>> The following package is in the inbox. It changes methods in the >>>> class BrowseTest, but this class does not exist in the image. I >>>> don't know whether BrowseTest was removed or it came into your >>>> image from another source. Can you please check? >>>> >>>> Cheers, >>>> Adrian >>>> >>>> >>>> Name: Tools-AlexandreBergel.83 >>>> Author: AlexandreBergel >>>> Time: 26 May 2008, 10:11:12 pm >>>> UUID: 49e5b0a5-ad37-41a1-9487-916b74ae07d9 >>>> Ancestors: Tools-stephane.ducasse.82 >>>> >>>> The class BrowseTest is not OB aware. Without this fix, >>>> BrowseTest raised an error when OB was the default browser. >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> -- >>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>> Alexandre Bergel http://www.bergel.eu >>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>> >>> >>> >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

July 15, 2008

Re: [Pharo-project] BrowseTest change in inbox

by Alexandre Bergel

This test was not that bad actually. Maybe it should be reintroduced. Cheers, Alexandre On 15 Jul 2008, at 12:13, Adrian Lienhard wrote: > Ok, I found the package that removed the class: > > ------------ > Name: Tools-stephane.ducasse.83 > Author: stephane.ducasse > Time: 25 May 2008, 6:51:03 pm > UUID: 0fd56f49-c138-4e05-850d-ed5c8f2ac9d6 > Ancestors: Tools-stephane.ducasse.82 > removed tests that open the old browsers and checked if the right > item was selected. > ------------ > > I assume Stef had a good reason to remove it. > Alex, shall I remove your package from the inbox or do you want to > check with Stef first? > > Cheers, > Adrian > > On Jul 15, 2008, at 11:23 , Alexandre Bergel wrote: > >> I just checked. >> Obviously someone removed BrowseTest. This class was present in a >> 2008-05-24 image. >> This aims at sending #browse to an arbitrary object and asserting >> that a window opens. >> >> How comes that a test class disappear ? >> >> Cheers, >> Alexandre >> >> >> On 14 Jul 2008, at 21:42, Adrian Lienhard wrote: >> >>> Hi Alex, >>> >>> The following package is in the inbox. It changes methods in the >>> class BrowseTest, but this class does not exist in the image. I >>> don't know whether BrowseTest was removed or it came into your >>> image from another source. Can you please check? >>> >>> Cheers, >>> Adrian >>> >>> >>> Name: Tools-AlexandreBergel.83 >>> Author: AlexandreBergel >>> Time: 26 May 2008, 10:11:12 pm >>> UUID: 49e5b0a5-ad37-41a1-9487-916b74ae07d9 >>> Ancestors: Tools-stephane.ducasse.82 >>> >>> The class BrowseTest is not OB aware. Without this fix, BrowseTest >>> raised an error when OB was the default browser. >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

July 15, 2008

Re: [Pharo-project] BrowseTest change in inbox

by Adrian Lienhard

Ok, I found the package that removed the class: ------------ Name: Tools-stephane.ducasse.83 Author: stephane.ducasse Time: 25 May 2008, 6:51:03 pm UUID: 0fd56f49-c138-4e05-850d-ed5c8f2ac9d6 Ancestors: Tools-stephane.ducasse.82 removed tests that open the old browsers and checked if the right item was selected. ------------ I assume Stef had a good reason to remove it. Alex, shall I remove your package from the inbox or do you want to check with Stef first? Cheers, Adrian On Jul 15, 2008, at 11:23 , Alexandre Bergel wrote: > I just checked. > Obviously someone removed BrowseTest. This class was present in a > 2008-05-24 image. > This aims at sending #browse to an arbitrary object and asserting > that a window opens. > > How comes that a test class disappear ? > > Cheers, > Alexandre > > > On 14 Jul 2008, at 21:42, Adrian Lienhard wrote: > >> Hi Alex, >> >> The following package is in the inbox. It changes methods in the >> class BrowseTest, but this class does not exist in the image. I >> don't know whether BrowseTest was removed or it came into your >> image from another source. Can you please check? >> >> Cheers, >> Adrian >> >> >> Name: Tools-AlexandreBergel.83 >> Author: AlexandreBergel >> Time: 26 May 2008, 10:11:12 pm >> UUID: 49e5b0a5-ad37-41a1-9487-916b74ae07d9 >> Ancestors: Tools-stephane.ducasse.82 >> >> The class BrowseTest is not OB aware. Without this fix, BrowseTest >> raised an error when OB was the default browser. >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

July 15, 2008

Re: [Pharo-project] BrowseTest change in inbox

by Alexandre Bergel

I just checked. Obviously someone removed BrowseTest. This class was present in a 2008-05-24 image. This aims at sending #browse to an arbitrary object and asserting that a window opens. How comes that a test class disappear ? Cheers, Alexandre On 14 Jul 2008, at 21:42, Adrian Lienhard wrote: > Hi Alex, > > The following package is in the inbox. It changes methods in the > class BrowseTest, but this class does not exist in the image. I > don't know whether BrowseTest was removed or it came into your image > from another source. Can you please check? > > Cheers, > Adrian > > > Name: Tools-AlexandreBergel.83 > Author: AlexandreBergel > Time: 26 May 2008, 10:11:12 pm > UUID: 49e5b0a5-ad37-41a1-9487-916b74ae07d9 > Ancestors: Tools-stephane.ducasse.82 > > The class BrowseTest is not OB aware. Without this fix, BrowseTest > raised an error when OB was the default browser. > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

July 15, 2008

[Pharo-project] about enhancing ReferenceStream

by StÃ©phane Ducasse

Hello guys I saw that dataStream and friends did not get the protocol using ...do: as the default fileStream does. And indeed, there are some code to clean in there. I would really like to have a code coverage tools.

July 15, 2008

Re: [Pharo-project] BrowseTest change in inbox

by Alexandre Bergel

Ok, I will check in a few minutes Alexandre On 14 Jul 2008, at 21:42, Adrian Lienhard wrote: > Hi Alex, > > The following package is in the inbox. It changes methods in the > class BrowseTest, but this class does not exist in the image. I > don't know whether BrowseTest was removed or it came into your image > from another source. Can you please check? > > Cheers, > Adrian > > > Name: Tools-AlexandreBergel.83 > Author: AlexandreBergel > Time: 26 May 2008, 10:11:12 pm > UUID: 49e5b0a5-ad37-41a1-9487-916b74ae07d9 > Ancestors: Tools-stephane.ducasse.82 > > The class BrowseTest is not OB aware. Without this fix, BrowseTest > raised an error when OB was the default browser. > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

July 15, 2008

[Pharo-project] a method to clean checkForConversionMethods

by StÃ©phane Ducasse

the reference to project, the logic of the methods and its place seems wrong to me. Stef

July 14, 2008

[Pharo-project] BrowseTest change in inbox

by Adrian Lienhard

Hi Alex, The following package is in the inbox. It changes methods in the class BrowseTest, but this class does not exist in the image. I don't know whether BrowseTest was removed or it came into your image from another source. Can you please check? Cheers, Adrian Name: Tools-AlexandreBergel.83 Author: AlexandreBergel Time: 26 May 2008, 10:11:12 pm UUID: 49e5b0a5-ad37-41a1-9487-916b74ae07d9 Ancestors: Tools-stephane.ducasse.82 The class BrowseTest is not OB aware. Without this fix, BrowseTest raised an error when OB was the default browser.

July 14, 2008