- Pharo-dev - lists.pharo.org

Re: [Pharo-project] [MC] Adding a constraint when declaring a required package

by Alexandre Bergel

Let me put it in another way. Is there a situation where a package named MyPackage should require another package MyPackage-Foo. As we experienced, this evil dependency brings inconsistencies when saving MyPackage. What would it a nice way to prevent such situation ? > I imagine that this is to avoid mistake like > Moose > Moose-X > Moose-Y > > and that people do it > Moose-All > Moose-X > Moose-Y Even these situations are not clean. We should have MooseAll MooseX MooseY I do not see a reason to have a - within the name. If you have 3 class categories: Moose Moose-X Moose-Y It means that the package Moose contains Moose-X and Moose-Y definitions In Visualworks there is no dash convention, which is much better... Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Oct. 12, 2008

Re: [Pharo-project] [MC] Adding a constraint when declaring a required package

by StÃ©phane Ducasse

Alex I imagine that this is to avoid mistake like Moose Moose-X Moose-Y and that people do it Moose-All Moose-X Moose-Y If this is what you have in mind how would it work from a process point of view 1- I create Moose 2- I create Moose-XXX -> wanring 3- remove/rename Moose -> Moose-All then be able to create Moose-XXX This scenario would be realllllly important because we can really screw up MC packges with overlapping packages Scenario 2 1 - I have Moose 2- I load Moose-XXX PS: if you want to have feedback from people, they should not know what you are implying in advance like me. On Oct 11, 2008, at 12:19 PM, Alexandre Bergel wrote: > Maybe we should forbid a package XXX-YYY to be required for a > package named XXX > What do you think? > A simple check will do it... > > Cheers, > Alexandre > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 12, 2008

Re: [Pharo-project] History and SUnit

by StÃ©phane Ducasse

good feedback. This means that soon we will also be able to run test server and systematically and easily know if we made progress or not. Now we may face the problem that running the tests make the packages dirty. Stef > Hi Alex, > > On Oct 10, 2008, at 13:25 , Alexandre Bergel wrote: > >>> I tried your extension and have the following questions/problems: >>> - when I first run all the tests in the system, I get 4 failures >>> (as expected) but the bar on top stays green where it should be >>> yellow (it worked before) >> >> that's strange. I run all the test, and it turns yellow saying: >> "10 October 2008 1:07:37 pm 2286 run, 2279 passes, 4 expected >> failures, 3 failures, 0 errors, 0 unexpected passes" > > ok, I downloaded a fresh image and updated to 10091 and now it also > works for me. > >>> - I don't understand the "Progress" feature. What I did is run the >>> tests, then "Store results", then I fixed a failing test, then >>> "Run Failures", then "Show progress". But nothing happens. Maybe I >>> did something wrong? >> >> Result is displayed in the Transcript. Sorry to not have said it >> before. > > oh, I see. Yes, this seems to be a really useful feature! > What is the difference between storing the result via the "History" > button vs. "Store result into classes". Then also the results of > "show diff" and "Show Progress" are almost the same. I guess this > is to make it possible to store the results with the code. It seems > to me that this could be simplified... > >> We though first about opening a workspace with the result inside, >> but I did not find an easy way to do it. So, for now, it prints in >> the Transcript. > > If you want to open a workspace you can do it like this: Workspace > new contents: 'foo'; openLabel: 'SUnit Progress' > > I think the feature should be more intuitive so that a user can > figure out how it works just by trying it out. Wouldn't the > following 2 actions be sufficient for most cases: 'Remember Result', > 'Compare Result'? You would always only remember one result and no > diff selection and history deleting would be necessary. The > usability would increase because you would go down from 8 possible > user actions to 2. > > Cheers, > Adrian > > > >> Cheers, >> Alexandre >> >>> >>> On Oct 1, 2008, at 16:56 , Alexandre Bergel wrote: >>> >>>> Dear list, >>>> >>>> In PharoInbox Gwenael and I put an extension of SUnit that >>>> records results when running a set of test. >>>> Feel free to suggest improvement.... >>>> >>>> Open a TestRunner to enjoy its 'History' button. >>>> >>>> Cheers, >>>> Alexandre >>>> -- >>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>>> Alexandre Bergel http://www.bergel.eu >>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>>> >>>> >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 12, 2008

Re: [Pharo-project] History and SUnit

by Adrian Lienhard

Hi Alex, On Oct 10, 2008, at 13:25 , Alexandre Bergel wrote: >> I tried your extension and have the following questions/problems: >> - when I first run all the tests in the system, I get 4 failures >> (as expected) but the bar on top stays green where it should be >> yellow (it worked before) > > that's strange. I run all the test, and it turns yellow saying: > "10 October 2008 1:07:37 pm 2286 run, 2279 passes, 4 expected > failures, 3 failures, 0 errors, 0 unexpected passes" ok, I downloaded a fresh image and updated to 10091 and now it also works for me. >> - I don't understand the "Progress" feature. What I did is run the >> tests, then "Store results", then I fixed a failing test, then "Run >> Failures", then "Show progress". But nothing happens. Maybe I did >> something wrong? > > Result is displayed in the Transcript. Sorry to not have said it > before. oh, I see. Yes, this seems to be a really useful feature! What is the difference between storing the result via the "History" button vs. "Store result into classes". Then also the results of "show diff" and "Show Progress" are almost the same. I guess this is to make it possible to store the results with the code. It seems to me that this could be simplified... > We though first about opening a workspace with the result inside, > but I did not find an easy way to do it. So, for now, it prints in > the Transcript. If you want to open a workspace you can do it like this: Workspace new contents: 'foo'; openLabel: 'SUnit Progress' I think the feature should be more intuitive so that a user can figure out how it works just by trying it out. Wouldn't the following 2 actions be sufficient for most cases: 'Remember Result', 'Compare Result'? You would always only remember one result and no diff selection and history deleting would be necessary. The usability would increase because you would go down from 8 possible user actions to 2. Cheers, Adrian > Cheers, > Alexandre > >> >> On Oct 1, 2008, at 16:56 , Alexandre Bergel wrote: >> >>> Dear list, >>> >>> In PharoInbox Gwenael and I put an extension of SUnit that records >>> results when running a set of test. >>> Feel free to suggest improvement.... >>> >>> Open a TestRunner to enjoy its 'History' button. >>> >>> Cheers, >>> Alexandre >>> -- >>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>> Alexandre Bergel http://www.bergel.eu >>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>> >>> >>> >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 11, 2008

[Pharo-project] SLICE-Mantis-KernelNumber-Fix-Mining-nice.1.mcz

by nicolas cellier

I push here some more or less important fixes. These are limited to one or two method per fix and should not take very long to review. Cheers Nicolas This gathers several Tests and Fixes from Mantis for Kernel-Number ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6781 0.0 raisedTo: -1.0 unexpected result The patch correct Number >> #raisedTo: and uses [^self class one] so that Float >> #raisedTo; can be removed (99% identical code). ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6729 -Infinity closeTo: Infinity self deny: (Float infinity negated closeTo: Float infinity) ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6695 Float storeStringBase: does not store the radix self assert: (20.0 storeStringBase: 16) = '16r14.0' compare to this: (20 storeStringBase: 16) Note: in base 10, radix is not prepended (same as Integer). ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6697 Number>>storeOn:base: default implementation is wrong Default implementation does omit the radix prefix when it should not! Change it to subclassResponsibility, since every subclass will have a different one... ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6990 0.0 significandAsInteger is too big ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=7114 SmallInteger minVal highBitOfMagnitude Try it, it should not raise an Error... ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=5640 additional tests and fixes for Number>>printShowingDecimalPlaces: http://bugs.squeak.org/view.php?id=7028 printShowingDecimalPlaces: is broken in 3.10 Try (-0.9 printShowingDecimalPlaces: 1) for example... Where is the minus sign? Fix included in 3.10 is incorrect and not complete ------------------------------------------------------------

Oct. 11, 2008

Re: [Pharo-project] Pharo image size: 10.9MB

by StÃ©phane Ducasse

did you clean the changesets? yes in cleaningCS :) Also the Utilities cleanseOtherworldlySteppers > Preferences setDefaultFonts: #( > (setSystemFontTo: 'Accuny' 10) > (setListFontTo: 'Accuny' 10) > (setMenuFontTo: 'Accuny' 10) > (setFlapsFontTo: 'Accuny' 12) > (setEToysFontTo: 'Accuny' 10) > (setPaintBoxButtonFontTo: 'Accuny' 10) > (setWindowTitleFontTo: 'Accuny' 15) > (setBalloonHelpFontTo: 'Accuny' 10) > (setCodeFontTo: 'Accuny' 10) > (setButtonFontTo: 'Accuny' 8)). > TextConstants associations do: [ :association | > ((association value isKindOf: TextStyle) > and: [ association key ~= #Accuny ] > and: [ (TextStyle defaultFamilyNames includes: association key) > not ]) > ifTrue: [ TextConstants removeKey: association key ]]. > TextConstants at: #DefaultFixedTextStyle put: (TextConstants at: > #Accuny). > > (Flaps classPool at: #SharedFlapTabs) removeAllSuchThat: [ :each | > (#(Tools Pharo) includes: each labelString) not ]. > NaturalLanguageFormTranslator classPool at: #CachedTranslations put: > nil. > NaturalLanguageTranslator resetCaches. > PartsBin clearThumbnailCache. > PaintBoxMorph initialize. > PaintBoxMorph classPool at: #ColorChart put: nil; at: #Prototype > put: nil. > Utilities classPool at: #ScrapsBook put: nil. > Project allInstancesDo: [ :each | each setThumbnail: nil ]. > InternalThreadNavigationMorph clearThumbnailCache. > ScriptingSystem stripGraphicsForExternalRelease. > ProjectHistory currentHistory initialize. > Utilities zapUpdateDownloader. > Smalltalk forgetDoIts. > Behavior flushObsoleteSubclasses. > CommandHistory allInstancesDo: #initialize. > ScriptLoader new cleaningCS. > RequiredSelectors initialize. > ProvidedSelectors initialize. > LocalSends initialize. > SendCaches initializeAllInstances. > Utilities cleanseOtherworldlySteppers. > Smalltalk organization removeEmptyCategories. > SystemBrowser removeObsolete. > TheWorldMenu removeObsolete. > AppRegistry removeObsolete. > FileServices removeObsolete. > SystemNavigation default obsoleteBehaviors. > MCFileBasedRepository flushAllCaches. > MCDefinition clearInstances. > Undeclared removeUnreferencedKeys. > Smalltalk flushClassNameCache. > 3 timesRepeat: [ Smalltalk garbageCollect. Symbol > compactSymbolTable ]. > Set rehashAllSets. > Smalltalk garbageCollect. > > > ___________________ > http://www.adrian-lienhard.ch/ > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 11, 2008

Re: [Pharo-project] Pharo image size: 10.9MB

by StÃ©phane Ducasse

excellent! I would be also curious about the size of the strings. And yes - we need to have a cleanup process as proposed/examplified by keith For the default fonts: do we have a process to reload the non default fonts? Stef On Oct 11, 2008, at 8:11 PM, Adrian Lienhard wrote: > I've been looking into how the current 13.4MB a Pharo image uses are > spent... I expected that at least half of it is used by classes > (compiled methods). But this is not the case. Actually, only about > 1/4th are classes. As it turned out, almost the same amount of > memory is used by forms (actually bitmaps)! > > If you want to know which are the largest 10 forms try this: > > (Form allInstances asSortedCollection: [ :e1 :e2 | e1 bits size >= > e2 bits size ]) from: 1 to: 10 do: [ :each | each asMorph > openInWorld ] > > ...among which for example are 4 different color pickers. In total > there are around 450 forms, most from EToys. I've manually traced > down where the larger forms come from and have cleaned up those that > were possible (many are only referenced by caches). The number of > forms is at 320 now. > > In the process I produced the script below, which among other stuff > removes all but the default font. Also, it actually removes the > flaps from the system instead of only hiding them. Here a history of > image sizes: > > Squeak 3.9: 15.6 MB > Pharo 10091: 13.4MB (before cleanup) > Pharo 10091: 10.9MB (after cleanup) > > Main conclusion: the system needs cleanup not only of the code > (where the mess is more directly visible), but also of the object > memory. Furthermore, I expect removing EToys will have an nice > impact on the image size. Also removing Sound will release some > memory because of sound samples. > > If anybody has suggestions to further reduce the image size (<10MB > would be a nice target for the first release...), please let me know. > > Cheers, > Adrian > > > > Preferences setDefaultFonts: #( > (setSystemFontTo: 'Accuny' 10) > (setListFontTo: 'Accuny' 10) > (setMenuFontTo: 'Accuny' 10) > (setFlapsFontTo: 'Accuny' 12) > (setEToysFontTo: 'Accuny' 10) > (setPaintBoxButtonFontTo: 'Accuny' 10) > (setWindowTitleFontTo: 'Accuny' 15) > (setBalloonHelpFontTo: 'Accuny' 10) > (setCodeFontTo: 'Accuny' 10) > (setButtonFontTo: 'Accuny' 8)). > TextConstants associations do: [ :association | > ((association value isKindOf: TextStyle) > and: [ association key ~= #Accuny ] > and: [ (TextStyle defaultFamilyNames includes: association key) > not ]) > ifTrue: [ TextConstants removeKey: association key ]]. > TextConstants at: #DefaultFixedTextStyle put: (TextConstants at: > #Accuny). > > (Flaps classPool at: #SharedFlapTabs) removeAllSuchThat: [ :each | > (#(Tools Pharo) includes: each labelString) not ]. > NaturalLanguageFormTranslator classPool at: #CachedTranslations put: > nil. > NaturalLanguageTranslator resetCaches. > PartsBin clearThumbnailCache. > PaintBoxMorph initialize. > PaintBoxMorph classPool at: #ColorChart put: nil; at: #Prototype > put: nil. > Utilities classPool at: #ScrapsBook put: nil. > Project allInstancesDo: [ :each | each setThumbnail: nil ]. > InternalThreadNavigationMorph clearThumbnailCache. > ScriptingSystem stripGraphicsForExternalRelease. > ProjectHistory currentHistory initialize. > Utilities zapUpdateDownloader. > Smalltalk forgetDoIts. > Behavior flushObsoleteSubclasses. > CommandHistory allInstancesDo: #initialize. > ScriptLoader new cleaningCS. > RequiredSelectors initialize. > ProvidedSelectors initialize. > LocalSends initialize. > SendCaches initializeAllInstances. > Utilities cleanseOtherworldlySteppers. > Smalltalk organization removeEmptyCategories. > SystemBrowser removeObsolete. > TheWorldMenu removeObsolete. > AppRegistry removeObsolete. > FileServices removeObsolete. > SystemNavigation default obsoleteBehaviors. > MCFileBasedRepository flushAllCaches. > MCDefinition clearInstances. > Undeclared removeUnreferencedKeys. > Smalltalk flushClassNameCache. > 3 timesRepeat: [ Smalltalk garbageCollect. Symbol > compactSymbolTable ]. > Set rehashAllSets. > Smalltalk garbageCollect. > > > ___________________ > http://www.adrian-lienhard.ch/ > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 11, 2008

[Pharo-project] Pharo image size: 10.9MB

by Adrian Lienhard

I've been looking into how the current 13.4MB a Pharo image uses are spent... I expected that at least half of it is used by classes (compiled methods). But this is not the case. Actually, only about 1/4th are classes. As it turned out, almost the same amount of memory is used by forms (actually bitmaps)! If you want to know which are the largest 10 forms try this: (Form allInstances asSortedCollection: [ :e1 :e2 | e1 bits size >= e2 bits size ]) from: 1 to: 10 do: [ :each | each asMorph openInWorld ] ...among which for example are 4 different color pickers. In total there are around 450 forms, most from EToys. I've manually traced down where the larger forms come from and have cleaned up those that were possible (many are only referenced by caches). The number of forms is at 320 now. In the process I produced the script below, which among other stuff removes all but the default font. Also, it actually removes the flaps from the system instead of only hiding them. Here a history of image sizes: Squeak 3.9: 15.6 MB Pharo 10091: 13.4MB (before cleanup) Pharo 10091: 10.9MB (after cleanup) Main conclusion: the system needs cleanup not only of the code (where the mess is more directly visible), but also of the object memory. Furthermore, I expect removing EToys will have an nice impact on the image size. Also removing Sound will release some memory because of sound samples. If anybody has suggestions to further reduce the image size (<10MB would be a nice target for the first release...), please let me know. Cheers, Adrian Preferences setDefaultFonts: #( (setSystemFontTo: 'Accuny' 10) (setListFontTo: 'Accuny' 10) (setMenuFontTo: 'Accuny' 10) (setFlapsFontTo: 'Accuny' 12) (setEToysFontTo: 'Accuny' 10) (setPaintBoxButtonFontTo: 'Accuny' 10) (setWindowTitleFontTo: 'Accuny' 15) (setBalloonHelpFontTo: 'Accuny' 10) (setCodeFontTo: 'Accuny' 10) (setButtonFontTo: 'Accuny' 8)). TextConstants associations do: [ :association | ((association value isKindOf: TextStyle) and: [ association key ~= #Accuny ] and: [ (TextStyle defaultFamilyNames includes: association key) not ]) ifTrue: [ TextConstants removeKey: association key ]]. TextConstants at: #DefaultFixedTextStyle put: (TextConstants at: #Accuny). (Flaps classPool at: #SharedFlapTabs) removeAllSuchThat: [ :each | (#(Tools Pharo) includes: each labelString) not ]. NaturalLanguageFormTranslator classPool at: #CachedTranslations put: nil. NaturalLanguageTranslator resetCaches. PartsBin clearThumbnailCache. PaintBoxMorph initialize. PaintBoxMorph classPool at: #ColorChart put: nil; at: #Prototype put: nil. Utilities classPool at: #ScrapsBook put: nil. Project allInstancesDo: [ :each | each setThumbnail: nil ]. InternalThreadNavigationMorph clearThumbnailCache. ScriptingSystem stripGraphicsForExternalRelease. ProjectHistory currentHistory initialize. Utilities zapUpdateDownloader. Smalltalk forgetDoIts. Behavior flushObsoleteSubclasses. CommandHistory allInstancesDo: #initialize. ScriptLoader new cleaningCS. RequiredSelectors initialize. ProvidedSelectors initialize. LocalSends initialize. SendCaches initializeAllInstances. Utilities cleanseOtherworldlySteppers. Smalltalk organization removeEmptyCategories. SystemBrowser removeObsolete. TheWorldMenu removeObsolete. AppRegistry removeObsolete. FileServices removeObsolete. SystemNavigation default obsoleteBehaviors. MCFileBasedRepository flushAllCaches. MCDefinition clearInstances. Undeclared removeUnreferencedKeys. Smalltalk flushClassNameCache. 3 timesRepeat: [ Smalltalk garbageCollect. Symbol compactSymbolTable ]. Set rehashAllSets. Smalltalk garbageCollect. ___________________ http://www.adrian-lienhard.ch/

Oct. 11, 2008

Re: [Pharo-project] Pharo Harvesting Infrastructure

by StÃ©phane Ducasse

for me this is the 15th but I'm cheating :) I want the gifts before :)) Stef >>> I will take the time to reply. RIght now I'm busy with friends >>> for my birthday :) >> >> hehe. I'll be celebrating my birthday later today too. Have fun! >> > No way. It's my birthday, too. :)) > > Norbert

Oct. 11, 2008

Re: [Pharo-project] Pharo Harvesting Infrastructure

by Norbert Hartl

On Sat, 2008-10-11 at 08:37 -0700, Matthew Fulmer wrote: > On Sat, Oct 11, 2008 at 04:55:52PM +0200, St?phane Ducasse wrote: > > I will take the time to reply. RIght now I'm busy with friends > > for my birthday :) > > hehe. I'll be celebrating my birthday later today too. Have fun! > No way. It's my birthday, too. :)) Norbert

Oct. 11, 2008