- Pharo-dev - lists.pharo.org

Re: [Pharo-project] some mess in 10161

by Marcus Denker

On 20.11.2008, at 10:48, Pavel Krivanek wrote: > BooleanScriptEditor has an obsolete superClass and should be removed. > I fixed that in 10162 > This removes some next obsolete classes: (Preferences preferenceAt: > #allowEtoyUserCustomEvents) changeInformee: nil changeSelector: nil. > > There's one new 'undeclared' after Smalltalk cleanOutUndeclared. > CPlatform used directly by HostSystemMenus class>>initialize > I put two issues on the bugtracker for those. Marcus -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Nov. 20, 2008

Re: [Pharo-project] SUnit: history support and OB icons

by David RÃ¶thlisberger

> Now we should really have a button to execute them :) > I was thinking that clicking on the icons should run the tests :) ok, this is no problem to do. I will work on this. David >>>> On Nov 19, 2008, at 10:02 PM, Simon Denier wrote: >>>> >>>>> Hi all >>>>> >>>>> Just to notify a new enhancement to review in the PharoInbox. >>>>> >>>>> SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2 >>>>> >>>>> >>>>> Short doc: >>>>> >>>>> Add: >>>>> - support history for test runs as well as progression filter to >>>>> show test in progression, regression >>>>> - support icons in OB to show the current state of a test: passed, >>>>> failed, progressed, regressed... >>>>> >>>>> History support: >>>>> - whenever some test cases run from the TestRunner, their results >>>>> are stored in a class side variable TestResult class>>History >>>>> - contextual menu for history in TestRunner>>error pane: >>>>> 1) History: access submenu to TestRunner instance history: can save >>>>> and show progress between results ran in the same TestRunner; lost >>>>> when this particular instance of TestRunner is closed >>>>> 2) Store results as progress reference: create/update a >>>>> lastStoredRun method on the class side of each TestCase which have >>>>> just been run, containing the results >>>>> 3) Show progress: make a diff between the last run and the >>>>> lastStoredRun, showing progress or regress in tests (new passed, >>>>> new failures, new errors) >>>>> >>>>> The idea is that whenever you are satisfied with the current >>>>> results of some of your tests, you can save this state as a >>>>> reference point with the 'Store results...' action. >>>>> This reference point can be compared with subsequent test results >>>>> to show your progression or regression. >>>>> >>>>> Test results are stored in a class side variable some are kept >>>>> local to your image. Reference results are stored in a special >>>>> method for each TestCase, so that they are saved with their package >>>>> and can be used as a common reference for package developers. So a >>>>> good practice is to store the latest test results as reference >>>>> before committing your changes. >>>>> >>>>> >>>>> Icons support: >>>>> OB Package browser now has icons for test methods in TestCase >>>>> subclasses: >>>>> - green circle: test has passed in the last run >>>>> - red circle: test has failed >>>>> - half green/half red circle: state unknown, test has no history or >>>>> test has changed since last run >>>>> - (no icon): test has raised an error >>>>> - upside green arrow: test has progressed since last reference run >>>>> - downside blue triangle: test has regressed since last reference run >>>>> >>>>> A test is in progression if it goes from error or failure to passed >>>>> state. >>>>> A test is in regression if it goes from passed to error or failure >>>>> state. >>>>> >>>>> The last two icons have other meanings with methods not related to >>>>> test, so we should change them whenever someone has better icons. >>>>> >>>>> Authors: Alexandre Bergel, Simon Denier, David RÃ¶thlisberger >>>>> >>>>> -- >

Nov. 20, 2008

Re: [Pharo-project] [update] #10157

by Marcus Denker

On 18.11.2008, at 11:12, StÃ©phane Ducasse wrote: > Cool > May be we should write a test or two for the classVariable > Yes, test would be nice... I add it to the TODO list. > Marcus do you know the the relationship between classVar and > classPool. > A classVar is added to the classPool dict? > Yes, Marcus > Stef > > > > On Nov 18, 2008, at 10:38 AM, Marcus Denker wrote: > >> >> -> Issue 84: 7136 TraitBehavior-2-dc >> Methods to make the interface of Traits compatible to classes, >> collected by Damien Cassou >> -> Issue 246: fix classVariableNames >> Metaclass shares the class variables with the class. (from Eliott >> Miranda) >> >> -- >> Marcus Denker -- denker(a)iam.unibe.ch >> http://www.iam.unibe.ch/~denker >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Nov. 20, 2008

Re: [Pharo-project] SUnit: history support and OB icons

by StÃ©phane Ducasse

THIS IS REALLY COOL! Now we should really have a button to execute them :) I was thinking that clicking on the icons should run the tests :) But it could be cool once we have an icon for the class tests (as discussed with samuel) to be able to trigger the tests from there. Stef On Nov 20, 2008, at 2:45 PM, David RÃ¶thlisberger wrote: > >>> which version of OB should I load to get that? >> Actually, it should work with any OB loaded by the latest version, >> the icon support was already there. > > yep, any version you can load with methods provided by ScriptLoader > contain this change. > > David > >>> On Nov 19, 2008, at 10:02 PM, Simon Denier wrote: >>> >>>> Hi all >>>> >>>> Just to notify a new enhancement to review in the PharoInbox. >>>> >>>> SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2 >>>> >>>> >>>> Short doc: >>>> >>>> Add: >>>> - support history for test runs as well as progression filter to >>>> show test in progression, regression >>>> - support icons in OB to show the current state of a test: >>>> passed, failed, progressed, regressed... >>>> >>>> History support: >>>> - whenever some test cases run from the TestRunner, their results >>>> are stored in a class side variable TestResult class>>History >>>> - contextual menu for history in TestRunner>>error pane: >>>> 1) History: access submenu to TestRunner instance history: can >>>> save and show progress between results ran in the same >>>> TestRunner; lost when this particular instance of TestRunner is >>>> closed >>>> 2) Store results as progress reference: create/update a >>>> lastStoredRun method on the class side of each TestCase which >>>> have just been run, containing the results >>>> 3) Show progress: make a diff between the last run and the >>>> lastStoredRun, showing progress or regress in tests (new passed, >>>> new failures, new errors) >>>> >>>> The idea is that whenever you are satisfied with the current >>>> results of some of your tests, you can save this state as a >>>> reference point with the 'Store results...' action. >>>> This reference point can be compared with subsequent test results >>>> to show your progression or regression. >>>> >>>> Test results are stored in a class side variable some are kept >>>> local to your image. Reference results are stored in a special >>>> method for each TestCase, so that they are saved with their >>>> package and can be used as a common reference for package >>>> developers. So a good practice is to store the latest test >>>> results as reference before committing your changes. >>>> >>>> >>>> Icons support: >>>> OB Package browser now has icons for test methods in TestCase >>>> subclasses: >>>> - green circle: test has passed in the last run >>>> - red circle: test has failed >>>> - half green/half red circle: state unknown, test has no history >>>> or test has changed since last run >>>> - (no icon): test has raised an error >>>> - upside green arrow: test has progressed since last reference run >>>> - downside blue triangle: test has regressed since last reference >>>> run >>>> >>>> A test is in progression if it goes from error or failure to >>>> passed state. >>>> A test is in regression if it goes from passed to error or >>>> failure state. >>>> >>>> The last two icons have other meanings with methods not related >>>> to test, so we should change them whenever someone has better >>>> icons. >>>> >>>> Authors: Alexandre Bergel, Simon Denier, David RÃ¶thlisberger >>>> >>>> -- >>>> Simon >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> -- >> Simon >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Nov. 20, 2008

Re: [Pharo-project] SUnit: history support and OB icons

by David RÃ¶thlisberger

>> which version of OB should I load to get that? > > Actually, it should work with any OB loaded by the latest version, the > icon support was already there. yep, any version you can load with methods provided by ScriptLoader contain this change. David >> On Nov 19, 2008, at 10:02 PM, Simon Denier wrote: >> >>> Hi all >>> >>> Just to notify a new enhancement to review in the PharoInbox. >>> >>> SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2 >>> >>> >>> Short doc: >>> >>> Add: >>> - support history for test runs as well as progression filter to show >>> test in progression, regression >>> - support icons in OB to show the current state of a test: passed, >>> failed, progressed, regressed... >>> >>> History support: >>> - whenever some test cases run from the TestRunner, their results are >>> stored in a class side variable TestResult class>>History >>> - contextual menu for history in TestRunner>>error pane: >>> 1) History: access submenu to TestRunner instance history: can save >>> and show progress between results ran in the same TestRunner; lost >>> when this particular instance of TestRunner is closed >>> 2) Store results as progress reference: create/update a lastStoredRun >>> method on the class side of each TestCase which have just been run, >>> containing the results >>> 3) Show progress: make a diff between the last run and the >>> lastStoredRun, showing progress or regress in tests (new passed, new >>> failures, new errors) >>> >>> The idea is that whenever you are satisfied with the current results >>> of some of your tests, you can save this state as a reference point >>> with the 'Store results...' action. >>> This reference point can be compared with subsequent test results to >>> show your progression or regression. >>> >>> Test results are stored in a class side variable some are kept local >>> to your image. Reference results are stored in a special method for >>> each TestCase, so that they are saved with their package and can be >>> used as a common reference for package developers. So a good practice >>> is to store the latest test results as reference before committing >>> your changes. >>> >>> >>> Icons support: >>> OB Package browser now has icons for test methods in TestCase >>> subclasses: >>> - green circle: test has passed in the last run >>> - red circle: test has failed >>> - half green/half red circle: state unknown, test has no history or >>> test has changed since last run >>> - (no icon): test has raised an error >>> - upside green arrow: test has progressed since last reference run >>> - downside blue triangle: test has regressed since last reference run >>> >>> A test is in progression if it goes from error or failure to passed >>> state. >>> A test is in regression if it goes from passed to error or failure >>> state. >>> >>> The last two icons have other meanings with methods not related to >>> test, so we should change them whenever someone has better icons. >>> >>> Authors: Alexandre Bergel, Simon Denier, David RÃ¶thlisberger >>> >>> -- >>> Simon >>> >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > Simon > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Nov. 20, 2008

Re: [Pharo-project] About Uppercase for class instance variable

by Alexandre Bergel

>> Shall I create an issue and rename CompoundTextSequence into >> compoundTextSequence and RightHalfSequence into rightHalfSequence >> ? So I create an issue Alexandre >> >> >> On 20 Nov 2008, at 05:49, StÃ©phane Ducasse wrote: >> >>> Hi >>> >>> I would like to know if you encountered class instance variable >>> with starting uppercase letter? >>> I hate that practice. >>> >>> Stef >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Nov. 20, 2008

Re: [Pharo-project] About Uppercase for class instance variable

by StÃ©phane Ducasse

thanks alex. Stef On Nov 20, 2008, at 2:02 PM, Alexandre Bergel wrote: > (Object allSubclasses select: [:cls| cls isMeta]) select: [:cls| cls > instVarNames anySatisfy: [:n | n first isUppercase] > In a Core-10156 it gives me: a Set(Latin1 class EncodedCharSet class) > > If I open a browser I have: > EncodedCharSet class > instanceVariableNames: 'CompoundTextSequence' > > Latin1 class > instanceVariableNames: 'RightHalfSequence' > > Shall I create an issue and rename CompoundTextSequence into > compoundTextSequence and RightHalfSequence into rightHalfSequence > ? > > Alexandre > > > On 20 Nov 2008, at 05:49, StÃ©phane Ducasse wrote: > >> Hi >> >> I would like to know if you encountered class instance variable >> with starting uppercase letter? >> I hate that practice. >> >> Stef >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Nov. 20, 2008

Re: [Pharo-project] About Uppercase for class instance variable

by Alexandre Bergel

(Object allSubclasses select: [:cls| cls isMeta]) select: [:cls| cls instVarNames anySatisfy: [:n | n first isUppercase] In a Core-10156 it gives me: a Set(Latin1 class EncodedCharSet class) If I open a browser I have: EncodedCharSet class instanceVariableNames: 'CompoundTextSequence' Latin1 class instanceVariableNames: 'RightHalfSequence' Shall I create an issue and rename CompoundTextSequence into compoundTextSequence and RightHalfSequence into rightHalfSequence ? Alexandre On 20 Nov 2008, at 05:49, StÃ©phane Ducasse wrote: > Hi > > I would like to know if you encountered class instance variable with > starting uppercase letter? > I hate that practice. > > Stef > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Nov. 20, 2008

[Pharo-project] [update] 10161/10162

by Marcus Denker

update10161 -> Issue 323: look at all the senders of noviceMode and try to remove this preference -> remove more etoy classes -> SystemNavigation default removeUnsentMessagesWithProgressBarInPackageNamed: EToys -> remove preferences: Preferences removePreference: #simpleMenus. Preferences removePreference: #mvcProjectsAllowed. Preferences removePreference: #uniTilesClassic. Preferences removePreference: #universalTiles. Preferences removePreference: #typeCheckingInTileScripting. Preferences removePreference: #eToyFriendly. Preferences removePreference: #eToyLoginEnabled. Preferences removePreference: #useVectorVocabulary. Preferences removePreference: #noviceMode. Preferences removePreference: #dropProducesWatcher. ------------------------------------------------------ update10162 More etoys/vocabulary cleans -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Nov. 20, 2008

Re: [Pharo-project] SUnit: history support and OB icons

by Simon Denier

On 20 nov. 08, at 11:55, StÃ©phane Ducasse wrote: > which version of OB should I load to get that? Actually, it should work with any OB loaded by the latest version, the icon support was already there. > > > Stef > > On Nov 19, 2008, at 10:02 PM, Simon Denier wrote: > >> Hi all >> >> Just to notify a new enhancement to review in the PharoInbox. >> >> SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2 >> >> >> Short doc: >> >> Add: >> - support history for test runs as well as progression filter to >> show test in progression, regression >> - support icons in OB to show the current state of a test: passed, >> failed, progressed, regressed... >> >> History support: >> - whenever some test cases run from the TestRunner, their results >> are stored in a class side variable TestResult class>>History >> - contextual menu for history in TestRunner>>error pane: >> 1) History: access submenu to TestRunner instance history: can save >> and show progress between results ran in the same TestRunner; lost >> when this particular instance of TestRunner is closed >> 2) Store results as progress reference: create/update a >> lastStoredRun method on the class side of each TestCase which have >> just been run, containing the results >> 3) Show progress: make a diff between the last run and the >> lastStoredRun, showing progress or regress in tests (new passed, >> new failures, new errors) >> >> The idea is that whenever you are satisfied with the current >> results of some of your tests, you can save this state as a >> reference point with the 'Store results...' action. >> This reference point can be compared with subsequent test results >> to show your progression or regression. >> >> Test results are stored in a class side variable some are kept >> local to your image. Reference results are stored in a special >> method for each TestCase, so that they are saved with their package >> and can be used as a common reference for package developers. So a >> good practice is to store the latest test results as reference >> before committing your changes. >> >> >> Icons support: >> OB Package browser now has icons for test methods in TestCase >> subclasses: >> - green circle: test has passed in the last run >> - red circle: test has failed >> - half green/half red circle: state unknown, test has no history or >> test has changed since last run >> - (no icon): test has raised an error >> - upside green arrow: test has progressed since last reference run >> - downside blue triangle: test has regressed since last reference run >> >> A test is in progression if it goes from error or failure to passed >> state. >> A test is in regression if it goes from passed to error or failure >> state. >> >> The last two icons have other meanings with methods not related to >> test, so we should change them whenever someone has better icons. >> >> Authors: Alexandre Bergel, Simon Denier, David RÃ¶thlisberger >> >> -- >> Simon >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Simon

Nov. 20, 2008