- Pharo-dev - lists.pharo.org

Re: [Pharo-project] On not unnecessarily closing down the language

by Janko MivÅ¡ek

Hi Stef, StÃ©phane Ducasse wrote: > I checked and > - pharo does not complain for what seems good. So no bugs from our > side. > > - SwazooBenchmarks seems to have an instance class variable with > uppercase > Singleton > > can you check and confirm. I tried to load beta2.2 > Thanks Yep, that's it! And it seems it comes from VW definition, where since 7.x you don't have class variables anymore but just shared ones. It seems I wrongly put this Singleton as the class instance variable and porting to Squeak ported that mistake too. Sorry for that and the error will be corrected in the next release. In the meantime you can safely just ignore it. Best regards Janko > > On Dec 29, 2008, at 5:16 PM, Janko MivÅ¡ek wrote: > >> Hi Ramon, >> >> Ramon Leon wrote: >> >>>>> Yes I contacted Janko if he can fix that >>>> I can fix of course but I'm a bit surprised that in Squeak the class >>>> variables are supposed to be lower case. I have in mind back >>>> from 1996 >>>> that they must be uppercase. >>> Janko, I'm pretty sure Lukas was talking about a class instance >>> variable, >>> not a class variable. Class instance variables should be lowercase >>> while >>> class vars are uppercase. Swazoo apparently contains a class- >>> instance >>> variable that is uppercased, which regardless of the outcome of this >>> discussion, should probably be fixed. >> Here is the exact definition of a Swazoo class in question: >> >> Object subclass: #SwazooServer >> instanceVariableNames: 'sites servers watchdog' >> classVariableNames: 'Singleton' >> poolDictionaries: '' >> category: 'Swazoo-Core' >> >> And here the same definition of Swazoo SiteRegistry in VW 3.0 back >> from >> 2000: >> >> Object subclass: #SiteRegistry >> instanceVariableNames: 'sites servers ' >> classVariableNames: 'Singleton ' >> poolDictionaries: '' >> category: 'Swazoo' >> >> So, this is obviously a class variable definition and not an instance >> one. Where is the problem then? I don't find any class instance >> variables in other classes and in any way the Singleton should be only >> class variable in use in Swazoo. >> >> Best regards >> Janko -- Janko MivÅ¡ek AIDA/Web Smalltalk Web Application Server http://www.aidaweb.si

Dec. 29, 2008

Re: [Pharo-project] On not unnecessarily closing down the language

by Ramon Leon

> > Strange if this is really that then it is correct and the check in > wrong in pharo. > I will check and fix > > Stef I just did, I get no errors, this class Object subclass: #SwazooServer instanceVariableNames: 'sites servers watchdog' classVariableNames: 'Singleton' poolDictionaries: '' category: 'Swazoo-Core' Compiles just fine in Pharo, I see nothing wrong with it. Ramon Leon http://onsmalltalk.com

Dec. 29, 2008

Re: [Pharo-project] On not unnecessarily closing down the language

by StÃ©phane Ducasse

Hi janko I checked and - pharo does not complain for what seems good. So no bugs from our side. - SwazooBenchmarks seems to have an instance class variable with uppercase Singleton can you check and confirm. I tried to load beta2.2 Thanks Stef On Dec 29, 2008, at 5:16 PM, Janko MivÅ¡ek wrote: > Hi Ramon, > > Ramon Leon wrote: > >>>> Yes I contacted Janko if he can fix that > >>> I can fix of course but I'm a bit surprised that in Squeak the class >>> variables are supposed to be lower case. I have in mind back >>> from 1996 >>> that they must be uppercase. > >> Janko, I'm pretty sure Lukas was talking about a class instance >> variable, >> not a class variable. Class instance variables should be lowercase >> while >> class vars are uppercase. Swazoo apparently contains a class- >> instance >> variable that is uppercased, which regardless of the outcome of this >> discussion, should probably be fixed. > > Here is the exact definition of a Swazoo class in question: > > Object subclass: #SwazooServer > instanceVariableNames: 'sites servers watchdog' > classVariableNames: 'Singleton' > poolDictionaries: '' > category: 'Swazoo-Core' > > And here the same definition of Swazoo SiteRegistry in VW 3.0 back > from > 2000: > > Object subclass: #SiteRegistry > instanceVariableNames: 'sites servers ' > classVariableNames: 'Singleton ' > poolDictionaries: '' > category: 'Swazoo' > > So, this is obviously a class variable definition and not an instance > one. Where is the problem then? I don't find any class instance > variables in other classes and in any way the Singleton should be only > class variable in use in Swazoo. > > Best regards > Janko > > > > > -- > Janko MivÅ¡ek > Svetovalec za informatiko > Eranova d.o.o. > Ljubljana, Slovenija > www.eranova.si > tel: 01 514 22 55 > faks: 01 514 22 56 > gsm: 031 674 565 > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Dec. 29, 2008

Re: [Pharo-project] On not unnecessarily closing down the language

by StÃ©phane Ducasse

Strange if this is really that then it is correct and the check in wrong in pharo. I will check and fix Stef On Dec 29, 2008, at 5:16 PM, Janko MivÅ¡ek wrote: > Hi Ramon, > > Ramon Leon wrote: > >>>> Yes I contacted Janko if he can fix that > >>> I can fix of course but I'm a bit surprised that in Squeak the class >>> variables are supposed to be lower case. I have in mind back >>> from 1996 >>> that they must be uppercase. > >> Janko, I'm pretty sure Lukas was talking about a class instance >> variable, >> not a class variable. Class instance variables should be lowercase >> while >> class vars are uppercase. Swazoo apparently contains a class- >> instance >> variable that is uppercased, which regardless of the outcome of this >> discussion, should probably be fixed. > > Here is the exact definition of a Swazoo class in question: > > Object subclass: #SwazooServer > instanceVariableNames: 'sites servers watchdog' > classVariableNames: 'Singleton' > poolDictionaries: '' > category: 'Swazoo-Core' > > And here the same definition of Swazoo SiteRegistry in VW 3.0 back > from > 2000: > > Object subclass: #SiteRegistry > instanceVariableNames: 'sites servers ' > classVariableNames: 'Singleton ' > poolDictionaries: '' > category: 'Swazoo' > > So, this is obviously a class variable definition and not an instance > one. Where is the problem then? I don't find any class instance > variables in other classes and in any way the Singleton should be only > class variable in use in Swazoo. > > Best regards > Janko > > > > > -- > Janko MivÅ¡ek > Svetovalec za informatiko > Eranova d.o.o. > Ljubljana, Slovenija > www.eranova.si > tel: 01 514 22 55 > faks: 01 514 22 56 > gsm: 031 674 565 > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Dec. 29, 2008

Re: [Pharo-project] On not unnecessarily closing down the language

by Janko MivÅ¡ek

Hi Ramon, Ramon Leon wrote: >>> Yes I contacted Janko if he can fix that >> I can fix of course but I'm a bit surprised that in Squeak the class >> variables are supposed to be lower case. I have in mind back >> from 1996 >> that they must be uppercase. > Janko, I'm pretty sure Lukas was talking about a class instance variable, > not a class variable. Class instance variables should be lowercase while > class vars are uppercase. Swazoo apparently contains a class-instance > variable that is uppercased, which regardless of the outcome of this > discussion, should probably be fixed. Here is the exact definition of a Swazoo class in question: Object subclass: #SwazooServer instanceVariableNames: 'sites servers watchdog' classVariableNames: 'Singleton' poolDictionaries: '' category: 'Swazoo-Core' And here the same definition of Swazoo SiteRegistry in VW 3.0 back from 2000: Object subclass: #SiteRegistry instanceVariableNames: 'sites servers ' classVariableNames: 'Singleton ' poolDictionaries: '' category: 'Swazoo' So, this is obviously a class variable definition and not an instance one. Where is the problem then? I don't find any class instance variables in other classes and in any way the Singleton should be only class variable in use in Swazoo. Best regards Janko -- Janko MivÅ¡ek Svetovalec za informatiko Eranova d.o.o. Ljubljana, Slovenija www.eranova.si tel: 01 514 22 55 faks: 01 514 22 56 gsm: 031 674 565

Dec. 29, 2008

Re: [Pharo-project] On not unnecessarily closing down the language

by StÃ©phane Ducasse

Exact! And lukas is just reporting a problem with pharo since we put a check to make sure that class instance variables are lowercase and class variable are uppecased. So Janko can you check a class instance variable named Singleton that should be named singleton. Stef On Dec 29, 2008, at 4:55 PM, Ramon Leon wrote: >>> Yes I contacted Janko if he can fix that >> >> I can fix of course but I'm a bit surprised that in Squeak the class >> variables are supposed to be lower case. I have in mind back >> from 1996 >> that they must be uppercase. > > Janko, I'm pretty sure Lukas was talking about a class instance > variable, > not a class variable. Class instance variables should be lowercase > while > class vars are uppercase. Swazoo apparently contains a class-instance > variable that is uppercased, which regardless of the outcome of this > discussion, should probably be fixed. > > Ramon Leon > http://onsmalltalk.com > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Dec. 29, 2008

Re: [Pharo-project] On not unnecessarily closing down the language

by Ramon Leon

> > Yes I contacted Janko if he can fix that > > I can fix of course but I'm a bit surprised that in Squeak the class > variables are supposed to be lower case. I have in mind back > from 1996 > that they must be uppercase. Janko, I'm pretty sure Lukas was talking about a class instance variable, not a class variable. Class instance variables should be lowercase while class vars are uppercase. Swazoo apparently contains a class-instance variable that is uppercased, which regardless of the outcome of this discussion, should probably be fixed. Ramon Leon http://onsmalltalk.com

Dec. 29, 2008

Re: [Pharo-project] On not unnecessarily closing down the language

by Janko MivÅ¡ek

Hi guys, Damien, Alexandre: >>> I am aware that I am talking as someone who does not maintain cross- >>> dialect applications, but we cannot trade readability for a local in >>> time commodity. >> Sure, but we could try to make the transition easier (e.g., complain >> to Janko for the moment and wait until Pharo stable to enforce >> conventions) StÃ©phane Ducasse wrote: > Yes I contacted Janko if he can fix that I can fix of course but I'm a bit surprised that in Squeak the class variables are supposed to be lower case. I have in mind back from 1996 that they must be uppercase. I just managed to open an old VisualWorks 2.5.2 image back from 1996 and exactly, class vars should be uppercase, see this class construction template: NameOfSuperclass subclass: #NameOfClass instanceVariableNames: 'instVarName1 instVarName2' classVariableNames: 'ClassVarName1 ClassVarName2' poolDictionaries: '' category: 'Collections-Unordered' But naming them lowercase is not enforced, you just got a warning: Static variable names should be capitalized. So, it seems that Squeak changed this convention or is this just a consequence of some later developed habit? From this I suggest that Lucas's proposal is considered, but only for this case regarding the class variables. Otherwise we will have the porting problems all the time. Best regards Janko -- Janko MivÅ¡ek AIDA/Web Smalltalk Web Application Server http://www.aidaweb.si

Dec. 29, 2008

Re: [Pharo-project] Dictionary as a Set

by StÃ©phane Ducasse

On Dec 29, 2008, at 12:23 PM, Alexandre Bergel wrote: > Dear List, > > I was wondering whether I am the only one shocked when I see this: > > (Set new add: #b -> 'B'; yourself) includes: #b -> 'B' ====> true > (Set new add: #b -> 'B'; yourself) includes: 'B' ====> false this is correct > (Dictionary new add: #b -> 'B'; yourself) includes: #b -> 'B' > ====> false > (Dictionary new add: #b -> 'B'; yourself) includes: 'B' ====> true we should check the semantics of includes: > Dictionary inherits from Set. This means that if Set would have a > contract, it would break in Dictionary. > IMO, we should have > (Dictionary new add: #b -> 'B'; yourself) includes: #b -> 'B' ====> > true > (Dictionary new add: #b -> 'B'; yourself) includes: 'B' ====> false > > No? Dictionary and Set relationship is subclassing so a lot can be strange. We should fix that in Bloc. > > > Alexandre > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Dec. 29, 2008

Re: [Pharo-project] Morphic Halos

by StÃ©phane Ducasse

OK I will check for the shift because I thought it worked. On Dec 29, 2008, at 12:32 PM, Rob Rothwell wrote: > Thanks...Preferences halosEnabled did it. Shift-click doesn't seem > to work, though... > > Take care, > > Rob > > On Mon, Dec 29, 2008 at 5:18 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > > wrote: > Press shift or Preferences enableHalos > > On Dec 29, 2008, at 1:13 AM, Rob Rothwell wrote: > > So...how do I bring up a Morph's halo in Pharo now? Something > between 10196 and 10201 made the Alt-click quit working...! > > Take care, > > Rob > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >

Dec. 29, 2008