- Pharo-dev - lists.pharo.org

Re: [Pharo-project] fastDragWindowsForMorphic locks up UI

by Rob Rothwell

How did you even go about debugging this when it went all non-responsive?! Rob On Wed, May 13, 2009 at 8:06 AM, Gary Chambers <gazzaguru2(a)btinternet.com>wrote: > Have a go with the proposed fix... > http://code.google.com/p/pharo/issues/detail?id=809 > > Regards, Gary > > ----- Original Message ----- > From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> > To: <Pharo-project(a)lists.gforge.inria.fr> > Sent: Tuesday, May 12, 2009 6:12 PM > Subject: Re: [Pharo-project] fastDragWindowsForMorphic locks up UI > > > > Tx! > > > > On May 12, 2009, at 4:51 PM, Steve Wirts wrote: > > > >> I've experienced this also > >> > >> 2009/5/12 Rob Rothwell <r.j.rothwell(a)gmail.com> > >> Can someone confirm that fastDragWindowForMorphic locks up the UI in > >> 10303 as soon as you try to move a window? > >> > >> I'll log an issue if it's not just me... > >> > >> Rob > >> > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >> > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

May 13, 2009

[Pharo-project] StringTest>>testUnescapePercentsWithTextEncoding is broken

by Oscar Nierstrasz

While checking if tests for the Squeak by Example book still work under Pharo, I discovered that StringTest>>testUnescapePercentsWithTextEncoding is broken. Trying to track this down, I saw that Michael Rueger changed the last line of ShiftJISTextConverter>>nextFromStream: from ^ self toUnicode: result to: ^ self byteToUnicode: result which seems to break the test. I can't say that I understand what is going on here, but shouldn't we roll back this change? Else rewrite the test ... - on

May 13, 2009

Re: [Pharo-project] fastDragWindowsForMorphic locks up UI

by Gary Chambers

Have a go with the proposed fix... http://code.google.com/p/pharo/issues/detail?id=809 Regards, Gary ----- Original Message ----- From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> To: <Pharo-project(a)lists.gforge.inria.fr> Sent: Tuesday, May 12, 2009 6:12 PM Subject: Re: [Pharo-project] fastDragWindowsForMorphic locks up UI > Tx! > > On May 12, 2009, at 4:51 PM, Steve Wirts wrote: > >> I've experienced this also >> >> 2009/5/12 Rob Rothwell <r.j.rothwell(a)gmail.com> >> Can someone confirm that fastDragWindowForMorphic locks up the UI in >> 10303 as soon as you try to move a window? >> >> I'll log an issue if it's not just me... >> >> Rob >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

May 13, 2009

[Pharo-project] Preference to settings refactoring: #annotationPanes case

by Alain Plantec

http://code.google.com/p/pharo/issues/detail?id=810 Alain ---------------------------------------------- annotationPanes : "if true, a thin horizontal pane is used in browsers" We have 3 implementations : Old browser and MC implementation in Pharo-core and OB one in Pharo-dev. Pharo-core Old browser implementation: It first relies on the #annotation related methods. (changed: #annotation, Browser>>annotation, ChangeList>>annotation, CodeHolder>>annotation). CodeHolder>>wantsAnnotationPane is the only user of the annotationPanes preference. CodeHolder>>addOptionalAnnotationsTo: window at: fractions plus: verticalOffset is the only user of wantsAnnotationPane. It has two senders: Browser>>openAsMorphMessageEditing: and CodeHolder>>addLowerPanesTo: window at: nominalFractions with: editString. method source with #annotation gives more interesting results such as: CodeHolder>>refreshAnnotation "If the receiver has an annotation pane that does not bear unaccepted edits, refresh it" (aPane := self dependents detect: [:m | (m inheritsFromAnyIn: #('PluggableTextView' 'PluggableTextMorph' )) and: [m getTextSelector == #annotation]] ifNone: []) ifNotNil: [:aPane | aPane hasUnacceptedEdits ifFalse: [aPane update: #annotation]] other "cool" pieces of code: PluggableTextMorph>>accept .... ok := self acceptTextInModel. ok == true ifTrue: [self setText: self getText. self hasUnacceptedEdits: false. (model dependents detect: [:dep | (dep isKindOf: PluggableTextMorph) and: [dep getTextSelector == #annotation]] ifNone: []) ifNotNilDo: [:aPane | model changed: #annotation]]. ... PluggableTextMorph>>cancel self setText: self getText. self setSelection: self getSelection. getTextSelector == #annotation ifFalse: [(aPane := model dependents detect: [:dep | (dep isKindOf: PluggableTextMorph) and: [dep getTextSelector == #annotation]] ifNone: []) ifNotNil: [:aPane | model changed: #annotation]] The displayed annotation is set only when a browser or message list is opened. Then, displayed information concerns only the method on which the browser is opened or only the method FROM which sender/implementor message list is opened. The annotation is never updated even a new method is selected. Pharo-core MC implementation: MCSnapshotBrowser, MCPatchBrowser, MCMergeBrowser: display (well) annotation when a method is selected. The method author initials, the date and the time of change and the category are displayed. Note that the height of the pane is sometime too thin, depending on the height of the font. When a vertical scrollbar is shown, the pane is always too thin. The implementation relies on #annotations and #annotations: methods. #annotations implementations MCCodeTool>>annotations (subclassresponsibility) ok MCConflict>>annotations ok MCPatchBrowser>>annotations ok MCSnapshotBrowser>>annotations ok MCDefinition>>annotations and MCPatchOperation>>annotations make use of Preferences class>>defaultAnnotationRequests. Preferences class>>defaultAnnotationRequests ^ Parameters at: #MethodAnnotations ifAbsent: [self setDefaultAnnotationInfo "Preferences annotationInfo"] #annotations: implementations MCDefinition>>annotations: and MCPatchOperation>>annotations: are the same MCDefinition>>annotations: requests "Answer a string for an annotation pane, trying to fulfill the annotation requests. These might include anything that Preferences defaultAnnotationRequests might return. Which includes anything in Preferences annotationInfo To edit these, use:" "Preferences editAnnotations" ^ String streamContents: [:s | self printAnnotations: requests on: s] MCSnapshotBrowser>>annotations: stuff self changed: #annotations The displayed data is given by Preferences annotationInfo which is supposed to be adaptable with the help of a specific tool opened with Preferences editAnnotations. The annotation is well updated each time a new method is selected. I didn't succeed in making Preferences editAnnotations work. Found the implementation clean except the Preferences annotationInfo/editAnnotations part. Pharo-dev OB implementation Relies on a OBAnnotationPanel for the view and on the OBSelectionChanged announcement for the annotation update. It works well. The implementation is simple and clean (The only bad point I've found is that, as for the Pharo-core MC implementation, the height of the panel is fixed whereas it should be dynamically computed from current code font height) action: Would remove the annotationPanes preference from pharo-core and make an OBBrowser specific setting. Why: because old browser implementation is really confusing and dirty and because it do not give useful feedback to the user. Would also remove MC implementation because it is not used by default and I think that MC user do not care about it. If people want to keep it, then it should not relies on a specific setting. Anyway, the Preferences annotationInfo/editAnnotations part should be removed. Consequence: Clean/remove all annotation related code from Pharo-core. Ask OB maintainers to add an OB specific settings as follow: OBCodeBrowser class>>showAnnotationPanel <setting> ^ ShowAnnotationPanel ifNil: [ShowAnnotationPanel := (SettingManager newSetting: 'Show annotation panel') default: true; parent: #obBrowsing; description: 'If true, a thin horizontal panel is used in browsers. The annotation panel is used to display useful informations about the selected method'] I will propose a .cs for the cleaning of Pharo-core when I will know what to do with MC implementation (keep, remove, ok to keep with cleaning?). Then I will propose a .cs to OB maintainers for Pharo-dev. Alain -------------------------------------

May 13, 2009

Re: [Pharo-project] How do I get copy/paste working again?

by Adrian Lienhard

Utilities updateFromServer The following is also handy if you want to upgrade only up to a specific version: Utilities updateFromServerThroughUpdateNumber: 10300 In #10303 copy/paste works for me again. Cheers, Adrian On May 13, 2009, at 12:12 , Oscar Nierstrasz wrote: > > Is there a way to programmatically update? The Software Update menu > item does not work for me any more. > > -on > > On May 13, 2009, at 12:00, StÃ©phane Ducasse wrote: > >> did you tried ctrl instead of command because it worked before >> upgrading to 10303. >> Else apply the fix of mike to your own risk :) >> Better upgrade but I'm not sure it is working ion pharo-dev >> I should produce a new core image. >> >> <HostSystemMenusMenuItem class.michael.rueger.1.cs> >> >> Stef >> >> On May 13, 2009, at 11:46 AM, Oscar Nierstrasz wrote: >> >>> >>> Hi, >>> >>> I have the latest pharo-dev image. It does not understand copy- >>> paste. I understand this has been fixed, but software update seems >>> to >>> be broken too! >>> >>> What is the quick fix? >>> >>> Cheers, >>> - on >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

May 13, 2009

Re: [Pharo-project] How do I get copy/paste working again?

by Oscar Nierstrasz

Is there a way to programmatically update? The Software Update menu item does not work for me any more. -on On May 13, 2009, at 12:00, StÃ©phane Ducasse wrote: > did you tried ctrl instead of command because it worked before > upgrading to 10303. > Else apply the fix of mike to your own risk :) > Better upgrade but I'm not sure it is working ion pharo-dev > I should produce a new core image. > > <HostSystemMenusMenuItem class.michael.rueger.1.cs> > > Stef > > On May 13, 2009, at 11:46 AM, Oscar Nierstrasz wrote: > >> >> Hi, >> >> I have the latest pharo-dev image. It does not understand copy- >> paste. I understand this has been fixed, but software update seems >> to >> be broken too! >> >> What is the quick fix? >> >> Cheers, >> - on >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

May 13, 2009

[Pharo-project] Bug in FTPClient

by Nicolas Cellier

There are two bugs in this code: lookForCode: code ifDifferent: handleBlock "We are expecting a certain numeric code next. However, in the FTP protocol, multiple lines are allowed. If the response is multi-line, the fourth character of the first line is a $- and the last line repeats the numeric code but the code is followed by a space. So it's possible that there are more lines left of the last response that we need to throw away. We use peekForAll: so that we don't discard the next response that is not a continuation line." | headToDiscard | "check for multi-line response" (self lastResponse size > 3 and: [(self lastResponse at: 4) = $-]) ifTrue: ["Discard continuation lines." [headToDiscard _ self lastResponse first: 4. [[self stream peekForAll: headToDiscard] whileTrue: [self stream nextLine]] on: Exception do: [:ex | ^handleBlock value: nil]]]. ^ super lookForCode: code ifDifferent: handleBlock 1) it attempts to catch Exception, which is generally a bad idea. Error would be more appropriated. 2) but the whole ifTrue: conditions is a no-op: it simply creates a block that is not used. Maybe intention was: ifTrue: ["Discard continuation lines." headToDiscard := self lastResponse first: 4. [[self stream peekForAll: headToDiscard] whileTrue: [self stream nextLine]] on: Exception do: [:ex | ^handleBlock value: nil]]. Is this code used?

May 13, 2009

Re: [Pharo-project] How do I get copy/paste working again?

by StÃ©phane Ducasse

did you tried ctrl instead of command because it worked before upgrading to 10303. Else apply the fix of mike to your own risk :) Better upgrade but I'm not sure it is working ion pharo-dev I should produce a new core image. Stef On May 13, 2009, at 11:46 AM, Oscar Nierstrasz wrote: > > Hi, > > I have the latest pharo-dev image. It does not understand copy- > paste. I understand this has been fixed, but software update seems to > be broken too! > > What is the quick fix? > > Cheers, > - on > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

May 13, 2009

Re: [Pharo-project] How do I get copy/paste working again?

by Alexandre Bergel

Hi Oscar, cut and paste works with a 10303 Core and the new VM Time to time, text is paste twice, but this is not critical. Alexandre On 13 May 2009, at 11:46, Oscar Nierstrasz wrote: > > Hi, > > I have the latest pharo-dev image. It does not understand copy- > paste. I understand this has been fixed, but software update seems to > be broken too! > > What is the quick fix? > > Cheers, > - on > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

May 13, 2009

[Pharo-project] How do I get copy/paste working again?

by Oscar Nierstrasz

Hi, I have the latest pharo-dev image. It does not understand copy- paste. I understand this has been fixed, but software update seems to be broken too! What is the quick fix? Cheers, - on

May 13, 2009