- Pharo-dev - lists.pharo.org

Bloc: Safe to Store SSH Passphrase in Pharo?

by Sean P. DeNigris

https://github.com/pharo-vcs/iceberg/blob/master/README.md suggests to configure Iceberg with the "Use Custom SSH Keys" setting, part of which seems to include pasting one's SSH Key Passphrase into Pharo's settings. Is that a good idea (i.e. is that safe)? ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 31, 2017

Re: [Pharo-dev] reviewing pull request are adding new remotes

by Cyril Ferlicot

On jeu. 31 aoÃ»t 2017 at 02:15, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > Is it right, that reviewing a pull request will add the others user git > repository in my > list of remotes ? > This may make sense if I actually merge the pull into my branch. But if I > just want > to see the code, or merge it into the image, do I need that repository in > my list of > remotes ? > > > Hi, When we do a PR it's because we have a repository with code that we want to integrate in another repository. If another user of the original repository wants to review this code, he needs to reference the fork of the new code's author because this code is not yet in the original repository. So, if in Pharo you want to see/merge the code of a PR, you need the fork of the author as a remote to be able to fetch/pull the code. Once the review is finished you can delete this remote if you wish. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Aug. 31, 2017

reviewing pull request are adding new remotes

by Nicolai Hess

Is it right, that reviewing a pull request will add the others user git repository in my list of remotes ? This may make sense if I actually merge the pull into my branch. But if I just want to see the code, or merge it into the image, do I need that repository in my list of remotes ?

Aug. 31, 2017

Re: [Pharo-dev] Can not review pull request with iceberg

by Nicolai Hess

2017-08-31 1:47 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > Hi, > > I set up my fork and iceberg as it is described in > https://github.com/guillep/PharoIntegrationProcess/wiki/ > Contribute-a-fix-to-Pharo > > now I try to review a pull request from the pharo-project repository. > 1. iceberg asked for the github credientials (why ? I can view pull > request on the webinterface without beeing looged in) > 2. I unchecked the checkbox "'Do you want this credentials to be stored > for future use?'" > 3. after entering the user/password, it asked again for user and password > when selecting one entry from the pull request list, the checkbox is again > checked, so for every operation I have to uncheck the checkbox again and > again. > 4. the dialog for the credentials opens two times right after another, and > I have to enter the user/password two times > 5. now the iceberg pull request list is un-focus-able, and the main > iceberg window too. > Every mouse click on the iceberg window, just shows the world menu > > any ideas what went wrong? > > (this with pharo 7 on windows) > > If I just store the credentials, (but actually I dont really want to), I can open the pull request view. But, when browsing a single pull request, this dialog is extremly slow. Resizing the window or scrolling in the list is slow, does it reload the whole data, everytime the content gets scrolled? Finally iceber crashes, I attached the crash.dmp

Aug. 30, 2017

Can not review pull request with iceberg

by Nicolai Hess

Hi, I set up my fork and iceberg as it is described in https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to… now I try to review a pull request from the pharo-project repository. 1. iceberg asked for the github credientials (why ? I can view pull request on the webinterface without beeing looged in) 2. I unchecked the checkbox "'Do you want this credentials to be stored for future use?'" 3. after entering the user/password, it asked again for user and password when selecting one entry from the pull request list, the checkbox is again checked, so for every operation I have to uncheck the checkbox again and again. 4. the dialog for the credentials opens two times right after another, and I have to enter the user/password two times 5. now the iceberg pull request list is un-focus-able, and the main iceberg window too. Every mouse click on the iceberg window, just shows the world menu any ideas what went wrong? (this with pharo 7 on windows)

Aug. 30, 2017

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Nicolai Hess

2017-08-31 0:28 GMT+02:00 Cyril Ferlicot D. <cyril.ferlicot(a)gmail.com>: > Le 31/08/2017 Ã 00:06, Nicolai Hess a Ã©crit : > > Hi, > > > > I am now able to use iceberg on windows, thanks for the help. > > > > But I am still a bit unsure about how the review and contribution > > workflow should work. > > > > up to pharo 6 I just load a latest image, > > - load the slice from a fogbugz number and was able to review the change > > - or create a slice and upload it to the inbox > > > > in pharo 7 > > - what is the equivalent to "getting the latest image" (and being able > > to load and review a fix), > > up to pharo 6 I just > > - load the latest image in pharolauncher (or from the command line). > > - opened the inbox repository. > > - load and review change/fix > > - throw away this change (close image without save) > > - reopen that image to move on with the next item to review. > > > > Hi, > > I'll not be of a great help here since I only reviewed PR via the github > interface for now but I know that Guille wrote this guide: > https://github.com/guillep/PharoIntegrationProcess/wiki/ > Pharo-Development-Process > > There is a review process discription. > Thank you Cyril. Do we have a list of links to this and other usefull articles or how did you know about this article?

Aug. 30, 2017

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Cyril Ferlicot D.

Le 31/08/2017 Ã 00:06, Nicolai Hess a Ã©critÂ : > Hi, > > I am now able to use iceberg on windows, thanks for the help. > > But I am still a bit unsure about how the review and contribution > workflow should work. > > up to pharo 6 I just load a latest image, > - load the slice from a fogbugz number and was able to review the change > - or create a slice and upload it to the inbox > > in pharo 7 > - what is the equivalent to "getting the latest image" (and being able > to load and review a fix), > Â Â up to pharo 6 I just > Â Â Â - load the latest image in pharolauncher (or from the command line). > Â Â Â - opened the inbox repository. > Â Â Â - load and review change/fix > Â Â Â - throw away this change (close image without save) > Â Â Â - reopen that image to move on with the next item to review. > Hi, I'll not be of a great help here since I only reviewed PR via the github interface for now but I know that Guille wrote this guide: https://github.com/guillep/PharoIntegrationProcess/wiki/Pharo-Development-P… There is a review process discription. > Â Â Â But now, do I have to update my local branch for every new pull > request ? And how do I do this ? In other git project I would, I would > Â Â Â fetch upstream, checkout master, merge with upstream/master, push > the master to my fork origin > Â Â How should this be done with my pharo 7 fork ? (And do we only work > on the development brach instead of the master)? > Â > Â Â And do I this only in the command line or do I manage my fork (and > keep it up to date) from within pharo with iceberg ? > Â Â How do I actually access the pull requests from within pharo ? Maybe > I am stupid, but I just can not find it. > Â Â I would like do this steps, (as I was used to it from the prior > contribution process, by loading code from the inbox) > Â Â - Just look at the changes > Â Â - apply the changes > Â Â - throw away this changes, and move one with the next fix review > > And the same for creating a fix / pull request. Do I need to be up to > date with my own fork, or only the local copy of the pharo repository ? > Again, for pharo 6 I would just load a latest image, make my changes / > code fixes and create a slice. Save to the inbox -> done. > And looking at iceberg, I have really no clue how to upload a fix. > To create a fix you don't really need a fork totally up to date with the origin repository but it's recommended to sync once in a while to not create conflics if changes happen in the same part of the system that you'll change. The process is described here: https://github.com/guillep/PharoIntegrationProcess/wiki/Keep-your-repo-in-s… In general this will do the trick: $ git checkout development (if not already on development) $ git pull [PHARO_ORIGIN] development $ git push [FORK_ORIGIN] development > I see that other people are using the new process, and I feel a bit lost > and closed out of the pharo 7 development process, as I am at the moment > unable to understand how this work. > Are there any other resources I missed ? > > I use the new process but I already had some knowledge of git. I used it to manage team work at the university and I used it with smalltalk's projects and file tree. Also I asked a looot of questions to esteban/pavel/guille. The process need to be improved again and I still often have troubles. (I got one vm crash and two iceberg crash today while contributing for example). I try to report the maximum of my reproducible problem here: https://github.com/pharo-vcs/iceberg/issues If you see trouble with Iceberg it could be cool to give info to help to ease the contribution process. For your last question, the resources I use are mostly the wiki of Guille: https://github.com/guillep/PharoIntegrationProcess/wiki My knowledge of git and the help of people like esteban/guille/pavel/marcusâ¦ I hope some of those resources can help you. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Aug. 30, 2017

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Nicolai Hess

Hi, I am now able to use iceberg on windows, thanks for the help. But I am still a bit unsure about how the review and contribution workflow should work. up to pharo 6 I just load a latest image, - load the slice from a fogbugz number and was able to review the change - or create a slice and upload it to the inbox in pharo 7 - what is the equivalent to "getting the latest image" (and being able to load and review a fix), up to pharo 6 I just - load the latest image in pharolauncher (or from the command line). - opened the inbox repository. - load and review change/fix - throw away this change (close image without save) - reopen that image to move on with the next item to review. But now, do I have to update my local branch for every new pull request ? And how do I do this ? In other git project I would, I would fetch upstream, checkout master, merge with upstream/master, push the master to my fork origin How should this be done with my pharo 7 fork ? (And do we only work on the development brach instead of the master)? And do I this only in the command line or do I manage my fork (and keep it up to date) from within pharo with iceberg ? How do I actually access the pull requests from within pharo ? Maybe I am stupid, but I just can not find it. I would like do this steps, (as I was used to it from the prior contribution process, by loading code from the inbox) - Just look at the changes - apply the changes - throw away this changes, and move one with the next fix review And the same for creating a fix / pull request. Do I need to be up to date with my own fork, or only the local copy of the pharo repository ? Again, for pharo 6 I would just load a latest image, make my changes / code fixes and create a slice. Save to the inbox -> done. And looking at iceberg, I have really no clue how to upload a fix. I see that other people are using the new process, and I feel a bit lost and closed out of the pharo 7 development process, as I am at the moment unable to understand how this work. Are there any other resources I missed ? 2017-08-11 19:30 GMT+02:00 Stephane Ducasse <stepharo.self(a)gmail.com>: > Nicolai > > I started super simple. I clone and point my fresh dled image to the use > the clone. > Then I can do simple PR and review the issues. > I will do the installation several times to learn (but not clone). > > I'm not sure that it is needed but I have > cd /Users/ducasse/Library/Preferences/pharo/7.0 > > StartupPreferencesLoader default executeAtomicItems: { > StartupAction > name: 'Git Settings' > code: [ > FileStream stdout > cr; nextPutAll: 'Setting the ssh > credentials'; cr. > Iceberg enableMetacelloIntegration: true. > IceCredentialsProvider useCustomSsh: true. > IceCredentialsProvider sshCredentials > username: 'git'; > publicKey: > '/Users/ducasse/.ssh/id_rsa.pub'; > privateKey: > '/Users/ducasse/.ssh/id_rsa'. > IceCredentialsProvider > plaintextCredentials: > (IcePlaintextCredentials new username: 'Ducasse'; password: 'xxxx' ; > yourself ). > FileStream stdout > cr; nextPutAll: 'Finished'; cr ]. > }. > > > > On Fri, Aug 11, 2017 at 9:46 AM, Guillermo Polito < > guillermopolito(a)gmail.com> wrote: > >> I extended the document with some windows specific instructions also. >> >> On Fri, Aug 11, 2017 at 9:31 AM, Guillermo Polito < >> guillermopolito(a)gmail.com> wrote: >> >>> >>> >>> On Fri, Aug 11, 2017 at 12:34 AM, Nicolai Hess <nicolaihess(a)gmail.com> >>> wrote: >>> >>>> >>>> >>>> 2017-08-10 17:17 GMT+02:00 Guillermo Polito <guillermopolito(a)gmail.com> >>>> : >>>> >>>>> Hi, >>>>> >>>>> I've made some write up for the pharo part (not metacello or external >>>>> projects) >>>>> >>>>> https://github.com/guillep/PharoIntegrationProcess/wiki/Cont >>>>> ribute-a-fix-to-Pharo >>>>> >>>>> Of course, expect bugs on it :) Not everything is smooth. If you have >>>>> comments, they are welcome. >>>>> >>>> >>>> >>>> >>>> [image: Inline-Bild 1] >>>> >>>> >>>> In option 2, I think this should be "Click on the Edit button", >>>> >>> >>> Thanks, fixed! >>> >>>> >>>> >>>> >>>> >>>>> >>>>> Guille >>>>> >>>>> -- >>>>> >>>>> >>>>> >>>>> Guille Polito >>>>> >>>>> >>>>> Research Engineer >>>>> >>>>> French National Center for Scientific Research - *http://www.cnrs.fr* >>>>> <http://www.cnrs.fr> >>>>> >>>>> >>>>> >>>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>>> >>>>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>>>> >>>> >>>> >>> >>> >>> -- >>> >>> >>> >>> Guille Polito >>> >>> >>> Research Engineer >>> >>> French National Center for Scientific Research - *http://www.cnrs.fr* >>> <http://www.cnrs.fr> >>> >>> >>> >>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>> >>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>> >> >> >> >> -- >> >> >> >> Guille Polito >> >> >> Research Engineer >> >> French National Center for Scientific Research - *http://www.cnrs.fr* >> <http://www.cnrs.fr> >> >> >> >> *Web:* *http://guillep.github.io* <http://guillep.github.io> >> >> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >> > >

Aug. 30, 2017

Re: [Pharo-dev] [Vm-dev] [ANN] Lowtalk, a new Smalltalk dialect that could eventually replace Slang

by Bernardo Ezequiel Contreras

that's a crazy amount of work, congrats!

Aug. 30, 2017

Re: [Pharo-dev] [pharo-project/pharo] 20355-Make-SUnit-Tests-green-on-bootstrapped-image (#230)

by pavel-krivanek

Merged #230. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pharo-project/pharo/pull/230#event-1228400184

Aug. 30, 2017