- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Stephane Ducasse

Hi nicolai here is what I do. I always download the latest image via a bash script because updating can fail since loading package without a baseline may break. After I use the set up described by guille blog post and I reuse my downloaded clone (to avoid to trash my SSD). Esteban told me that he will do a video: - for producing a PR - for reviewing Stef On Thu, Aug 31, 2017 at 12:06 AM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > Hi, > > I am now able to use iceberg on windows, thanks for the help. > > But I am still a bit unsure about how the review and contribution workflow > should work. > > up to pharo 6 I just load a latest image, > - load the slice from a fogbugz number and was able to review the change > - or create a slice and upload it to the inbox > > in pharo 7 > - what is the equivalent to "getting the latest image" (and being able to > load and review a fix), > up to pharo 6 I just > - load the latest image in pharolauncher (or from the command line). > - opened the inbox repository. > - load and review change/fix > - throw away this change (close image without save) > - reopen that image to move on with the next item to review. > > But now, do I have to update my local branch for every new pull > request ? And how do I do this ? In other git project I would, I would > fetch upstream, checkout master, merge with upstream/master, push the > master to my fork origin > How should this be done with my pharo 7 fork ? (And do we only work on > the development brach instead of the master)? > > And do I this only in the command line or do I manage my fork (and keep > it up to date) from within pharo with iceberg ? > How do I actually access the pull requests from within pharo ? Maybe I > am stupid, but I just can not find it. > I would like do this steps, (as I was used to it from the prior > contribution process, by loading code from the inbox) > - Just look at the changes > - apply the changes > - throw away this changes, and move one with the next fix review > > And the same for creating a fix / pull request. Do I need to be up to date > with my own fork, or only the local copy of the pharo repository ? > Again, for pharo 6 I would just load a latest image, make my changes / > code fixes and create a slice. Save to the inbox -> done. > And looking at iceberg, I have really no clue how to upload a fix. > > I see that other people are using the new process, and I feel a bit lost > and closed out of the pharo 7 development process, as I am at the moment > unable to understand how this work. > Are there any other resources I missed ? > > > > > 2017-08-11 19:30 GMT+02:00 Stephane Ducasse <stepharo.self(a)gmail.com>: > >> Nicolai >> >> I started super simple. I clone and point my fresh dled image to the use >> the clone. >> Then I can do simple PR and review the issues. >> I will do the installation several times to learn (but not clone). >> >> I'm not sure that it is needed but I have >> cd /Users/ducasse/Library/Preferences/pharo/7.0 >> >> StartupPreferencesLoader default executeAtomicItems: { >> StartupAction >> name: 'Git Settings' >> code: [ >> FileStream stdout >> cr; nextPutAll: 'Setting the ssh >> credentials'; cr. >> Iceberg enableMetacelloIntegration: true. >> IceCredentialsProvider useCustomSsh: true. >> IceCredentialsProvider sshCredentials >> username: 'git'; >> publicKey: >> '/Users/ducasse/.ssh/id_rsa.pub'; >> privateKey: >> '/Users/ducasse/.ssh/id_rsa'. >> IceCredentialsProvider >> plaintextCredentials: >> (IcePlaintextCredentials new username: 'Ducasse'; password: 'xxxx' ; >> yourself ). >> FileStream stdout >> cr; nextPutAll: 'Finished'; cr ]. >> }. >> >> >> >> On Fri, Aug 11, 2017 at 9:46 AM, Guillermo Polito < >> guillermopolito(a)gmail.com> wrote: >> >>> I extended the document with some windows specific instructions also. >>> >>> On Fri, Aug 11, 2017 at 9:31 AM, Guillermo Polito < >>> guillermopolito(a)gmail.com> wrote: >>> >>>> >>>> >>>> On Fri, Aug 11, 2017 at 12:34 AM, Nicolai Hess <nicolaihess(a)gmail.com> >>>> wrote: >>>> >>>>> >>>>> >>>>> 2017-08-10 17:17 GMT+02:00 Guillermo Polito <guillermopolito(a)gmail.com >>>>> >: >>>>> >>>>>> Hi, >>>>>> >>>>>> I've made some write up for the pharo part (not metacello or external >>>>>> projects) >>>>>> >>>>>> https://github.com/guillep/PharoIntegrationProcess/wiki/Cont >>>>>> ribute-a-fix-to-Pharo >>>>>> >>>>>> Of course, expect bugs on it :) Not everything is smooth. If you have >>>>>> comments, they are welcome. >>>>>> >>>>> >>>>> >>>>> >>>>> [image: Inline-Bild 1] >>>>> >>>>> >>>>> In option 2, I think this should be "Click on the Edit button", >>>>> >>>> >>>> Thanks, fixed! >>>> >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> Guille >>>>>> >>>>>> -- >>>>>> >>>>>> >>>>>> >>>>>> Guille Polito >>>>>> >>>>>> >>>>>> Research Engineer >>>>>> >>>>>> French National Center for Scientific Research - *http://www.cnrs.fr* >>>>>> <http://www.cnrs.fr> >>>>>> >>>>>> >>>>>> >>>>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>>>> >>>>>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> >>>> >>>> Guille Polito >>>> >>>> >>>> Research Engineer >>>> >>>> French National Center for Scientific Research - *http://www.cnrs.fr* >>>> <http://www.cnrs.fr> >>>> >>>> >>>> >>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>> >>>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>>> >>> >>> >>> >>> -- >>> >>> >>> >>> Guille Polito >>> >>> >>> Research Engineer >>> >>> French National Center for Scientific Research - *http://www.cnrs.fr* >>> <http://www.cnrs.fr> >>> >>> >>> >>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>> >>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>> >> >> >

Aug. 31, 2017

Re: [Pharo-dev] Pinning Objects in Pharo

by Stephane Ducasse

thanks for the explanation. I think that we should add a shorter version to the pin method. On Wed, Aug 30, 2017 at 5:46 PM, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > Hi Torsten, Hi All, > > re pinDuring: > >> On Aug 28, 2017, at 9:17 AM, Torsten Bergmann <astares(a)gmx.de> wrote: >> >> As some of you are aware of Spur added memory pinning and in Pharo 6.1 (#60510) as well as Pharo 7 >> we currently have >> >> Object>>pin >> Object>>unpin >> Object>>isPinned >> >> and also Object>>setPinned:. >> >> Object pinning is explained by Eliot here [1]. >> >> I would propose two changes (at least for Pharo but ideally also for Squeak): >> >> 1. IMHO #setPinned: should be moved to a private protocol >> 2. Provide a #pinDuring: aBlock method like: >> >> pinDuring: aBlock >> [ self pin. >> aBlock value ] ensure: [ self unpin ] >> >> so we can ensure that a pinned object is unpinned after an operation. > > From an implementation perspective, I suspect this is unnecessary. There are two reasons, one to do with collecting pinned objects and the other to do with compaction. > > Pinning an object forces it into oldSpace if it was not there already, but does not prevent it being garbage collected. So any un references pinned object in oldSpace will be collected at the next full GC. > > It is possible (but in implemented) to move not large objects back to newSpace but the forwarder left in oldSpace will prevent its collection until the next full GC so trying to move an object back into newSpace is pointless. Conclusion, there is no point unpinning for garbage collectability. > > The compactor does a good job of moving unpinned objects around pinned objects, typically leaving very small gaps before pinned objects. [One can observe how much free space exists in an image file to get an idea of how much free space this causes. It's low]. The number of uncollectable pinned objects in an application, which will be objects that are long-lived that have been passed through the FFI, is likely to be small. Conclusion there is little to be gained in avoiding fragmentation by unpinning long-lived objects pinned on an FFI call. > > > In summary, collectible ones objects will be collected anyway, and the few long-lived pinned objects should not cause significant fragmentation. So pinDuring: is unlikely to provide any benefit. Simply pin and leave it to the GC and its compactor to clean up afterwards. > >> What do you think? >> >> Also I wonder why FFICallbackTests>>#testCqsortWithByteArray is sending #pin but not >> #unpin afterwards. Maybe that is the reason why there is a flag in this method that it >> is crashing on Windows. >> >> Bye >> T. >> >> [1] http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-August/195129.h… >

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Stephane Ducasse

On Thu, Aug 31, 2017 at 11:23 AM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > you are all confused :) > > Sean talks about storing the passphrase for SSH, not the HTTPS user/pass. > Nevertheless both, passphrase and user/pass needs to be stored on Pharo and > then they are not safe. > > Now, how can we reliable store passwords in Pharo? > This is a good thing we need to solve before blame Iceberg :P > > So far, we can do just two things to avoid this problem: > > - do not store the passwords on Pharo, which means we need to introduce them > each time we use it (not very confortableâ¦ and btw this can be not working > on ssh mode, I didnât test). can we store them in the starting preferences? > - use ssh keys without password protection. I have to be honest: since I > never used password protection of ssh keys in my life, I never seen this > problem until Norbert pointed it to me :P > > I will be glad to have a general solution for password storing in Pharo. > But that would be like creating a keychain, isnât? > Also, the openness of our system makes the problem even harderâ¦ :S > > cheers, > Esteban > > On 31 Aug 2017, at 10:29, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > But ssh agent not working for you? > > I work with Iceberg without extra configuration in image. No problems for > me. But I am on Mac. > So image now only keeps github password for pull requests. > > (Only problem with latest Mac update is that I am now manually add ssh keys > after any reboot: ssh-add -A). > > 2017-08-31 3:32 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: >> >> https://github.com/pharo-vcs/iceberg/blob/master/README.md suggests to >> configure Iceberg with the "Use Custom SSH Keys" setting, part of which >> seems to include pasting one's SSH Key Passphrase into Pharo's settings. >> Is >> that a good idea (i.e. is that safe)? >> >> >> >> ----- >> Cheers, >> Sean >> -- >> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >> > >

Aug. 31, 2017

Re: [Pharo-dev] slow Pharo downloading and Travis

by Marcus Denker

> On 31 Aug 2017, at 16:56, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > Peter UhnÃ¡k wrote >> over the past week+ downloading the latest Pharo 6 version has been >> extremely slow -- 5+ minutes to download the zip. > > I don't know if this is related, but Launcher just took several minutes to > "Fetch source files for Pharo 6.0" when I tried to launch an imageâ¦ > > I know have opened a ticket to see if the admins know of any Inria related networking issues. Marcus

Aug. 31, 2017

Re: [Pharo-dev] slow Pharo downloading and Travis

by Sean P. DeNigris

Peter UhnÃ¡k wrote > over the past week+ downloading the latest Pharo 6 version has been > extremely slow -- 5+ minutes to download the zip. I don't know if this is related, but Launcher just took several minutes to "Fetch source files for Pharo 6.0" when I tried to launch an imageâ¦ ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Sean P. DeNigris

Oops, misfire. Let me try that againâ¦ Peter UhnÃ¡k wrote > Just about as safe as storing credentials for SmalltalkHub. (and to be > fair, STHub is even worse in that the connection is not encrypted. Imagine > someone observing traffic on PharoDays/ESUG conf.) That is exactly why I originally moved all my projects to GitHub and have tried to fork as many of the outside projects I use there as well (of course the fork part is practically impossible to keep up). ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Sean P. DeNigris

Peter UhnÃ¡k wrote > Just about as safe as storing credentials for SmalltalkHub. (and to be > fair, STHub is even worse in that the connection is not encrypted. Imagine > someone observing traffic on PharoDays/ESUG conf.) ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Norbert Hartl

> Am 31.08.2017 um 12:52 schrieb Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > > So you do not put passphrases on your ssh keys? > > Not always. > > Because you don't give the private key away why protect it? So imagine you have development process that includes a jenkins that needs to build the source and therefor needs access to the repository. What do you do? > > I give it a password-less ssh key, encrypted in some manner. (I do not know what Jenkins offers, but both Travis and GitLab(Runner) support file/data encryption.) > Adding the build server a password on top of the key would make no difference. If you have access to one, you have the access to the other. > So deal with it outside of the image. It is the same situation as a sandbox and key chain access. Exactly what I was meaning. Norbert

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Tim Mackinnon

To further her add to what Peter is saying - in GitLab you can add secret variables (which are encrypted) and can be referenced only during the build process. So you can call your image with the value of one of these variables. Which is fine if you don't persist the value. I'm wondering if we have a concept of "transient" variables that don't persist on image save? Then iceberg could use one of those, and expect you to pass that value through on the command line of Pharo? I was toying with the idea of having an encrypted vault in my image (to hold multiple values for convenience) and I would then pass an unlock value on the command line - but I would need some way to ensure that value isn't persisted? Is this where a plugin might help? Something to save a value transiently only during image execution? Tim Sent from my iPhone On 31 Aug 2017, at 12:52, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: >> So you do not put passphrases on your ssh keys? > > Not always. > >> Because you don't give the private key away why protect it? So imagine you have development process that includes a jenkins that needs to build the source and therefor needs access to the repository. What do you do? > > I give it a password-less ssh key, encrypted in some manner. (I do not know what Jenkins offers, but both Travis and GitLab(Runner) support file/data encryption.) > Adding the build server a password on top of the key would make no difference. If you have access to one, you have the access to the other. > > Peter >

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Peter UhnÃ¡k

> > So you do not put passphrases on your ssh keys? > Not always. > Because you don't give the private key away why protect it? So imagine you > have development process that includes a jenkins that needs to build the > source and therefor needs access to the repository. What do you do? > I give it a password-less ssh key, encrypted in some manner. (I do not know what Jenkins offers, but both Travis and GitLab(Runner) support file/data encryption.) Adding the build server a password on top of the key would make no difference. If you have access to one, you have the access to the other. Peter

Aug. 31, 2017