- Pharo-dev - lists.pharo.org

Re: [Pharo-project] SUnit assert:equals:

by Michael Roberts

If you are adding this it would be good to either add or review existing implementation that checks the comparison is within a tolerance. This would be for asserting double values are close but not necessarily exact. I would rather we didn't get double comparison going through this method you describe which would be easy to do. Thanks mike On Tuesday, July 7, 2009, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Yes! > May be one day we will arrive to use packages published in other > places but right now > critical elements should be in one project. > Oscar if you see other good addition please push them too. > > Stef > > PS: I do not why I can open MC repositories but I cannot publish there. > > > On Jul 7, 2009, at 6:56 PM, Oscar Nierstrasz wrote: > >> >> Apparently http://squeaksource.com/Testing/ already contains such a >> method, but sticks to the java convention. Regardless of which is >> better, it would be a bad idea to introduce an identically named >> method which reverse the argument order, so I suggest we stick to the >> implementation in the repository. >> >> !TestCase methodsFor: 'accessing' stamp: 'dc 4/2/2007 18:38'! >> assert: expected equals: actual >> Â Â Â ^ self >> Â Â Â Â Â Â Â assert: (expected = actual) >> Â Â Â Â Â Â Â description: (self comparingStringBetween: expected and: actual) >> ! ! >> >> >> !TestCase methodsFor: 'private' stamp: 'dc 4/2/2007 18:46'! >> comparingStringBetween: expected and: actual >> Â Â Â ^ String streamContents: [:stream | >> Â Â Â Â Â Â Â stream >> Â Â Â Â Â Â Â Â Â Â Â nextPutAll: 'Expected '; >> Â Â Â Â Â Â Â Â Â Â Â nextPutAll: (expected printStringLimitedTo: 10); >> Â Â Â Â Â Â Â Â Â Â Â nextPutAll: ' but was '; >> Â Â Â Â Â Â Â Â Â Â Â nextPutAll: (actual printStringLimitedTo: 10); >> Â Â Â Â Â Â Â Â Â Â Â nextPutAll: '.' >> Â Â Â Â Â Â Â ]! ! >> >> I would really like these methods in Pharo. Â dc is Damien Cassou, so >> this is license clean, I guess. >> >> Shall I publish just these methods to PharoInbox? >> >> - on >> >> On 7 Jul 2009, at 18:44, Oscar Nierstrasz wrote: >> >>> >>> OK, have posted issue 939 and will post the change shortly ... >>> >>> http://code.google.com/p/pharo/issues/detail?id=939 >>> >>> TestCase>>assert: actual equals: expected >>> Â Â Â actual = expected ifFalse: [self signalFailure: 'Assertion failed. >>> Expected: ' , expected printString >>> , '; got: ' , actual printString] >>> >>> Is it better to send asString or printString? >>> >>> - on >>> >>> On 7 Jul 2009, at 17:11, StÃ©phane Ducasse wrote: >>> >>>> please go ahead. >>>> I thought we got assert:equals: >>>> >>>> >>>> Somebody should also have a look at SUnitExtensions one of these >>>> days. >>>> >>>> On Jul 7, 2009, at 3:58 PM, Oscar Nierstrasz wrote: >>>> >>>>> >>>>> Hi Folks, >>>>> >>>>> I seem to recall that we added TestCase>>assert:eauals: to SUnit, >>>>> but >>>>> now I cannot find it. >>>>> >>>>> It would be really useful to get decent error messages from >>>>> equality >>>>> tests (instead of "test failed", we would get "expected X but got >>>>> Y"). >>>>> >>>>> Does anyone know what the story is? >>>>> >>>>> If it exists somewhere, I would like to add it to Pharo. >>>>> >>>>> If it doesn't exist anywhere, I would like to add it to Pharo. >>>>> >>>>> - on >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/Â <http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project>

July 7, 2009

Re: [Pharo-project] Fwd: about sensor vs. InputSensor in primitiveError:

by Michael Rueger

StÃ©phane Ducasse wrote: >> >> should not this method use InputSensor? Sensor is a global pointing to the current sensor instance. Michael P.S. We should remove the old Sensor classes to avoid confusion. >> >> primitiveError: aString >> "This method is called when the error handling results in a >> recursion in >> calling on error: or halt or halt:." >> >> | context | >> (String >> streamContents: >> [:s | >> s nextPutAll: '***System error handling failed***'. >> s cr; nextPutAll: aString. >> context := thisContext sender sender. >> 20 timesRepeat: [context == nil ifFalse: [s cr; print: >> (context := context sender)]]. >> s cr; nextPutAll: '-------------------------------'. >> s cr; nextPutAll: 'Type CR to enter an emergency evaluator.'. >> s cr; nextPutAll: 'Type any other character to restart.']) >> displayAt: 0 @ 0. >> [Sensor keyboardPressed] whileFalse. >> Sensor keyboard = Character cr ifTrue: [Transcripter >> emergencyEvaluator]. >> World install "init hands and redisplay" >> >> >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

July 7, 2009

Re: [Pharo-project] Fwd: issue 348

by StÃ©phane Ducasse

pavel I was wondering why you want to have interactiveParserFor: in UIManager and not in Compiler? May be I missed something but I'm ready to learn. Stef On Jul 7, 2009, at 7:18 PM, StÃ©phane Ducasse wrote: > > From: Pavel Krivanek <pavel.krivanek(a)gmail.com> > Date: July 6, 2009 2:26:56 PM CEDT > To: stephane ducasse <stephane.ducasse(a)free.fr> > Subject: issue 348 > > Hi Stef, > > I updated the issue http://code.google.com/p/pharo/issues/detail? > id=348 > > Cheers, > -- Pavel > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

July 7, 2009

[Pharo-project] Fwd: issue 348

by StÃ©phane Ducasse

From: Pavel Krivanek <pavel.krivanek(a)gmail.com> Date: July 6, 2009 2:26:56 PM CEDT To: stephane ducasse <stephane.ducasse(a)free.fr> Subject: issue 348 Hi Stef, I updated the issue http://code.google.com/p/pharo/issues/detail?id=348 Cheers, -- Pavel

July 7, 2009

[Pharo-project] Fwd: about sensor vs. InputSensor in primitiveError:

by StÃ©phane Ducasse

> > > should not this method use InputSensor? > > primitiveError: aString > "This method is called when the error handling results in a > recursion in > calling on error: or halt or halt:." > > | context | > (String > streamContents: > [:s | > s nextPutAll: '***System error handling failed***'. > s cr; nextPutAll: aString. > context := thisContext sender sender. > 20 timesRepeat: [context == nil ifFalse: [s cr; print: > (context := context sender)]]. > s cr; nextPutAll: '-------------------------------'. > s cr; nextPutAll: 'Type CR to enter an emergency evaluator.'. > s cr; nextPutAll: 'Type any other character to restart.']) > displayAt: 0 @ 0. > [Sensor keyboardPressed] whileFalse. > Sensor keyboard = Character cr ifTrue: [Transcripter > emergencyEvaluator]. > World install "init hands and redisplay" > > >

July 7, 2009

Re: [Pharo-project] SUnit assert:equals:

by StÃ©phane Ducasse

Yes! May be one day we will arrive to use packages published in other places but right now critical elements should be in one project. Oscar if you see other good addition please push them too. Stef PS: I do not why I can open MC repositories but I cannot publish there. On Jul 7, 2009, at 6:56 PM, Oscar Nierstrasz wrote: > > Apparently http://squeaksource.com/Testing/ already contains such a > method, but sticks to the java convention. Regardless of which is > better, it would be a bad idea to introduce an identically named > method which reverse the argument order, so I suggest we stick to the > implementation in the repository. > > !TestCase methodsFor: 'accessing' stamp: 'dc 4/2/2007 18:38'! > assert: expected equals: actual > ^ self > assert: (expected = actual) > description: (self comparingStringBetween: expected and: actual) > ! ! > > > !TestCase methodsFor: 'private' stamp: 'dc 4/2/2007 18:46'! > comparingStringBetween: expected and: actual > ^ String streamContents: [:stream | > stream > nextPutAll: 'Expected '; > nextPutAll: (expected printStringLimitedTo: 10); > nextPutAll: ' but was '; > nextPutAll: (actual printStringLimitedTo: 10); > nextPutAll: '.' > ]! ! > > I would really like these methods in Pharo. dc is Damien Cassou, so > this is license clean, I guess. > > Shall I publish just these methods to PharoInbox? > > - on > > On 7 Jul 2009, at 18:44, Oscar Nierstrasz wrote: > >> >> OK, have posted issue 939 and will post the change shortly ... >> >> http://code.google.com/p/pharo/issues/detail?id=939 >> >> TestCase>>assert: actual equals: expected >> actual = expected ifFalse: [self signalFailure: 'Assertion failed. >> Expected: ' , expected printString >> , '; got: ' , actual printString] >> >> Is it better to send asString or printString? >> >> - on >> >> On 7 Jul 2009, at 17:11, StÃ©phane Ducasse wrote: >> >>> please go ahead. >>> I thought we got assert:equals: >>> >>> >>> Somebody should also have a look at SUnitExtensions one of these >>> days. >>> >>> On Jul 7, 2009, at 3:58 PM, Oscar Nierstrasz wrote: >>> >>>> >>>> Hi Folks, >>>> >>>> I seem to recall that we added TestCase>>assert:eauals: to SUnit, >>>> but >>>> now I cannot find it. >>>> >>>> It would be really useful to get decent error messages from >>>> equality >>>> tests (instead of "test failed", we would get "expected X but got >>>> Y"). >>>> >>>> Does anyone know what the story is? >>>> >>>> If it exists somewhere, I would like to add it to Pharo. >>>> >>>> If it doesn't exist anywhere, I would like to add it to Pharo. >>>> >>>> - on >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

July 7, 2009

Re: [Pharo-project] SUnit assert:equals:

by Oscar Nierstrasz

Apparently http://squeaksource.com/Testing/ already contains such a method, but sticks to the java convention. Regardless of which is better, it would be a bad idea to introduce an identically named method which reverse the argument order, so I suggest we stick to the implementation in the repository. !TestCase methodsFor: 'accessing' stamp: 'dc 4/2/2007 18:38'! assert: expected equals: actual ^ self assert: (expected = actual) description: (self comparingStringBetween: expected and: actual) ! ! !TestCase methodsFor: 'private' stamp: 'dc 4/2/2007 18:46'! comparingStringBetween: expected and: actual ^ String streamContents: [:stream | stream nextPutAll: 'Expected '; nextPutAll: (expected printStringLimitedTo: 10); nextPutAll: ' but was '; nextPutAll: (actual printStringLimitedTo: 10); nextPutAll: '.' ]! ! I would really like these methods in Pharo. dc is Damien Cassou, so this is license clean, I guess. Shall I publish just these methods to PharoInbox? - on On 7 Jul 2009, at 18:44, Oscar Nierstrasz wrote: > > OK, have posted issue 939 and will post the change shortly ... > > http://code.google.com/p/pharo/issues/detail?id=939 > > TestCase>>assert: actual equals: expected > actual = expected ifFalse: [self signalFailure: 'Assertion failed. > Expected: ' , expected printString > , '; got: ' , actual printString] > > Is it better to send asString or printString? > > - on > > On 7 Jul 2009, at 17:11, StÃ©phane Ducasse wrote: > >> please go ahead. >> I thought we got assert:equals: >> >> >> Somebody should also have a look at SUnitExtensions one of these >> days. >> >> On Jul 7, 2009, at 3:58 PM, Oscar Nierstrasz wrote: >> >>> >>> Hi Folks, >>> >>> I seem to recall that we added TestCase>>assert:eauals: to SUnit, >>> but >>> now I cannot find it. >>> >>> It would be really useful to get decent error messages from equality >>> tests (instead of "test failed", we would get "expected X but got >>> Y"). >>> >>> Does anyone know what the story is? >>> >>> If it exists somewhere, I would like to add it to Pharo. >>> >>> If it doesn't exist anywhere, I would like to add it to Pharo. >>> >>> - on >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >

July 7, 2009

Re: [Pharo-project] SUnit assert:equals:

by StÃ©phane Ducasse

> OK, have posted issue 939 and will post the change shortly ... > > http://code.google.com/p/pharo/issues/detail?id=939 > > TestCase>>assert: actual equals: expected > actual = expected ifFalse: [self signalFailure: 'Assertion failed. > Expected: ' , expected printString > , '; got: ' , actual printString] > > Is it better to send asString or printString? printString I imagine. > > - on > > On 7 Jul 2009, at 17:11, StÃ©phane Ducasse wrote: > >> please go ahead. >> I thought we got assert:equals: >> >> >> Somebody should also have a look at SUnitExtensions one of these >> days. >> >> On Jul 7, 2009, at 3:58 PM, Oscar Nierstrasz wrote: >> >>> >>> Hi Folks, >>> >>> I seem to recall that we added TestCase>>assert:eauals: to SUnit, >>> but >>> now I cannot find it. >>> >>> It would be really useful to get decent error messages from equality >>> tests (instead of "test failed", we would get "expected X but got >>> Y"). >>> >>> Does anyone know what the story is? >>> >>> If it exists somewhere, I would like to add it to Pharo. >>> >>> If it doesn't exist anywhere, I would like to add it to Pharo. >>> >>> - on >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

July 7, 2009

Re: [Pharo-project] Just a little point

by Miguel CobÃ¡

On Tue, Jul 7, 2009 at 11:28 AM, Keith Hodges<keith_hodges(a)yahoo.co.uk> wrote: > Keith Hodges wrote: >>> so I'm laughing when people suggest that we are predators. >>> >>> >> I am still counting your contributions back to the packages which you >> are using, which are public domain, and have public repositories... >> >> answer zero >> >> > Its not even a technical issue, you have chosen a philosophically > predatory stance from the outset. > > "We will make our own image, without any concern for giving back to > those who made it possible" The number of times I have heard, we are > changing this that or the other, and if you want the improvement "you > can port it if you want to", completely illustrates my point. > > Those who made the contributions that you are using probably expected > that any improvements to their efforts would be fed back to them in a > form that they could make use of. This is a priori discarded because of the MIT license. If you don't want this kind of behavior, the GPL/LGPL licenses exists for this very exact situation. With MIT you can't force retributions back. > > It is the main reason for companies to make their code open source, > because they anticipate some reciprocation from those who benefit, and > thus the benefit is mutual, and might offset the considerable cost of > development. > I don't think so. And when they do so, the choose other license. Take the Java case. It is not MIT, but GPL. This is so that MS, IBM and other can't run away with the code with giving back. Again, the license establish the rights and obligations of the receiving party. > And in case you are wondering, the public repository for the community > to work towards improving SUnit, > Â ( squeaksource/Testing ) does include > > #assert:equals: > > Keith > Miguel CobÃ¡ > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

July 7, 2009

Re: [Pharo-project] Just a little point

by Miguel CobÃ¡

Hey Keith, please stop this whole fighting attitude. In squeak-dev you're fighting vs Andreas, here you're trying to do the same with Stephane. Maybe you don't give a book the same value that source code, but Squeak by example it is as valuable or maybe more than code than others (including you and of course me) are written. Why, because it is the obligated first stop in learning squeak/smalltalk. At least for me it was. This kind of mails don't add anything to the smalltalk arena. Live your life, do your things and let others do that they want (books, code, forks, whatever). Not every people can be measured by your own standards. *I* personally admire you by your code (seaside helpers and installer) and hope someday can write something as useful like that, but these days the mails sent to the list by a lot of squeak/pharo members have exposed others facets not as remarkable as the technical ones of the senders. So, let this whole thing behind and lets continue with the great job *everyone* is doing in his own field. With all respect, Miguel CobÃ¡ On Tue, Jul 7, 2009 at 11:14 AM, Keith Hodges<keith_hodges(a)yahoo.co.uk> wrote: > >> so I'm laughing when people suggest that we are predators. >> > I am still counting your contributions back to the packages which you > are using, which are public domain, and have public repositories... > > answer zero > > Keith > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

July 7, 2009