- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Nicolas Cellier

2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: > > On Oct 5, 2009, at 3:19 53PM, Nicolas Cellier wrote: > >> 2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: >>> Good to know I'm not the only one who found it strange :) >>> >>> BTW, I thought the default for Collections was to do a shallowCopy >>> with a copy operation? >>> >> >> I removed this default behaviour SequenceableCollection>>shallowCopy >> which used to use (self copyFrom: 1 to: self size). >> This beautifull hack was using self species, leading to this mess... >> And it forced me defining a #basicShallowCopy to work the hack around >> (which was the shortest but uggliest solution). >> >> The copy was deep enough so that modifying the copy would not modify >> the original, and this is what postCopy now does. >> >>> ll := LinkedList new. >>> ll add: Link new. >>> ll2 := ll copy. >>> ll add: Link new. >>> >>> inspecting ll2, it's firstLink does not have a nextLink, which >>> implies >>> to me a deepCopy has occured. >>> >> | list link1 link2 link3 copy | link1 := StackLink with: 1.0. link2 := StackLink with: 2.0. link3 := StackLink with: 3.0. link4 := StackLink with: 4.0. (list := LinkedList new) add: link1; add: link2; add: link3. copy := list copy. self assert: list size = 3. self assert: copy size = 3. self assert: copy first element == list first element. list remove: link2. self assert: list size = 2. self assert: copy size = 3. copy add: link4 before: copy third. self assert: list size = 2. self assert: copy size = 4. ^copy As you can see, this is not a deepCopy, the element identity are preserved. Of course not the link objects themselves, that can't be ! Otherwise modifying the copy would modify the original. Like Associations in Dictionary, they should be copied (but the value identity should not change). >> I did not take time to write all tests yet, I will give it a try in >> trunk. >> >>> Of course, it's arguable that that's better behaviour for >>> LinkedLists, >>> seeing as otherwise ll2's lastLink would be invalid when you added to >>> ll. >>> At a glance, SparseLargeTable, Stack (Through LinkedList >>> implementation) and WideCharacterSet in your changeset all seem to do >>> a deep copy. >>> >> >> just deep enough, not more, not less. > > To my understanding, that's too deep. > You're copying elements in the collection as well, not just creating a > copy of the collection with the same elements. > That's what I'd define as a deepCopy, after a copy, I'd expect the > elements in them to be the same. > Maybe it's just what I've gotten used to in VW, and Squeak does > something else historically, but mixing and matching which to do based > on what feels best at any given time can lead to some nasty bugs :) > I don't think so, at least not in trunk image. The best thing would be to provide tests. >> >>> Also, how does part in SharedQueue2 >>> monitor critical: [ >>> monitor := Monitor new. >>> items := items copy >>> ] Â work? Seems a bit fishy to me to have a critical section on a >>> monitor, then replacing it as part of it... >>> >> >> He he, it should just work, because we are talking to a Monitor object >> (the Smalltalk way), not to a pointer *monitor somewhere in memory >> (the C/C++ view). > > Oh, absolutely, it will not crash due to deallocated pointers or such. > > What I meant was a concurrency issue, when some other object requests > something that requires a monitor lock, after Monitor has been > replaced, but before the items have been copied. > i.e. > while the intent of the critical section in that piece of code as far > as I can tell, is that the two operations should happen without items > being accessible before they have been copied. > so you'd actually have to write something like: > monitor critical: [ > Â Â Â Â monitor := Monitor new. > Â Â Â Â monitor critical: > Â Â Â Â [items := items copy]] > to ensure that does not happen. > IMO, this is currently unnecessary because no one yet knows about this copy. The sole use is ^self shallowCopy postCopy, so there is no pointer on me yet but the active process stack. We only have to protect against a modification of original in between But in case of exotic use of #postCopy, you are right. Just reversing the order would do. monitor critical: [ items := items copy monitor := Monitor new]. Nicolas > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 5, 2009

Re: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Henrik Johansen

On Oct 5, 2009, at 3:42 59PM, Henrik Johansen wrote: > > On Oct 5, 2009, at 3:19 53PM, Nicolas Cellier wrote: > >> 2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: >> >>> Of course, it's arguable that that's better behaviour for >>> LinkedLists, >>> seeing as otherwise ll2's lastLink would be invalid when you added >>> to >>> ll. >>> At a glance, SparseLargeTable, Stack (Through LinkedList >>> implementation) and WideCharacterSet in your changeset all seem to >>> do >>> a deep copy. >>> >> >> just deep enough, not more, not less. > > To my understanding, that's too deep. > You're copying elements in the collection as well, not just creating a > copy of the collection with the same elements. > That's what I'd define as a deepCopy, after a copy, I'd expect the > elements in them to be the same. > Maybe it's just what I've gotten used to in VW, and Squeak does > something else historically, but mixing and matching which to do based > on what feels best at any given time can lead to some nasty bugs :) Thinking for a bit more than 2 minutes (which I should do more often, I know), I guess I agree with copying the links the way you do it. So just disregard what I wrote. SparseLargeTables works as I'd expect: assoc := 7 -> 10. slt := SparseLargeTable new:5 . slt at: 5 put: assoc. slt2 := slt copy. (slt at: 5) value: 11. (slt2 at: 5) 7->11 And I guess it doesn't make sense anyhow to mutate elements of a WideCharacterSet :) Sorry for the noise. Cheers, Henry

Oct. 5, 2009

Re: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Schwab,Wilhelm K

The Dolphin solution to this type of problem is to define #species that answers the collection type to use when copying - then the super class method has a much easier time answering a collection of the expected type. Bill -----Original Message----- From: pharo-project-bounces(a)lists.gforge.inria.fr [mailto:pharo-project-bounces@lists.gforge.inria.fr] On Behalf Of Henrik Johansen Sent: Monday, October 05, 2009 7:00 AM To: Pharo-project(a)lists.gforge.inria.fr Subject: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987) Somewhat related, at least I noticed it when debugging this: Sending copy to a LinkedList or a Semaphore will give back an array, since it uses shallowCopy from SequenceableCollection. Probably applies to more of SequenceableCollection's subclasses too, f.ex. DirectoryEntry for which copy leads to an MNU. Another side-effect of strange class-hierarchy, I guess :) Not quite sure how/if you want to implement those differently. Submitted to tracker as Issue1272. Cheers, Henry On Oct 5, 2009, at 1:12 38PM, StÃ©phane Ducasse wrote: > Thanks we will integrate that as soon as we can breath :) > > On Oct 5, 2009, at 12:14 PM, Henrik Johansen wrote: > >> Updated Issue987 with a SLICE in Inbox, which "fixes" the DNU in the >> way below. >> Used printString instead of asString as proposed by HernÃ¡n, as it (in >> principle) should be more robustly implemented and thus more suited >> for debugger display. >> (If sig's idea from some time back was adopted, this should be >> debugString instead of printString, of course). >> >> Cheers, >> Henry >> >> On Oct 5, 2009, at 11:51 23AM, Henrik Johansen wrote: _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 5, 2009

Re: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Henrik Johansen

On Oct 5, 2009, at 3:19 53PM, Nicolas Cellier wrote: > 2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: >> Good to know I'm not the only one who found it strange :) >> >> BTW, I thought the default for Collections was to do a shallowCopy >> with a copy operation? >> > > I removed this default behaviour SequenceableCollection>>shallowCopy > which used to use (self copyFrom: 1 to: self size). > This beautifull hack was using self species, leading to this mess... > And it forced me defining a #basicShallowCopy to work the hack around > (which was the shortest but uggliest solution). > > The copy was deep enough so that modifying the copy would not modify > the original, and this is what postCopy now does. > >> ll := LinkedList new. >> ll add: Link new. >> ll2 := ll copy. >> ll add: Link new. >> >> inspecting ll2, it's firstLink does not have a nextLink, which >> implies >> to me a deepCopy has occured. >> > > I did not take time to write all tests yet, I will give it a try in > trunk. > >> Of course, it's arguable that that's better behaviour for >> LinkedLists, >> seeing as otherwise ll2's lastLink would be invalid when you added to >> ll. >> At a glance, SparseLargeTable, Stack (Through LinkedList >> implementation) and WideCharacterSet in your changeset all seem to do >> a deep copy. >> > > just deep enough, not more, not less. To my understanding, that's too deep. You're copying elements in the collection as well, not just creating a copy of the collection with the same elements. That's what I'd define as a deepCopy, after a copy, I'd expect the elements in them to be the same. Maybe it's just what I've gotten used to in VW, and Squeak does something else historically, but mixing and matching which to do based on what feels best at any given time can lead to some nasty bugs :) > >> Also, how does part in SharedQueue2 >> monitor critical: [ >> monitor := Monitor new. >> items := items copy >> ] work? Seems a bit fishy to me to have a critical section on a >> monitor, then replacing it as part of it... >> > > He he, it should just work, because we are talking to a Monitor object > (the Smalltalk way), not to a pointer *monitor somewhere in memory > (the C/C++ view). Oh, absolutely, it will not crash due to deallocated pointers or such. What I meant was a concurrency issue, when some other object requests something that requires a monitor lock, after Monitor has been replaced, but before the items have been copied. i.e. while the intent of the critical section in that piece of code as far as I can tell, is that the two operations should happen without items being accessible before they have been copied. so you'd actually have to write something like: monitor critical: [ monitor := Monitor new. monitor critical: [items := items copy]] to ensure that does not happen. Cheers, Henry

Oct. 5, 2009

Re: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Nicolas Cellier

2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: > Good to know I'm not the only one who found it strange :) > > BTW, I thought the default for Collections was to do a shallowCopy > with a copy operation? > I removed this default behaviour SequenceableCollection>>shallowCopy which used to use (self copyFrom: 1 to: self size). This beautifull hack was using self species, leading to this mess... And it forced me defining a #basicShallowCopy to work the hack around (which was the shortest but uggliest solution). The copy was deep enough so that modifying the copy would not modify the original, and this is what postCopy now does. > ll := LinkedList new. > ll add: Link new. > ll2 := ll copy. > ll add: Link new. > > inspecting ll2, it's firstLink does not have a nextLink, which implies > to me a deepCopy has occured. > I did not take time to write all tests yet, I will give it a try in trunk. > Of course, it's arguable that that's better behaviour for LinkedLists, > seeing as otherwise ll2's lastLink would be invalid when you added to > ll. > At a glance, SparseLargeTable, Stack (Through LinkedList > implementation) and WideCharacterSet in your changeset all seem to do > a deep copy. > just deep enough, not more, not less. > Also, how does part in SharedQueue2 > monitor critical: [ > monitor := Monitor new. > items := items copy > ] Â work? Seems a bit fishy to me to have a critical section on a > monitor, then replacing it as part of it... > He he, it should just work, because we are talking to a Monitor object (the Smalltalk way), not to a pointer *monitor somewhere in memory (the C/C++ view). > Cheers, > Henry > > > On Oct 5, 2009, at 2:25 12PM, Nicolas Cellier wrote: > >> He he, I just noticed this last evening, see >> http://bugs.squeak.org/view.php?id=7402 >> http://bugs.squeak.org/view.php?id=7403 >> http://bugs.squeak.org/view.php?id=7404 >> >> I thus provided another solution for >> http://bugs.squeak.org/view.php?id=6535 (previous solution has been >> uploaded in pharo). >> >> Nicolas >> >> 2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: >>> Somewhat related, at least I noticed it when debugging this: >>> >>> Sending copy to a LinkedList or a Semaphore will give back an array, >>> since it uses shallowCopy from SequenceableCollection. >>> Probably applies to more of SequenceableCollection's subclasses too, >>> f.ex. DirectoryEntry for which copy leads to an MNU. >>> >>> Another side-effect of strange class-hierarchy, I guess :) >>> >>> Not quite sure how/if you want to implement those differently. >>> >>> Submitted to tracker as Issue1272. >>> >>> Cheers, >>> Henry >>> >>> >>> On Oct 5, 2009, at 1:12 38PM, StÃ©phane Ducasse wrote: >>> >>>> Thanks we will integrate that as soon as we can breath :) >>>> >>>> On Oct 5, 2009, at 12:14 PM, Henrik Johansen wrote: >>>> >>>>> Updated Issue987 with a SLICE in Inbox, which "fixes" the DNU in >>>>> the >>>>> way below. >>>>> Used printString instead of asString as proposed by HernÃ¡n, as it >>>>> (in >>>>> principle) should be more robustly implemented and thus more suited >>>>> for debugger display. >>>>> (If sig's idea from some time back was adopted, this should be >>>>> debugString instead of printString, of course). >>>>> >>>>> Cheers, >>>>> Henry >>>>> >>>>> On Oct 5, 2009, at 11:51 23AM, Henrik Johansen wrote: >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 5, 2009

[Pharo-project] [BUG]UndefinedObject(Object)>>doesNotUnderstand: #null

by anlarionov＠gmail.com

Almost all refactorings ends with this DNU. Is it platform specific? Or maybe i miss something 5 October 2009 5:17:34 pm VM: unix - i686 - linux-gnu - Pharo0.1 of 16 May 2008 [latest update: #10074] Image: Pharo1.0beta [Latest update: #10466] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /home/mou/development/smalltalk/pharo1.0-10451-BETAweb09.09.3 Trusted Dir /home/mou/development/smalltalk/pharo1.0-10451-BETAweb09.09.3/secure Untrusted Dir /home/mou/development/smalltalk/pharo1.0-10451-BETAweb09.09.3/My Squeak UndefinedObject(Object)>>doesNotUnderstand: #null Receiver: nil Arguments and temporary variables: aMessage: null exception: MessageNotUnderstood: receiver of "null" is nil resumeValue: nil Receiver's instance variables: nil RBMethodNode>>primitiveNode Receiver: <<error during printing>> Arguments and temporary variables: Receiver's instance variables: parent: nil properties: a RBSmallIdentityDictionary(#comments->an OrderedCollection() ) annotations: nil selector: #protocol selectorParts: an Array( RBIdentifierToken('protocol')) body: <<error during printing>> RBMethodNode>>primitiveText Receiver: <<error during printing>> Arguments and temporary variables: set: nil Receiver's instance variables: parent: nil properties: a RBSmallIdentityDictionary(#comments->an OrderedCollection() ) annotations: nil selector: #protocol selectorParts: an Array( RBIdentifierToken('protocol')) body: <<error during printing>> RBMethodNode>>primitiveSources Receiver: <<error during printing>> Arguments and temporary variables: tgs: #() text: nil Receiver's instance variables: parent: nil properties: a RBSmallIdentityDictionary(#comments->an OrderedCollection() ) annotations: nil selector: #protocol selectorParts: an Array( RBIdentifierToken('protocol')) body: <<error during printing>> RBFormatter>>formatTagFor: Receiver: a RBFormatter Arguments and temporary variables: <<error during printing> Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBFormatter>>acceptSequenceNode: Receiver: a RBFormatter Arguments and temporary variables: <<error during printing> Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBSequenceNode>>acceptVisitor: Receiver: <<error during printing>> Arguments and temporary variables: aProgramNodeVisitor: a RBFormatter Receiver's instance variables: parent: <<error during printing>> RBFormatter>>visitNode: Receiver: a RBFormatter Arguments and temporary variables: <<error during printing> Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 [] in RBFormatter>>acceptMethodNode: Receiver: a RBFormatter Arguments and temporary variables: <<error during printing> Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBFormatter>>indent:while: Receiver: a RBFormatter Arguments and temporary variables: anInteger: 1 aBlock: [closure] in RBFormatter>>acceptMethodNode: Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBFormatter>>indentWhile: Receiver: a RBFormatter Arguments and temporary variables: aBlock: [closure] in RBFormatter>>acceptMethodNode: Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBFormatter>>acceptMethodNode: Receiver: a RBFormatter Arguments and temporary variables: <<error during printing> Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBMethodNode>>acceptVisitor: Receiver: <<error during printing>> Arguments and temporary variables: aProgramNodeVisitor: a RBFormatter Receiver's instance variables: parent: nil properties: a RBSmallIdentityDictionary(#comments->an OrderedCollection() ) annotations: nil selector: #protocol selectorParts: an Array( RBIdentifierToken('protocol')) body: <<error during printing>> RBFormatter>>visitNode: Receiver: a RBFormatter Arguments and temporary variables: <<error during printing> Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBFormatter>>format: Receiver: a RBFormatter Arguments and temporary variables: <<error during printing> Receiver's instance variables: codeStream: a WriteStream 'protocol ' lineStart: 10 firstLineLength: 8 tabs: 1 positionDelta: 0 RBMethodNode(RBProgramNode)>>formattedCode Receiver: <<error during printing>> Arguments and temporary variables: Receiver's instance variables: parent: nil properties: a RBSmallIdentityDictionary(#comments->an OrderedCollection() ) annotations: nil selector: #protocol selectorParts: an Array( RBIdentifierToken('protocol')) body: <<error during printing>> RBClass(RBAbstractClass)>>compileTree:classified: Receiver: FCGIServer Arguments and temporary variables: <<error during printing> Receiver's instance variables: name: #FCGIServer newMethods: an IdentityDictionary() instanceVariableNames: an OrderedCollection('handler' 'port' 'socket' 'profile'...etc... model: a RBNamespace superclass: an Object subclasses: an OrderedCollection() removedMethods: nil realClass: FCGIServer classVariableNames: an OrderedCollection() poolDictionaryNames: nil category: nil comment: an Object RBClass(RBAbstractClass)>>compileTree: Receiver: FCGIServer Arguments and temporary variables: <<error during printing> Receiver's instance variables: name: #FCGIServer newMethods: an IdentityDictionary() instanceVariableNames: an OrderedCollection('handler' 'port' 'socket' 'profile'...etc... model: a RBNamespace superclass: an Object subclasses: an OrderedCollection() removedMethods: nil realClass: FCGIServer classVariableNames: an OrderedCollection() poolDictionaryNames: nil category: nil comment: an Object RenameClassRefactoring(Refactoring)>>convertMethod:for:using: Receiver: a RenameClassRefactoring Arguments and temporary variables: <<error during printing> Receiver's instance variables: model: a RBNamespace options: nil className: #FCGIProtocolVersion1 newName: #FCGIAdapter class: FCGIProtocolVersion1 [] in RenameClassRefactoring>>renameReferences Receiver: a RenameClassRefactoring Arguments and temporary variables: replacer: FCGIServer>>protocol method: a ParseTreeRewriter Receiver's instance variables: model: a RBNamespace options: nil className: #FCGIProtocolVersion1 newName: #FCGIAdapter class: FCGIProtocolVersion1 [] in [] in RBNamespace>>allReferencesToClass:do: Receiver: a RBNamespace Arguments and temporary variables: <<error during printing> Receiver's instance variables: changes: FCGIProtocolVersion1 rename: #FCGIAdapter! environment: Smalltalk newClasses: an IdentityDictionary() removedClasses: a Set() changedClasses: an IdentityDictionary(size 494) rootClasses: nil implementorsCache: an IdentityDictionary() sendersCache: an IdentityDictionary() Set>>do: Receiver: a Set(#protocol) Arguments and temporary variables: aBlock: [closure] in [] in RBNamespace>>allReferencesToClass:do: index: 3 each: #protocol indexLimiT: 5 Receiver's instance variables: tally: 1 array: #(nil nil #protocol nil nil) [] in RBNamespace>>allReferencesToClass:do: Receiver: a RBNamespace Arguments and temporary variables: aRBClass: FCGIServer aBlock: FCGIProtocolVersion1 each: [closure] in RenameClassRefactoring>>renameReferences Receiver's instance variables: changes: FCGIProtocolVersion1 rename: #FCGIAdapter! environment: Smalltalk newClasses: an IdentityDictionary() removedClasses: a Set() changedClasses: an IdentityDictionary(size 494) rootClasses: nil implementorsCache: an IdentityDictionary() sendersCache: an IdentityDictionary() [] in RBNamespace>>allClassesDo: Receiver: a RBNamespace Arguments and temporary variables: aBlock: FCGIServer seen: [closure] in RBNamespace>>allReferencesToClass:do: evalBlock: a Set(#FCGIProtocolVersion1) each: FCGIServer class: [closure] in RBNamespace>>allReferencesToClass:do: Receiver's instance variables: changes: FCGIProtocolVersion1 rename: #FCGIAdapter! environment: Smalltalk newClasses: an IdentityDictionary() removedClasses: a Set() changedClasses: an IdentityDictionary(size 494) rootClasses: nil implementorsCache: an IdentityDictionary() sendersCache: an IdentityDictionary() [] in BrowserEnvironment>>classesDo: Receiver: Smalltalk Arguments and temporary variables: aBlock: FCGIServer each: [closure] in RBNamespace>>allClassesDo: Receiver's instance variables: label: nil searchStrings: nil [] in BrowserEnvironment>>allClassesDo: Receiver: Smalltalk Arguments and temporary variables: aBlock: FCGIServer each: [closure] in BrowserEnvironment>>classesDo: Receiver's instance variables: label: nil searchStrings: nil OrderedCollection>>do: Receiver: an OrderedCollection(AColorSelectorMorph ADPCMCodec AIFFFileReader ASTPrettyPrinting ASamp...etc... Arguments and temporary variables: aBlock: [closure] in BrowserEnvironment>>allClassesDo: index: 492 Receiver's instance variables: array: {AColorSelectorMorph . ADPCMCodec . AIFFFileReader . ASTPrettyPrinting ....etc... firstIndex: 1 lastIndex: 4204 SystemDictionary>>allClassesDo: Receiver: Smalltalk Arguments and temporary variables: aBlock: [closure] in BrowserEnvironment>>allClassesDo: Receiver's instance variables: tally: 4332 array: {#PRReferenceRenderer->PRReferenceRenderer . #PRLightBoxView->PRLightBox...etc... cachedClassNames: a SortedCollection(#AColorSelectorMorph #ADPCMCodec #AIFFFile...etc... SystemNavigation>>allClassesDo: Receiver: a SystemNavigation Arguments and temporary variables: aBlock: [closure] in BrowserEnvironment>>allClassesDo: Receiver's instance variables: browserClass: nil hierarchyBrowserClass: nil BrowserEnvironment>>allClassesDo: Receiver: Smalltalk Arguments and temporary variables: aBlock: [closure] in BrowserEnvironment>>classesDo: Receiver's instance variables: label: nil searchStrings: nil BrowserEnvironment>>classesDo: Receiver: Smalltalk Arguments and temporary variables: aBlock: [closure] in RBNamespace>>allClassesDo: Receiver's instance variables: label: nil searchStrings: nil RBNamespace>>allClassesDo: Receiver: a RBNamespace Arguments and temporary variables: aBlock: [closure] in RBNamespace>>allReferencesToClass:do: seen: a Set(#FCGIProtocolVersion1) evalBlock: [closure] in RBNamespace>>allClassesDo: Receiver's instance variables: changes: FCGIProtocolVersion1 rename: #FCGIAdapter! environment: Smalltalk newClasses: an IdentityDictionary() removedClasses: a Set() changedClasses: an IdentityDictionary(size 494) rootClasses: nil implementorsCache: an IdentityDictionary() sendersCache: an IdentityDictionary() RBNamespace>>allReferencesToClass:do: Receiver: a RBNamespace Arguments and temporary variables: aRBClass: FCGIProtocolVersion1 aBlock: [closure] in RenameClassRefactoring>>renameReferences Receiver's instance variables: changes: FCGIProtocolVersion1 rename: #FCGIAdapter! environment: Smalltalk newClasses: an IdentityDictionary() removedClasses: a Set() changedClasses: an IdentityDictionary(size 494) rootClasses: nil implementorsCache: an IdentityDictionary() sendersCache: an IdentityDictionary() RenameClassRefactoring>>renameReferences Receiver: a RenameClassRefactoring Arguments and temporary variables: replacer: a ParseTreeRewriter Receiver's instance variables: model: a RBNamespace options: nil className: #FCGIProtocolVersion1 newName: #FCGIAdapter class: FCGIProtocolVersion1 [] in RenameClassRefactoring>>transform Receiver: a RenameClassRefactoring Arguments and temporary variables: Receiver's instance variables: model: a RBNamespace options: nil className: #FCGIProtocolVersion1 newName: #FCGIAdapter class: FCGIProtocolVersion1 BlockClosure>>ensure: Receiver: [closure] in RenameClassRefactoring>>transform Arguments and temporary variables: aBlock: [closure] in RBNamespace>>performChange:around: returnValue: nil b: nil Receiver's instance variables: outerContext: RenameClassRefactoring>>transform startpc: 33 numArgs: 0 RBNamespace>>performChange:around: Receiver: a RBNamespace Arguments and temporary variables: aCompositeRefactoryChange: FCGIProtocolVersion1 rename: #FCGIAdapter! aBlock: [closure] in RenameClassRefactoring>>transform oldChanges: refactor class, rename Receiver's instance variables: changes: FCGIProtocolVersion1 rename: #FCGIAdapter! environment: Smalltalk newClasses: an IdentityDictionary() removedClasses: a Set() changedClasses: an IdentityDictionary(size 494) rootClasses: nil implementorsCache: an IdentityDictionary() sendersCache: an IdentityDictionary() RBNamespace>>renameClass:to:around: Receiver: a RBNamespace Arguments and temporary variables: aRBClass: FCGIProtocolVersion1 aSymbol: #FCGIAdapter aBlock: [closure] in RenameClassRefactoring>>transform change: FCGIProtocolVersion1 rename: #FCGIAdapter! value: nil dict: nil Receiver's instance variables: changes: FCGIProtocolVersion1 rename: #FCGIAdapter! environment: Smalltalk newClasses: an IdentityDictionary() removedClasses: a Set() changedClasses: an IdentityDictionary(size 494) rootClasses: nil implementorsCache: an IdentityDictionary() sendersCache: an IdentityDictionary() RenameClassRefactoring>>transform Receiver: a RenameClassRefactoring Arguments and temporary variables: Receiver's instance variables: model: a RBNamespace options: nil className: #FCGIProtocolVersion1 newName: #FCGIAdapter class: FCGIProtocolVersion1 --- The full stack --- UndefinedObject(Object)>>doesNotUnderstand: #null RBMethodNode>>primitiveNode RBMethodNode>>primitiveText RBMethodNode>>primitiveSources RBFormatter>>formatTagFor: RBFormatter>>acceptSequenceNode: RBSequenceNode>>acceptVisitor: RBFormatter>>visitNode: [] in RBFormatter>>acceptMethodNode: RBFormatter>>indent:while: RBFormatter>>indentWhile: RBFormatter>>acceptMethodNode: RBMethodNode>>acceptVisitor: RBFormatter>>visitNode: RBFormatter>>format: RBMethodNode(RBProgramNode)>>formattedCode RBClass(RBAbstractClass)>>compileTree:classified: RBClass(RBAbstractClass)>>compileTree: RenameClassRefactoring(Refactoring)>>convertMethod:for:using: [] in RenameClassRefactoring>>renameReferences [] in [] in RBNamespace>>allReferencesToClass:do: Set>>do: [] in RBNamespace>>allReferencesToClass:do: [] in RBNamespace>>allClassesDo: [] in BrowserEnvironment>>classesDo: [] in BrowserEnvironment>>allClassesDo: OrderedCollection>>do: SystemDictionary>>allClassesDo: SystemNavigation>>allClassesDo: BrowserEnvironment>>allClassesDo: BrowserEnvironment>>classesDo: RBNamespace>>allClassesDo: RBNamespace>>allReferencesToClass:do: RenameClassRefactoring>>renameReferences [] in RenameClassRefactoring>>transform BlockClosure>>ensure: RBNamespace>>performChange:around: RBNamespace>>renameClass:to:around: RenameClassRefactoring>>transform - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - RenameClassRefactoring(Refactoring)>>primitiveExecute [] in OR2CmdRenameClassRefactoring(OR2Command)>>performRefactoring: BlockClosure>>ensure: CursorWithMask(Cursor)>>showWhile: OBShoutPlatform(OBMorphicPlatform)>>handleWaitRequest: OBWaitRequest>>handleWith: OBWaitRequest(OBInteractionRequest)>>defaultAction UndefinedObject>>handleSignal: MethodContext(ContextPart)>>handleSignal: MethodContext(ContextPart)>>handleSignal: MethodContext(ContextPart)>>handleSignal: OBWaitRequest(Exception)>>signal OBWaitRequest class>>block: OR2CmdRenameClassRefactoring(OR2Command)>>waitWhile: OR2CmdRenameClassRefactoring(OR2Command)>>performRefactoring: [] in [] in OR2CmdRenameClassRefactoring(OR2CmdRefactoring)>>execute BlockClosure>>on:do: OR2CmdRenameClassRefactoring(OR2Command)>>handleError: [] in OR2CmdRenameClassRefactoring(OR2CmdRefactoring)>>execute BlockClosure>>on:do: OR2CmdRenameClassRefactoring(OR2CmdRefactoring)>>execute OR2CmdRenameClassRefactoring(O2Command)>>perform:orSendTo: [] in ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent: BlockClosure>>ensure: CursorWithMask(Cursor)>>showWhile: ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent: ToggleMenuItemMorph(MenuItemMorph)>>mouseUp: ToggleMenuItemMorph(MenuItemMorph)>>handleMouseUp: MouseButtonEvent>>sentTo: ToggleMenuItemMorph(Morph)>>handleEvent: MorphicEventDispatcher>>dispatchDefault:with: MorphicEventDispatcher>>dispatchEvent:with: ToggleMenuItemMorph(Morph)>>processEvent:using: MorphicEventDispatcher>>dispatchDefault:with: MorphicEventDispatcher>>dispatchEvent:with: MenuMorph(Morph)>>processEvent:using: MenuMorph(Morph)>>processEvent: MenuMorph>>handleFocusEvent: [] in HandMorph>>sendFocusEvent:to:clear: [] in PasteUpMorph>>becomeActiveDuring: BlockClosure>>on:do: PasteUpMorph>>becomeActiveDuring: HandMorph>>sendFocusEvent:to:clear: HandMorph>>sendEvent:focus:clear: HandMorph>>sendMouseEvent: HandMorph>>handleEvent: HandMorph>>processEvents [] in WorldState>>doOneCycleNowFor: Array(SequenceableCollection)>>do: WorldState>>handsDo: WorldState>>doOneCycleNowFor: WorldState>>doOneCycleFor: PasteUpMorph>>doOneCycle [] in Project class>>spawnNewProcess [] in BlockClosure>>newProcess

Oct. 5, 2009

Re: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Henrik Johansen

Good to know I'm not the only one who found it strange :) BTW, I thought the default for Collections was to do a shallowCopy with a copy operation? ll := LinkedList new. ll add: Link new. ll2 := ll copy. ll add: Link new. inspecting ll2, it's firstLink does not have a nextLink, which implies to me a deepCopy has occured. Of course, it's arguable that that's better behaviour for LinkedLists, seeing as otherwise ll2's lastLink would be invalid when you added to ll. At a glance, SparseLargeTable, Stack (Through LinkedList implementation) and WideCharacterSet in your changeset all seem to do a deep copy. Also, how does part in SharedQueue2 monitor critical: [ monitor := Monitor new. items := items copy ] work? Seems a bit fishy to me to have a critical section on a monitor, then replacing it as part of it... Cheers, Henry On Oct 5, 2009, at 2:25 12PM, Nicolas Cellier wrote: > He he, I just noticed this last evening, see > http://bugs.squeak.org/view.php?id=7402 > http://bugs.squeak.org/view.php?id=7403 > http://bugs.squeak.org/view.php?id=7404 > > I thus provided another solution for > http://bugs.squeak.org/view.php?id=6535 (previous solution has been > uploaded in pharo). > > Nicolas > > 2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: >> Somewhat related, at least I noticed it when debugging this: >> >> Sending copy to a LinkedList or a Semaphore will give back an array, >> since it uses shallowCopy from SequenceableCollection. >> Probably applies to more of SequenceableCollection's subclasses too, >> f.ex. DirectoryEntry for which copy leads to an MNU. >> >> Another side-effect of strange class-hierarchy, I guess :) >> >> Not quite sure how/if you want to implement those differently. >> >> Submitted to tracker as Issue1272. >> >> Cheers, >> Henry >> >> >> On Oct 5, 2009, at 1:12 38PM, StÃ©phane Ducasse wrote: >> >>> Thanks we will integrate that as soon as we can breath :) >>> >>> On Oct 5, 2009, at 12:14 PM, Henrik Johansen wrote: >>> >>>> Updated Issue987 with a SLICE in Inbox, which "fixes" the DNU in >>>> the >>>> way below. >>>> Used printString instead of asString as proposed by HernÃ¡n, as it >>>> (in >>>> principle) should be more robustly implemented and thus more suited >>>> for debugger display. >>>> (If sig's idea from some time back was adopted, this should be >>>> debugString instead of printString, of course). >>>> >>>> Cheers, >>>> Henry >>>> >>>> On Oct 5, 2009, at 11:51 23AM, Henrik Johansen wrote: >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 5, 2009

Re: [Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Nicolas Cellier

He he, I just noticed this last evening, see http://bugs.squeak.org/view.php?id=7402 http://bugs.squeak.org/view.php?id=7403 http://bugs.squeak.org/view.php?id=7404 I thus provided another solution for http://bugs.squeak.org/view.php?id=6535 (previous solution has been uploaded in pharo). Nicolas 2009/10/5 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: > Somewhat related, at least I noticed it when debugging this: > > Sending copy to a LinkedList or a Semaphore will give back an array, > since it uses shallowCopy from SequenceableCollection. > Probably applies to more of SequenceableCollection's subclasses too, > f.ex. DirectoryEntry for which copy leads to an MNU. > > Another side-effect of strange class-hierarchy, I guess :) > > Not quite sure how/if you want to implement those differently. > > Submitted to tracker as Issue1272. > > Cheers, > Henry > > > On Oct 5, 2009, at 1:12 38PM, StÃ©phane Ducasse wrote: > >> Thanks we will integrate that as soon as we can breath :) >> >> On Oct 5, 2009, at 12:14 PM, Henrik Johansen wrote: >> >>> Updated Issue987 with a SLICE in Inbox, which "fixes" the DNU in the >>> way below. >>> Used printString instead of asString as proposed by HernÃ¡n, as it (in >>> principle) should be more robustly implemented and thus more suited >>> for debugger display. >>> (If sig's idea from some time back was adopted, this should be >>> debugString instead of printString, of course). >>> >>> Cheers, >>> Henry >>> >>> On Oct 5, 2009, at 11:51 23AM, Henrik Johansen wrote: > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 5, 2009

[Pharo-project] Copy for SequenceableCollection subclasses? (Was: Fix for 987)

by Henrik Johansen

Somewhat related, at least I noticed it when debugging this: Sending copy to a LinkedList or a Semaphore will give back an array, since it uses shallowCopy from SequenceableCollection. Probably applies to more of SequenceableCollection's subclasses too, f.ex. DirectoryEntry for which copy leads to an MNU. Another side-effect of strange class-hierarchy, I guess :) Not quite sure how/if you want to implement those differently. Submitted to tracker as Issue1272. Cheers, Henry On Oct 5, 2009, at 1:12 38PM, StÃ©phane Ducasse wrote: > Thanks we will integrate that as soon as we can breath :) > > On Oct 5, 2009, at 12:14 PM, Henrik Johansen wrote: > >> Updated Issue987 with a SLICE in Inbox, which "fixes" the DNU in the >> way below. >> Used printString instead of asString as proposed by HernÃ¡n, as it (in >> principle) should be more robustly implemented and thus more suited >> for debugger display. >> (If sig's idea from some time back was adopted, this should be >> debugString instead of printString, of course). >> >> Cheers, >> Henry >> >> On Oct 5, 2009, at 11:51 23AM, Henrik Johansen wrote:

Oct. 5, 2009

[Pharo-project] Fwd: [squeak-dev] The Trunk: Compiler-jcg.87.mcz

by StÃ©phane Ducasse

Begin forwarded message: > From: commits(a)source.squeak.org > Date: October 1, 2009 8:21:58 AM GMT+02:00 > To: squeak-dev(a)lists.squeakfoundation.org > Subject: [squeak-dev] The Trunk: Compiler-jcg.87.mcz > Reply-To: squeak-dev(a)lists.squeakfoundation.org > > Joshua Gargus uploaded a new version of Compiler to project The Trunk: > http://source.squeak.org/trunk/Compiler-jcg.87.mcz > > ==================== Summary ==================== > > Name: Compiler-jcg.87 > Author: jcg > Time: 30 September 2009, 11:21:53 am > UUID: 71bf4e8d-f9f3-4371-a218-ad31a985cfd8 > Ancestors: Compiler-ul.86 > > Revert to lazy-initialization of method properties, which is used by > the externally-maintained Prolog package (which loads cleanly into > 3.10.2, but not trunk). > > Part 2 of 2... need to load -jcg.85 first (this is taken care of by > the Monticello Configuration update-jcg.32.mcm) > > =============== Diff against Compiler-ul.86 =============== > > Item was changed: > ----- Method: Parser>>addPragma: (in category 'pragmas') ----- > addPragma: aPragma > + properties := self properties copyWith: aPragma! > - properties := properties copyWith: aPragma! > > Item was changed: > ----- Method: Parser>>method:context:encoder: (in category > 'expression types') ----- > method: doit context: ctxt encoder: encoderToUse > " pattern [ | temporaries ] block => MethodNode." > > | sap blk prim temps messageComment methodNode | > - properties := AdditionalMethodState new. > encoder := encoderToUse. > sap := self pattern: doit inContext: ctxt. > "sap={selector, arguments, precedence}" > + self properties selector: (sap at: 1). > - properties selector: (sap at: 1). > encoder selector: (sap at: 1). > (sap at: 2) do: [:argNode | argNode beMethodArg]. > doit ifFalse: [self pragmaSequence]. > temps := self temporaries. > messageComment := currentComment. > currentComment := nil. > doit ifFalse: [self pragmaSequence]. > prim := self pragmaPrimitives. > self statements: #() innerBlock: doit. > blk := parseNode. > doit ifTrue: [blk returnLast] > ifFalse: [blk returnSelfIfNoOther: encoder]. > hereType == #doIt ifFalse: [^self expected: 'Nothing more']. > self interactive ifTrue: [self removeUnusedTemps]. > methodNode := self newMethodNode comment: messageComment. > ^methodNode > selector: (sap at: 1) > arguments: (sap at: 2) > precedence: (sap at: 3) > temporaries: temps > block: blk > encoder: encoder > primitive: prim > properties: properties! > > Item was changed: > ----- Method: > MethodNode > >>selector:arguments:precedence:temporaries:block:encoder:primitive: > (in category 'initialize-release') ----- > selector: selOrFalse arguments: args precedence: p temporaries: > temps block: blk encoder: anEncoder primitive: prim > + > + self > + selector: selOrFalse > + arguments: args > + precedence: p > + temporaries: temps > + block: blk encoder: > + anEncoder > + primitive: prim > + properties: AdditionalMethodState new.! > - "Initialize the receiver with respect to the arguments given." > - > - encoder := anEncoder. > - selectorOrFalse := selOrFalse. > - precedence := p. > - arguments := args. > - temporaries := temps. > - block := blk. > - primitive := prim! > > Item was changed: > ----- Method: Parser>>pragmaPrimitives (in category 'pragmas') ----- > pragmaPrimitives > | primitives | > + self properties isEmpty ifTrue: > - properties isEmpty ifTrue: > [^0]. > primitives := properties pragmas select: > [:pragma| > self class primitivePragmaSelectors includes: pragma keyword]. > primitives isEmpty ifTrue: > [^0]. > primitives size > 1 ifTrue: > [^self notify: 'Ambigous primitives']. > ^self perform: primitives first keyword withArguments: primitives > first arguments! > >

Oct. 5, 2009