- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Issue 1311: Refactoring scope is broken

by Lukas Renggli

The question is what should the expression #( . ) should parse as? Neither the ST-80 book, nor the ANSI standard define anything. Another nice example where the Smalltalk language is underspecified ;-) Squeak and VisualWorks parse the dot as a the symbol #'.', which is a good choice, I guess. Unfortunately not that easy to fix in RBScanner ... Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Oct. 17, 2009

Re: [Pharo-project] [update] 10472

by Adrian Lienhard

Hi Mike Thanks for asking. I removed it because I had the impression it depends on the class XMLWriter that is not in the image. Looking at it again, I see that this is just example code to run the test on. If I change XMLWriter to Object the test run green. I will add it again. Issue 1317: Add MethodHighlightingTests back http://code.google.com/p/pharo/issues/detail?id=1317 Adrian On Oct 17, 2009, at 11:47 , Michael Roberts wrote: > Hi Adrian > is method highlighting test broken or bogus? Was there a reason to not > mark it expected failure? > > Thanks > mike > > On Saturday, October 17, 2009, Adrian Lienhard <adi(a)netstyle.ch> > wrote: >> Issue 1310: Make all tests green (not complete yet) >> - Remove class MethodHighlightingTests >> - ParseNode removeSelector: #addCommentToMorph: >> - Fix SelfEvaluatingObjectTest>>testArray ({1 + 0 . 1 @ 2 . 3}' >> prints >> '{1. 1@2. 3}) >> - Remove method CompiledMethod>>primitiveNode as it is not used >> anymore >> - Fix toolbuilder tests (sort of) >> - Fix Decompiler>>decompileBlock: (regression of closure fixes). This >> makes BlockContextTest>>testDecompile pass again >> - Make BlockContextTest>>testTrace run by commenting out broken part >> of code simulation >> Issue 1308: FixedIdentitySet = fails when compared with an >> integer >> >> >> ___________________ >> http://www.adrian-lienhard.ch/ >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 17, 2009

Re: [Pharo-project] [update] 10472

by Michael Roberts

Hi Adrian is method highlighting test broken or bogus? Was there a reason to not mark it expected failure? Thanks mike On Saturday, October 17, 2009, Adrian Lienhard <adi(a)netstyle.ch> wrote: > Issue 1310: Â Â Make all tests green (not complete yet) > - Remove class MethodHighlightingTests > - ParseNode removeSelector: #addCommentToMorph: > - Fix SelfEvaluatingObjectTest>>testArray ({1 + 0 . 1 @ 2 . 3}' prints > '{1. 1@2. 3}) > - Remove method CompiledMethod>>primitiveNode as it is not used anymore > - Fix toolbuilder tests (sort of) > - Fix Decompiler>>decompileBlock: (regression of closure fixes). This > makes BlockContextTest>>testDecompile pass again > - Make BlockContextTest>>testTrace run by commenting out broken part > of code simulation > Issue 1308: Â Â FixedIdentitySet = fails when compared with an integer > > > ___________________ > http://www.adrian-lienhard.ch/ > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 17, 2009

Re: [Pharo-project] Google issue tracker API

by Michael Roberts

That looks good. Mike On Saturday, October 17, 2009, Adrian Lienhard <adi(a)netstyle.ch> wrote: > Yesterday, Google announced the new API for the bug tracker: > > http://googlecode.blogspot.com/2009/10/issue-tracker-data-api-for-project.h… > > Adrian > ___________________ > http://www.adrian-lienhard.ch/ > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 17, 2009

[Pharo-project] [update] 10472

by Adrian Lienhard

Issue 1310: Make all tests green (not complete yet) - Remove class MethodHighlightingTests - ParseNode removeSelector: #addCommentToMorph: - Fix SelfEvaluatingObjectTest>>testArray ({1 + 0 . 1 @ 2 . 3}' prints '{1. 1@2. 3}) - Remove method CompiledMethod>>primitiveNode as it is not used anymore - Fix toolbuilder tests (sort of) - Fix Decompiler>>decompileBlock: (regression of closure fixes). This makes BlockContextTest>>testDecompile pass again - Make BlockContextTest>>testTrace run by commenting out broken part of code simulation Issue 1308: FixedIdentitySet = fails when compared with an integer ___________________ http://www.adrian-lienhard.ch/

Oct. 17, 2009

Re: [Pharo-project] Issue 1311: Refactoring scope is broken

by StÃ©phane Ducasse

excellent! Noce to see that you are online.. Stef On Oct 17, 2009, at 11:14 AM, Lukas Renggli wrote: > I'll look into this. Look like a bug in the RBScanner. > > Cheers, > Lukas > > 2009/10/17 Oscar Nierstrasz <oscar(a)iam.unibe.ch>: >> >> Take latest pharo1.0-10470-BETAdev09.10.2 (must be a dev image). >> >> - Select (say) AST-Nodes category (or any other category) >> - refactoring scope>super-sends >> - Yields: Error: Unknown character in literal array >> >> The same is observed for self-sends ... Also using the package >> browser. >> According to David Roethlisberger, this should be a problem in RB. >> It >> encounters a nil character while parsing >> all the methods, which happens when an unknown character is >> encountered. >> >> The problem appears to be an unknown character somewhere within >> ClosureCompilerTest>>#testInjectIntoDecompilations >> >> Deleting the body of this method "fixes" the problem :-( >> >> - on >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 17, 2009

Re: [Pharo-project] Issue 1311: Refactoring scope is broken

by Lukas Renggli

I'll look into this. Look like a bug in the RBScanner. Cheers, Lukas 2009/10/17 Oscar Nierstrasz <oscar(a)iam.unibe.ch>: > > Take latest pharo1.0-10470-BETAdev09.10.2 (must be a dev image). > > - Select (say) AST-Nodes category (or any other category) > - refactoring scope>super-sends > - Yields: Error: Unknown character in literal array > > The same is observed for self-sends ... Also using the package browser. > According to David Roethlisberger, this should be a problem in RB. Â It > encounters a nil character while parsing > all the methods, which happens when an unknown character is encountered. > > The problem appears to be an unknown character somewhere within > ClosureCompilerTest>>#testInjectIntoDecompilations > > Deleting the body of this method "fixes" the problem :-( > > - on > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Oct. 17, 2009

[Pharo-project] Fix for issue 1258

by Niko Schwarz

In Pharo, '.1' = 0 evaluates to true. In the bug tracker, it was proposed to change this to an error being raised, which I implemented: http://code.google.com/p/pharo/issues/detail?id=1258 Cheers, Niko

Oct. 17, 2009

[Pharo-project] Issue 1313: Process Browser interaction broken

by Oscar Nierstrasz

Take PharoCore-1.0-10470-BETA.1 Select the 1st item in the left pane (Delay class) Select 2nd item in 2nd pane ([] in Delay class) Yields: Message not understood: receiver of "keywords" is nil Same occurs when clicking on other items. Seems to be some hacky code in CompiledMethod>>#getSourceFor:in: (See comment in final return expression.) [This does not seem to be related to issue 751.] - on

Oct. 17, 2009

[Pharo-project] Small bug fix

by Niko Schwarz

I found and fixed a tiny bug in FixedIdentitySet: http://code.google.com/p/pharo/issues/detail?id=1308&can=3&colspec=ID%20Typ… Cheers, Niko

Oct. 17, 2009