- Pharo-dev - lists.pharo.org

Re: [Pharo-project] (no subject)

by Schwab,Wilhelm K

Lukas, What about the handling of comments? The RB or its parser, etc. made *no* attempt to get them in the correct position as presented to the formatter, making the effort of creating a formatter fairly pointless. If that has improved, I will take another look, but my instinct is to ask for the RB to make a list what it would need to reformat so I can take care of it myself - it was that bad. Bill -----Original Message----- From: pharo-project-bounces(a)lists.gforge.inria.fr [mailto:pharo-project-bounces@lists.gforge.inria.fr] On Behalf Of Lukas Renggli Sent: Sunday, November 22, 2009 7:33 AM To: Pharo-project(a)lists.gforge.inria.fr Subject: Re: [Pharo-project] (no subject) > I still have issues with not preserving code formatting in the latest > pharo-dev. Particularly, method renaming cause code to be reformatted. The formatting cannot be preserved in all cases. For example, if the renamed method has many arguments or is sent with complex arguments (block, nested message sends, ...) the code is still reformatted. For the cases where an automatic formatting is not avoidable, the class RBConfigurableFormatter can be configured to produce something that is more to your likings. Lukas -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by George Herolyants

Yes. 2009/11/22 Lukas Renggli <renggli(a)gmail.com>: >> Thanks for the explanation. But I have just a test method without any >> arguments which isn't referenced from anywhere. And this very method >> loses its formatting after renaming. I've tried to rename some other >> methods without parameters but the result is the same. > > Are you sure you have the latest code, e.g. AST-Core-lr.27, > Refactoring-Core-lr.77 and OB-Refactory-lr.170? > > Lukas

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by Lukas Renggli

> Thanks for the explanation. But I have just a test method without any > arguments which isn't referenced from anywhere. And this very method > loses its formatting after renaming. I've tried to rename some other > methods without parameters but the result is the same. Are you sure you have the latest code, e.g. AST-Core-lr.27, Refactoring-Core-lr.77 and OB-Refactory-lr.170? Lukas > > 2009/11/22 Lukas Renggli <renggli(a)gmail.com>: >>> I still have issues with not preserving code formatting in the latest >>> pharo-dev. Particularly, method renaming cause code to be reformatted. >> >> The formatting cannot be preserved in all cases. For example, if the >> renamed method has many arguments or is sent with complex arguments >> (block, nested message sends, ...) the code is still reformatted. For >> the cases where an automatic formatting is not avoidable, the class >> RBConfigurableFormatter can be configured to produce something that is >> more to your likings. >> >> Lukas >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by George Herolyants

Thanks for the explanation. But I have just a test method without any arguments which isn't referenced from anywhere. And this very method loses its formatting after renaming. I've tried to rename some other methods without parameters but the result is the same. 2009/11/22 Lukas Renggli <renggli(a)gmail.com>: >> I still have issues with not preserving code formatting in the latest >> pharo-dev. Particularly, method renaming cause code to be reformatted. > > The formatting cannot be preserved in all cases. For example, if the > renamed method has many arguments or is sent with complex arguments > (block, nested message sends, ...) the code is still reformatted. For > the cases where an automatic formatting is not avoidable, the class > RBConfigurableFormatter can be configured to produce something that is > more to your likings. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by Adrian Lienhard

On Nov 22, 2009, at 13:28 , Lukas Renggli wrote: >>> OR2 depends on the old Refactoring Engine from 1999. I recently >>> ported >>> some newer code of John Brant that avoids unnecessary >>> reformatting. It >>> looks like O2 hasn't been updated yet. The refactoring tools should >>> work well in the default OmniBrowser. >>> >>> Lukas >> >> Is formatting when refactoring removed altogether? If so, that is >> great >> news! >> >> However, I get the same error with OBSystemBrowser. (I assume this >> is >> the "default OmniBrowser")? > > The problem is that O2 overrides methods in the system and therefor > breaks also the default system browser. I am afraid that you need to > start from a core image and only load the default browser to get a > working configuration > (http://code.google.com/p/pharo/wiki/ImageBuildScripts) Do we have a ticket for this already? Adrian

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by Lukas Renggli

> I still have issues with not preserving code formatting in the latest > pharo-dev. Particularly, method renaming cause code to be reformatted. The formatting cannot be preserved in all cases. For example, if the renamed method has many arguments or is sent with complex arguments (block, nested message sends, ...) the code is still reformatted. For the cases where an automatic formatting is not avoidable, the class RBConfigurableFormatter can be configured to produce something that is more to your likings. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by Lukas Renggli

>> OR2 depends on the old Refactoring Engine from 1999. I recently ported >> some newer code of John Brant that avoids unnecessary reformatting. It >> looks like O2 hasn't been updated yet. The refactoring tools should >> work well in the default OmniBrowser. >> >> Lukas > > Is formatting when refactoring removed altogether? Â If so, that is great > news! > > However, I get the same error with OBSystemBrowser. Â (I assume this is > the "default OmniBrowser")? The problem is that O2 overrides methods in the system and therefor breaks also the default system browser. I am afraid that you need to start from a core image and only load the default browser to get a working configuration (http://code.google.com/p/pharo/wiki/ImageBuildScripts) Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by George Herolyants

I still have issues with not preserving code formatting in the latest pharo-dev. Particularly, method renaming cause code to be reformatted. > Lukas Renggli <renggli(a)gmail.com> writes: > >> OR2 depends on the old Refactoring Engine from 1999. I recently ported >> some newer code of John Brant that avoids unnecessary reformatting. It >> looks like O2 hasn't been updated yet. The refactoring tools should >> work well in the default OmniBrowser. >> >> Lukas

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by Henrik Jegbjerg Hansen

Lukas Renggli <renggli(a)gmail.com> writes: > OR2 depends on the old Refactoring Engine from 1999. I recently ported > some newer code of John Brant that avoids unnecessary reformatting. It > looks like O2 hasn't been updated yet. The refactoring tools should > work well in the default OmniBrowser. > > Lukas Is formatting when refactoring removed altogether? If so, that is great news! However, I get the same error with OBSystemBrowser. (I assume this is the "default OmniBrowser")? -- Henrik Jegbjerg Hansen

Nov. 22, 2009

Re: [Pharo-project] (no subject)

by Lukas Renggli

OR2 depends on the old Refactoring Engine from 1999. I recently ported some newer code of John Brant that avoids unnecessary reformatting. It looks like O2 hasn't been updated yet. The refactoring tools should work well in the default OmniBrowser. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Nov. 22, 2009