- Pharo-dev - lists.pharo.org

Re: Improving Variable Shadow model

by Marcus Denker

# Adding a Release test to check for shadowed vars defined at the level of a class Imagine we make a class like this: Object subclass: #MyClass instanceVariableNames: 'Array i' classVariableNames: 'Object' package: 'MyPackage' We can ask the class for all the variables it defines with #definedVariables. Thus is is easy to filter for the shadowing variables: ```Smalltalk MyClass definedVariables select: [ :variable | variable isShadowing ] "{#Array => InstanceVariableSlot. #Object->nil}" ``` With this, we now can easily scan the whole system for problematic classes: ```Smalltalk Smalltalk globals allBehaviors select: [ :class | class definedVariables anySatisfy: [:var | var isShadowing]]. ``` And interestingly, this returns results! Of course, our class MyClass as defined above, but in addition we do have 6 classes where class variables shadow globals. We should fix them at some point. For now, we can add a release test that ensures that we do not add more cases: ```Smalltalk testClassesShadow | classes validExceptions remaining | classes := Smalltalk globals allBehaviors select: [ :class | class definedVariables anySatisfy: [:var | var isShadowing]]. validExceptions := #(). remaining := classes asOrderedCollection reject: [ :each | validExceptions includes: each name]. "6 left that we need to fix" self assert: remaining size <= 6. ``` What we need next is a Code Critique rule. This for once warns developers early, but in addition it will make it much easier to fix the 6 problem cases seen above.

April 2, 2021

This week (13/2021) on the Pharo Issue Tracker

by Marcus Denker

We merged 32 Pull Requests and closed 24 issues on the main repository. But some PRs combine multiple fixes and commits, thus the real number is far higher. Merge NewTools 0.6 #8876 ======================== - This version introduces new Spotter tool! - uses style contributor (thanks @tesonep) to add styles for each tool (using it in spotter) - fixes cmd+p, and cmd+i, etc on playground. - fixes pharo-spec/NewTools#171 - fixes #8765 - fixes pharo-spec/NewTools#161 - fixes pharo-spec/NewTools#176 - several debugger fixes - cleanups - https://github.com/pharo-spec/NewTools/releases/tag/v0.6 Merge newtools 0.6.1 #8922 ========================== - fixes #5551 - fixes pharo-spec/NewTools#189 - fixes pharo-spec/NewTools#197 - fixes pharo-spec/NewTools#192 - fixes pharo-spec/NewTools#205 - spotter: showing of tips configurable - spotter: several small bug fixes/enhancements - inspector: Avoid errors when printing in title - https://github.com/pharo-spec/NewTools/releases/tag/v0.6.1 Spec 0.8.6 ============ - add cursorPositionIndex: to input fields - add beEditable property to input fields - https://github.com/pharo-spec/Spec/releases/tag/v0.8.6 Spec2 0.8.7 ============ - fixes SpFilteringSelectableListPresenter>>selectItems: - fix missing style apply for just-built layouts - https://github.com/pharo-spec/Spec/releases/tag/v0.8.7 Refactoring Engine ================== - RB - Improve extract setUp Refactoring #8877 https://github.com/pharo-project/pharo/pull/8877 - RB - Add preview when use "extract method refactoring" #8898 https://github.com/pharo-project/pharo/pull/8898 - RB - Replace method's senders by another #8903 https://github.com/pharo-project/pharo/pull/8903 - RB - Improve Extract Method Refactoring #8924 https://github.com/pharo-project/pharo/pull/8924 Improved Rules ============ - ReVariableReferencedOnceRule-show-varname #8874 https://github.com/pharo-project/pharo/pull/8874 - ReVariableAssignedLiteralRule-Skip-PoolVars #8882 https://github.com/pharo-project/pharo/pull/8882 - 8009-Rule-required-for-shadowed-variables #8917 https://github.com/pharo-project/pharo/pull/8917 First Class Variables ================= - Variable-model-Shadowing #8909 https://blog.marcusdenker.de/modeling-variable-shadowing https://github.com/pharo-project/pharo/pull/8909 - add SystemDictionary>>#resetReservedVariables #8907 https://github.com/pharo-project/pharo/pull/8907 - Speedup-reflective-read-IndexedSlot #8928 https://blog.marcusdenker.de/first-class-variables-speeding-up-reflective-v… https://github.com/pharo-project/pharo/pull/8928 Features ======== - Add CairoLibrary>>versionString #8880 https://github.com/pharo-project/pharo/pull/8880 - Add SDL2 class >> version #8912 https://github.com/pharo-project/pharo/pull/8912 - add isDoubleQuote method #8896 https://github.com/pharo-project/pharo/pull/8896 - 8194-Enhance-Welcome-with-Build-Date #8919 https://github.com/pharo-project/pharo/pull/8919 - Added RewriteRuleEditor to world menu #8902 https://github.com/pharo-project/pharo/pull/8902 Fixes ===== - Use LibraryFinder in CairoLibrary>>macLibraryName #8879 https://github.com/pharo-project/pharo/pull/8879 - 8793-some-settings-for-code-completion-are-not-working #8885 https://github.com/pharo-project/pharo/pull/8885 - Rolling back to the old morphic behavior (but in OUPS) when opening debuggers #8893 https://github.com/pharo-project/pharo/pull/8893 - [fix] fixes #8878: Fluid class and more got broken by recent calypso... #8884 https://github.com/pharo-project/pharo/pull/8884 - taskbarCloseAllLikeThis closes windows with the same name #8914 https://github.com/pharo-project/pharo/pull/8914 - 8525-Errors--Insufficient-buffer-size-to-read-current-working-directory-at-the-launch-of https://github.com/pharo-project/pharo/pull/8911 - [Redo #8894] Introduce bestNodeForAtPosition: by moving selector extractor heuristic. #8905 https://github.com/pharo-project/pharo/pull/8905 - 8793-some-settings-for-code-completion-are-not-working Part 2 #8895 https://github.com/pharo-project/pharo/pull/8895 Cleanups ======== - 8921 gtDisplayString should be deprecated and use displayString #8923 https://github.com/pharo-project/pharo/pull/8923 - 8814-Is-registerBreakableIndex-still-needed #8920 https://github.com/pharo-project/pharo/pull/8920 - testNoUnusedInstanceVariablesLeft-down-to-19 #8915 https://github.com/pharo-project/pharo/pull/8915 Comments ======== - fixes #8904 Better class comment for some SUnit classes #8913 https://github.com/pharo-project/pharo/pull/8913 - 6970-win32ModuleName-not-implemented #8842 https://github.com/pharo-project/pharo/pull/8842

April 2, 2021