- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Monticello diff between chosen revisionsisbroken

by StÃ©phane Ducasse

gary what would be great is to have a label on top of the two methods shown I never now what I'm reading Incoming InWorkingCopy New Current would be so great! Stef On Jan 25, 2010, at 7:25 PM, Gary Chambers wrote: > Yes, in this case it is a bug with Polymorph. > > Try with > > MCVersionInspector>>changes > "Open a patch morph for the changes." > > self viewChanges: self version changes > > > Hopefully no bad side-effects... > > With a bit more work it may be possible to show both versions between which the changes apply (unlike the old MC tools) ;-) > > Regards, Gary > ----- Original Message ----- > From: Gary Chambers > To: Pharo-project(a)lists.gforge.inria.fr > Sent: Monday, January 25, 2010 6:05 PM > Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken > > > MCVersionInspector>>diff > | ancestorVersion | > self pickAncestor ifNotNil: > [:ancestor | > ancestorVersion := self version workingCopy repositoryGroup versionWithInfo: ancestor. > (self version asDiffAgainst: ancestorVersion) open] > > > Regards, Gary > ----- Original Message ----- > From: Gary Chambers > To: Pharo-project(a)lists.gforge.inria.fr > Sent: Monday, January 25, 2010 5:50 PM > Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken > > Needs looking at since it is confusing. IIRC the Diff button creates a .mcd file of the changes between some versions... > > Regards, Gary > ----- Original Message ----- > From: Mariano Martinez Peck > To: Pharo-project(a)lists.gforge.inria.fr > Sent: Monday, January 25, 2010 5:34 PM > Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken > > > > 2010/1/25 Gary Chambers <gazzaguru2(a)btinternet.com> > The "Diff" button on the Monticello repository browser does what its balloon help says... > > 'Create an equivalent version based on an earlier release'. This is a diff version. I never use them as they can be confusing :-) > > > Ok...I never used before...but something is clear: the second ask about a version, has no sense, and even is wrong if it compares to the last version. See step 6 of Stefan. Then, we have to options: > > - Or we remove that second prompt, as it always will use the last version > - Or we change the diff implementation so that it uses the selected version instead of the last. > > What do you think ? > > Does someone really know what this "diff" should do ? > > Cheers > > Mariano > > If you want to compare two existing versions you should: > > 1. Open Monticello Browser > 2. Select a repo > 3. click open > 4. Select a revision, not the latest one > 5. Click HISTORY > > 6. chose an ancestor from the list > > > Regards, Gary > ----- Original Message ----- > From: Mariano Martinez Peck > To: Pharo-project(a)lists.gforge.inria.fr > Cc: Lukas Renggli > Sent: Sunday, January 24, 2010 12:59 PM > Subject: Re: [Pharo-project] Monticello diff between chosen revisions isbroken > > > > On Sat, Jan 23, 2010 at 9:51 PM, Stefan Marr <pharo(a)stefan-marr.de> wrote: > Hi: > > In the current dev image (10508), Monticello is broken with respect to showing the differences of between chosen revisions. > > However, that seems to be broken already in 10496. (and maybe earlier) > > To reproduce: > > 1. Open Monticello Browser > 2. Select a repo > 3. click open > 4. Select a revision, not the latest one > 5. Click diff > 6. chose an ancestor from the list > Now you got a window 'Version: ...5' > Saying (Diff against ...2) > Here I would expect the changes button to open a window showing the changes between the chosen revisions, but it always diffs against the latest version. > > > Yes, I could reproduce the problem. Can you open a ticket ? > > Maybe Lukas Monticello guru can help us ? hahaha > > Cheers > > Mariano > > > Best > Stefan > > -- > Stefan Marr > Software Languages Lab > Vrije Universiteit Brussel > Pleinlaan 2 / B-1050 Brussels / Belgium > http://soft.vub.ac.be/~smarr > Phone: +32 2 629 3956 > Fax: +32 2 629 3525 > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 26, 2010

Re: [Pharo-project] Monticello diff between chosen revisionsisbroken

by StÃ©phane Ducasse

Yes let us remove that. Stef On Jan 25, 2010, at 7:10 PM, Lukas Renggli wrote: >> Needs looking at since it is confusing. IIRC the Diff button creates a .mcd >> file of the changes between some versions... > > No this has nothing to do with .mcd. The .mcd thing was an experiment > (that should probably better be removed again) that did not always > safe a complete package but only a delta to the ancestor. I think it > has never been used in production and is quite buggy. > > Lukas > > > >> Regards, Gary >> >> ----- Original Message ----- >> From: Mariano Martinez Peck >> To: Pharo-project(a)lists.gforge.inria.fr >> Sent: Monday, January 25, 2010 5:34 PM >> Subject: Re: [Pharo-project] Monticello diff between chosen >> revisionsisbroken >> >> >> 2010/1/25 Gary Chambers <gazzaguru2(a)btinternet.com> >>> >>> The "Diff" button on the Monticello repository browser does what its >>> balloon help says... >>> >>> 'Create an equivalent version based on an earlier release'. This is a >>> diff version. I never use them as they can be confusing :-) >>> >> >> Ok...I never used before...but something is clear: the second ask about a >> version, has no sense, and even is wrong if it compares to the last version. >> See step 6 of Stefan. Then, we have to options: >> - Or we remove that second prompt, as it always will use the last version >> - Or we change the diff implementation so that it uses the selected version >> instead of the last. >> What do you think ? >> Does someone really know what this "diff" should do ? >> Cheers >> Mariano >> >>> >>> If you want to compare two existing versions you should: >>> >>> 1. Open Monticello Browser >>> 2. Select a repo >>> 3. click open >>> 4. Select a revision, not the latest one >>> 5. Click HISTORY >>> 6. chose an ancestor from the list >>> >>> Regards, Gary >>> >>> ----- Original Message ----- >>> From: Mariano Martinez Peck >>> To: Pharo-project(a)lists.gforge.inria.fr >>> Cc: Lukas Renggli >>> Sent: Sunday, January 24, 2010 12:59 PM >>> Subject: Re: [Pharo-project] Monticello diff between chosen revisions >>> isbroken >>> >>> >>> On Sat, Jan 23, 2010 at 9:51 PM, Stefan Marr <pharo(a)stefan-marr.de> wrote: >>>> >>>> Hi: >>>> >>>> In the current dev image (10508), Monticello is broken with respect to >>>> showing the differences of between chosen revisions. >>>> >>>> However, that seems to be broken already in 10496. (and maybe earlier) >>>> >>>> To reproduce: >>>> >>>> 1. Open Monticello Browser >>>> 2. Select a repo >>>> 3. click open >>>> 4. Select a revision, not the latest one >>>> 5. Click diff >>>> 6. chose an ancestor from the list >>>> Now you got a window 'Version: ...5' >>>> Saying (Diff against ...2) >>>> Here I would expect the changes button to open a window showing the >>>> changes between the chosen revisions, but it always diffs against the latest >>>> version. >>>> >>> >>> Yes, I could reproduce the problem. Can you open a ticket ? >>> >>> Maybe Lukas Monticello guru can help us ? hahaha >>> >>> Cheers >>> >>> Mariano >>> >>>> >>>> Best >>>> Stefan >>>> >>>> -- >>>> Stefan Marr >>>> Software Languages Lab >>>> Vrije Universiteit Brussel >>>> Pleinlaan 2 / B-1050 Brussels / Belgium >>>> http://soft.vub.ac.be/~smarr >>>> Phone: +32 2 629 3956 >>>> Fax: +32 2 629 3525 >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> ________________________________ >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> ________________________________ >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 26, 2010

Re: [Pharo-project] [ANN] Video Course on Smalltalk

by Geert Claes

Yep, do let us know when the English version is available! -- View this message in context: http://n2.nabble.com/ANN-Video-Course-on-Smalltalk-tp4454395p4459336.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Jan. 26, 2010

Re: [Pharo-project] new mac menu code :)

by Adrian Lienhard

Great! I updated http://code.google.com/p/pharo/issues/detail?id=1323 Adrian On Jan 26, 2010, at 00:26 , John M McIntosh wrote: > Ok, I figured it out, well I think I did.. Mariano is confirming... But I'll post the expected fix in this email. > > The problem is related to what InputEventSensor>>processEvent: does. > > Normally the expectation is that this method takes the existing event and does some type of post processing. > to set state or twiddle the event data, then return the modified event. > > However the EventTypeMenu is different and doesn't follow expectations. Instead generates > three synthetic keyboard events which are pushed to the queue and returns nil. > > Now the problem then is triggered if someone calls InputSensor>>peekEvent with just the right timing to > see the menu event on the queue. If that happens from Morph's desired to peek ahead to make decision on > mouse movement or keyboard interaction, then the side effect of the peek is to generate a duplicate set of > synthetic keystrokes. > > The fix is to alter peekEvent so that we ignore for EventTypeMenu > > peekEvent > "Look ahead at the next event." > | nextEvent | > nextEvent := eventQueue peek. > ^((nextEvent isNil not) and: [(nextEvent at: 1) ~= EventTypeMenu]) > ifTrue: [self processEvent: nextEvent] > > > > As for the changes earlier posted, we should run with those. Michael altered them to make the logic cleaner, and > I had to change the cmd-key to synthetic key generation to meet expectations based on changes done in the last 5 years. > > > On 2010-01-25, at 12:14 PM, StÃ©phane Ducasse wrote: > >>> File in Michael's change first, then mine > > -- > =========================================================================== > John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 > Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com > =========================================================================== > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 26, 2010

Re: [Pharo-project] [newbee] How do I save the contents of a Workspace?

by HernÃ¡n Morales Durand

Hi Alex, Notice that you don't need files to save workspaces, you may like the ScriptManager package, to install simply evaluate: Gofer new squeaksource: 'DeveloperWorkspace'; package: 'ScriptManager'; load. and open it from Tools -> More -> Script Manager Cheers, HernÃ¡n 2009/12/16 alesch <alex(a)schenkman.info>: > > I remember I used a menu item in Squeak, but I cannot find in Pharo. > > Thanks! > -- > View this message in context: http://n2.nabble.com/newbee-How-do-I-save-the-contents-of-a-Workspace-tp417… > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 26, 2010

Re: [Pharo-project] new mac menu code :)

by John M McIntosh

Ok, I figured it out, well I think I did.. Mariano is confirming... But I'll post the expected fix in this email. The problem is related to what InputEventSensor>>processEvent: does. Normally the expectation is that this method takes the existing event and does some type of post processing. to set state or twiddle the event data, then return the modified event. However the EventTypeMenu is different and doesn't follow expectations. Instead generates three synthetic keyboard events which are pushed to the queue and returns nil. Now the problem then is triggered if someone calls InputSensor>>peekEvent with just the right timing to see the menu event on the queue. If that happens from Morph's desired to peek ahead to make decision on mouse movement or keyboard interaction, then the side effect of the peek is to generate a duplicate set of synthetic keystrokes. The fix is to alter peekEvent so that we ignore for EventTypeMenu peekEvent "Look ahead at the next event." | nextEvent | nextEvent := eventQueue peek. ^((nextEvent isNil not) and: [(nextEvent at: 1) ~= EventTypeMenu]) ifTrue: [self processEvent: nextEvent] As for the changes earlier posted, we should run with those. Michael altered them to make the logic cleaner, and I had to change the cmd-key to synthetic key generation to meet expectations based on changes done in the last 5 years. On 2010-01-25, at 12:14 PM, StÃ©phane Ducasse wrote: >> File in Michael's change first, then mine -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================

Jan. 25, 2010

Re: [Pharo-project] help with removing a file

by John M McIntosh

I *think* you can run into problems if your evil windows virus package has the file OPEN has it's trying to figure out which of the 100 million viruses could exist in the file. This can cause your delete to fail. Maybe you have to wait 1000 milliseconds? for Norton to catch up? The windows code runs the following code, and there is a FAIL check to see if there is a duplicate file name based on case sensitivity. sqInt sqFileDeleteNameSize(char* fileNameIndex, sqInt fileNameSize) { WCHAR win32Path[MAX_PATH+1]; int sz; /* convert the file name into a null-terminated C string */ sz = MultiByteToWideChar(CP_UTF8, 0, fileNameIndex, fileNameSize, NULL, 0); if(sz > MAX_PATH) FAIL(); MultiByteToWideChar(CP_UTF8, 0, fileNameIndex, fileNameSize, win32Path, sz); win32Path[sz] = 0; if(hasCaseSensitiveDuplicate(win32Path)) FAIL(); if(!DeleteFileW(win32Path)) FAIL(); return 1; } On 2010-01-25, at 2:07 PM, Mariano Martinez Peck wrote: > Hi folks. I don't want other than green tests in dev images, thus, I started to fix them as much as possible. There are a lot of failing tests of Nile (only fail in windows). The test is NSCompressedSourceStreamTest and I noticed something weird. If you look to tearDown method, it tries to remove two files that it actually were created in the setUp method. > > But it is weird because it tries to remove a file that actually exist and it is not being removed. > > If I debug in DosFileDirectory >> deleteFileNamed: localFileName ifAbsent: failBlock > > everything looks ok, but the file is not removed and the failBlock is executed :( > > localFileName -> 'testCompressedSourceStream.stc' > > (self fullNameFor: localFileName) asVmPathName -> 'C:\mariano\squeak\imagenes\Pharo1.0-10508-rc2dev10.01.2\testCompressedSourceStream.stc' > > And that file exist, as you can see in screenshot that I attach. > > Can someone help me with this ? > > Cheers > > Mariano > <Picture 2.png>_______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================

Jan. 25, 2010

Re: [Pharo-project] Failing Gofer test in windows [WAS] [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Lukas Renggli

> Just make a bug report and put the version in the inbox (and make sure it's mergable, that is, > provide all nececary intermediate versions) It probably won't merge because I splitted the package into a Core and a Test package, so the tests don't have to be present as well. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 25, 2010

Re: [Pharo-project] Failing Gofer test in windows [WAS] [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Marcus Denker

On Jan 25, 2010, at 10:59 PM, Mariano Martinez Peck wrote: > hahahahahahahah > > BTW...do you know who/when merges your latest gofer code into PharoCore? > Just make a bug report and put the version in the inbox (and make sure it's mergable, that is, provide all nececary intermediate versions) Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

Jan. 25, 2010

Re: [Pharo-project] Failing Gofer test in windows [WAS] [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Dale Henrichs

On second thought .. I don't have too... I want to push Metacello 1.0-beta.22 today... Dale ----- "Dale Henrichs" <dale.henrichs(a)gemstone.com> wrote: | ----- "Mariano Martinez Peck" <marianopeck(a)gmail.com> wrote: | | | BTW...do you know who/when merges your latest gofer code into | | PharoCore? | | I'll hold off ConfigurationOfGofer until the bugfix is merged into | Pharo repository... | | Dale | | _______________________________________________ | Pharo-project mailing list | Pharo-project(a)lists.gforge.inria.fr | http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 25, 2010