- Pharo-dev - lists.pharo.org

[Pharo-project] Expectation for readFrom:... getting bored to fix bugs.

by stephane ducasse

Hi What are the expectation for DateAndTime>>readFrom? On squeak such tests do not pass. testReadFromFoolProofExtension "Convenient extension without a time, only a date" "self debug: #testReadFromFoolProofExtension" self assert: ('2008' asDateAndTime printString = '2008-01-01T00:00:00+00:00'). self assert: ('2008-08' asDateAndTime printString = '2008-08-01T00:00:00+00:00'). self assert: ('2006-08-28' asDateAndTime printString = '2006-08-28T00:00:00+00:00'). "Regular nanoseconds" self assert: ('2006-08-28T00:00:00.123456789' asDateAndTime printString = '2006-08-28T00:00:00.123456789+00:00'). "Extra picoseconds precision should not spoil the DateAndTime" self assert: ('2006-08-28T00:00:00.123456789000' asDateAndTime printString = '2006-08-28T00:00:00.123456789+00:00'). in Pharo DateAndTime>>rreadFrom: aStream | bc year month day hour minute second nanos offset buffer ch | aStream peek = $- ifTrue: [ aStream next. bc := -1] ifFalse: [bc := 1]. year := (aStream upTo: $-) asInteger * bc. month := (aStream upTo: $-) asInteger ifNil: [1]. day := (aStream upTo: $T) asInteger ifNil: [1]. hour := (aStream upTo: $:) asInteger ifNil: [0]. buffer := '00:' copy. ch := nil. minute := buffer writeStream. [ aStream atEnd | (ch = $:) | (ch = $+) | (ch = $-) ] whileFalse: [ ch := minute nextPut: aStream next. ]. (ch isNil or: [ch isDigit]) ifTrue: [ ch := $: ]. minute := (buffer readStream upTo: ch) asInteger. buffer := '00.' copy. second := buffer writeStream. [ aStream atEnd | (ch = $.) | (ch = $+) | (ch = $-) ] whileFalse: [ ch := second nextPut: aStream next. ]. (ch isNil or: [ch isDigit]) ifTrue: [ ch := $. ]. second := (buffer readStream upTo: ch) asInteger. buffer := '000000000' copy. (ch = $.) ifTrue: [ nanos := buffer writeStream. [ aStream atEnd | ((ch := aStream next) = $+) | (ch = $-) ] whileFalse: [ nanos nextPut: ch. ]. (ch isNil or: [ch isDigit]) ifTrue: [ ch := $+ ]. ]. nanos := buffer asInteger. aStream atEnd ifTrue: [ offset := Duration zero ] ifFalse: [ch := aStream next. ch = $+ ifTrue: [ch := Character space]. offset := Duration fromString: ch asString, '0:', aStream upToEnd, ':0']. ^ self year: year month: month day: day hour: hour minute: minute second: second nanoSecond: nanos offset: offset. It loosk a bit ugly and crashed on some inputs In Squeak they have code that looks cleaner readFrom: aStream | offset date time ch | date := Date readFrom: aStream. [aStream peek isDigit] whileFalse: [aStream next]. time := Time readFrom: aStream. aStream atEnd ifTrue: [ offset := Duration zero ] ifFalse: [ ch := aStream next. ch = $+ ifTrue: [ch := Character space]. offset := Duration fromString: ch asString, '0:', aStream upToEnd, ':0']. ^ self year: date year month: date monthIndex day: date dayOfMonth hour: time hour minute: time minute second: time second nanoSecond: time nanoSecond offset: offset Date ============================================================ For Date we have readFrom: aStream readFrom: pattern: "Read a Date from the stream in any of the forms: <day> <month> <year> (15 April 1982; 15-APR-82; 15.4.82; 15APR82) <month> <day> <year> (April 15, 1982; 4/15/82) Squeak has a better one readFrom: pattern: "Read a Date from the stream in any of the forms: <day> <month> <year> (15 April 1982; 15-APR-82; 15.4.82; 15APR82) <month> <day> <year> (April 15, 1982; 4/15/82) <year>-<month>-<day> (1982-04-15) (ISO8601)" I like the idea to have a readFrom: that is parsing a specific input and that the variations are handled in separate methods. So for DateAndTime we coudl have fuzzyReadFrom: aStream or something like that. Duration ====================================================== Now for Duration readFrom: the pattern is strictly followed "Formatted as per ANSI 5.8.2.16: [-]D:HH:MM:SS[.S]" In pharo it was bogus. So I was considering the one of Squeak, which looks cleaner. Pharo broke for (Duration readFrom: '0:00:00:00.001 ' readStream) nanoSeconds Squeak>>readFrom: aStream "Formatted as per ANSI 5.8.2.16: [-]D:HH:MM:SS[.S]" | sign days hours minutes seconds nanos nanosBuffer | sign := (aStream peekFor: $-) ifTrue: [-1] ifFalse: [1]. days := (aStream upTo: $:) asInteger sign: sign. hours := (aStream upTo: $:) asInteger sign: sign. minutes := (aStream upTo: $:) asInteger sign: sign. seconds := (aStream upTo: $.) asInteger sign: sign. nanosBuffer := '000000000' copy. nanos := WriteStream on: nanosBuffer. [aStream atEnd not and: [aStream peek isDigit]] whileTrue: [nanos nextPut: aStream next]. ^ self days: days hours: hours minutes: minutes seconds: seconds nanoSeconds: (nanosBuffer asInteger sign: sign) Pharo>>readFrom: aStream "Formatted as per ANSI 5.8.2.16: [-]D:HH:MM:SS[.S] To assiste DateAndTime>>#readFrom: SS may be unpadded or absent." | sign days hours minutes seconds nanos ws ch | sign := (aStream peekFor: $-) ifTrue: [-1] ifFalse: [1]. days := (aStream upTo: $:) asInteger sign: sign. hours := (aStream upTo: $:) asInteger sign: sign. minutes := (aStream upTo: $:) asInteger sign: sign. aStream atEnd ifTrue: [seconds := 0. nanos := 0] ifFalse: [ ws := String new writeStream. [ch := aStream next. (ch isNil) | (ch = $.)] whileFalse: [ ws nextPut: ch ]. seconds := ws contents asInteger sign: sign. ws reset. 9 timesRepeat: [ ch := aStream next. ws nextPut: (ch ifNil: [$0] ifNotNil: [ch]) ]. nanos := ws contents asInteger sign: sign]. ^ self days: days hours: hours minutes: minutes seconds: seconds nanoSeconds: nanos. ====================================================== Stef

April 24, 2010

[Pharo-project] Change Window Size

by Lukas Renggli

I am trying to change the window size in a headless build script on Linux, so that when I open the image on my Mac it appears bigger. DisplayScreen depth: DisplayScreen actualScreenDepth width: 1920 height: 1032 fullscreen: false There is no change though. Any other ideas on how to change the default VM window size? Lukas -- Lukas Renggli www.lukas-renggli.ch

April 24, 2010

Re: [Pharo-project] starting to think about 1.1 freeze

by StÃ©phane Ducasse

ok but this is still good to know what we could wrap up. Now I'm fixing some tests if somebody wants to help there are some problems on weak structures. Stef On Apr 24, 2010, at 10:31 AM, Marcus Denker wrote: > > On Apr 23, 2010, at 8:30 PM, Schwab,Wilhelm K wrote: > >> Stef, >> >> I will soon reach a point of missing a way to do callbacks. Alien/FFI is listed among the goals, and I would very much like to see that happen, especially if callbacks are well supported as a result. >> > > But what we should *not* do is to delay the release for that. Releases should be a snapshot of what is already done. 1.1 *as it is now* (minus bugs) is already a huge step > forward. If we delay that to make it even better, we will again delay the release for a looong time. > > I vote for just defininf 1.1 as what 1.1 is *now* and stabilize it. There will be a 1.2 anyway. > > Marcus > > > > -- > Marcus Denker -- http://www.marcusdenker.de > INRIA Lille -- Nord Europe. Team RMoD. > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 24, 2010

Re: [Pharo-project] starting to think about 1.1 freeze

by Marcus Denker

On Apr 23, 2010, at 8:30 PM, Schwab,Wilhelm K wrote: > Stef, > > I will soon reach a point of missing a way to do callbacks. Alien/FFI is listed among the goals, and I would very much like to see that happen, especially if callbacks are well supported as a result. > But what we should *not* do is to delay the release for that. Releases should be a snapshot of what is already done. 1.1 *as it is now* (minus bugs) is already a huge step forward. If we delay that to make it even better, we will again delay the release for a looong time. I vote for just defininf 1.1 as what 1.1 is *now* and stabilize it. There will be a 1.2 anyway. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

April 24, 2010

Re: [Pharo-project] about DateAndTime =

by StÃ©phane Ducasse

Indeed this would be good to fold TimeStamp in its superclass. I was not aware of this situation but now we will fix it. May be some care is needed to keep the nice printout of TimeStamp. If you have some pharo code send it. Stef On Apr 23, 2010, at 11:36 PM, Chris Muller wrote: > Hi Stef, I will help on the Squeak side. I suppose I could work on > that symmetry with Timestamp, but I'd rather talk about removing > Timestamp instead first.. It doesn't really seem like we need two > time-stamp classes, do we? > > > > On Fri, Apr 23, 2010 at 3:06 PM, StÃ©phane Ducasse > <stephane.ducasse(a)inria.fr> wrote: >> I'm turning this into tests! >> Brent if you want to help fixing let me know. >> I will focus now on the parsing problem. >> >> Stef >> >> On Apr 23, 2010, at 9:51 PM, Nicolas Cellier wrote: >> >>> 2010/4/23 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: >>>> Hi all >>>> >>>> I'm trying to fix some tests and I do not like the behavior of DateAndTime = >>>> Comparing aDateAndTime and a something tries to convert the something in a dateAndTime automagically. >>>> I find that not really good because it hides potential problem: manipulating string instead of objects. >>>> >>>> So I would like to have >>>> (aDateAndTime offset: '0:12:00:00') = '1901-01-01T00:00:00+12:00' -> false >>>> (aDateAndTime offset: '0:12:00:00') asString = '1901-01-01T00:00:00+12:00' -> true. >>>> >>>> What do you think. >>>> >>> >>> I would expect this for = >>> 1) Reflexive >>> self assert: x = x. >>> 2) Symmetric >>> self assert: (x = y) = (y = x). >>> 3) Transitive >>> self assert: (x = y) & (y = z) ==> (x = z). >>> >>> I guess equality with a String at least breaks 2). >>> >>> Nicolas >>> >>> >>>> Stef >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >

April 24, 2010

Re: [Pharo-project] about DateAndTime =

by StÃ©phane Ducasse

it will be :) http://code.google.com/p/pharo/issues/detail?id=2348 On Apr 23, 2010, at 11:18 PM, Brent Pinkney wrote: >> What is Timestamp? > > A legacy class that has a Date and a TIme object. > Predates ANSI DateAndTime. > > Should be purged IMHO. > > Brent > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 24, 2010

Re: [Pharo-project] about DateAndTime =

by StÃ©phane Ducasse

On Apr 23, 2010, at 10:25 PM, Henrik Johansen wrote: > It's still wrong though, in that it is not symmetric... > > Due to the isKindOf: self class test, and > = not being reimplemented in Timestamp (DateAndTime subclass), so Timestamp to DateAndTime comparitions will fail: > > aDateandTime = anEquivalentTimestamp true > anEquivalentTimestamp = aDateAndTime false > > There's a test for you! :D :) Stef > > Cheers, > Henry > > On Apr 23, 2010, at 10:01 30PM, StÃ©phane Ducasse wrote: > >> Thanks >> >> Chris about the speed what do you compare? >> using accessors to access month/date or something else. >> This is not clear to me. >> >> On Apr 23, 2010, at 9:49 PM, Chris Muller wrote: >> >>> In case anyone cares, Brent and I have been working together >>> professionally for the last couple of years. Brent, we have been >>> running with that method modified since 2007 to not do that >>> conversion. We have not sufferred any ill-effects from it. Check our >>> vanilla image: >>> >>> DateAndTime>>#= comparand >>> "comparand conforms to protocol DateAndTime, >>> or can be converted into something that conforms." >>> | comparandAsDateAndTime | >>> self == comparand ifTrue: [ ^ true ]. >>> (comparand isKindOf: self class) ifFalse: [ ^ false ]. >>> [ comparandAsDateAndTime := comparand asDateAndTime ] >>> on: MessageNotUnderstood >>> do: [ ^ false ]. >>> ^ self offset = comparandAsDateAndTime offset >>> ifTrue: [ self hasEqualTicks: comparandAsDateAndTime ] >>> ifFalse: [ self asUTC ticks = comparandAsDateAndTime asUTC ticks ] >>> >>> I agree with Stef on this. Not only is it confusing to me, it is >>> inconsistent with other type-checks. But the primary reason I >>> overrode it back in 2007 was for better performance. Try benching the >>> above against the stock comparison... >>> >>> - Chris >>> >>> On Fri, Apr 23, 2010 at 2:26 PM, Brent Pinkney <brent(a)zamail.co.za> wrote: >>>> On Friday 23 April 2010 21:12:03 StÃ©phane Ducasse wrote: >>>>> Hi all >>>>> >>>>> I'm trying to fix some tests and I do not like the behavior of DateAndTime >>>>> = Comparing aDateAndTime and a something tries to convert the something in >>>>> a dateAndTime automagically. I find that not really good because it hides >>>>> potential problem: manipulating string instead of objects. >>>>> >>>>> So I would like to have >>>>> (aDateAndTime offset: '0:12:00:00') = '1901-01-01T00:00:00+12:00' -> >>>>> false (aDateAndTime offset: '0:12:00:00') asString = >>>>> '1901-01-01T00:00:00+12:00' -> true. >>>>> >>>>> What do you think. >>>> >>>> Hi, >>>> >>>> I wrote that code, and it is needed to compare DateAndTimes with Timespans - eg Month, Year, Date... >>>> Please tread carefully - lots of production code relies on that. >>>> >>>> Already my (DateAndTime now != DateAndTime now) have been removed :( >>>> >>>> Thanks >>>> >>>> Brent >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 24, 2010

Re: [Pharo-project] about DateAndTime =

by Chris Muller

Hi Stef, I will help on the Squeak side. I suppose I could work on that symmetry with Timestamp, but I'd rather talk about removing Timestamp instead first.. It doesn't really seem like we need two time-stamp classes, do we? On Fri, Apr 23, 2010 at 3:06 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > I'm turning this into tests! > Brent if you want to help fixing let me know. > I will focus now on the parsing problem. > > Stef > > On Apr 23, 2010, at 9:51 PM, Nicolas Cellier wrote: > >> 2010/4/23 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: >>> Hi all >>> >>> I'm trying to fix some tests and I do not like the behavior of DateAndTime = >>> Comparing aDateAndTime and a something tries to convert the something in a dateAndTime automagically. >>> I find that not really good because it hides potential problem: manipulating string instead of objects. >>> >>> So I would like to have >>> Â Â Â Â (aDateAndTime offset: '0:12:00:00') = Â '1901-01-01T00:00:00+12:00' -> false >>> Â Â Â Â (aDateAndTime offset: '0:12:00:00') asString = Â '1901-01-01T00:00:00+12:00' -> true. >>> >>> What do you think. >>> >> >> I would expect this for = >> 1) Reflexive >> Â Â self assert: x = x. >> 2) Symmetric >> Â Â self assert: (x = y) = (y = x). >> 3) Transitive >> Â Â self assert: (x = y) & (y = z) ==> (x = z). >> >> I guess equality with a String at least breaks 2). >> >> Nicolas >> >> >>> Stef >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 23, 2010

Re: [Pharo-project] about DateAndTime =

by Brent Pinkney

> What is Timestamp? A legacy class that has a Date and a TIme object. Predates ANSI DateAndTime. Should be purged IMHO. Brent

April 23, 2010

Re: [Pharo-project] about DateAndTime =

by Chris Muller

What is Timestamp? On Fri, Apr 23, 2010 at 3:25 PM, Henrik Johansen <henrik.s.johansen(a)veloxit.no> wrote: > It's still wrong though, in that it is not symmetric... > > Due to the isKindOf: self class test, and > = Â not being reimplemented in Timestamp (DateAndTime subclass), so Timestamp to DateAndTime comparitions will fail: > > aDateandTime = anEquivalentTimestamp true > anEquivalentTimestamp = aDateAndTime false > > There's a test for you! :D > > Cheers, > Henry > > On Apr 23, 2010, at 10:01 30PM, StÃ©phane Ducasse wrote: > >> Thanks >> >> Chris about the speed what do you compare? >> using accessors to access month/date or something else. >> This is not clear to me. >> >> On Apr 23, 2010, at 9:49 PM, Chris Muller wrote: >> >>> In case anyone cares, Brent and I have been working together >>> professionally for the last couple of years. Â Brent, we have been >>> running with that method modified since 2007 to not do that >>> conversion. Â We have not sufferred any ill-effects from it. Â Check our >>> vanilla image: >>> >>> DateAndTime>>#= comparand >>> Â Â Â "comparand conforms to protocol DateAndTime, >>> Â Â Â or can be converted into something that conforms." >>> Â Â Â | comparandAsDateAndTime | >>> Â Â Â self == comparand ifTrue: [ ^ true ]. >>> Â Â Â (comparand isKindOf: self class) ifFalse: [ ^ false ]. >>> Â Â Â [ comparandAsDateAndTime := comparand asDateAndTime ] >>> Â Â Â Â Â Â Â on: MessageNotUnderstood >>> Â Â Â Â Â Â Â do: [ ^ false ]. >>> Â Â Â ^ self offset = comparandAsDateAndTime offset >>> Â Â Â Â Â Â Â ifTrue: [ self hasEqualTicks: comparandAsDateAndTime ] >>> Â Â Â Â Â Â Â ifFalse: [ self asUTC ticks = comparandAsDateAndTime asUTC ticks ] >>> >>> I agree with Stef on this. Â Not only is it confusing to me, it is >>> inconsistent with other type-checks. Â But the primary reason I >>> overrode it back in 2007 was for better performance. Â Try benching the >>> above against the stock comparison... >>> >>> - Chris >>> >>> On Fri, Apr 23, 2010 at 2:26 PM, Brent Pinkney <brent(a)zamail.co.za> wrote: >>>> On Friday 23 April 2010 21:12:03 StÃ©phane Ducasse wrote: >>>>> Hi all >>>>> >>>>> I'm trying to fix some tests and I do not like the behavior of DateAndTime >>>>> = Comparing aDateAndTime and a something tries to convert the something in >>>>> a dateAndTime automagically. I find that not really good because it hides >>>>> potential problem: manipulating string instead of objects. >>>>> >>>>> So I would like to have >>>>> Â Â Â (aDateAndTime offset: '0:12:00:00') = Â '1901-01-01T00:00:00+12:00' -> >>>>> false (aDateAndTime offset: '0:12:00:00') asString = >>>>> '1901-01-01T00:00:00+12:00' -> true. >>>>> >>>>> What do you think. >>>> >>>> Hi, >>>> >>>> I wrote that code, and it is needed to compare DateAndTimes with Timespans - eg Month, Year, Date... >>>> Please tread carefully - lots of production code relies on that. >>>> >>>> Already my (DateAndTime now != DateAndTime now) Â have been removed :( >>>> >>>> Thanks >>>> >>>> Brent >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 23, 2010