- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Stack should be reimplemented with Array

by StÃ©phane Ducasse

On Oct 19, 2010, at 1:23 AM, Igor Stasenko wrote: > On 19 October 2010 00:25, Levente Uzonyi <leves(a)elte.hu> wrote: >> On Mon, 18 Oct 2010, Igor Stasenko wrote: >> >>> Stephane, i could say more: >>> - i don't like how LinkedList implemented. >>> >>> I don't see why it should mimic things like #at: #at:put: at all.. >> >> It's not mimicing those methods. A list usually support things like this, >> but the user should know the consequences. >> > > The consequences of such approach is much more far-reaching: leads to > bad design practices, crappy application performance, > and then tons of bugs and workarounds. > >>> IMO this protocol should be pruned from it, to not provoke uses which >>> completely do not fit for given data structure. >> >> I'm not sure if it's okay to remove features, because users lacking really >> basic CS knowledge may use them the wrong way. >> > > Imo, we should prohibit this from the beginning. Standard, core > classes should not contain an API, which could lead to > careless, abusive programming techniques. Yes and we should have comments comments comments and comments. > IMO, a kernel APIs should serve not only as an implementation of basic > system funcionality, it also must serve as guide, > how to best use these facilities, so people will learn what is the > right way to use it. > > We should teach users to use right tools for things they need. > > >>> >>> Removing/inserting into the middle of list is quite ineffective >>> operation (O(n)), >> >> As long as you don't give away the link objects, it's O(n), otherwise it can >> be O(1). > > giving away link objects... oh, that's the worst thing, which could > possibly happen :) > >> >>> while inserting at the begginning/end of list is O(1). >>> >>> Lists are sequenceable.. but sequenceable ~~ indexable. Period. >> >> Sequenceable is indexable, but good performance is not guaranteed. >> > Unless you representing an infinite collection(s). > Streams are good example of sequenceable, however non-indexable containers. > > >> >> Levente >> >>> >>> -- >>> Best regards, >>> Igor Stasenko AKA sig. >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Best regards, > Igor Stasenko AKA sig. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 19, 2010

Re: [Pharo-project] Stack should be reimplemented with Array

by StÃ©phane Ducasse

one point at a time :) I'm talking about stack :) On Oct 18, 2010, at 10:49 PM, Igor Stasenko wrote: > Stephane, i could say more: > - i don't like how LinkedList implemented. > > I don't see why it should mimic things like #at: #at:put: at all.. > IMO this protocol should be pruned from it, to not provoke uses which > completely do not fit for given data structure. > > Removing/inserting into the middle of list is quite ineffective > operation (O(n)), > while inserting at the begginning/end of list is O(1). > > Lists are sequenceable.. but sequenceable ~~ indexable. Period. > > -- > Best regards, > Igor Stasenko AKA sig. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 19, 2010

Re: [Pharo-project] bad bracket autocompletion in Pharo Core 1.2

by StÃ©phane Ducasse

>> >> > > Maybe Pharo runs some hidden AI process, which refactors and changes > things under the hood? :) If we could educate it to autofix it this would be a clear win-win situation :) Seriously guillermo how this code arrived in since it is not in CUIS? Stef

Oct. 19, 2010

Re: [Pharo-project] Little change for Objects As Methods

by StÃ©phane Ducasse

Hi mariano I do not really like your solution. Implementing flushCache is not that bad in your class. It is not a bad compromise. May be it should be better documented. Stef > When you are using Objects as methods, MethodWrappers, or whatever with run:with:in, you have to implement not only that method, but also flushCache doing nothing because it is used in: > > MethodDictionary >> at: put: > > at: key put: value > "Set the value at key to be value." > | index | > index := self findElementOrNil: key. > (self basicAt: index) == nil > ifTrue: > [tally := tally + 1. > self basicAt: index put: key] > ifFalse: > [(array at: index) flushCache]. > array at: index put: value. > self fullCheck. > ^ value > > > Ok, I can implement that in my classes, and in MethodWrappers, but I think it would be nicer and cleanly if you only have to implement run:with:in: since flushChache doesn't make sense for normal objects. > > So, I would like to change that code to > > at: key put: value > "Set the value at key to be value." > | index | > index := self findElementOrNil: key. > (self basicAt: index) == nil > ifTrue: > [tally := tally + 1. > self basicAt: index put: key] > ifFalse: > [(array at: index) isCompiledMethod ifTrue: [flushCache]]. > array at: index put: value. > self fullCheck. > ^ value > > > Yes, yes, I know the if is ugly, but it gives us a cleaner way to define objects as methods. > The other option is to implement flushCache in Object doing nothing but I like it less than this. > > opinions? > > thanks > > mariano > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 19, 2010

[Pharo-project] Best way for embed a file on Smalltalk image method

by nullPointer

Hi IÂ´m doing a class for embed files in class methods. I want know if exists a best way for do that task than IÂ´m using... I do something like that... codeSource := CLStringBuilder new. codeSource appendLine: nameOfResource; tab; appendFormat: '^''{1}'' -> ''' withValues: {fileName}. readStream := FileStream readOnlyFileNamed: aFilePath. base64Contents := (Base64MimeConverter mimeEncode: readStream binary) contents. codeSource append: base64Contents asString. codeSource append:''''. CLSystem createMessageInClass: self withCodeSource: (codeSource asString) inProtocol: 'resources' inClassSide: true. I get the next result: courierNewBoldttf ^'Courier New Bold.ttf' -> 'AAEAAAATAQAABAAwRFNJR0rTjTkACiUQAAAbgEdERUYTqQ1VAApAkAAAAkxHUE9T3wr9iAAK QtwAADeeR1NVQgwWqYIACnp8AAAT1k9TLzIQrF1xAAABuAAAAGBWRE1YNVhPeQAAGrwAABGU Y21hcHepKTsAACxQAAAhqmN2dCCka4hDAABqbAAACA5mcGdtUXaa9wAATfwAAAdZZ2FzcAAW AAkACiUAAAAAEGdseWbVwXRoAACjvAAI9Z5oZWFk05ZxuQAAATwAAAA2aGhlYQrAAZoAAAF0 .......... '. Exists a enhanced way for do that? My main problem is the image grow very much. When I export to Monticello I get a file of 900 KB. When embed a file of 600KB the final size on Monticello file is 2MB!! and almost 4MB of difference in size of image :( Many thanks for the help -- View this message in context: http://forum.world.st/Best-way-for-embed-a-file-on-Smalltalk-image-method-t… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Oct. 19, 2010

[Pharo-project] Little change for Objects As Methods

by Mariano Martinez Peck

When you are using Objects as methods, MethodWrappers, or whatever with run:with:in, you have to implement not only that method, but also flushCache doing nothing because it is used in: MethodDictionary >> at: put: at: key put: value "Set the value at key to be value." | index | index := self findElementOrNil: key. (self basicAt: index) == nil ifTrue: [tally := tally + 1. self basicAt: index put: key] ifFalse: [(array at: index) flushCache]. array at: index put: value. self fullCheck. ^ value Ok, I can implement that in my classes, and in MethodWrappers, but I think it would be nicer and cleanly if you only have to implement run:with:in: since flushChache doesn't make sense for normal objects. So, I would like to change that code to at: key put: value "Set the value at key to be value." | index | index := self findElementOrNil: key. (self basicAt: index) == nil ifTrue: [tally := tally + 1. self basicAt: index put: key] ifFalse: [(array at: index) isCompiledMethod ifTrue: [flushCache]]. array at: index put: value. self fullCheck. ^ value Yes, yes, I know the if is ugly, but it gives us a cleaner way to define objects as methods. The other option is to implement flushCache in Object doing nothing but I like it less than this. opinions? thanks mariano

Oct. 19, 2010

[Pharo-project] Pharo full name screen ...

by Geert Claes

I noticed the screen where the user is asked for their full name (see attached) has a few usability issues: The window title "Information Required" is probably not descriptive enough. The user name is also specified in the Settings browser as the "Author identification" in the "Code browsing > Editing" section, so there should be some sort of consistency. Should it actually be possible to save a name using characters which are to be avoided as people tend to not read text? Should these characters really be avoided and if so why? How about asking for the author's full name and when typing the full name, unwanted characters will be stripped from the user name? http://forum.world.st/file/n3001669/startGSPharo3.png -- View this message in context: http://forum.world.st/Pharo-full-name-screen-tp3001669p3001669.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Oct. 19, 2010

Re: [Pharo-project] call for scripting idea

by Lukas Renggli

On 19 October 2010 09:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > why not :) > could you send them to the list so that we can see them? http://github.com/renggli/builder Lukas -- Lukas Renggli www.lukas-renggli.ch

Oct. 19, 2010

Re: [Pharo-project] Speeding up Pharo 1.1

by Henrik Sperre Johansen

On 19.10.2010 09:17, StÃ©phane Ducasse wrote: > How can we make progress on this issue? > > Stef As far as I can tell (again, I haven't actually experienced this slowdown), any of: - Port Levente's WeakKeyDictionary, which is much faster. - Wait for new VM's supporting Igors finalization scheme, which should be much faster (haven't tested it personally) - Rewrite the MC package caching to not use weak collections/ be smarter about what it keeps. Cheers, Henry

Oct. 19, 2010

Re: [Pharo-project] Speeding up Pharo 1.1

by Henrik Sperre Johansen

On 19.10.2010 09:14, StÃ©phane Ducasse wrote: > On Oct 18, 2010, at 10:19 PM, Nicolas Cellier wrote: > >> 2010/10/17 Levente Uzonyi<leves(a)elte.hu>: >>> On Sat, 16 Oct 2010, Bart Veenstra wrote: >>> >>>> Hi list, >>>> >>>> I have been working with Pharo for almost a month now, and I suspect >>>> that the performance is degrading fast. UI tasks takes several seconds >>>> to react to my keyboard. >>> That kind of sluggishness is probably related to finalization/gc. Please >>> send us the result of the following expression: >>> >>> (WeakArray classPool at: #FinalizationDependents) >>> select: [ :each | each notNil ] >>> thenCollect: [ :each | each class -> each size ] >>> >> While updating pharo 1.2, after an EndOfCentralDirectory error, I got >> a very unresponsive image... > can you reproduce it? > Which image ? > Which vm ? > Never heard about this error before If he means "Error: can't find EOCD position", that happens when squeaksource is down while you try updating. (If you inspect the zip stream it's trying to read, you'll see the request returned an html page containing the string: " SqueakSource is currently down. We are sorry for the inconvenience and working on the problem. In the meantime you can still commit to a directory repository on your disk and later copy the versions to SqueakSource." rather than the actual zip) I got it too when updating yesterday, my resulting image wasn't very unresponsive though. Cheers, Henry

Oct. 19, 2010