- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Failing tests in #development

by Christophe Demarey

> Le 19 dÃ©c. 2017 Ã 10:50, Esteban Lorenzano <estebanlm(a)gmail.com> a Ã©crit : > > but this is because we still need to stabilise the CI: what happens now is that we know some tests are failing randomly then we do not trust the CI to tell us everything is ok. > Then we accept PRs in red state. > Of course, this will fail eventually, and thatâs what we are seeing. > > Most important thing, IMO is to fix the CI: those tests that fails randomly (I think most of them are networking problems) needs to be fixed or removed. I think we should not rely on external services for our tests. We should mock every network service call to have a local version (still using the network). Then, you will not have failing tests because of timeout or network problem. With Zinc or Teapot itâs quite easy to set up a network service on a local port of the machine running tests.

Dec. 20, 2017

Re: [Pharo-dev] Failing tests in #development

by Stephane Ducasse

ahhhhhhhhhhh ok so this is then really nothing. Just blurs any further tests. So in case case we should do two PR on without iceberg and one for iceberg + change the test after... Seems to me a bit over kill. On Tue, Dec 19, 2017 at 6:37 PM, Cyril Ferlicot <cyril.ferlicot(a)gmail.com> wrote: > > On mar. 19 dÃ©c. 2017 at 18:27, Stephane Ducasse <stepharo.self(a)gmail.com> > wrote: >> >> Yes sorry I did not think that it could crash. >> I do not really understand why the tooltip can break only for one tool. > > > Hi, > > With the tooltips I added a test to ensure all tools have an explanation. > Currently there is one missing for Iceberg since it will be in its next > release. > >> > -- > Cyril Ferlicot > https://ferlicot.fr > > http://www.synectique.eu > 2 rue Jacques PrÃ©vert 01, > 59650 Villeneuve d'ascq France

Dec. 19, 2017

Re: [Pharo-dev] Does pharo build not retry anymore?

by Stephane Ducasse

agreed :) On Mon, Dec 18, 2017 at 11:43 AM, Guillermo Polito < guillermopolito(a)gmail.com> wrote: > Hi, just to not mistake my intentions :) > > I don't care WHO removed the retry or WHO fixed it. I care about the WHY. > > If the WHY is not clear nor documented, we risk to make the mistake again. > Please, let all of us be strict on the issue reports we do, and even > stricter on ourselves. We need to raise the quality bar, not move it down! > > And regarding this particular issue, I'd like to raise a warning. Let's > not fix symptoms, fix causes. If we fix the symptom, the problem is still > there. And moreover, if we fix the symptom and we lose track of it, we may > forget unless somebody realizes weeks afterwards and it is too late (not > this case fortunately). > > On Sat, Dec 16, 2017 at 9:47 PM, Stephane Ducasse <stepharo.self(a)gmail.com > > wrote: > >> tx them too. >> This is great to be surrounded by all you guys! >> >> >> On Sat, Dec 16, 2017 at 8:22 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com >> > wrote: >> >>> The UI Manager problem was fixed by Pablo and Guille >>> >>> -- Pavel >>> >>> 2017-12-16 13:06 GMT+01:00 Stephane Ducasse <stepharo.self(a)gmail.com>: >>> >>>> tx pavel >>>> >>>> On Sat, Dec 16, 2017 at 9:25 AM, Pavel Krivanek < >>>> pavel.krivanek(a)gmail.com> wrote: >>>> >>>>> The problems were related UIManager initialization and consequences >>>>> of the opening of the Welcome window. >>>>> >>>>> -- Pavel >>>>> >>>>> 2017-12-16 9:12 GMT+01:00 Stephane Ducasse <stepharo.self(a)gmail.com>: >>>>> >>>>>> Pavel what was the problem? >>>>>> >>>>>> Stef >>>>>> >>>>>> >>>>>> On Tue, Dec 12, 2017 at 9:34 PM, Pavel Krivanek < >>>>>> pavel.krivanek(a)gmail.com> wrote: >>>>>> >>>>>>> The variable value was reverted to the original value. Thanks. >>>>>>> >>>>>>> -- Pavel >>>>>>> >>>>>>> 2017-12-12 20:13 GMT+01:00 Pavel Krivanek <pavel.krivanek(a)gmail.com> >>>>>>> : >>>>>>> >>>>>>>> Yes, with Marcus we decreased the retryTimes variable two weeks >>>>>>>> ago to 1 because in that time the validations were in really bad shape and >>>>>>>> literally every validation failed on some random issue and the retries >>>>>>>> caused enormous build times. It was producing more troubles than profit. It >>>>>>>> probably can be reverted now because the main problem of the validation >>>>>>>> instability was suppressed. I will prepare a PR. >>>>>>>> >>>>>>>> -- Pavel >>>>>>>> >>>>>>>> 2017-12-12 18:52 GMT+01:00 Guillermo Polito < >>>>>>>> guillermopolito(a)gmail.com>: >>>>>>>> >>>>>>>>> I see that we are retrying tests only once, which is causing most >>>>>>>>> (if not all) pull requests to fail sporadically... >>>>>>>>> >>>>>>>>> Maybe it got lost because of a mistake? >>>>>>>>> >>>>>>>>> Also, I'd like that changes in the build process are discussed in >>>>>>>>> the mailing list from time to time... I've put a lot of effort into making >>>>>>>>> it work and if we have regressions I'd like to understand them... >>>>>>>>> >>>>>>>>> Guille >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Guille Polito >>>>>>>>> >>>>>>>>> Research Engineer >>>>>>>>> >>>>>>>>> Centre de Recherche en Informatique, Signal et Automatique de Lille >>>>>>>>> >>>>>>>>> CRIStAL - UMR 9189 >>>>>>>>> >>>>>>>>> French National Center for Scientific Research - *http://www.cnrs.fr >>>>>>>>> <http://www.cnrs.fr>* >>>>>>>>> >>>>>>>>> >>>>>>>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>>>>>>> >>>>>>>>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > > > -- > > > > Guille Polito > > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > > CRIStAL - UMR 9189 > > French National Center for Scientific Research - *http://www.cnrs.fr > <http://www.cnrs.fr>* > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >

Dec. 19, 2017

Re: [Pharo-dev] Failing tests in #development

by Cyril Ferlicot

On mar. 19 dÃ©c. 2017 at 18:27, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: > Yes sorry I did not think that it could crash. > I do not really understand why the tooltip can break only for one tool. > Hi, With the tooltips I added a test to ensure all tools have an explanation. Currently there is one missing for Iceberg since it will be in its next release. > -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Dec. 19, 2017

Re: [Pharo-dev] Dictionary newFromKeys: andValues:

by Stephane Ducasse

Thanks I will rework my PR because I lost some code and also did not see that SmallDictionary is not a HashedCollection On Mon, Dec 18, 2017 at 11:38 AM, Guillermo Polito < guillermopolito(a)gmail.com> wrote: > Yes I think this is good. > > On Fri, Dec 15, 2017 at 8:32 PM, Stephane Ducasse <stepharo.self(a)gmail.com > > wrote: > >> Hi >> >> I was looking at the Dictionary instance creation API and I would like to >> add >> newFromKeys:andValues: >> Because I do not see why I have to create associations when I have >> already the two collections. >> What do you think? >> >> Stef >> >> > > > -- > > > > Guille Polito > > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > > CRIStAL - UMR 9189 > > French National Center for Scientific Research - *http://www.cnrs.fr > <http://www.cnrs.fr>* > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >

Dec. 19, 2017

Re: [Pharo-dev] Failing tests in #development

by Stephane Ducasse

Yes sorry I did not think that it could crash. I do not really understand why the tooltip can break only for one tool. On Mon, Dec 18, 2017 at 9:12 AM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > it was a bad idea to integrate PR 606 [1] about the world menu tooltips > before it was green. Now we have failing tests in the development branch and > validations of new pull requests will fail immediately. > > Btw. I do not think this test should be in the ReleaseTest because these > tests should be valid for the minimal image too. > > [1] https://github.com/pharo-project/pharo/pull/606 > > -- Pavel >

Dec. 19, 2017

[Pharo 7.0-dev] Build #392: 20880-failing-test-testIfCompletelyBroken

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #392 was: FAILURE. The Pull Request #614 was integrated: "20880-failing-test-testIfCompletelyBroken" Pull request url: https://github.com/pharo-project/pharo/pull/614 Issue Url: https://pharo.fogbugz.com/f/cases/20880 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Dec. 19, 2017

[Pharo 7.0-dev] Build #391: 20880-failing-test-testIfCompletelyBroken

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #391 was: FAILURE. The Pull Request #614 was integrated: "20880-failing-test-testIfCompletelyBroken" Pull request url: https://github.com/pharo-project/pharo/pull/614 Issue Url: https://pharo.fogbugz.com/f/cases/20880 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Dec. 19, 2017

[Pharo 7.0-dev] Build #390: 20876-Drag-and-drop-of-methods-is-broken

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #390 was: FAILURE. The Pull Request #616 was integrated: "20876-Drag-and-drop-of-methods-is-broken" Pull request url: https://github.com/pharo-project/pharo/pull/616 Issue Url: https://pharo.fogbugz.com/f/cases/20876 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Dec. 19, 2017

Re: [Pharo-dev] [ANN] Pharo TechTalk Dec 19: Contributing to Pharo7

by Marcus Denker

Hi, Due to complete pre-holiday stress we sadly have to postpone this. > On 1 Dec 2017, at 09:18, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Pharo TechTalk December 19: > > - 19 Dec 2017 5:00 PM - 7:00 PM (UTC+01:00) > - Where? Discord / Youtube live > > Topic: Contributing. How to report bugs, submit code change. > > This will be a hands-on session where we show how to > > â¢ report bugs > â¢ create pull requests > â¢ help reviewing issues and pull requests > > > https://association.pharo.org/event-2642666

Dec. 19, 2017