- Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3342 in pharo: have a look at sharedQueue fixes from Levente

by pharo＠googlecode.com

Status: Accepted Owner: stephane.ducasse Labels: Milestone-1.3 Type-Squeak New issue 3342 by stephane.ducasse: have a look at sharedQueue fixes from Levente http://code.google.com/p/pharo/issues/detail?id=3342 Check the squeak mailing: the thread of 15 of november 2010: [squeak-dev] The Trunk: Kernel-ul.515.mcz Hi Folks, Please also restore Semaphore>>critical:ifLocked: It already includes this comment: "Note: The following is tricky and depends on the fact that the VM will not switch between processes while executing byte codes (process switches happen only in real sends). The following test is written carefully so that it will result in bytecodes only." To be more explicit, in Cuis it also says: "Do not change the following #== for #=, as #== is not a real message send, just a bytecode." It's unnecessary, because #= also has it's own bytecode in the current VM. So #= won't be a real message send in this case, because both excessSignals and 0 are SmallIntegers. Also, this method has a bug. There's no guarantee, that the sender won't wait for the semaphore. I uploaded a fix to the Inbox for review recently, though I didn't get any feedback on it: http://lists.squeakfoundation.org/pipermail/squeak-dev/2010-November/155058…

Nov. 27, 2010

Re: [Pharo-project] Issue 3341 in pharo: use #= for integer comparison instead of #==

by pharo＠googlecode.com

Comment #3 on issue 3341 by stephane.ducasse: use #= for integer comparison instead of #== http://code.google.com/p/pharo/issues/detail?id=3341 Name: Kernel-dtl.517 Author: dtl Time: 15 November 2010, 12:49:28.804 pm UUID: 2c83e064-fa7d-4fc0-8e81-140b88e48a49 Ancestors: Kernel-ul.516 Revert last change to Semaphore>>critical:ifLocked: using latest version from Cuis, which adds a method comment to explain the reason for use of #== rather than #= =============== Diff against Kernel-ul.516 =============== Item was changed: ----- Method: Semaphore>>critical:ifLocked: (in category 'mutual exclusion') ----- critical: mutuallyExcludedBlock ifLocked: alternativeBlock "Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished." + "Note: The following is tricky and depends on the fact that the VM will not switch between processes while executing byte codes (process switches happen only in real sends). The following test is written carefully so that it will result in bytecodes only. + Do not change the following #== for #=, as #== is not a real message send, just a bytecode." + excessSignals == 0 ifTrue: [ - "Note: The following is tricky and depends on the fact that the VM will not switch between processes while executing byte codes (process switches happen only in real sends). The following test is written carefully so that it will result in bytecodes only." - excessSignals = 0 ifTrue:[ "If we come here, then the semaphore was locked when the test executed. Evaluate the alternative block and answer its result." ^alternativeBlock value ]. ^self critical: mutuallyExcludedBlock!

Nov. 27, 2010

Re: [Pharo-project] How to build a multipart MIME email message

by Tony Fleig

Yes, I looked at MailMessage, but there appears to be only one method to add MIME content to the message, AddAttachmentFrom:withName, and it assumes a base64-encoded attachment. I'm okay with extending it to support text/plain and text/html parts, but I don't want to do that if the capability already exists somewhere. Regards, TF On Sat, Nov 27, 2010 at 7:25 AM, Adrian Lienhard <adi(a)netstyle.ch> wrote: > Have you looked at MailMessage? It supports multi-part mails. > > Cheers, > Adrian > > > On Nov 27, 2010, at 16:15 , Tony Fleig wrote: > > > Okay, a follow on question then: Are the MIME-related classes present in > > Pharo/Seaside intended to allow one to build a MIME document or only to > > read/parse one? > > > > I really do need this functionality, so I will probably build it if it is > > not there -- probably patterned after what is in VisualWorks (see > > > http://forum.world.st/Multipart-MIME-email-message-HTML-plus-plain-text-td1… > > .) > > > > Thanks again, > > TF > > > > On Sat, Nov 27, 2010 at 12:09 AM, StÃ©phane Ducasse < > > stephane.ducasse(a)inria.fr> wrote: > > > >> if you build one we would like to integrate it. > >> as test would be gorgeous > >> > >> On Nov 27, 2010, at 4:34 AM, Tony Fleig wrote: > >> > >>> Is there an example of how to construct a multi-part (text/plain and > >> text/html) MIME email message in Pharo/Seaside anywhere? > >>> > >>> Thanks, > >>> TF > >> > >> > >> > > >

Nov. 27, 2010

Re: [Pharo-project] Issue 3341 in pharo: use #= for integer comparison instead of #==

by pharo＠googlecode.com

Comment #2 on issue 3341 by stephane.ducasse: use #= for integer comparison instead of #== http://code.google.com/p/pharo/issues/detail?id=3341 http://source.squeak.org/trunk/Kernel-ul.516.mcz ==================== Summary ==================== Name: Kernel-ul.516 Author: ul Time: 15 November 2010, 11:23:57.645 am UUID: 6faf4568-4121-8543-897b-a4aef9f01454 Ancestors: Kernel-ul.515 - reverted Object >> #inboundPointersExcluding: and added a comment with some explanation about the use of #==. =============== Diff against Kernel-ul.515 =============== Item was changed: ----- Method: Object>>inboundPointersExcluding: (in category 'tracing') ----- inboundPointersExcluding: objectsToExclude "Answer a list of all objects in the system that point to me, excluding those in the collection of objectsToExclude. I do my best to avoid creating any temporary objects that point to myself, especially method and block contexts. Adapted from PointerFinder class >> #pointersTo:except:" | anObj pointers objectsToAlwaysExclude | Smalltalk garbageCollect. "big collection shouldn't grow, so it's contents array is always the same" pointers := OrderedCollection new: 1000. "#allObjectsDo: and #pointsTo: are expanded inline to keep spurious method and block contexts out of the results" anObj := self someObject. + [0 == anObj] whileFalse: [ "We must use #== here, to avoid leaving the loop when anObj is another number that's equal to 0 (e.g. 0.0)." - [0 = anObj] whileFalse: [ anObj isInMemory ifTrue: [((anObj instVarsInclude: self) or: [anObj class == self]) ifTrue: [pointers add: anObj]]. anObj := anObj nextObject]. objectsToAlwaysExclude := { pointers collector. thisContext. thisContext sender. thisContext sender sender. objectsToExclude. }. ^ pointers removeAllSuchThat: [:ea | (objectsToAlwaysExclude identityIncludes: ea) or: [objectsToExclude identityIncludes: ea]]!

Nov. 27, 2010

Re: [Pharo-project] Issue 3341 in pharo: use #= for integer comparison instead of #==

by pharo＠googlecode.com

Comment #1 on issue 3341 by stephane.ducasse: use #= for integer comparison instead of #== http://code.google.com/p/pharo/issues/detail?id=3341 <CompiledMethod>scanForEqSmallConstant "Answer whether the receiver contains the pattern <expression> == <constant>, where constant is -1, 0, 1, or 2..." | scanner | scanner _ InstructionStream on: self. ^ scanner scanFor: [:instr | (instr between: 116 and: 119) and: [scanner followingByte = 198]] " SystemNavigation new browseAllSelect: [:m | m scanForEqSmallConstant] "

Nov. 27, 2010

Re: [Pharo-project] PipeableOSProcess #close

by David T. Lewis

On Sat, Nov 27, 2010 at 10:07:54AM -0500, Schwab,Wilhelm K wrote: > Dave, > > FWIW, I also ran into this one: > > http://article.gmane.org/gmane.comp.lang.smalltalk.squeak.general/121000/ma… > > Is there a time when a user/programmer would want to send #close rather > than #closePipes? Perhaps #close could become #basicClose with #close > then being changed to send #closePipes. #closePipes seems like something > that might be private; it's (almost) obvious now, but it looks like a > recurring trap for casual users. Yes, there is definitely a time for using #close rather than #closePipes. In the context of a PipeableOSProcess, #close means "I am done writing things to you". That means that the external process will see EOF on its input, and presumably will complete its processing and write some additional output. You do not want to do a #closePipes at this point, because that will make it impossible to read that last output from the external process. I left the responsibility for calling #closePipes with the user of the PipeableOSProcess, who will presumably read data up to end of file and then close the pipes when done. You're right, it's a recurring trap for casual users. It's also an inherently asynchronous operation, and I don't know an easy way to make it right for all use cases. To some extent it depends on how you intend to use it; if the external process is a /bin/ls command, then you probably would want to run the program, close the input, read all output up to end of file, then close all pipes. On the other hand, if the external process is /usr/bin/wish (a Tk/Tcl interpreter), then you want to just run the program and keep all pipes open until you are done interacting with the external interpreter. > It appears that I had been having intermittent problems with this for > a while. Yesterday, I ran a big batch that would not go to completion, > and I noted that after the first error, pretty much every file operation > failed. The latter lead me to strongly suspect cleanup of the pipes, > and the above was then easy to find. The batch runs nicely now. Good! Dave

Nov. 27, 2010

[Pharo-project] Issue 3341 in pharo: use #= for integer comparison instead of #==

by pharo＠googlecode.com

Status: Accepted Owner: stephane.ducasse Labels: Milestone-1.3 Type-Squeak New issue 3341 by stephane.ducasse: use #= for integer comparison instead of #== http://code.google.com/p/pharo/issues/detail?id=3341 Please read the original statement of dan. http://bugs.squeak.org/view.php?id=2788 I think that this bunch of fixes are important. ==================== Summary ==================== Name: Collections-ul.406 Author: ul Time: 15 November 2010, 10:30:39.825 am UUID: 9cd8fc97-4673-3340-9ea2-2f3dbd5f38e3 Ancestors: Collections-cmm.405 - use #= for integer comparison instead of #== (http://bugs.squeak.org/view.php?id=2788 ) =============== Diff against Collections-cmm.405 =============== Item was changed: ----- Method: SequenceableCollection>>after:ifAbsent: (in category 'accessing') ----- after: target ifAbsent: exceptionBlock "Answer the element after target. Answer the result of evaluation the exceptionBlock if target is not in the receiver, or if there are no elements after it." | index | index := self indexOf: target. + ^ (index = 0 or: [index = self size]) - ^ (index == 0 or: [index = self size]) ifTrue: [exceptionBlock value] ifFalse: [self at: index + 1]! Item was changed: ----- Method: SequenceableCollection>>before:ifAbsent: (in category 'accessing') ----- before: target ifAbsent: exceptionBlock "Answer the receiver's element immediately before target. Answer the result of evaluating the exceptionBlock if target is not an element of the receiver, or if there are no elements before it." | index | index := self indexOf: target. + ^ (index = 0 or: [index = 1]) - ^ (index == 0 or: [index == 1]) ifTrue: [exceptionBlock value] ifFalse: [self at: index - 1]! Item was changed: ----- Method: String>>asIdentifier: (in category 'converting') ----- asIdentifier: shouldBeCapitalized "Return a legal identifier, with first character in upper case if shouldBeCapitalized is true, else lower case. This will always return a legal identifier, even for an empty string" | aString firstChar firstLetterPosition | aString := self select: [:el | el isAlphaNumeric]. firstLetterPosition := aString findFirst: [:ch | ch isLetter]. + aString := firstLetterPosition = 0 - aString := firstLetterPosition == 0 ifFalse: [aString copyFrom: firstLetterPosition to: aString size] ifTrue: ['a', aString]. firstChar := shouldBeCapitalized ifTrue: [aString first asUppercase] ifFalse: [aString first asLowercase]. ^ firstChar asString, (aString copyFrom: 2 to: aString size) " '234Fred987' asIdentifier: false '235Fred987' asIdentifier: true '' asIdentifier: true '()87234' asIdentifier: false '())z>=PPve889 U >' asIdentifier: false "! Item was changed: ----- Method: String>>initialIntegerOrNil (in category 'converting') ----- initialIntegerOrNil "Answer the integer represented by the leading digits of the receiver, or nil if the receiver does not begin with a digit" | firstNonDigit | + (self size = 0 or: [self first isDigit not]) ifTrue: [^ nil]. - (self size == 0 or: [self first isDigit not]) ifTrue: [^ nil]. firstNonDigit := (self findFirst: [:m | m isDigit not]). firstNonDigit = 0 ifTrue: [firstNonDigit := self size + 1]. ^ (self copyFrom: 1 to: (firstNonDigit - 1)) asNumber " '234Whoopie' initialIntegerOrNil 'wimpy' initialIntegerOrNil '234' initialIntegerOrNil '2N' initialIntegerOrNil '2' initialIntegerOrNil ' 89Ten ' initialIntegerOrNil '78 92' initialIntegerOrNil " ! Item was changed: ----- Method: String>>sansPeriodSuffix (in category 'converting') ----- sansPeriodSuffix "Return a copy of the receiver up to, but not including, the first period. If the receiver's *first* character is a period, then just return the entire receiver. " | likely | likely := self copyUpTo: $.. + ^ likely size = 0 - ^ likely size == 0 ifTrue: [self] ifFalse: [likely]! Item was changed: ----- Method: String>>utf8ToIso (in category 'internet') ----- utf8ToIso "Only UTF-8 characters that maps to 8-bit ISO-8559-1 values are converted. Others raises an error" | s i c v c2 v2 | s := WriteStream on: (String new: self size). i := 1. [i <= self size] whileTrue: [ c := self at: i. i:=i+1. v := c asciiValue. (v > 128) ifFalse: [ s nextPut: c ] + ifTrue: [((v bitAnd: 252) = 192) - ifTrue: [((v bitAnd: 252) == 192) ifFalse: [self error: 'illegal UTF-8 ISO character'] ifTrue: [ (i > self size) ifTrue: [ self error: 'illegal end-of-string, expected 2nd byte of UTF-8']. c2 := self at: i. i:=i+1. v2 := c2 asciiValue. ((v2 bitAnd: 192) = 128) ifFalse: [self error: 'illegal 2nd UTF-8 char']. s nextPut: ((v2 bitAnd: 63) bitOr: ((v << 6) bitAnd: 192)) asCharacter]]]. ^s contents. ! Item was changed: ----- Method: Symbol class>>selectorsContaining: (in category 'access') ----- selectorsContaining: aString "Answer a list of selectors that contain aString within them. Case-insensitive. Does return symbols that begin with a capital letter." | size selectorList ascii | selectorList := OrderedCollection new. (size := aString size) = 0 ifTrue: [^selectorList]. aString size = 1 ifTrue: [ ascii := aString first asciiValue. ascii < 128 ifTrue: [selectorList add: (OneCharacterSymbols at: ascii+1)] ]. (aString first isLetter or: [aString first isDigit]) ifFalse: [ + aString size = 2 ifTrue: - aString size == 2 ifTrue: [Symbol hasInterned: aString ifTrue: [:s | selectorList add: s]]. ^selectorList ]. selectorList := selectorList copyFrom: 2 to: selectorList size. self allSymbolTablesDo: [:each | each size >= size ifTrue: [(each findSubstring: aString in: each startingAt: 1 matchTable: CaseInsensitiveOrder) > 0 ifTrue: [selectorList add: each]]]. ^selectorList reject: [:each | "reject non-selectors, but keep ones that begin with an uppercase" each numArgs < 0 and: [each asString withFirstCharacterDownshifted numArgs < 0]]. "Symbol selectorsContaining: 'scon'"! Item was changed: ----- Method: Symbol>>isInfix (in category 'testing') ----- isInfix "Answer whether the receiver is an infix message selector." + ^ self precedence = 2! - ^ self precedence == 2! Item was changed: ----- Method: Symbol>>isKeyword (in category 'testing') ----- isKeyword "Answer whether the receiver is a message keyword." + ^ self precedence = 3! - ^ self precedence == 3! Item was changed: ----- Method: Symbol>>isUnary (in category 'testing') ----- isUnary "Answer whether the receiver is an unary message selector." + ^ self precedence = 1! - ^ self precedence == 1!

Nov. 27, 2010

[Pharo-project] Issue 3340 in pharo: ThreadSafe DebuggerMethodMap

by pharo＠googlecode.com

Status: Accepted Owner: stephane.ducasse Labels: Milestone-1.3 Type-Squeak New issue 3340 by stephane.ducasse: ThreadSafe DebuggerMethodMap http://code.google.com/p/pharo/issues/detail?id=3340 We should have a look at that fix from squeak A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ul.278.mcz ==================== Summary ==================== Name: Tools-ul.278 Author: ul Time: 15 November 2010, 8:46:10.672 am UUID: d03d7286-1db1-f943-9e1c-6e86626b5f89 Ancestors: Tools-ul.277 Thread-safe DebuggerMethodMap =============== Diff against Tools-ul.277 =============== Item was changed: Object subclass: #DebuggerMethodMap instanceVariableNames: 'timestamp methodReference methodNode abstractSourceRanges sortedSourceMap' + classVariableNames: 'AccessLock MapCache MapCacheEntries' - classVariableNames: 'MapCache MapCacheEntries' poolDictionaries: '' category: 'Tools-Debugger'! !DebuggerMethodMap commentStamp: '<historical>' prior: 0! I am a place-holder for information needed by the Debugger to inspect method activations. I insulate the debugger from details of code generation such as exact bytecode offsets and temporary variable locations. I have two concreate subclasses, one for methods compiled using BlueBook blocks and one for methods compiled using Closures. These classes deal with temporary variable access. My function is to abstract the source map away from actual bytecode pcs to abstract bytecode pcs. To reduce compilation time I try and defer as much computation to access time as possible as instances of me will be created after each compilation. I maintain a WeakIdentityDictionary of method to DebuggerMethodMap to cache maps. I refer to my method through a WeakArray to keep the map cache functional. If the reference from a DebuggerMethodMap to its method were strong then the method would never be dropped from the cache because the reference from its map would keep it alive.! Item was changed: ----- Method: DebuggerMethodMap class>>cacheDebugMap:forMethod: (in category 'debugger support') ----- cacheDebugMap: aDebuggerMethodMap forMethod: aCompiledMethod + + ^self protected: [ + MapCache size >= MapCacheEntries ifTrue: [ + MapCache slowSize >= MapCacheEntries + ifFalse: [ MapCache rehash ] + ifTrue: [ + | mapsByAge | + mapsByAge := MapCache keys sort: [ :m1 :m2 | + "We are holding strongly on the keys, so #at: is suitable." + (MapCache at: m1) timestamp < (MapCache at: m2) timestamp]. + mapsByAge from: 1 to: mapsByAge size - MapCacheEntries do: [ :each | + MapCache removeKey: each ] ] ]. + MapCache + at: aCompiledMethod + put: aDebuggerMethodMap ]! - MapCache finalizeValues. - [MapCache size >= MapCacheEntries] whileTrue: - [| mapsByAge | - mapsByAge := MapCache keys asArray sort: - [:m1 :m2| - (MapCache at: m1) timestamp - < (MapCache at: m2) timestamp]. - mapsByAge notEmpty ifTrue: "There be race conditions and reentrancy issues here" - [MapCache removeKey: mapsByAge last]]. - - ^MapCache - at: aCompiledMethod - put: aDebuggerMethodMap! Item was changed: ----- Method: DebuggerMethodMap class>>forMethod: (in category 'instance creation') ----- forMethod: aMethod "<CompiledMethod>" "Answer a DebuggerMethodMap suitable for debugging activations of aMethod. Answer an existing instance from the cache if it exists, cacheing a new one if required." + + ^self protected: [ + MapCache + at: aMethod + ifAbsent: [self + cacheDebugMap: + (self + forMethod: aMethod + methodNode: aMethod methodNode) + forMethod: aMethod] ]! - ^MapCache - at: aMethod - ifAbsent: [self - cacheDebugMap: - (self - forMethod: aMethod - methodNode: aMethod methodNode) - forMethod: aMethod]! Item was added: + ----- Method: DebuggerMethodMap class>>protected: (in category 'synchronization') ----- + protected: aBlock + + ^(AccessLock ifNil: [ AccessLock := Mutex new ]) critical: aBlock! Item was changed: ----- Method: DebuggerMethodMap class>>voidMapCache (in category 'class initialization') ----- voidMapCache + + self protected: [ + MapCache := WeakIdentityKeyDictionary new. + MapCacheEntries := 16 ]! - MapCache := WeakIdentityKeyDictionary new. - MapCacheEntries := 16!

Nov. 27, 2010

Re: [Pharo-project] Is FFI (installation) broken?

by Mariano Martinez Peck

Hi John. That link is outdated :( We do not use ScriptLoader anymore to install packages. The recommended way to install external packages in Pharo is now using Metacello. To install FFI in Pharo, evaluate: Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfFFI'; load. ((Smalltalk at: #ConfigurationOfFFI) project version: '1.3') load. For more information about Metacello: http://code.google.com/p/metacello/ On Sat, Nov 27, 2010 at 4:18 PM, John Cromartie <jcromartie(a)gmail.com>wrote: > I followed the advice here: > http://code.google.com/p/pharo/wiki/CodeSnippets > > I tried to do: > > ScriptLoader loadFFI. > > but the method loadFFI does not exist. > >

Nov. 27, 2010

[Pharo-project] Issue 3339 in pharo: WeakOrderedCollection

by pharo＠googlecode.com

Status: Accepted Owner: stephane.ducasse Labels: Milestone-1.3 New issue 3339 by stephane.ducasse: WeakOrderedCollection http://code.google.com/p/pharo/issues/detail?id=3339 Squeak got weak ordered collection and we could want to have that too.

Nov. 27, 2010