- Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3549 in pharo: ChooseClassOrTrait

by pharo＠googlecode.com

Status: Accepted Owner: stephane...(a)gmail.com New issue 3549 by stephane...(a)gmail.com: ChooseClassOrTrait http://code.google.com/p/pharo/issues/detail?id=3549 ==================== Summary ==================== Name: ToolBuilder-Kernel-ul.39 Author: ul Time: 12 December 2010, 11:18:16.463 pm UUID: 68b3bc0b-91c7-8e4c-8ad1-1f9a1ae18f3a Ancestors: ToolBuilder-Kernel-ar.38 - added UIManager >> #chooseClassOrTrait:from: as a common way to select a class or trait from an environment (SystemDictionary) =============== Diff against ToolBuilder-Kernel-ar.38 =============== Item was added: + ----- Method: UIManager>>chooseClassOrTrait (in category 'ui requests') ----- + chooseClassOrTrait + "Let the user choose a Class or Trait" + + ^self chooseClassOrTrait: 'Class name or fragment?'! Item was added: + ----- Method: UIManager>>chooseClassOrTrait: (in category 'ui requests') ----- + chooseClassOrTrait: label + "Let the user choose a Class or Trait" + + ^self chooseClassOrTrait: label from: Smalltalk environment! Item was added: + ----- Method: UIManager>>chooseClassOrTrait:from: (in category 'ui requests') ----- + chooseClassOrTrait: label from: environment + "Let the user choose a Class or Trait." + + | pattern | + pattern := self request: label. + ^Utilities classOrTraitFrom: environment pattern: pattern label: label + ! Item was added: + ----- Method: Utilities class>>classFromPattern:withCaption: (in category '*ToolBuilder-Kernel') ----- + classFromPattern: pattern withCaption: aCaption + "If there is a class or trait whose name exactly given by pattern, return it. + If there is only one class or trait in the system whose name matches pattern, return it. + Otherwise, put up a menu offering the names of all classes that match pattern, and return the class chosen, else nil if nothing chosen. + This method ignores separator characters in the pattern" + + ^self classOrTraitFrom: Smalltalk environment pattern: pattern label: aCaption + " + self classFromPattern: 'CharRecog' withCaption: '' + self classFromPattern: 'rRecog' withCaption: '' + self classFromPattern: 'znak' withCaption: '' + self classFromPattern: 'orph' withCaption: '' + self classFromPattern: 'TCompil' withCaption: '' + " + ! Item was added: + ----- Method: Utilities class>>classOrTraitFrom:pattern:label: (in category '*ToolBuilder-Kernel') ----- + classOrTraitFrom: environment pattern: pattern label: label + "If there is a class or trait whose name exactly given by pattern, return it. + If there is only one class or trait in the given environment whose name matches pattern, return it. + Otherwise, put up a menu offering the names of all classes that match pattern, and return the class chosen, else nil if nothing chosen. + This method ignores separator characters in the pattern" + + | toMatch potentialNames names exactMatch lines reducedIdentifiers selectedIndex | + toMatch := pattern copyWithoutAll: Character separators. + toMatch ifEmpty: [ ^nil ]. + "If there's a class or trait named as pattern, then return it." + Symbol hasInterned: pattern ifTrue: [ :symbol | + environment at: symbol ifPresent: [ :maybeClassOrTrait | + ((maybeClassOrTrait isKindOf: Class) or: [ + maybeClassOrTrait isTrait ]) + ifTrue: [ ^maybeClassOrTrait ] ] ]. + "No exact match, look for potential matches." + toMatch := pattern asLowercase copyWithout: $.. + potentialNames := environment classAndTraitNames. + names := pattern last = $. "This is some old hack, using String>>#match: may be better." + ifTrue: [ potentialNames select: [ :each | each asLowercase = toMatch ] ] + ifFalse: [ + potentialNames select: [ :each | + each includesSubstring: toMatch caseSensitive: false ] ]. + exactMatch := names detect: [ :each | each asLowercase = toMatch ] ifNone: [ nil ]. + lines := OrderedCollection new. + exactMatch ifNotNil: [ lines add: 1 ]. + "Also try some fuzzy matching." + reducedIdentifiers := pattern suggestedTypeNames select: [ :each | + potentialNames includes: each ]. + reducedIdentifiers ifNotEmpty: [ + names addAll: reducedIdentifiers. + lines add: 1 + names size + reducedIdentifiers size ]. + "Let the user select if there's more than one possible match. This may give surprising results." + selectedIndex := names size = 1 + ifTrue: [ 1 ] + ifFalse: [ + exactMatch ifNotNil: [ names addFirst: exactMatch ]. + UIManager default chooseFrom: names lines: lines title: label ]. + selectedIndex = 0 ifTrue: [ ^nil ]. + ^environment at: (names at: selectedIndex) asSymbol!

Jan. 18, 2011

[Pharo-project] Issue 3548 in pharo: Network changes from Etoy

by pharo＠googlecode.com

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3548 by stephane...(a)gmail.com: Network changes from Etoy http://code.google.com/p/pharo/issues/detail?id=3548 A new version of Network was added to project The Inbox: http://source.squeak.org/inbox/Network-ul.100.mcz ==================== Summary ==================== Name: Network-ul.100 Author: ul Time: 12 December 2010, 4:49:19.894 am UUID: 81823263-c3d6-f949-a8b0-6a107dcb5322 Ancestors: Network-ul.99 Network changes from the EToys repository. We should really have a look at that. But this can be a bit boring.

Jan. 18, 2011

Re: [Pharo-project] Issue 3547 in pharo: Have a look at the new match: implementation

by pharo＠googlecode.com

Comment #3 on issue 3547 by stephane...(a)gmail.com: Have a look at the new match: implementation http://code.google.com/p/pharo/issues/detail?id=3547 ame: CollectionsTests-ul.179 Author: ul Time: 15 January 2011, 1:58:09.591 pm UUID: eda65a29-e17b-634b-b99c-e6f862302701 Ancestors: CollectionsTests-nice.178 - updated StringTest >> #testMatch to reflect the changes of Collections-ul.420 =============== Diff against CollectionsTests-nice.178 =============== Item was changed: ----- Method: StringTest>>testMatch (in category 'test-comparing') ----- testMatch + #('**' 'f**' 'f**o' 'f*' '*f*' 'f#*' 'f##' '*oo' '#oo' '*o*' '#o#' '#o*' '*o#' 'fo*' 'fo#' '*foo*' '###' '*#' 'f*#' 'f*#o') - #('**' '*#' 'f**' 'f*#' 'f**o' 'f*#o') do: [ :each | - self should: [ each match: 'foo' ] raise: Error ]. - #('f*' '*f*' 'f#*' 'f##' '*oo' '#oo' '*o*' '#o#' '#o*' '*o#' 'fo*' 'fo#' '*foo*' '###') do: [ :each | self assert: (each match: 'foo') ]. #('bar' 'foo#' '#foo' '*foo#' '#foo*' '*bar*') do: [ :each | self deny: (each match: 'foo') ]!

Jan. 18, 2011

Re: [Pharo-project] Issue 3547 in pharo: Have a look at the new match: implementation

by pharo＠googlecode.com

Updates: Labels: Type-Squeak Difficulty-Easy Comment #2 on issue 3547 by stephane...(a)gmail.com: Have a look at the new match: implementation http://code.google.com/p/pharo/issues/detail?id=3547 (No comment was entered for this change.)

Jan. 18, 2011

Re: [Pharo-project] Issue 3547 in pharo: Have a look at the new match: implementation

by pharo＠googlecode.com

Comment #1 on issue 3547 by stephane...(a)gmail.com: Have a look at the new match: implementation http://code.google.com/p/pharo/issues/detail?id=3547 A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ul.420.mcz ==================== Summary ==================== Name: Collections-ul.420 Author: ul Time: 15 January 2011, 1:57:14.662 pm UUID: aadc4c69-dd68-4f46-8370-dda4404f0153 Ancestors: Collections-mtf.419 - do not raise an error in String >> #match: if the receiver contains '**' or '*#' as a substring. - fixed the comment in String >> #match: =============== Diff against Collections-mtf.419 =============== Item was changed: ----- Method: String>>match: (in category 'comparing') ----- match: text "Answer whether text matches the pattern in this string. Matching ignores upper/lower case differences. Where this string contains #, text may contain any character. Where this string contains *, text may contain any sequence of characters." ^ self startingAt: 1 match: text startingAt: 1 " '*' match: 'zort' true '*baz' match: 'mobaz' true '*baz' match: 'mobazo' false '*baz*' match: 'mobazo' true '*baz*' match: 'mozo' false 'foo*' match: 'foozo' true 'foo*' match: 'bozo' false 'foo*baz' match: 'foo23baz' true 'foo*baz' match: 'foobaz' true 'foo*baz' match: 'foo23bazo' false 'foo' match: 'Foo' true 'foo*baz*zort' match: 'foobazort' false + 'foo*baz*zort' match: 'foobazzort' true - 'foo*baz*zort' match: 'foobazzort' false '*foo#zort' match: 'afoo3zortthenfoo3zort' true '*foo*zort' match: 'afoodezortorfoo3zort' true "! Item was changed: ----- Method: String>>startingAt:match:startingAt: (in category 'comparing') ----- startingAt: keyStart match: text startingAt: textStart "Answer whether text matches the pattern in this string. Matching ignores upper/lower case differences. Where this string contains #, text may contain any character. Where this string contains *, text may contain any sequence of characters." + | anyMatch matchStart matchEnd i matchStr j ii jj | i := keyStart. j := textStart. + + "Process consecutive *s and #s at the beginning." + anyMatch := false. + [ i <= self size and: [ + (self at: i) + caseOf: { + [ $* ] -> [ + anyMatch := true. + i := i + 1. + true ]. + [ $# ] -> [ + i := i + 1. + j := j + 1. + true ] } + otherwise: [ false ] ] ] whileTrue. + i > self size ifTrue: [ + ^j - 1 = text size or: [ "We reached the end by matching the character with a #." + anyMatch and: [ j <= text size ] "Or there was a * before the end." ] ]. + matchStart := i. - "Check for any #'s" - [i > self size ifTrue: [^ j > text size "Empty key matches only empty string"]. - (self at: i) = $#] whileTrue: - ["# consumes one char of key and one char of text" - j > text size ifTrue: [^ false "no more text"]. - i := i+1. j := j+1]. - - "Then check for *" - (self at: i) = $* - ifTrue: [i = self size ifTrue: - [^ true "Terminal * matches all"]. - "* means next match string can occur anywhere" - anyMatch := true. - matchStart := i + 1] - ifFalse: ["Otherwise match string must occur immediately" - anyMatch := false. - matchStart := i]. - "Now determine the match string" matchEnd := self size. + (ii := self indexOf: $* startingAt: matchStart) > 0 ifTrue: [ matchEnd := ii-1 ]. + (ii := self indexOf: $# startingAt: matchStart) > 0 ifTrue: [ matchEnd := matchEnd min: ii-1 ]. - (ii := self indexOf: $* startingAt: matchStart) > 0 ifTrue: - [ii = matchStart ifTrue: [self error: '** not valid -- use * instead']. - matchEnd := ii-1]. - (ii := self indexOf: $# startingAt: matchStart) > 0 ifTrue: - [ii = matchStart ifTrue: [self error: '*# not valid -- use #* instead']. - matchEnd := matchEnd min: ii-1]. matchStr := self copyFrom: matchStart to: matchEnd. "Now look for the match string" [jj := text findString: matchStr startingAt: j caseSensitive: false. anyMatch ifTrue: [jj > 0] ifFalse: [jj = j]] whileTrue: ["Found matchStr at jj. See if the rest matches..." (self startingAt: matchEnd+1 match: text startingAt: jj + matchStr size) ifTrue: [^ true "the rest matches -- success"]. "The rest did not match." anyMatch ifFalse: [^ false]. "Preceded by * -- try for a later match" j := j+1]. ^ false "Failed to find the match string"!

Jan. 18, 2011

[Pharo-project] Issue 3547 in pharo: Have a look at the new match: implementation

by pharo＠googlecode.com

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3547 by stephane...(a)gmail.com: Have a look at the new match: implementation http://code.google.com/p/pharo/issues/detail?id=3547 Collections-ul.420 Hi Squeakers, Latest trunk version broke the Aida/web and Herbert managed to find the reason in new behavior of String>>match: which doesn't allow two '**' in pattern anymore. In Aida the matching patterns are usually composed out of many strings and as it happens two stars occurs in Aida's default installation already. Because this new match behavior (not allowing two '**') is new only in Squeak but allowed in all other Smalltalks, I propose to reconsider this decision and better retract back to old behavior. answer: ------ The old behavior was definitely wrong. Here are two examples with the old behavior from the corresponding issue (http://bugs.squeak.org/view.php?id=6841 ): '*#' match: 'e'. "false" '**' match: 'e'. "false" If you look at the previous version of the method from 2004 (I don't know if this is the original or not), then you'll see that it tried to raise an error if the string contained '**', but it failed to do so because of this bug. So the intended behavior - to disallow ** in the pattern - is not new at all. IMHO the best solution to this problem is to rewrite the method to allow any combination of * and # in the pattern.

Jan. 18, 2011

[Pharo-project] Issue 3546 in pharo: Have a look at SystemReporter

by pharo＠googlecode.com

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3546 by stephane...(a)gmail.com: Have a look at SystemReporter http://code.google.com/p/pharo/issues/detail?id=3546 In the SystemReporter you can chose what system information should be gathered. So you could have a compact overview of the image and the VM or a full length/all details report. Add the repository SystemReporter to Monitcello. MCHttpRepository location: 'http://www.squeaksource.com/SystemReporter' user: '' password: '' Load the package SystemReporter and do SystemReporter open in a workspace. This very simple and needs to be polished further. License is MIT and everybody is invited to add code. It's easy to extend the reporter and it is explained in the class comment. This works with Squeak Trunk and Pharo 1.1.1 (needs to get rid of the deprecation warning) Alex

Jan. 18, 2011

Re: [Pharo-project] [SPAM] Re: Xtreams-Xtras: hashing and HMAC

by Sven Van Caekenberghe

On 18 Jan 2011, at 21:24, mkobetic(a)gmail.com wrote: > "Sven Van Caekenberghe"<sven(a)beta9.be> wrote: >>> I didn't find a way to browse a "package" in Pharo 1.2 so I'm struggling a bit to keep the categories in line. >> >> Hmm, click the 'Browse' button in either the Monticello Browser or the Repository Browser with the correct package selected ? But I guess you know that as well... > > Well, those seem to be "read-only", i.e. any edits I try to make in those seem to disappear, so I've been ignoring those browsers. Interestingly, the one-click image (Pharo 1.1.1) seems to have 'browse package' in the SystemBrowser menus which seems to be more functional, but that doesn't seem present in the PharoCore 1.2, so I'm just getting by with the basic SystemBrowser atm. Indeed, they are a read only view on what Monticello thinks the package is (the same browser is used to look at MC packages not loaded). And you are right, going between that browser and the regular one is a bit hard, if possible at all. >> The problem is the one I reported earlier: XTFileReadingWritingTest expecting a read stream to be aware of data written to a file after it was opened. This does not seem to work on Mac OS X. > > Yeah I have your previous report still in my inbox, but I'm kinda stuck there. As I said I don't have OSX to work with so I can't dig in to figure out what's going on. Given that it works on OSX in VW, I'm inclined to say that it should work on OSX in Squeak too. I wonder if there's some mixup in terms of file descriptors, maybe we're not talking to the same one or something such. I think Nicolas has OSX available so I'm hoping he might be able to find the time to look into it at some point. OK. Thx for the responses, Sven

Jan. 18, 2011

Re: [Pharo-project] list on he fly selection :)

by Benjamin

You must have tried between two commits on squeaksource (I hope ^^) I will refactor that because the inst var is named lastKeystrokes but the method is named lastKeyStrokes ... Thanks for your feedback :) Ben On Jan 18, 2011, at 8:34 PM, Tudor Girba wrote: > I am not sure where it should work, but I tried in Pharo 1.2 and it does not work. First, there is a "self self". Second, even if I fix this one, I still get a DNU for OnTheFlySelectionPluggableListMorph>>lastKeystrokes. > > Cheers, > Doru > > > On 18 Jan 2011, at 20:21, StÃ©phane Ducasse wrote: > >> close your eyes and imagine that you can just type as to get all the methods starting with as* >> without extra shortcut whatever.... >> same for classes, packages... of course. >> >> Stef >> >> On Jan 18, 2011, at 4:16 PM, Alexandre Bergel wrote: >> >>> Just tried. I could not immediately figure out what is the difference with the "Find Class" panel (pressing Cmd-f in OB)? >>> >>> Cheers, >>> Alexandre >>> >>> >>> On 18 Jan 2011, at 12:00, StÃ©phane Ducasse wrote: >>> >>>> Hi guys >>>> >>>> I'm sure that some of you will really like to type on that list and see it auto selectioning its elements.... >>>> >>>> Gofer it >>>> squeaksource: 'DirtyExperiments'; >>>> package: 'DirtyExperiments'; >>>> load >>>> >>>> | test | >>>> test := DummyTest on: (Smalltalk allClasses). >>>> test openInWorld >>>> >>>> Of course I would love to have that for a lot of lists..... :) >>>> >>>> Thanks Benjamin for this first version :) >>>> Stef >>> >>> -- >>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>> Alexandre Bergel http://www.bergel.eu >>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>> >>> >>> >>> >>> >>> >> >> > > -- > www.tudorgirba.com > > "Sometimes the best solution is not the best solution." > >

Jan. 18, 2011

Re: [Pharo-project] Unsubscribing for Announcements

by Sean P. DeNigris

Tudor Girba wrote: > > The WeakAnnouncement are already on the agenda for 1.3. > Ah, very good! Sean -- View this message in context: http://forum.world.st/Unsubscribing-for-Announcements-tp3220751p3223939.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Jan. 18, 2011