- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Reviewing Changes ?

by Pavel Krivanek

2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > Hi, > > With pull requests, it is relatively easy to see what changed in GitHub. > > Eg. Marcus' latest fix: > > https://github.com/pharo-project/pharo/pull/797 > > shows 6 files/classes changed, reasonably readable diff. > > How does one review such a PR in an image, to test it out ? The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip) Esteban did a Pull request review tool: - register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes" > Has someone written a guide on how to do this best/most-easily ? No idea, but Esteban presented that several times on ESUG and other places. > How is/can this be related to contributing ? If you want to use the PR review tool, you should have own fork and local repository - the same for contributing If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically. Cheers, -- Pavel > > Sven >

Feb. 5, 2018

Re: [Pharo-dev] Reviewing Changes ?

by tesonep＠gmail.com

Hello Sven, the easy way I found to review an image of the change in a PR is to use the image from the CI server. In https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2… you can see all the jobs of the PR (every PR is run in the CI as soon as it is created or updated). There you can find the PR by its number, for example: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2… And then later you can check the results of the tests or downloading an image with the changes in Last Successful Artifacts: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2… The images are inside the folder "bootstrap-cache" and you should take the Pharo-32bits-****.zip or Pharo-64bits-****.zip. Cheers. On Mon, Feb 5, 2018 at 1:54 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Hi, > > With pull requests, it is relatively easy to see what changed in GitHub. > > Eg. Marcus' latest fix: > > https://github.com/pharo-project/pharo/pull/797 > > shows 6 files/classes changed, reasonably readable diff. > > How does one review such a PR in an image, to test it out ? > Has someone written a guide on how to do this best/most-easily ? > How is/can this be related to contributing ? > > Sven > > -- Pablo Tesone. tesonep(a)gmail.com

Feb. 5, 2018

Reviewing Changes ?

by Sven Van Caekenberghe

Hi, With pull requests, it is relatively easy to see what changed in GitHub. Eg. Marcus' latest fix: https://github.com/pharo-project/pharo/pull/797 shows 6 files/classes changed, reasonably readable diff. How does one review such a PR in an image, to test it out ? Has someone written a guide on how to do this best/most-easily ? How is/can this be related to contributing ? Sven

Feb. 5, 2018

[Bug] Sometimes the debugger opens with the context one off

by Marcus Denker

Hi, This one was annoying me for a while: sometimes, when you put a halt the debugger opens but with exactly the method you put the halt in not selected and hidden (you need to scroll up!). I analysed a bit the situation and the case were this happens is when you put a halt and then run a test to trigger the halt. Normal halts are ok. https://pharo.manuscript.com/f/cases/21236/Sometimes-the-debugger-opens-wit… fix to review: https://github.com/pharo-project/pharo/pull/797

Feb. 5, 2018

Re: [Pharo-dev] nil suspend

by Sven Van Caekenberghe

https://pharo.manuscript.com/f/cases/21237/Remove-UndefinedObject-suspend https://github.com/pharo-project/pharo/pull/798 > On 22 Nov 2017, at 21:25, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: > > +1 > > > On Mon, Nov 20, 2017 at 10:06 AM, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > Yes, it doesn't sound right. I vote for removal :) > > On Sat, Nov 18, 2017 at 11:04 PM, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > It sounds like a left over... > no time stamp in Squeak, so it must be old. > Display reverse; reverse means we wanted to catch when such oddity was necessary. > (I would do it differently with an Exception and a MessageTally like I already exhibited several times) > The fact that reverse; reverse was commented is more difficult to interpret... Is it really necessary? > I removed the method in a Squeak image, and so fare nothing wrong happened, but it does not prove anything. > The best is to ask in Squeak lists, maybe someone can remember... > Or carefully analyze all senders of suspend... > > 2017-11-18 22:36 GMT+01:00 Aliaksei Syrel <alex.syrel(a)gmail.com>: > Hi, > > I was looking at nil (already funny) and found a very interesting method: > > suspend > > "Kills off processes that didn't terminate properly" > > > "Display reverse; reverse." "<-- So we can catch the suspend bug" > > > Processor terminateActive > It means that the following code is probably the shortest way to kill your image (save first!) > > nil suspend > It terminates a UI process if evaluated from anywhere using CMD+d :D > > Cheers, > Alex > > > > > -- > > Guille Polito > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - http://www.cnrs.fr > > Web: http://guillep.github.io > Phone: +33 06 52 70 66 13 >

Feb. 5, 2018

Re: [Pharo-dev] Esteban's ChangeLog week of 29 January 2018

by Esteban Lorenzano

not very rich this report :) Iâve been digging and failing with VM compilation on CI, which is broken again :( also signing didnât work because I do not have (yet) the correct certificate, but it will be done soon. Esteban > On 5 Feb 2018, at 08:00, estebanlm(a)gmail.com wrote: > > Hello! > > This is my weekly ChangeLog, from 29 January 2018 to 4 February 2018. > You can see it in a better format by going here: http://log.smallworks.eu/web/search?from=29/1/2018&to=4/2/2018 > > ChangeLog > ========= > > 29 January 2018: > ---------------- > > * I spent the morning adding certificates to the VM to sign it :) > > Next batch of VMs should come signed... now it rest to see if we need to sign the images also. > > > cheers! > Esteban

Feb. 5, 2018

[CfP] ICOOOLPS 2018

by Tim Felgentreff

Call for Papers: ICOOOLPS'18 ============================ 13th Workshop on Implementation, Compilation, Optimization of Object- Oriented Languages, Programs and Systems Co-located with ECOOP 2018 held Mon 16 - Sun 22 July in Amsterdam, Netherlands Twitter: @ICOOOLPS URL: https://conf.researchr.org/track/ecoop-issta-2018/ICOOOLPS-2018-papers The ICOOOLPS workshop series brings together researchers and practitioners working in the field of language implementation and optimization. The goal of the workshop is to discuss emerging problems and research directions as well as new solutions to classic performance challenges. The topics of interest for the workshop include techniques for the implementation and optimization of a wide range of languages including but not limited to object-oriented ones. Furthermore, meta-compilation techniques or language-agnostic approaches are welcome, too. ### Topics of Interest A non-exclusive list of topics of interest for this workshop is: - Implementation and optimization of fundamental languages features (from automatic memory management to zero-overhead metaprogramming) - Runtime systems technology (libraries, virtual machines) - Static, adaptive, and speculative optimizations and compiler techniques - Meta-compilation techniques and language-agnostic approaches for the efficient implementation of languages - Compilers (intermediate representations, offline and online optimizations,â¦) - Empirical studies on language usage, benchmark design, and benchmarking methodology - Resource-sensitive systems (real-time, low power, mobile, cloud) - Studies on design choices and tradeoffs (dynamic vs. static compilation, heuristics vs. programmer input,â¦) - Tooling support, debuggability and observability of languages as well as their implementations ### Workshop Format and Submissions This workshop welcomes the presentation and discussion of new ideas and emerging problems that give a chance for interaction and exchange. More mature work is welcome as part of a mini-conference format, too. We aim to interleave interactive brainstorming and demonstration sessions between the formal presentations to foster an active exchange of ideas. The workshop papers will be published in ACM DL or an open archive (to be confirmed). Papers are to be submitted using the sigplanconf LaTeX template (http://www.sigplan.org/Resources/LaTeXClassFile/) Please submit contributions via EasyChair: https://easychair.org/conferences/submission_show_all.cgi?a=17114062 ### Important Dates Submissions: 18 May 2018 Author Notification: 8 June 2018 ### Program Committee The program committee consists of the organizers and the following reviewers: Nada Amin, University of Cambridge ClÃ©ment BÃ©ra, RMOD - INRIA Lille Nord Europe Shigeru Chiba, University of Tokyo Benoit Daloze, JKU Linz GÃ¶rel Hedin, Lund University Eric Jul, University of Oslo Stefan Marr, University of Kent Eliot Miranda, Cadence Design Systems Sarah Mount, King's College London Tobias Pape, Hasso Plattner Institute Jennifer Sartor, Vrije Universiteit Brussel + University Ghent ### Workshop Organizers Tim Felgentreff, Oracle Labs Potsdam Olivier Zendra, INRIA / LORIA

Feb. 5, 2018

Re: [Pharo-dev] Pavel's ChangeLog week of 2018-01-29

by Pavel Krivanek

The mailing list server rejected the original message because of the screenshots size. The next try to attach them 2018-02-05 10:18 GMT+01:00 Pavel Krivanek <pavel.krivanek(a)gmail.com>: > Hi, > > on my laptop, I have a 13.3" display with resolution 3200x1800. The > value of PPI of this display is 276 and because I'm using Linux that > does not provide a simple way how to scale the resolution of a window > that does not provide high PPI out of the box, it makes Pharo with the > default settings usable on that machine only with a magnifier. I need > to say that Pharo is not alone, a huge amount of application has real > troubles with high values of PPI on Linux. > > Pharo provides a possibility to increase the size of the fonts which > makes system more usable but it has a lot of issues. The icons, > scrollbars and other elements keep the original size so they are > really tiny. The grips for windows resizing too which makes them hard > to catch. The default size of the windows is not changed as well so > you need to resize literally every window by hand. > > This is not only an issue of high PPI displays. When you do a > presentation on projectors, in most cases you need to make text > bigger. > > Unfortunately, in current Morphic it is not imaginable that we will > solve this issue properly on the level of canvases. The rendering of > the Morphic with Athens is a better way but nor ready and no-one will > spend energy on it with the planned switch to Bloc that will finally > solve this issue properly. > > But because I needed some solution, I decided to introduce a > worldScaleFactor that provides a simple constant that that will scale > the UI elements and then started to use it in all places where it is > needed. It is a dirty solution but starts to work quite well. > > > > You can scale the UI down too. From the screenshot, you can see that > some places still need to be improved. > > > > The next issue whit high PPI on Linux VM is with the cursor's size. It > cannot be replaced by bigger ones that the package VistaCursors > provides because the primitive for the cursor replacing fails. But > fortunately it has a simple solution, the VM needs to be linked with > Xrender library, see > https://pharo.fogbugz.com/f/cases/12960/Primitive-101-Cursor-beCursor-fails… > > Cheers, > -- Pavel

Feb. 5, 2018

Pavel's ChangeLog week of 2018-01-29

by Pavel Krivanek

Hi, on my laptop, I have a 13.3" display with resolution 3200x1800. The value of PPI of this display is 276 and because I'm using Linux that does not provide a simple way how to scale the resolution of a window that does not provide high PPI out of the box, it makes Pharo with the default settings usable on that machine only with a magnifier. I need to say that Pharo is not alone, a huge amount of application has real troubles with high values of PPI on Linux. Pharo provides a possibility to increase the size of the fonts which makes system more usable but it has a lot of issues. The icons, scrollbars and other elements keep the original size so they are really tiny. The grips for windows resizing too which makes them hard to catch. The default size of the windows is not changed as well so you need to resize literally every window by hand. This is not only an issue of high PPI displays. When you do a presentation on projectors, in most cases you need to make text bigger. Unfortunately, in current Morphic it is not imaginable that we will solve this issue properly on the level of canvases. The rendering of the Morphic with Athens is a better way but nor ready and no-one will spend energy on it with the planned switch to Bloc that will finally solve this issue properly. But because I needed some solution, I decided to introduce a worldScaleFactor that provides a simple constant that that will scale the UI elements and then started to use it in all places where it is needed. It is a dirty solution but starts to work quite well. You can scale the UI down too. From the screenshot, you can see that some places still need to be improved. The next issue whit high PPI on Linux VM is with the cursor's size. It cannot be replaced by bigger ones that the package VistaCursors provides because the primitive for the cursor replacing fails. But fortunately it has a simple solution, the VM needs to be linked with Xrender library, see https://pharo.fogbugz.com/f/cases/12960/Primitive-101-Cursor-beCursor-fails… Cheers, -- Pavel

Feb. 5, 2018

Re: [Pharo-dev] git workflow (iceberg) and monticello packages

by Guillermo Polito

On Sun, Feb 4, 2018 at 11:07 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > Hi , > > I am still not sure I understand the git based development workflow. > > I set up my image and repository as described by the guide. > > now, if new commits are in the pharo-project, iceberg shows the list of > incoming > changes (commits). Ok, but: > > If I modify code in my image (for example, change a method in class Morph), > the morphic-core package is marked as dirty in monticello and my > pharo repository in iceberg is marked with an asterisk. > If I choose "synchronize repository ..." I would expect my change to be an > uncommited change, but instead, it isn't shown and the Morphic-core package > isn't dirty anymore. > > Is it because I need to create a branch first ? But why is the > Morphic-core package > not dirty anymore, the change is not commited or published, how do I know > where are my changes ? > No, that's a bug between the iceberg-monticello interaction. Iceberg does not manage himself the detection of modified/dirty packages, he relies for that on monticello. And it happens from time to time that - a package is marked as dirty and it is not - a package is marked as cleand and it is not both cases are confusing. I don't know if this comes from a bad usage of the monticello API or something else... > > > nicolai > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

Feb. 5, 2018