- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Reviewing Changes ?

by Stephane Ducasse

And please please please use BIG font is you want to show something. Stef On Wed, Feb 7, 2018 at 11:45 AM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > I made notes and will add a page with all the infos later today. (for > http://pharo.org/contribute ) > > Marcus > > > On 5 Feb 2018, at 16:57, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > Ah, Esteban's PR review tool is exactly what I was looking for. It works ! > > Still, please, please (Pavel) write down somewhere what you just explained > to me, else it will eventually be lost. > > Docs needed > > (1) contribute to Pharo (we have that) > (2) keep in sync once you have done (1) (we have that, but not about image > side) > (3) review pull requests of others (new, this email to start) > > Anyway, thanks for the answers. > > On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > > 2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > > Hi, > > With pull requests, it is relatively easy to see what changed in GitHub. > > Eg. Marcus' latest fix: > > https://github.com/pharo-project/pharo/pull/797 > > shows 6 files/classes changed, reasonably readable diff. > > How does one review such a PR in an image, to test it out ? > > > The easiest way is to download an image bootstrapped from that PR. > Next to the commits you have a validation status (red cross here), > click on it, go to "Artifacts" and then download the image > (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip) > > Esteban did a Pull request review tool: > > - register your local Pharo repository copy to Iceberg > - in the "Remotes" open context menu on the pharo-project remote (not > origin, which is probably our fork) > - GitHub - Review pull requests... > - open context menu on an issue and select "Review pull request..." > - select the newest commit and check changes > - to test it locally, do "Merge into image", answer "Yes" > > Has someone written a guide on how to do this best/most-easily ? > > > No idea, but Esteban presented that several times on ESUG and other places. > > How is/can this be related to contributing ? > > > If you want to use the PR review tool, you should have own fork and > local repository - the same for contributing > > If you then want to propose a modification fo the PR, you already have > a branch from the PR merging. > - do your change and synchronize the repository so your branch will be > present on your fork. > - then go to "Remotes" tab, open context menu on "MarcusDenker" remote > (it will be created during merging of the PR into your image) and then > do pull request. > - in Head select your fork and your issue branch name > - in Base select Marcus/Denker/pharo and the issue branch name > - click on Create Pull request > > It will create a PR on the repository that Marcus has. Like > https://github.com/MarcusDenker/pharo/pull/1 > When he will merge it, his PR to on Pharo repository will be updated > automatically. > > Cheers, > -- Pavel > > > Sven > > > >

Feb. 7, 2018

Re: [Pharo-dev] [Seaside-dev] How should I load Seaside/Bootstrap in Pharo 7 ?

by Stephane Ducasse

Thanks for pushing this. I plan to work on migrating the seaside book to pillar when I'm done with the moose book and the magritte booklet. Stef On Wed, Feb 7, 2018 at 1:45 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Hi, > > Using [ https://github.com/SeasideSt/Seaside/pull/979 ] (I attach a manually modified BaselineOfSeaside3 that I used), I managed to load Seaside 3.2 (GitHub.1516790362) in Pharo 7 (Pharo-7.0+alpha.build.493.sha.d53a70bc946ed83b046f61ac35f00c67fa77269a (32 Bit)) and at least the load and some quick testing with ZnZincSeasideAdaptor (via the spec based Seaside Control Panel) seems to indicate no direct problems. > > Metacello new > baseline:'Seaside3'; > repository: 'github://SeasideSt/Seaside:master/repository'; > load. > > Why don't we integrate this so that others can load Seaside 3.2 in Pharo 7 too ? > > This is _really_ important to make progress, IMHO. > > I changed WABrowser>>#updateUrl: to send #name instead of #fullName to the selected class of the model. I am not sure that is entirely correct, but it seemed to work. Apart from that, the WAImageStatus web app worked fine. > > Sven > >> On 6 Nov 2017, at 09:49, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> OK, Max, thanks for the reply. >> >> I will ask on the Pharo ML as well. >> >> I think it is important that Seaside works on Pharo 7, it is an important use case and test during development, and very necessary as well. >> >>> On 6 Nov 2017, at 09:40, Max Leske <maxleske(a)gmail.com> wrote: >>> >>> Hi Sven, >>> >>> We don't have a build for Pharo 7 yet. Loading from github would be the recommended way. A quick look makes me think that it will require a bit of work to get the baseline set up correctly. I can't promise anything before next weekend. >>> >>> How urgent is the situation for you? >>> >>> Cheers, >>> Max >>> >>> >>> On 5 November 2017 at 19:22:03, Sven Van Caekenberghe (sven(a)stfx.eu) wrote: >>> >>>> Hi, >>>> >>>> I am stuck trying to move my main development to Pharo 7 because I have trouble loading Seaside (which I normally do indirectly by loading the Bootstrap project). Here is my dependency: >>>> >>>> project: 'Bootstrap' with: [ >>>> spec >>>> className: 'ConfigurationOfBootstrap'; >>>> repository: 'http://smalltalkhub.com/mc/TorstenBergmann/Bootstrap/main/'; >>>> versionString: #stable ] >>>> >>>> I also tried the following: >>>> >>>> Metacello new >>>> baseline:'Seaside3'; >>>> repository: 'github://SeasideSt/Seaside:master/repository'; >>>> load. >>>> >>>> What is the right/recommended way to do it ? >>>> >>>> Thx, >>>> >>>> Sven >>>> >>>> _______________________________________________ >>>> seaside-dev mailing list >>>> seaside-dev(a)lists.squeakfoundation.org >>>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >>> _______________________________________________ >>> seaside-dev mailing list >>> seaside-dev(a)lists.squeakfoundation.org >>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >> > >

Feb. 7, 2018

Re: [Pharo-dev] VMs build process restored

by Stephane Ducasse

Yes thank you both! Stef On Tue, Feb 6, 2018 at 6:52 PM, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > Thank you very much Esteban, Thanks Fabio. > > On Tue, Feb 6, 2018 at 5:58 PM, Esteban Lorenzano <estebanlm(a)gmail.com> > wrote: >> >> (it was broken since december) >> >> Which means latest vm versions are latest builds from OSVM: >> >> 64bit >> >> â¢ http://files.pharo.org/get-files/70/pharo64-mac-latest.zip >> â¢ >> http://files.pharo.org/get-files/70/pharo64-linux-threaded-latest.zip >> â¢ http://files.pharo.org/get-files/70/pharo64-linux-latest.zip >> â¢ http://files.pharo.org/get-files/70/pharo64-win-latest.zip >> 32bit >> >> â¢ >> http://files.pharo.org/get-files/70/pharo-linux-threaded-latest.zip >> â¢ http://files.pharo.org/get-files/70/pharo-linux-latest.zip >> â¢ http://files.pharo.org/get-files/70/pharo-mac-latest.zip >> â¢ http://files.pharo.org/get-files/70/pharo-win-latest.zip >> >> Hints >> >> â¢ MacOS VMs now are signed! This should fix a lot of problems we >> had before. >> â¢ Please take note that win64 build lacks all library >> dependencies, and many things will not work (working on that). >> Thanks to Fabio to help me put all the pieces together. >> >> >> cheers, >> Esteban > > > > > -- > ClÃ©ment BÃ©ra > Pharo consortium engineer > https://clementbera.wordpress.com/ > BÃ¢timent B 40, avenue Halley 59650 Villeneuve d'Ascq

Feb. 7, 2018

[Pharo 7.0-dev] Build #508: 21248-Add-possibility-to-skip-some-tests-on-CI

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #508 was: SUCCESS. The Pull Request #808 was integrated: "21248-Add-possibility-to-skip-some-tests-on-CI" Pull request url: https://github.com/pharo-project/pharo/pull/808 Issue Url: https://pharo.fogbugz.com/f/cases/21248 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 7, 2018

Re: [Pharo-dev] How to force a BaselineOf to load ?

by Cyril Ferlicot

On Tue, Feb 6, 2018 at 4:22 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Hi, > Hi, > I have a Pharo 4 (#40627) image that already contains P3. Now I want to update P3, without completely rebuilding this image from scratch. > > It seems as if an expression like > > Metacello new > baseline: 'P3'; > repository: 'github://svenvc/P3'; > load. > > executed like > > $ ../bin/pharo build-trackit.image eval --save "Metacello new baseline: 'P3'; repository: 'github://svenvc/P3'; load" > > does not really reload the code. How can I force it to (re)load ? > IIRC, Dale worked on Metacello to introduce a new project kind in the baseline to manage this problem. See thread: http://forum.world.st/ANN-Metacello-support-for-GitFileTree-metadata-less-m… So you need to implement this method in the baseline: projectClass ^ MetacelloCypressBaselineProject Quoted from Dale (http://forum.world.st/unsolicited-package-cache-use-td5060335.html Jan 18, 2018; 4:10pm): Â«if not, then what looks like a package-cache problem could be that you haven't told Metacello that you are using a metadataless filetree/tonel repository. Metacello has an internal rule to not load Monticello packages of the same version, since they are already loaded. However, when using metadataless repositories the filetree/tonel Monticello package readers typically generate a package name using the author/version `-cypress.1`, which make Metacello think that the versions are the same and the package is not loaded ... by including the above method in your baselineof, Metacello will know to ignore the Monticello author/version of the package and always load it.... Of course, because Monticello only installs changed definitions when loading a package, "loading the same package over and over again" costs a little bit in loading the _definitions_ into the image from disk, but doesn't end up compiling any new methods or creating new classes ...Â» BUT! Because there is a but... This is not present by default in Pharo... To get it, we need to upgrade Matacello :( > Thx, > > Sven -- Cyril Ferlicot https://ferlicot.fr

Feb. 7, 2018

[Pharo 7.0-dev] Build #507: 21247--TraitMethodDescription-is-missing-isNotEmpty

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #507 was: FAILURE. The Pull Request #807 was integrated: "21247--TraitMethodDescription-is-missing-isNotEmpty" Pull request url: https://github.com/pharo-project/pharo/pull/807 Issue Url: https://pharo.fogbugz.com/f/cases/21247 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 7, 2018

Re: [Pharo-dev] [Seaside-dev] How should I load Seaside/Bootstrap in Pharo 7 ?

by Sven Van Caekenberghe

Of course, I forgot the attachment: > On 7 Feb 2018, at 13:45, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > Hi, > > Using [ https://github.com/SeasideSt/Seaside/pull/979 ] (I attach a manually modified BaselineOfSeaside3 that I used), I managed to load Seaside 3.2 (GitHub.1516790362) in Pharo 7 (Pharo-7.0+alpha.build.493.sha.d53a70bc946ed83b046f61ac35f00c67fa77269a (32 Bit)) and at least the load and some quick testing with ZnZincSeasideAdaptor (via the spec based Seaside Control Panel) seems to indicate no direct problems. > > Metacello new > baseline:'Seaside3'; > repository: 'github://SeasideSt/Seaside:master/repository'; > load. > > Why don't we integrate this so that others can load Seaside 3.2 in Pharo 7 too ? > > This is _really_ important to make progress, IMHO. > > I changed WABrowser>>#updateUrl: to send #name instead of #fullName to the selected class of the model. I am not sure that is entirely correct, but it seemed to work. Apart from that, the WAImageStatus web app worked fine. > > Sven > >> On 6 Nov 2017, at 09:49, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> OK, Max, thanks for the reply. >> >> I will ask on the Pharo ML as well. >> >> I think it is important that Seaside works on Pharo 7, it is an important use case and test during development, and very necessary as well. >> >>> On 6 Nov 2017, at 09:40, Max Leske <maxleske(a)gmail.com> wrote: >>> >>> Hi Sven, >>> >>> We don't have a build for Pharo 7 yet. Loading from github would be the recommended way. A quick look makes me think that it will require a bit of work to get the baseline set up correctly. I can't promise anything before next weekend. >>> >>> How urgent is the situation for you? >>> >>> Cheers, >>> Max >>> >>> >>> On 5 November 2017 at 19:22:03, Sven Van Caekenberghe (sven(a)stfx.eu) wrote: >>> >>>> Hi, >>>> >>>> I am stuck trying to move my main development to Pharo 7 because I have trouble loading Seaside (which I normally do indirectly by loading the Bootstrap project). Here is my dependency: >>>> >>>> project: 'Bootstrap' with: [ >>>> spec >>>> className: 'ConfigurationOfBootstrap'; >>>> repository: 'http://smalltalkhub.com/mc/TorstenBergmann/Bootstrap/main/'; >>>> versionString: #stable ] >>>> >>>> I also tried the following: >>>> >>>> Metacello new >>>> baseline:'Seaside3'; >>>> repository: 'github://SeasideSt/Seaside:master/repository'; >>>> load. >>>> >>>> What is the right/recommended way to do it ? >>>> >>>> Thx, >>>> >>>> Sven >>>> >>>> _______________________________________________ >>>> seaside-dev mailing list >>>> seaside-dev(a)lists.squeakfoundation.org >>>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >>> _______________________________________________ >>> seaside-dev mailing list >>> seaside-dev(a)lists.squeakfoundation.org >>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >> >

Feb. 7, 2018

Re: [Pharo-dev] [Seaside-dev] How should I load Seaside/Bootstrap in Pharo 7 ?

by Sven Van Caekenberghe

Hi, Using [ https://github.com/SeasideSt/Seaside/pull/979 ] (I attach a manually modified BaselineOfSeaside3 that I used), I managed to load Seaside 3.2 (GitHub.1516790362) in Pharo 7 (Pharo-7.0+alpha.build.493.sha.d53a70bc946ed83b046f61ac35f00c67fa77269a (32 Bit)) and at least the load and some quick testing with ZnZincSeasideAdaptor (via the spec based Seaside Control Panel) seems to indicate no direct problems. Metacello new baseline:'Seaside3'; repository: 'github://SeasideSt/Seaside:master/repository'; load. Why don't we integrate this so that others can load Seaside 3.2 in Pharo 7 too ? This is _really_ important to make progress, IMHO. I changed WABrowser>>#updateUrl: to send #name instead of #fullName to the selected class of the model. I am not sure that is entirely correct, but it seemed to work. Apart from that, the WAImageStatus web app worked fine. Sven > On 6 Nov 2017, at 09:49, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > OK, Max, thanks for the reply. > > I will ask on the Pharo ML as well. > > I think it is important that Seaside works on Pharo 7, it is an important use case and test during development, and very necessary as well. > >> On 6 Nov 2017, at 09:40, Max Leske <maxleske(a)gmail.com> wrote: >> >> Hi Sven, >> >> We don't have a build for Pharo 7 yet. Loading from github would be the recommended way. A quick look makes me think that it will require a bit of work to get the baseline set up correctly. I can't promise anything before next weekend. >> >> How urgent is the situation for you? >> >> Cheers, >> Max >> >> >> On 5 November 2017 at 19:22:03, Sven Van Caekenberghe (sven(a)stfx.eu) wrote: >> >>> Hi, >>> >>> I am stuck trying to move my main development to Pharo 7 because I have trouble loading Seaside (which I normally do indirectly by loading the Bootstrap project). Here is my dependency: >>> >>> project: 'Bootstrap' with: [ >>> spec >>> className: 'ConfigurationOfBootstrap'; >>> repository: 'http://smalltalkhub.com/mc/TorstenBergmann/Bootstrap/main/'; >>> versionString: #stable ] >>> >>> I also tried the following: >>> >>> Metacello new >>> baseline:'Seaside3'; >>> repository: 'github://SeasideSt/Seaside:master/repository'; >>> load. >>> >>> What is the right/recommended way to do it ? >>> >>> Thx, >>> >>> Sven >>> >>> _______________________________________________ >>> seaside-dev mailing list >>> seaside-dev(a)lists.squeakfoundation.org >>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >> _______________________________________________ >> seaside-dev mailing list >> seaside-dev(a)lists.squeakfoundation.org >> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >

Feb. 7, 2018

Re: [Pharo-dev] Reviewing Changes ?

by Marcus Denker

I made notes and will add a page with all the infos later today. (for http://pharo.org/contribute <http://pharo.org/contribute> ) Marcus > On 5 Feb 2018, at 16:57, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > Ah, Esteban's PR review tool is exactly what I was looking for. It works ! > > Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost. > > Docs needed > > (1) contribute to Pharo (we have that) > (2) keep in sync once you have done (1) (we have that, but not about image side) > (3) review pull requests of others (new, this email to start) > > Anyway, thanks for the answers. > >> On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: >> >> 2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >>> Hi, >>> >>> With pull requests, it is relatively easy to see what changed in GitHub. >>> >>> Eg. Marcus' latest fix: >>> >>> https://github.com/pharo-project/pharo/pull/797 >>> >>> shows 6 files/classes changed, reasonably readable diff. >>> >>> How does one review such a PR in an image, to test it out ? >> >> The easiest way is to download an image bootstrapped from that PR. >> Next to the commits you have a validation status (red cross here), >> click on it, go to "Artifacts" and then download the image >> (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip) >> >> Esteban did a Pull request review tool: >> >> - register your local Pharo repository copy to Iceberg >> - in the "Remotes" open context menu on the pharo-project remote (not >> origin, which is probably our fork) >> - GitHub - Review pull requests... >> - open context menu on an issue and select "Review pull request..." >> - select the newest commit and check changes >> - to test it locally, do "Merge into image", answer "Yes" >> >>> Has someone written a guide on how to do this best/most-easily ? >> >> No idea, but Esteban presented that several times on ESUG and other places. >> >>> How is/can this be related to contributing ? >> >> If you want to use the PR review tool, you should have own fork and >> local repository - the same for contributing >> >> If you then want to propose a modification fo the PR, you already have >> a branch from the PR merging. >> - do your change and synchronize the repository so your branch will be >> present on your fork. >> - then go to "Remotes" tab, open context menu on "MarcusDenker" remote >> (it will be created during merging of the PR into your image) and then >> do pull request. >> - in Head select your fork and your issue branch name >> - in Base select Marcus/Denker/pharo and the issue branch name >> - click on Create Pull request >> >> It will create a PR on the repository that Marcus has. Like >> https://github.com/MarcusDenker/pharo/pull/1 >> When he will merge it, his PR to on Pharo repository will be updated >> automatically. >> >> Cheers, >> -- Pavel >> >>> >>> Sven > >

Feb. 7, 2018

Re: [Pharo-dev] OSVM pre-release 201802061430 ready to be tested

by Marcus Denker

That is great! Thanks a lot! > On 6 Feb 2018, at 22:22, Fabio Niephaus <lists(a)fniephaus.com> wrote: > > Dear all, > > We were able to fix all build problems today, so here is the OpenSmalltalkVM pre-release 201802061430 [1]. > The Pharo VMs for macOS are now correctly signed. More importantly, they come with a fix for "Crashes while typing on macOS Sierra" [2]. > > Please give the VMs a try if you have some time and report any bugs at [3]. > > Best, > Fabio > > [1] https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/201802061430 > [2] https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/141 > [3] https://github.com/OpenSmalltalk/opensmalltalk-vm/issues â Inria RMoD https://rmod.inria.fr ZWEIDENKER GmbH http://zweidenker.de

Feb. 7, 2018