- Pharo-dev - lists.pharo.org

Re: [Pharo-project] [Vm-dev] Fwd: Issue 1064 in pharo: There are still problem with keyboard shortcuts in Windows

by David T. Lewis

Thanks Mariano, I added this to http://bugs.squeak.org/view.php?id=7611 so the issue will be tracked. The standard VM and the Cog VM share identical support code for this function, so I am assuming that the issue affects all Windows VMs (please correct me if this is wrong). Andreas, Eliot - this would be a one-line fix in the support code if you approve, and should be applied to both the trunk and the cog branches. Thanks, Dave. On Sun, Mar 06, 2011 at 04:12:24PM +0100, Mariano Martinez Peck wrote: > > Hi, I fordward this thread to the VM mailing list since it looks more > appropiated. > David, here "tn" is proposing a fix. I am not qualified to take a look. > Hope it helps > > Mariano > > ---------- Forwarded message ---------- > From: <pharo(a)googlecode.com> > Date: Sat, Mar 5, 2011 at 9:23 PM > Subject: Re: [Pharo-project] Issue 1064 in pharo: There are still problem > with keyboard shortcuts in Windows > To: pharo-project(a)lists.gforge.inria.fr > > > > Comment #14 on issue 1064 by happy.lo...(a)gmail.com: There are still problem > with keyboard shortcuts in Windows > > http://code.google.com/p/pharo/issues/detail?id=1064 > > Hi, I'm tn. > > 'ctrl + m' problem is Cog VM bug. > > Normally, when character key is pushed, keyboard events occur as follows on > Squeak. > > 1. key press (down) > 2. character (character code notification) > 3. key release (up) > > They are produced by a primitive method in IutEventFetcher >> > primGetNextEvent. > But when ctrl + m is pushed, a character event doesn't occur. > Because 'ctrl + m' value is 13. The value is same as ENTER key. > Cog VM ignores WM_CHAR message(character event) when ENTER key is pushed. > > The one of solution for this problem is to add CTRL key state to the > if-condition. > > -- sqWin32Window.c -- > > int recordKeyboardEvent(MSG *msg) { > ... > > switch(msg->message) { > ... > > case WM_CHAR: > case WM_SYSCHAR: > /* Note: VK_RETURN is recorded as virtual key ONLY */ > if(keyCode == 13 && !ctrl) return 1; // add "&& !ctrl" > pressCode = EventKeyChar; > break; > ... > } > ... > > Note: ENTER keyCode is 13. But when ctrl + ENTER is pushed, the keyCode is > 10. > So if the condition is revised, ctrl + m problem is corrected. > but other behavior is not changed. > > > If you want to prevent to generate character event for CTRL + ENTER, > you can add following code. By this way, we can produce > not only ctrl+m (0x0D)'s character event but also ctrl+j (0x0A)'s one. > > -- sqWin32Window.c -- > > // add this function > static int isNotKeyDownCtrlReturn(MSG* msgp){ > if(msgp->message == WM_KEYDOWN && msgp->wParam == VK_RETURN){ > if(GetKeyState(VK_CONTROL) & 0x8000) { > return FALSE; > } > } > return TRUE; > } > > ... > > int ioProcessEvents(void) > { static MSG msg; > ... > if(isNotKeyDownCtrlReturn(&msg)){ // add > TranslateMessage(&msg); > } // add > DispatchMessage(&msg); > ... > } > > ... > > int recordKeyboardEvent(MSG *msg) { > ... > > if(pressCode == EventKeyDown && virtCode != 0 && > isNotKeyDownCtrlReturn(lastMessage) ) { > // add " && > isNotKeyDownCtrlReturn(lastMessage) " > /* generate extra character event */ > ... > } > return 1; > } > > An attached file is source, which has been corrected by above way. > > > Note: Below is a comment in the source code. > > /* note: several keys are not reported as character events; > most noticably the mapped virtual keys. For those we > generate extra character events here */ > > Those keys(e.g. arrow) should not be ascii code. > ENTER key is not. but an extra character events is created for ENTER. > I don't think this behavior is correct. > As for ENTER key, an extra character event must not be generated, > and WM_CHAR message should be processed. > Please see MSDN about TranslateMessage. > > > see also Comment 11. > > Thanks, > > Attachments: > sqWin32Window.c 99 KB

March 7, 2011

Re: [Pharo-project] Pharo 1.2 and test failures

by Norbert Hartl

On 06.03.2011, at 21:24, Mariano Martinez Peck wrote: > I think there is no magic here. If you want daily build images, then you have 2 options: > > 1) Always use ALL last version of everything > 2) Use last metacello version. Someone needs to update each configuration. > 3) copy a fixed set of mczs to a repository and use the baseline I thought that all mczs are copied to a let's say pharo 1.2 repository. In this case you don't need metacello versions because it loads the newest version which is always true. Well, it is always true if integrating fixes means that the changed package is put into that specific repository. But it doesn't seem to be like that so I have to read it again :) If the packages are taken from their own repositories than I don't see another way than to nail the version in the metacello config and update as soon as a package is updated. A tool like the browser will ease this step. Norbert > If you want 2), then the PEOPLE needs to update configuration. There is no magic. Don't expect to always use the last code. If you want to use 1), perfect. But don't expect that the image is always working perfect: most repositories are public, so people can commit crap, and even more, some repositories are shared with squeak so someone can commit something that doesn't work with Pharo. > > We have to choose. > > To implement 2) then the Hudson script should be updated so that it loads the bleedingEdge: symbolic version of ConfigurationOfPharo. > > cheers > > mariano > > On Sun, Mar 6, 2011 at 8:48 PM, Dale Henrichs <dhenrich(a)vmware.com> wrote: > > On Mar 6, 2011, at 11:29 AM, StÃ©phane Ducasse wrote: > > well, I provided a fix already. And it seems that 3 mails to the list and the mentioning withing this mail does not make it visible. It needs an integration step or just to load the newest ImageForDevelopers > > How to tell? > > I think the ConfigurationOfPharo needs to be updated... > > Probably. Do you know what was the problem? Because I can have a look but I need to know what went wrong. > > I am all in all not happy with the process we have... we should fix it. > > I would not be that negative. I think that we are building an infrastructure and learning how to use it. > Generating one single image is easy. Generating an infrastructure to be able to manage multiple images over different > setup in another story. I think that metacello is getting there and also knowledge. This is why I spent time writing and fixing the > metacello chapter. Now there is more than 30 pages and with the latest important features like symbolic configuration. > > I spent 2 hours to integrate one single changes for shout last week-end, so I know the pain now I think that the situation will > get better. Then else I would like to know your solution and roadmap? > For me this is clear: metacello and distributions are the way. I like that alex and dale are pushing tools on top of Metacello > because we have first class spec and dependencies and we can use them to get to a much better stage and we will get there. > > Stef > > I agree with Stef ... the solution is going to involve both tools and process and at the moment Metacello tools are almost non-existent (Alex and I are trying to change that ... excellent effort Alex!) and we are still learning the process ... > > The integration process for Pharo dev should parallel the process for creating PharoCore ... I'm not familiar with the PharoCore integration process , but after a bug is submitted for fixing, someone changes a script or a config to get the change included in the next PharoCore build ... the same thing needs to happen for Pharo Dev ... the Pharo dev configuration has to be edited to include the proposed fixes ... > > The developer submitting the change _could_ update the configuration or the "owner" of the configuration could update the config or .... > > I can imagine more possibilities ... right now it probably makes sense for an owner to make the changes ... that way if there are configuration issues the owner is responsible for fixing the issues the owner could also filter the changes, much the same way that the bugfixes for PharoCore are filtered ... once the manual process settles down we can look at improving the process and tool support incrementally... > > Dale > > >

March 6, 2011

Re: [Pharo-project] Issue 3778 in pharo: cleaning cursor: and cursor

by pharo＠googlecode.com

Comment #2 on issue 3778 by fernando...(a)gmail.com: cleaning cursor: and cursor http://code.google.com/p/pharo/issues/detail?id=3778 Modified a bit the changeset, no more need to compare Cursor currentCursor == myCursor,beacuse i've added Cursor>>isCurrent; also replaced the usage of #currentCursor: by "myCursor show". Attachments: events.2.cs 8.2 KB

March 6, 2011

Re: [Pharo-project] [COTDC] 26 - PickAFileToWriteNotification

by Fernando Olivero

I'm a notification, with an unclear purpose because I have no senders in the image. I should probably be removed from the system. On Sun, Mar 6, 2011 at 9:29 PM, laurent laffont <laurent.laffont(a)gmail.com> wrote: > Today: Â PickAFileToWriteNotification > > Comment Of The Day Contest - One Day One Comment > Rules: > #1: Each day a not commented class is elected. Each day the best comment > will be integrated with name of the author(s). > #2: If you cannot comment it, deprecate it. > Results:Â http://code.google.com/p/pharo/wiki/CommentOfTheDayContest > Laurent

March 6, 2011

Re: [Pharo-project] Issue 3784 in pharo: ImageForDevelopers uses SHWorkspace which is not defined in the image

by pharo＠googlecode.com

Updates: Status: Closed Comment #4 on issue 3784 by stephane...(a)gmail.com: ImageForDevelopers uses SHWorkspace which is not defined in the image http://code.google.com/p/pharo/issues/detail?id=3784 Ok I published a new version of ConfigurationOfPharo to use ImageForDevelopers-pharo-NorbertHartl.251 Let us see if this is working. I guess so :)

March 6, 2011

Re: [Pharo-project] Issue 3784 in pharo: ImageForDevelopers uses SHWorkspace which is not defined in the image

by pharo＠googlecode.com

Comment #3 on issue 3784 by stephane...(a)gmail.com: ImageForDevelopers uses SHWorkspace which is not defined in the image http://code.google.com/p/pharo/issues/detail?id=3784 Name: ConfigurationOfPharo-StephaneDucasse.141 Author: StephaneDucasse Time: 27 February 2011, 10:51:11 pm UUID: 57852297-5d85-45b9-8641-2f724d7fa49c Ancestors: ConfigurationOfPharo-StephaneDucasse.140 fixing SHWorkspace reference in imageForDeveloper for 1.2.2

March 6, 2011

[Pharo-project] Pharocasts: Build a XML browser

by laurent laffont

Watch this to learn how to: - get and parse XML - use Polymorph to build a GUI with a tree and text editor - add a button in Pharo IDE to open the XML browser - control when your breakpoints will trigger see http://www.pharocasts.com/2011/03/build-xml-browser.html Laurent Laffont - @lolgzs <http://twitter.com/#!/lolgzs> Pharo Smalltalk Screencasts: http://www.pharocasts.com/ Blog: http://magaloma.blogspot.com/

March 6, 2011

[Pharo-project] [COTDC] 26 - PickAFileToWriteNotification

by laurent laffont

Today: PickAFileToWriteNotification Comment Of The Day Contest - One Day One Comment Rules: #1: Each day a not commented class is elected. Each day the best comment will be integrated with name of the author(s). #2: If you cannot comment it, deprecate it. Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest Laurent

March 6, 2011

[Pharo-project] [update 1.3] #13073

by StÃ©phane Ducasse

13073 ----- - Issue 3728: Changed MenuMorph references to go through UIManager default menuClass. Thanks Fernando Oliviero for reviewing the changes. Stef

March 6, 2011

Re: [Pharo-project] [COTDC] 25 - PolymorphSystemSettings

by laurent laffont

I provide settings for Morphic appearance (theme, fonts, colors, ...) that can be found and changed in the Settings browser. Laurent On Fri, Mar 4, 2011 at 10:37 PM, laurent laffont <laurent.laffont(a)gmail.com>wrote: > Today: PolymorphSystemSettings > > > Comment Of The Day Contest - One Day One Comment > Rules: > #1: Each day a not commented class is elected. Each day the best comment > will be integrated with name of the author(s). > #2: If you cannot comment it, deprecate it. > Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest > > Laurent >

March 6, 2011