May 2022 - Pharo-dev - lists.pharo.org

Pharo Launcher 3.0.1: no GUI

by Shaping

From: Shaping <shaping(a)uurda.org> Sent: Wednesday, 4 May, 2022 02:46 To: 'Pharo Development List' <pharo-dev(a)lists.pharo.org> Cc: 'Pharo-users' <pharo-users(a)lists.pharo.org> Subject: [Pharo-dev] Re: [ANN] Pharo Launcher 3.0.1 released! On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. â¦ I do have SDL2.dll in â¦\AppData\Local\PharoLauncher. Still the GUI doesnât open Hi Christophe. Do we understand why the PL 3.0.1 GUI doesnât open sometimes even when SDL2.dll is present? I have in my PharoLauncher folder 74 items. One of those is the images folder. Is that as it should be? â¦ Should the PL 3.0.1 installer produce a \PharoLancher install folder containing 74 items, of which one is the \images folder? If there is a file/folder list discrepancy, we can start the debugging there. â¦ I rebooted the PC, uninstalled PL 3.0.1, and then reinstalled it. The GUI still doesnât appear, but I have 70 files/folders now (not 74), one of which is \images. The difference seems to be caused by the change in OS state after the reboot. Strange. Any ideas? I still have an SDL2.dll. So, although the absence of this file in Johnâs install explains his missing GUI, it doesnât explain mine. Is anyone besides John and me seeing no PL 3.0.1 GUI on Windows? Shaping

May 12, 2022

Re: About Image Size Pharo9->Pharo11

by Norbert Hartl

This is gold. This is the work nobody usually likes to do but is THE apsect for sustainability of a system. Like it!!! thanks, Norbert > Am 11.05.2022 um 09:00 schrieb Marcus Denker <marcus.denker(a)inria.fr>: > > Pharo9: 65,8 MB > Pharo10: 57,4 MB > Pharo11: 56,5 MB > > The space saving come from three things: > > 1) Code cleanup Pharo9-Pharo10 > ========================= > > e.g. removal of support in Kernel and Compiler of old style blocks and bytecodes, > to mention one smaller (in term of image size) but deep cleanup. > > Of course, we can do more here. There is still a lot of dead code (and duplicated > things) in the image! > > > 2) Global Literal Sharing > =================== > > Literals are now, when the method is compiled, set to be read-only, recursively in the case of arrays. > > This allows us to unify (share one instance) not only in the same method, but globally over all methods. > > As the compiler can not do a global literal table when compiling a single method (too slow), this is implemented > as an additional pass, called as part of the build process. > > If you load a lot of code, it might be an idea to do that as part of your build again: > > ImageCleaner shareLiterals > > > 3) Improvement of code structure objects > =============================== > > e.g, in Pharo10 we found two empty OrderedCollections per class that where not needed. > > Further work on this idea is where the improvement in Pharo11 comes from, we merged these three changes: > > - Class>>#classPool: empty dictionary for all classes, but not many define class vars #11172 > https://github.com/pharo-project/pharo/issues/11172 > > - [Memory] sharedPools OrderedCollections waste memory #10957 > https://github.com/pharo-project/pharo/issues/10957 > > - [Memory] AllProtocol uses a lot of memory #10963 > https://github.com/pharo-project/pharo/issues/10963 > > > The classPools/sharedPool improves the size of the bootstrapped image not to0 much as the boostrap creates > classes with nil there, but for newly loaded code this will be more visible. > > This direction has some more fairly simple next steps: > > - [Memory] commentSourcePointer is not needed for MetaClasses > https://github.com/pharo-project/pharo/issues/10958 > > - [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959 > https://github.com/pharo-project/pharo/issues/10959 > > > ... and of course there are many more things to find with just looking a bit. > > (And it is interesting starting point to think about better language support for making long living but rarely changed > data structures more memory efficient) > > If you want to get an impression of which classes use image space, "SpaceTally printSpaceAnalysis" > prints a per-class analysis. > > Marcus

May 11, 2022

Re: About Image Size Pharo9->Pharo11

by Sven Van Caekenberghe

Great work, Marcus. > On 11 May 2022, at 09:00, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Pharo9: 65,8 MB > Pharo10: 57,4 MB > Pharo11: 56,5 MB > > The space saving come from three things: > > 1) Code cleanup Pharo9-Pharo10 > ========================= > > e.g. removal of support in Kernel and Compiler of old style blocks and bytecodes, > to mention one smaller (in term of image size) but deep cleanup. > > Of course, we can do more here. There is still a lot of dead code (and duplicated > things) in the image! > > > 2) Global Literal Sharing > =================== > > Literals are now, when the method is compiled, set to be read-only, recursively in the case of arrays. > > This allows us to unify (share one instance) not only in the same method, but globally over all methods. > > As the compiler can not do a global literal table when compiling a single method (too slow), this is implemented > as an additional pass, called as part of the build process. > > If you load a lot of code, it might be an idea to do that as part of your build again: > > ImageCleaner shareLiterals > > > 3) Improvement of code structure objects > =============================== > > e.g, in Pharo10 we found two empty OrderedCollections per class that where not needed. > > Further work on this idea is where the improvement in Pharo11 comes from, we merged these three changes: > > - Class>>#classPool: empty dictionary for all classes, but not many define class vars #11172 > https://github.com/pharo-project/pharo/issues/11172 > > - [Memory] sharedPools OrderedCollections waste memory #10957 > https://github.com/pharo-project/pharo/issues/10957 > > - [Memory] AllProtocol uses a lot of memory #10963 > https://github.com/pharo-project/pharo/issues/10963 > > > The classPools/sharedPool improves the size of the bootstrapped image not to0 much as the boostrap creates > classes with nil there, but for newly loaded code this will be more visible. > > This direction has some more fairly simple next steps: > > - [Memory] commentSourcePointer is not needed for MetaClasses > https://github.com/pharo-project/pharo/issues/10958 > > - [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959 > https://github.com/pharo-project/pharo/issues/10959 > > > ... and of course there are many more things to find with just looking a bit. > > (And it is interesting starting point to think about better language support for making long living but rarely changed > data structures more memory efficient) > > If you want to get an impression of which classes use image space, "SpaceTally printSpaceAnalysis" > prints a per-class analysis. > > Marcus

May 11, 2022

About Image Size Pharo9->Pharo11

by Marcus Denker

Pharo9: 65,8 MB Pharo10: 57,4 MB Pharo11: 56,5 MB The space saving come from three things: 1) Code cleanup Pharo9-Pharo10 ========================= e.g. removal of support in Kernel and Compiler of old style blocks and bytecodes, to mention one smaller (in term of image size) but deep cleanup. Of course, we can do more here. There is still a lot of dead code (and duplicated things) in the image! 2) Global Literal Sharing =================== Literals are now, when the method is compiled, set to be read-only, recursively in the case of arrays. This allows us to unify (share one instance) not only in the same method, but globally over all methods. As the compiler can not do a global literal table when compiling a single method (too slow), this is implemented as an additional pass, called as part of the build process. If you load a lot of code, it might be an idea to do that as part of your build again: ImageCleaner shareLiterals 3) Improvement of code structure objects =============================== e.g, in Pharo10 we found two empty OrderedCollections per class that where not needed. Further work on this idea is where the improvement in Pharo11 comes from, we merged these three changes: - Class>>#classPool: empty dictionary for all classes, but not many define class vars #11172 https://github.com/pharo-project/pharo/issues/11172 - [Memory] sharedPools OrderedCollections waste memory #10957 https://github.com/pharo-project/pharo/issues/10957 - [Memory] AllProtocol uses a lot of memory #10963 https://github.com/pharo-project/pharo/issues/10963 The classPools/sharedPool improves the size of the bootstrapped image not to0 much as the boostrap creates classes with nil there, but for newly loaded code this will be more visible. This direction has some more fairly simple next steps: - [Memory] commentSourcePointer is not needed for MetaClasses https://github.com/pharo-project/pharo/issues/10958 - [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959 https://github.com/pharo-project/pharo/issues/10959 ... and of course there are many more things to find with just looking a bit. (And it is interesting starting point to think about better language support for making long living but rarely changed data structures more memory efficient) If you want to get an impression of which classes use image space, "SpaceTally printSpaceAnalysis" prints a per-class analysis. Marcus

May 11, 2022

Re: [ANN] Pharo Launcher 3.0.1 released!

by Shaping

From: Shaping <shaping(a)uurda.org> Sent: Wednesday, 4 May, 2022 02:46 To: 'Pharo Development List' <pharo-dev(a)lists.pharo.org> Cc: 'Pharo-users' <pharo-users(a)lists.pharo.org> Subject: [Pharo-dev] Re: [ANN] Pharo Launcher 3.0.1 released! On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. â¦ I do have SDL2.dll in â¦\AppData\Local\PharoLauncher. Still the GUI doesnât open Hi Christophe. Do we understand why the PL 3.0.1 GUI doesnât open sometimes even when SDL2.dll is present? I have in my PharoLauncher folder 74 items. One of those is the images folder. Is that as it should be? â¦ Hi. Christophe. Should the PL 3.0.1 installer produce a \PharoLancher install folder containing 74 items, of which one is the \images folder? If there is a file/folder list discrepancy, we can start the debugging there. Shaping

May 10, 2022

Re: About ReToDoRule

by Marcus Denker

Nobody seems to have an immediate reason that it is good to keep, I propose to just remove that rule: https://github.com/pharo-project/pharo/pull/11164 <https://github.com/pharo-project/pharo/pull/11164> (PR in need of a review!) > On 9 May 2022, at 15:12, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > I have never seen ReToDoRule to suggest a change that I wanted to do. > > I think it tries to detect if there is #at: send to the collection inside the block and suggests to use more high-level iterators. > > But the suggestions are odd and it seems to be too naive with just detecting the #at: message send to the iterated value. > > "Checks for use of to:do: when a do:, with:do: or timesRepeat: when should be used.â > > â¢ #timesRepeat: does not take an argument for the block with the running index, so it is not a replacement > â¢ with:do: is not a replacement for to:do: ? it would mean creating first a collection and then iterating > â¢ using do: on an interval is bad, we even have a rule against that: ReUnoptimizedToDoRule > > > Maybe I am missing something? > > > The rule ReToDoCollectRule seems to be working nicely, though. > > Issue tracker entry: https://github.com/pharo-project/pharo/issues/11162 > > >

May 10, 2022

Dictionary newFrom: and duplicated keys

by Marcus Denker

Hi, Dictionary class>>#newFrom: right now raises an error if it sees duplicated keys. newFrom: aDictionaryOrCollectionOfAssociations "Answer an instance of me containing the same associations as the argument. Error if any key appears twice." | newDictionary | newDictionary := self new: aDictionaryOrCollectionOfAssociations size. aDictionaryOrCollectionOfAssociations associationsDo: [:x | (newDictionary includesKey: x key) ifTrue: [self error: 'Duplicate key: ', x key printString] ifFalse: [newDictionary add: x]]. ^ newDictionary this leads to an error for: {#a->1. #a->2} asDictionary While just creating it with new and putting the data of course has no problem with duplicated keys: Dictionary new at: #a put: 1; at: #a put: 2; yourself We have a suggestion to remove the error. PR is here: https://github.com/pharo-project/pharo/pull/11176 <https://github.com/pharo-project/pharo/pull/11176> (as a side-effect, this speed up asDictionary a little, too) Marcus

May 10, 2022

About ReToDoRule

by Marcus Denker

I have never seen ReToDoRule to suggest a change that I wanted to do. I think it tries to detect if there is #at: send to the collection inside the block and suggests to use more high-level iterators. But the suggestions are odd and it seems to be too naive with just detecting the #at: message send to the iterated value. "Checks for use of to:do: when a do:, with:do: or timesRepeat: when should be used.â â¢ #timesRepeat: does not take an argument for the block with the running index, so it is not a replacement â¢ with:do: is not a replacement for to:do: ? it would mean creating first a collection and then iterating â¢ using do: on an interval is bad, we even have a rule against that: ReUnoptimizedToDoRule Maybe I am missing something? The rule ReToDoCollectRule seems to be working nicely, though. Issue tracker entry: https://github.com/pharo-project/pharo/issues/11162

May 9, 2022

Re: This week (18/2022) on the Pharo Issue Tracker

by Guillermo Polito

Thanks Marcus! > El 6 may 2022, a las 8:15, Marcus Denker <marcus.denker(a)inria.fr> escribiÃ³: > > We merged 8 PRs and fixed 9 Issue tracker entries. > > There are more PRs ready to be reviewed! https://github.com/pharo-project/pharo/pulls > > Even a reviews for trivial changes (like improvements in comments, removal of dead codeâ¦) > are very helpful. > > > Memory/Image Size > ================= > > Size is down to 56.5 MB for the bootstrapped full image after this. > > - 11172-ClassclassPool-empty-dictionary-for-all-classes-but-not-many-define-class-vars #11175 > https://github.com/pharo-project/pharo/pull/11175 > > > Features > ======== > - Reflectivity-AddPragmaSupport #10436 > https://github.com/pharo-project/pharo/pull/10436 > > - Added shortcut method to show the formatting key bindings. #11181 > https://github.com/pharo-project/pharo/pull/11181 > > - Added Array2D inspector extension #365 > https://github.com/pharo-spec/NewTools/pull/365 > > Bugs > === > - Fixes issue #11143: MiniDrTests raise error #11180 > https://github.com/pharo-project/pharo/pull/11180 > > > Cleanup > ======= > > - Rename BlockClosure startpc to compiledBlock #11188 > https://github.com/pharo-project/pharo/pull/11188 > > - Start to remove code from Deprecated10 package. #11192 > https://github.com/pharo-project/pharo/pull/11192 > > - [ci skip] [cleanup] improve comment of directories and files methods #11174 > https://github.com/pharo-project/pharo/pull/11174

May 6, 2022

This week (18/2022) on the Pharo Issue Tracker

by Marcus Denker

We merged 8 PRs and fixed 9 Issue tracker entries. There are more PRs ready to be reviewed! https://github.com/pharo-project/pharo/pulls Even a reviews for trivial changes (like improvements in comments, removal of dead codeâ¦) are very helpful. Memory/Image Size ================= Size is down to 56.5 MB for the bootstrapped full image after this. - 11172-ClassclassPool-empty-dictionary-for-all-classes-but-not-many-define-class-vars #11175 https://github.com/pharo-project/pharo/pull/11175 Features ======== - Reflectivity-AddPragmaSupport #10436 https://github.com/pharo-project/pharo/pull/10436 - Added shortcut method to show the formatting key bindings. #11181 https://github.com/pharo-project/pharo/pull/11181 - Added Array2D inspector extension #365 https://github.com/pharo-spec/NewTools/pull/365 Bugs === - Fixes issue #11143: MiniDrTests raise error #11180 https://github.com/pharo-project/pharo/pull/11180 Cleanup ======= - Rename BlockClosure startpc to compiledBlock #11188 https://github.com/pharo-project/pharo/pull/11188 - Start to remove code from Deprecated10 package. #11192 https://github.com/pharo-project/pharo/pull/11192 - [ci skip] [cleanup] improve comment of directories and files methods #11174 https://github.com/pharo-project/pharo/pull/11174

May 6, 2022