April 2021 - Pharo-dev - lists.pharo.org

[ANN] Freezing Pharo 9 development right now :)

by Esteban Lorenzano

Hi, So, today I was checking how much it is missing for release and what is our status, and I realized if we do not freeze now, we will never release in a reasonable time. So, even if there are a couple of cleanups and that to still do that should happen before, I will declare that Pharo 9.0 enters in freeze Pharo 9.0 right now (and I will sneak the cleanups anyway, but being more careful). What does this means? No more features, just bugfixes No more fixes of things that can wait until Pharo 10 In two weeks I will open the Pharo 10 development branch, up to then, please help fixing what's missing (which is a lot) ! Have a great weekend, cheers! Esteban

April 30, 2021

This week (17/2021) on the Pharo Issue Tracker

by Marcus Denker

We merged 37 Pull Requests and fixed 35 issues this week. The focus was for one on Newtools, the others have been general bugfixes and cleanups. NewTools 0.6.4 =============== - [spotter] enhance the way of keeping selection while adding new results - [inspector] halt on call appears again - [playground] add a simple versioning system based on ombu - fix #8803 (thanks @MarcusDenker) - fix pharo-spec/NewTools#154 - fix #888 - cleanups NewTools 0.6.5 ============== - spotter handles correctly scoping it by an origin (it will be used in calypso <meta+h> command, and probably others). Spec 0.8.11 ============= - feature: add standard dialogs - code presenter: enhance method selection - fix pharo-spec/Spec#1047 - fix #8434 (thanks @kasperosterbye) - fix #8421 (thanks @kasperosterbye) - some fixes in SpDemo (WIP) - cleanups Spec 0.8.12 ============ - trees now can collapse paths Fixes ===== - fixing-socket-availableData #9130 https://github.com/pharo-project/pharo/pull/9130 - 9196-Enter-key-in-the-numpad-does-not-work #9204 https://github.com/pharo-project/pharo/pull/9204 - 9208 rb sequence node periods statements temporaries point to the same instance #9209 https://github.com/pharo-project/pharo/pull/9209 - 9077-SpValueHolder-did-not-untderstand-asTest-in-new-playground-About-menu #9132 https://github.com/pharo-project/pharo/pull/9132 - Allow-Shadowing-RequestorVars #9202 https://github.com/pharo-project/pharo/pull/9202 - 9188-Text-does-understand-unescapeCharacter #9198 https://github.com/pharo-project/pharo/pull/9198 - fixes #9183 by adding a deprecated subclass #9191 https://github.com/pharo-project/pharo/pull/9191 - 9187-Debug-it-raises-isReturnSpecial-was-sent-to-nil #9190 https://github.com/pharo-project/pharo/pull/9190 - Context>>printDetails trimmed the last character #9134 https://github.com/pharo-project/pharo/pull/9134 - Fix 9150-Right-click-is-broken-on-variables-in-the-Calypso-browser #9151 https://github.com/pharo-project/pharo/pull/9151 - update commitish for newtools v0.6.3 #9133 https://github.com/pharo-project/pharo/pull/9133 - every AthensCanvas has own paint cache #9111 https://github.com/pharo-project/pharo/pull/9111 Cleanups ======== - testNoUnusedInstanceVariablesLeft-down-to-6 #9207 https://github.com/pharo-project/pharo/pull/9207 - RubParagraphDecorator-class-isUsed #9184 https://github.com/pharo-project/pharo/pull/9184 - Epicea-deprecation-rewrites #9192 https://github.com/pharo-project/pharo/pull/9192 - IconicListItem should be in Deprecated90 package #9180 https://github.com/pharo-project/pharo/pull/9180 - TabLabelItem should be in Deprecated90 package #9182 https://github.com/pharo-project/pharo/pull/9182 - AthensAbstractShape should be abstract #9158 https://github.com/pharo-project/pharo/pull/9158 - AthensAbstractMeshPaintPatch should be abstract #9155 https://github.com/pharo-project/pharo/pull/9155 - AthensAbstractPaint should be abstract #9153 https://github.com/pharo-project/pharo/pull/9153 - SignalLogger should be abstract #9163 https://github.com/pharo-project/pharo/pull/9163 - Implement CodeChunk(class)>>#isAbstract #9168 https://github.com/pharo-project/pharo/pull/9168 - Abstract classes in Keymapping package #9174 https://github.com/pharo-project/pharo/pull/9174 - BytecodeEncoder should implement #isAbstract to return true #9172 https://github.com/pharo-project/pharo/pull/9172 - Fix small lint issue in ClapImage commands #9166 https://github.com/pharo-project/pharo/pull/9166 - Remove class AthensTiger3 #9159 https://github.com/pharo-project/pharo/pull/9159 - 9160 review athens text display command #9161 https://github.com/pharo-project/pharo/pull/9161 - Cleanup BehaviorOwnedChunk #9170 https://github.com/pharo-project/pharo/pull/9170 - Fix typo in MicSingleLineBlock class comment #9178 https://github.com/pharo-project/pharo/pull/9178 - 8864/calypso names #9148 https://github.com/pharo-project/pharo/pull/9148 - Cleanup-CommentTestCase-cleanUpInstanceVariables #9143 https://github.com/pharo-project/pharo/pull/9143 - 9140-ContributingToTheCatalogHelp-can-be-removed #9144 https://github.com/pharo-project/pharo/pull/9144 - 9129-RubTextEditorunescapeCharacterinString-should-be-implemented-in-String #9131 https://github.com/pharo-project/pharo/pull/9131

April 30, 2021

[ANN] Next Pharo Sprint: April 30

by Marcus Denker

Next Pharo Sprint: April 30 We will organize a Pharo sprint / Moose dojo April 30 Goals of this sprint: - Fix issues from tracker https://github.com/pharo-project/pharo/issues - Especially checking older issues This is a Remote Sprint, it happens on Discord. http://pharo.org/contribute-events We have added a Board to coordinate the work: https://github.com/orgs/pharo-project/projects/9 A list of all Pharo Event of the year an be found here: https://association.pharo.org/events

April 27, 2021

Progress Report -> Refactoring Project - ( April 19 - April 23)

by Evelyn Cusi Lopez

Hi everyone, Last week I did these tasks: -* Introduce class deprecation refactoring*, Fix issue: Introduce class Deprecation as Refactoring #9033 <https://github.com/pharo-project/pharo/issues/9033> Check PR <https://github.com/pharo-project/pharo/pull/9103> to know the changes. You can see the new behavior in this video: https://youtu.be/sVq6cyyvf7s . -* Introduce **Migrate References From Class to Another*. Fix issue: MigrateReferencesFromClass: A to: NewClass #9101 <https://github.com/pharo-project/pharo/issues/9101>. Check PR <https://github.com/pharo-project/pharo/pull/9103> to know the changes. - *Add support to alias in RBNamespace *. Fix issue: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> . You can see the changes here: PR <https://github.com/pharo-project/pharo/pull/9141> . - *Improve inline all senders refactoring.* Fix issues: RB - Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042>, Inline senders refactoring does not correctly manage errors #6218 <https://github.com/pharo-project/pharo/issues/6218> . Check PR <https://github.com/pharo-project/pharo/pull/9141> to know the changes. You can watch the new behavior in: https://youtu.be/H9S3nmEHL9s . -* Improve preconditions of Realize Class Refactoring and add tests for it*. Check PR <https://github.com/pharo-project/pharo/pull/9146> to know the changes. You can watch the new behavior in this video: https://youtu.be/UAoiiEK1Xy4 . - *Add preview for refactorings.* Check PR <https://github.com/pharo-project/pharo/pull/9146> to know the changes. Tasks for this week: - Finish to add the new preview to select a default scope. - Fix issue: RB - Inline all senders of class methods (instance creation) doesn't work, need improve pattern to search #9142 <https://github.com/pharo-project/pharo/issues/9142> - Fix issues: Enhance Refactoring Preview Widget #9060 <https://github.com/pharo-project/pharo/issues/9060> and Refactoring dialogs should not be modal #5894 . <https://github.com/pharo-project/pharo/issues/5894> <https://github.com/pharo-project/pharo/issues/6218> - Fix issue: When I rename a method I cannot rename its parameter #9139 <https://github.com/pharo-project/pharo/issues/9139> - Fix issue: Inline temp refactoring can create code with different behavior. #6056 <https://github.com/pharo-project/pharo/issues/6056> (using create cascade refactoring) - Fix issue: RB - Improve instance variable refactoring #8665 <https://github.com/pharo-project/pharo/issues/8665> Regards, Evelyn C.

April 26, 2021

This week (16/2021) on the Pharo Issue Tracker

by Marcus Denker

We merged 32 PRs and fixed 23 issue tracker entries this week. https://github.com/pharo-project/pharo/pulse Spec v0.8.10 ============ - added a trait SpTModel to add "model" behavior to presenters. - SpPanedLayout: deprecating position/position: using positionOfSlider: now - Fixed error when entering an empty text on the field of SpRGBSliders (Thanks @jordanmontt) - small fixes NewTools v0.6.3 ================ - Raw inspection should show always first fixed slots then variable slots (thanks @guillep) - do not use gtDisplay things (thanks @Ducasse) - applying deprecations - small fixes Refactoring Tools ================= - RB - Update deprecate method refactoring and add command #9085 https://github.com/pharo-project/pharo/pull/9085 - RB - Fix command extract set up #9109 https://github.com/pharo-project/pharo/pull/9109 Compiler ======== - Refactor semantics analyzer to not rely on #isLocalVariable message #9113 https://github.com/pharo-project/pharo/pull/9113 - Cleanup DoItVariable from locals related methods (markRead and etc.) #9122 https://github.com/pharo-project/pharo/pull/9122 - Compiler-Improve-lookupVar #9118 https://github.com/pharo-project/pharo/pull/9118 Features ======= - adding-variadic-TF-functions #9102 https://github.com/pharo-project/pharo/pull/9102 - Added a setting configuration for ClyTextLineNumberSwitchMorph #9104 https://github.com/pharo-project/pharo/pull/9104 - Pr new help #9090 https://github.com/pharo-project/pharo/pull/9090 - 4443-We-should-have-a-code-critic-rule-checking-for-dot-at-the-end-of-method-signature #9088 https://github.com/pharo-project/pharo/pull/9088 Fixes ===== - remove hidden character #9082 https://github.com/pharo-project/pharo/pull/9082 - Fix #8654 - Process>>#terminate should answer self consistently #8712 https://github.com/pharo-project/pharo/pull/8712 - 9069-Typing-in-Transcript-gives-a-DNU-doItContext-CompletionEngine #9084 https://github.com/pharo-project/pharo/pull/9084 - 5818-SHRBTextStyler-doesnt-format-comments-on-root-AST-node #9083 https://github.com/pharo-project/pharo/pull/9083 - Fix/9056: The 'meta' keyboard shortcut modifier should not be used in the UI #9078 https://github.com/pharo-project/pharo/pull/9078 - Order in Calypso menu order for test handling #9124 https://github.com/pharo-project/pharo/pull/9124 - Continue improving DrTests Doc comments plugin #9081 https://github.com/pharo-project/pharo/pull/9081 - Simplify-CommentTestCase #9116 https://github.com/pharo-project/pharo/pull/9116 Improve Tests ============= - Fixes: #9091: ading some tests to the Mock SUnit extensions #9092 https://github.com/pharo-project/pharo/pull/9092 - ReleaseTest-Dot-end-of-Signature #9097 https://github.com/pharo-project/pharo/pull/9097 - improve-taskit-tests-for-waitingGC #9106 https://github.com/pharo-project/pharo/pull/9106 - testNoUnusedInstanceVariablesLeft-down-to-12 #9126 https://github.com/pharo-project/pharo/pull/9126 - 6337-Ensure-test-classes-are-named-in-singular #9089 https://github.com/pharo-project/pharo/pull/9089 Cleanups ======== - 6319-SmallInteger-as31BitInteger-wrong-on-64-bit-systems #9100 https://github.com/pharo-project/pharo/pull/9100 - Editor-Cleanup-Unused-Rubric-Subclasses #9120 https://github.com/pharo-project/pharo/pull/9120 - Remove GTPlaygroundHelp #9079 https://github.com/pharo-project/pharo/pull/9079

April 23, 2021

Re: Progress Report -> Refactoring Project - ( April 12 - April 16)

by Evelyn Cusi Lopez

Hi Noury, I hope that the work we are doing with Stef, Pablo and Juan Pablo helps to improve the user experience in the automatic refactorings of Pharo. Any comments on the changes or the introduction of new ideas are welcome. Regards, Evelyn El lun, 19 abr 2021 a las 10:03, Noury Bouraqadi (<bouraqadi(a)gmail.com>) escribiÃ³: > Hi Evelyn, > > I've been silently watching your weekly progress. > I thought, for once say thank you :-) > > Noury > On Apr 19 2021, at 7:08 am, Evelyn Cusi Lopez <cusi.evelyn(a)gmail.com> > wrote: > > Hi everyone, > > Last week I did these tasks: > > - *Improve and add command to deprecate a method. *Check PR > <https://github.com/pharo-project/pharo/pull/9085> to know the changes. > - *Improve "Set up score command" *Check PR > <https://github.com/pharo-project/pharo/pull/9039> to know the changes. > I'm not sure if this issue is still relevant, but you can see the new > behavior here: https://youtu.be/ejL_RTLPOMo . > -* Fix move method with suggestion of protocol* (Move to package of > defining class enh #8929 > <https://github.com/pharo-project/pharo/issues/8929>) Check PR > <https://github.com/pharo-project/pharo/pull/9095> to know the changes. > You can see the new behavior in this video: https://youtu.be/r22E1BUZxrE . > - *Add preview rename class refactoring*, now show changes one by one, > not all in one. Check PR > <https://github.com/pharo-project/pharo/pull/9043> to know the changes. > -* Introduce class deprecation refactoring*, It was based mainly on > Stef's suggestions, however before doing the PR I hope to resolve some > doubts to see if any of the behaviors from the previous refactoring should > be preserved. You can see the changes here: > https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:ClassDepre… > . > - I start to do the *new preview to set the default scope*. Still in > progress. > - I continue fixing the issue: RBNamespace doesn't support alias #9041 > <https://github.com/pharo-project/pharo/issues/9041> and Inline method > refactoring doesn't handle well, handling calls to super or overrides #9042 > <https://github.com/pharo-project/pharo/issues/9042> . Still in progress. > > Tasks for this week: > > - Add command to class deprecation refactoring. > - Finish to add the new preview to select a default scope. > - Finish to fix: RBNamespace doesn't support alias #9041 > <https://github.com/pharo-project/pharo/issues/9041> > - Finish to fix issues: Inline method refactoring doesn't handle well, > handling calls to super or overrides #9042 > <https://github.com/pharo-project/pharo/issues/9042> and Inline senders > refactoring does not correctly manage errors #6218 > <https://github.com/pharo-project/pharo/issues/6218> > - Fix issues: Enhance Refactoring Preview Widget #9060 > <https://github.com/pharo-project/pharo/issues/9060> and > > Refactoring dialogs should not be modal #5894 . > <https://github.com/pharo-project/pharo/issues/5894> > > > > > Regards, > > Evelyn C. > >

April 19, 2021

Re: Progress Report -> Refactoring Project - ( April 12 - April 16)

by Noury Bouraqadi

Hi Evelyn, I've been silently watching your weekly progress. I thought, for once say thank you :-) Noury On Apr 19 2021, at 7:08 am, Evelyn Cusi Lopez <cusi.evelyn(a)gmail.com> wrote: > Hi everyone, > > Last week I did these tasks: > > - Improve and add command to deprecate a method. Check PR (https://github.com/pharo-project/pharo/pull/9085) to know the changes. > - Improve "Set up score command" Check PR (https://github.com/pharo-project/pharo/pull/9039) to know the changes. I'm not sure if this issue is still relevant, but you can see the new behavior here: https://youtu.be/ejL_RTLPOMo . > > - Fix move method with suggestion of protocol (Move to package of defining class enh #8929 (https://github.com/pharo-project/pharo/issues/8929)) Check PR (https://github.com/pharo-project/pharo/pull/9095) to know the changes. You can see the new behavior in this video: https://youtu.be/r22E1BUZxrE . > - Add preview rename class refactoring, now show changes one by one, not all in one. Check PR (https://github.com/pharo-project/pharo/pull/9043) to know the changes. > > - Introduce class deprecation refactoring, It was based mainly on Stef's suggestions, however before doing the PR I hope to resolve some doubts to see if any of the behaviors from the previous refactoring should be preserved. You can see the changes here: https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:ClassDepre… . > - I start to do the new preview to set the default scope. Still in progress. > > - I continue fixing the issue: RBNamespace doesn't support alias #9041 (https://github.com/pharo-project/pharo/issues/9041) and Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 (https://github.com/pharo-project/pharo/issues/9042) . Still in progress. > > Tasks for this week: > > - Add command to class deprecation refactoring. > - Finish to add the new preview to select a default scope. > > - Finish to fix: RBNamespace doesn't support alias #9041 (https://github.com/pharo-project/pharo/issues/9041) > - Finish to fix issues: Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 (https://github.com/pharo-project/pharo/issues/9042) and Inline senders refactoring does not correctly manage errors #6218 (https://github.com/pharo-project/pharo/issues/6218) > - Fix issues: Enhance Refactoring Preview Widget #9060 (https://github.com/pharo-project/pharo/issues/9060) and > > Refactoring dialogs should not be modal #5894 . (https://github.com/pharo-project/pharo/issues/5894) > > > > > Regards, > > Evelyn C.

April 19, 2021

Progress Report -> Refactoring Project - ( April 12 - April 16)

by Evelyn Cusi Lopez

Hi everyone, Last week I did these tasks: - *Improve and add command to deprecate a method. *Check PR <https://github.com/pharo-project/pharo/pull/9085> to know the changes. - *Improve "Set up score command" *Check PR <https://github.com/pharo-project/pharo/pull/9039> to know the changes. I'm not sure if this issue is still relevant, but you can see the new behavior here: https://youtu.be/ejL_RTLPOMo . -* Fix move method with suggestion of protocol* (Move to package of defining class enh #8929 <https://github.com/pharo-project/pharo/issues/8929>) Check PR <https://github.com/pharo-project/pharo/pull/9095> to know the changes. You can see the new behavior in this video: https://youtu.be/r22E1BUZxrE . - *Add preview rename class refactoring*, now show changes one by one, not all in one. Check PR <https://github.com/pharo-project/pharo/pull/9043> to know the changes. -* Introduce class deprecation refactoring*, It was based mainly on Stef's suggestions, however before doing the PR I hope to resolve some doubts to see if any of the behaviors from the previous refactoring should be preserved. You can see the changes here: https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:ClassDepre… . - I start to do the *new preview to set the default scope*. Still in progress. - I continue fixing the issue: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> and Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042> . Still in progress. Tasks for this week: - Add command to class deprecation refactoring. - Finish to add the new preview to select a default scope. - Finish to fix: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> - Finish to fix issues: Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042> and Inline senders refactoring does not correctly manage errors #6218 <https://github.com/pharo-project/pharo/issues/6218> - Fix issues: Enhance Refactoring Preview Widget #9060 <https://github.com/pharo-project/pharo/issues/9060> and Refactoring dialogs should not be modal #5894 . <https://github.com/pharo-project/pharo/issues/5894> <https://github.com/pharo-project/pharo/issues/6218> Regards, Evelyn C.

April 19, 2021

This week (15/2021) on the Pharo Issue Tracker

by Marcus Denker

We merged 35 PRs and closed 14 issues. https://github.com/pharo-project/pharo/pulse merge spec 0.8.9 #9049 ================ - https://github.com/pharo-spec/Spec/releases/tag/v0.8.9 - removed some unused methods (starting to clean up before release a final version) - code presenter: Fix implementors and senders to work as in Pharo 8 (thanks @guillep) - toolbar: fixing moving buttons (thanks @tesonep) - small fixes Fixes ===== - 8966-hidden-Undeclared-instance-variables-after-renaming #8997 https://github.com/pharo-project/pharo/pull/8997 - added a comparisson to KeyboardKey #8436 https://github.com/pharo-project/pharo/pull/8436 - fix-dependency-test-error-with-SUnit-Mock #9054 https://github.com/pharo-project/pharo/pull/9054 - Answer the new instance in OSWindowGestureHandler #9058 https://github.com/pharo-project/pharo/pull/9058 - Parse comments at the end of methods without statements #9066 https://github.com/pharo-project/pharo/pull/9066 Tool Fixes =========== - Links in class comments crash instead of opening a browser #9068 https://github.com/pharo-project/pharo/pull/9068 - 9000-MethodFinder-class-works-as-expected-but-not-in-the-Finder-tool--error-in-Finder-documentation #9017 https://github.com/pharo-project/pharo/pull/9017 - 8978-Selector-extraction-for-browsing-sendersimplementors-does-not-work-for-for-multi-line-calls #9053 https://github.com/pharo-project/pharo/pull/9053 - 8974-Adding-a-breakpoint-using-the-context-menu-does-not-work-in-the-latest-build #9045 https://github.com/pharo-project/pharo/pull/9045 Tool Improvements ================= - 2586 deleting a class with references gives extra do you want to delete anyway msg #8901 https://github.com/pharo-project/pharo/pull/8901 - Allow the user to delete a class even if the class has references. #9055 https://github.com/pharo-project/pharo/pull/9055 - Add simple mock objects implementation to SUnit #8489 https://github.com/pharo-project/pharo/pull/8489 Cleanups ======== - 8941-Cleanup-shadowing-class-Variables #9001 https://github.com/pharo-project/pharo/pull/9001 - 7305-HiExampleCommit-classiceberg-v1-5-6-contains-huuuuge-String #9061 https://github.com/pharo-project/pharo/pull/9061 - IRBuilderTest-testLiteralVariableClassVariable-cleanup #9059 https://github.com/pharo-project/pharo/pull/9059 - DrTest-Simplify-Docomment-detection #9062 https://github.com/pharo-project/pharo/pull/9062 - Cleanup-GLMHighlighterTextParserStyler #9065 https://github.com/pharo-project/pharo/pull/9065 - copyOldValuesToNewVariable-no-offset #9051 https://github.com/pharo-project/pharo/pull/9051 - Remove GTDebuggerHelp and subclasses #9071 https://github.com/pharo-project/pharo/pull/9071 - Remove GTInspectorHelp #9073 https://github.com/pharo-project/pharo/pull/9073 - remove hidden character #9082 https://github.com/pharo-project/pharo/pull/9082 Cleanup: unify class names ======= - Rename WidgetExamples to WidgetExample #9005 https://github.com/pharo-project/pharo/pull/9005 - Rename TabSelected to TabSelectedState. #9008 https://github.com/pharo-project/pharo/pull/9008 - Rename TabDisabled to TabDisabledState #9009 https://github.com/pharo-project/pharo/pull/9009 - Rename Pharo3TabPanelBorder to Pharo3TabPanelBorderStyle. #9028 https://github.com/pharo-project/pharo/pull/9028 - Rename ToggleMenuItemShortcutWithSymbol to ToggleWithSymbolMenuItemShâ¦ #9006 https://github.com/pharo-project/pharo/pull/9006 - Rename ExampleRadioButtonModel to RadioButtonModelExample #9007 https://github.com/pharo-project/pharo/pull/9007 - Rename IconicListItem to IconicListItemMorph. #9031 https://github.com/pharo-project/pharo/pull/9031 - Rename FTMultipleSelection to FTMultipleSelectionStrategy. #9003 https://github.com/pharo-project/pharo/pull/9003 - Rename FTSimpleSelection to FTSimpleSelectionStrategy. #9004 https://github.com/pharo-project/pharo/pull/9004 - Rename IconicButton to IconicButtonMorph and TabLabelItem to TabLabelâ¦ #9037 https://github.com/pharo-project/pharo/pull/9037 - Renaming the TabState hierarchy. #9036 https://github.com/pharo-project/pharo/pull/9036

April 16, 2021

Re: Improving Variable Shadow model

by Noury Bouraqadi

Thanks Marcus On Apr 14 2021, at 10:53 am, Marcus Denker <marcus.denker(a)inria.fr> wrote: > Just a status update: we merged all the code. > > - we now have for both the class and method view a Critique rule that warns you if you use shadowing vars. > > - Pavel fixed all the cases of shadowing class variables. Thanks! > > - release tests are active, #testNoShadowedVariablesInMethods fo methods and at the class level: > > > testClassesShadow > > | classes | > classes := Smalltalk globals allBehaviors select: [ :class | > class definedVariables anySatisfy: [ :var | > var isShadowing ] ]. > > self assert: classes isEmpty description: classes asArray asString > > > status cleanups: > > - DONE: Shadowed vars (as we saw) > => TODO: combine the snippets of writing into one blog post for the devblog > - DONE: unused Class Variables > - ongoing: unused ivars. Just some left in Spec+Newtools (and one in Kernel tests) > - ongoing: all methods should be categorized. > - todo: we should have no method that is the same as a method in a superclass > > > > On 2 Apr 2021, at 15:33, Marcus Denker <marcus.denker(a)inria.fr (mailto:marcus.denker@inria.fr)> wrote: > > > > > > # Code Critique > > > > What we need next is a Code Critique rule. This for once warns developers early, but in addition it will > > make it much easier to fix the 6 problem cases that the release test exposed. > > > > Checking for current senders of #definedVariables leads us to ReVariableAssignedLiteralRule, we can use this as a template. > > The main method doing the check looks like this: > > > > ```Smalltalk > > check: aClass forCritiquesDo: aCriticBlock > > > > aClass definedVariables do: [ :variable | > > variable isShadowing ifTrue: [ > > aCriticBlock cull: (self critiqueFor: aClass about: variable name) ] ] > > ``` > > > > The full PR is here: https://github.com/pharo-project/pharo/pull/8940

April 14, 2021