February 2020 - Pharo-dev - lists.pharo.org

RE: [Pharo-dev] PR without Tests

by Vincent Blondeau

Great news! I was wondering if they were also something planned to get some coverage information report to help to add more tests on parts of the system that are not tested? Cheers, Vincent -----Original Message----- From: Pharo-dev On Behalf Of tesonep(a)gmail.com Sent: Thursday, 6 February 2020 10:30 To: Pharo-dev <pharo-dev(a)lists.pharo.org>; rmod(a)inria.fr list <rmod(a)inria.fr> Subject: [Pharo-dev] PR without Tests Hello, Pharo is not Smalltalk / Smalltalk is not Pharo / Pharo is Smalltalk. Now that I have your attention because it seems the only read mail has to have this. We have to continue improving the quality of Pharo. One of the biggest assets that we have in Pharo are the tons of tests. So, we need to reject any PR that does not have tests or it is not already tested. To ease this quality measure, please add some comments on the PR about how your new code or modified code is tested or benchmarked. Cheers. -- Pablo Tesone. tesonep(a)gmail.com

Feb. 6, 2020

Re: [Pharo-dev] [rmod] PR without Tests

by Esteban Lorenzano

+1000 > On 6 Feb 2020, at 10:29, tesonep(a)gmail.com wrote: > > > --

Feb. 6, 2020

Re: [Pharo-dev] PR without Tests

by tesonep＠gmail.com

Of course, the already open PR are there, and it is ok, we can handle them. On Thu, Feb 6, 2020 at 10:29 AM tesonep(a)gmail.com <tesonep(a)gmail.com> wrote: > > Hello, > Pharo is not Smalltalk / Smalltalk is not Pharo / Pharo is Smalltalk. > Now that I have your attention because it seems the only read mail has > to have this. > > We have to continue improving the quality of Pharo. One of the biggest > assets that we have in Pharo are the tons of tests. So, we need to > reject any PR that does not have tests or it is not already tested. > > To ease this quality measure, please add some comments on the PR about > how your new code or modified code is tested or benchmarked. > > Cheers. > > -- > Pablo Tesone. > tesonep(a)gmail.com -- Pablo Tesone. tesonep(a)gmail.com

Feb. 6, 2020

PR without Tests

by tesonep＠gmail.com

Hello, Pharo is not Smalltalk / Smalltalk is not Pharo / Pharo is Smalltalk. Now that I have your attention because it seems the only read mail has to have this. We have to continue improving the quality of Pharo. One of the biggest assets that we have in Pharo are the tons of tests. So, we need to reject any PR that does not have tests or it is not already tested. To ease this quality measure, please add some comments on the PR about how your new code or modified code is tested or benchmarked. Cheers. -- Pablo Tesone. tesonep(a)gmail.com

Feb. 6, 2020