August 2019 - Pharo-dev - lists.pharo.org

[Pharo 8.0] Build #667: 4406-fix-class-def-parser-for-simple-definitions

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #667 was: FAILURE. The Pull Request #4409 was integrated: "4406-fix-class-def-parser-for-simple-definitions" Pull request url: https://github.com/pharo-project/pharo/pull/4409 Issue Url: https://github.com/pharo-project/pharo/issues/4406 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 23, 2019

Re: [Pharo-dev] Class definition with slot template is broken

by Marcus Denker

> On 23 Aug 2019, at 12:43, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > > >> On 23 Aug 2019, at 12:13, Denis Kudriashov <dionisiydk(a)gmail.com <mailto:dionisiydk@gmail.com>> wrote: >> >> Hi >> >> Ð¿Ñ, 23 Ð°Ð²Ð³. 2019 Ð³., 11:06 Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>>: >> >> >> > On 23 Aug 2019, at 11:49, Cyril Ferlicot <cyril.ferlicot(a)gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote: >> > >> > Hi, >> > >> > Since yesterday I get a lot of bugs when I try to edit class >> > definitions while having the slot template in class definition >> > enabled. (See comment: >> > https://github.com/pharo-project/pharo/pull/4391 <https://github.com/pharo-project/pharo/pull/4391>) >> > This make it a little hard to develop :( >> > >> > Is there an easy fix? Else maybe we should revert the change until we >> > have the fix? >> > >> >> I have a fix, I will commit when the internet connection is good enough >> >> That's good. > > https://github.com/pharo-project/pharo/pull/4409 <https://github.com/pharo-project/pharo/pull/4409> > > >> >> I guess it was a class parser bug? I only tested browser with classic definition. > > yes, even with this fix I need to do some (larger) change to support Slots with parameters, e.g. > > {#lazy => LazySlot default: 5 . > #computed => ComputedSlot with: [:object | object calculateSomething] } > > I updated the fix: now it should work, there will be just no menu shown for these kinds of slots for now (to be fixed in a second step, we should add tests, too) Marcus

Aug. 23, 2019

Re: [Pharo-dev] Class definition with slot template is broken

by Marcus Denker

> On 23 Aug 2019, at 12:13, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > Hi > > Ð¿Ñ, 23 Ð°Ð²Ð³. 2019 Ð³., 11:06 Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>>: > > > > On 23 Aug 2019, at 11:49, Cyril Ferlicot <cyril.ferlicot(a)gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote: > > > > Hi, > > > > Since yesterday I get a lot of bugs when I try to edit class > > definitions while having the slot template in class definition > > enabled. (See comment: > > https://github.com/pharo-project/pharo/pull/4391 <https://github.com/pharo-project/pharo/pull/4391>) > > This make it a little hard to develop :( > > > > Is there an easy fix? Else maybe we should revert the change until we > > have the fix? > > > > I have a fix, I will commit when the internet connection is good enough > > That's good. https://github.com/pharo-project/pharo/pull/4409 <https://github.com/pharo-project/pharo/pull/4409> > > I guess it was a class parser bug? I only tested browser with classic definition. yes, even with this fix I need to do some (larger) change to support Slots with parameters, e.g. {#lazy => LazySlot default: 5 . #computed => ComputedSlot with: [:object | object calculateSomething] } This need some change in how the class parser models slots, thoughâ¦ CDSlotNode is just modelling a name and the class of the slot, but not the fact that slot definitions can contain parameters which can contain even blocksâ¦ and with composition (not yet in Pharo8), we need to support things like #lazyAndObservable => SpObservableSlot + LazySlot default: 5 . but I think it is not hard to do. Marcus

Aug. 23, 2019

Re: [Pharo-dev] Class definition with slot template is broken

by Denis Kudriashov

Hi Ð¿Ñ, 23 Ð°Ð²Ð³. 2019 Ð³., 11:06 Marcus Denker <marcus.denker(a)inria.fr>: > > > > On 23 Aug 2019, at 11:49, Cyril Ferlicot <cyril.ferlicot(a)gmail.com> > wrote: > > > > Hi, > > > > Since yesterday I get a lot of bugs when I try to edit class > > definitions while having the slot template in class definition > > enabled. (See comment: > > https://github.com/pharo-project/pharo/pull/4391) > > This make it a little hard to develop :( > > > > Is there an easy fix? Else maybe we should revert the change until we > > have the fix? > > > > I have a fix, I will commit when the internet connection is good enough > That's good. I guess it was a class parser bug? I only tested browser with classic definition. > Marcus > > >

Aug. 23, 2019

Re: [Pharo-dev] Class definition with slot template is broken

by Marcus Denker

> On 23 Aug 2019, at 11:49, Cyril Ferlicot <cyril.ferlicot(a)gmail.com> wrote: > > Hi, > > Since yesterday I get a lot of bugs when I try to edit class > definitions while having the slot template in class definition > enabled. (See comment: > https://github.com/pharo-project/pharo/pull/4391) > This make it a little hard to develop :( > > Is there an easy fix? Else maybe we should revert the change until we > have the fix? > I have a fix, I will commit when the internet connection is good enough Marcus

Aug. 23, 2019

Re: [Pharo-dev] Class definition with slot template is broken

by ducasse

Argh this is probably the changes using the class definition. Denis can you check? Else I will check how to revert it and wait that it becoming more ready. Stef > On 23 Aug 2019, at 11:49, Cyril Ferlicot <cyril.ferlicot(a)gmail.com> wrote: > > Hi, > > Since yesterday I get a lot of bugs when I try to edit class > definitions while having the slot template in class definition > enabled. (See comment: > https://github.com/pharo-project/pharo/pull/4391) > This make it a little hard to develop :( > > Is there an easy fix? Else maybe we should revert the change until we > have the fix? > > Have a nice day! > > -- > Cyril Ferlicot > https://ferlicot.fr >

Aug. 23, 2019

Class definition with slot template is broken

by Cyril Ferlicot

Hi, Since yesterday I get a lot of bugs when I try to edit class definitions while having the slot template in class definition enabled. (See comment: https://github.com/pharo-project/pharo/pull/4391) This make it a little hard to develop :( Is there an easy fix? Else maybe we should revert the change until we have the fix? Have a nice day! -- Cyril Ferlicot https://ferlicot.fr

Aug. 23, 2019

[Pharo 8.0] Build #666: LazySlotPrinting

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #666 was: SUCCESS. The Pull Request #4399 was integrated: "LazySlotPrinting" Pull request url: https://github.com/pharo-project/pharo/pull/4399 Issue Url: https://github.com/pharo-project/pharo/issues/LazySlotPrinting Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #665: Improve-WeakValueDictionary

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #665 was: SUCCESS. The Pull Request #4396 was integrated: "Improve-WeakValueDictionary" Pull request url: https://github.com/pharo-project/pharo/pull/4396 Issue Url: https://github.com/pharo-project/pharo/issues/Improve Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #664: Monticello-tests-should-not-depend-on-deprecated-streams

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #664 was: FAILURE. The Pull Request #4347 was integrated: "Monticello-tests-should-not-depend-on-deprecated-streams" Pull request url: https://github.com/pharo-project/pharo/pull/4347 Issue Url: https://github.com/pharo-project/pharo/issues/Monticello Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019