August 2019 - Pharo-dev - lists.pharo.org

[Pharo 8.0] Build #663: Add-deny-equivalent-of-assertCollection-hasSameElements

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #663 was: FAILURE. The Pull Request #4381 was integrated: "Add-deny-equivalent-of-assertCollection-hasSameElements" Pull request url: https://github.com/pharo-project/pharo/pull/4381 Issue Url: https://github.com/pharo-project/pharo/issues/Add Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #662: Enable CDClassParser in class definition in Calypso

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #662 was: FAILURE. The Pull Request #4391 was integrated: "Enable CDClassParser in class definition in Calypso" Pull request url: https://github.com/pharo-project/pharo/pull/4391 Issue Url: https://github.com/pharo-project/pharo/issues/classParserInCalypso Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #661: psKeysSemaSimplify

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #661 was: FAILURE. The Pull Request #4392 was integrated: "psKeysSemaSimplify" Pull request url: https://github.com/pharo-project/pharo/pull/4392 Issue Url: https://github.com/pharo-project/pharo/issues/psKeysSemaSimplify Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #660: Push-down-method-on-right-owner

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #660 was: FAILURE. The Pull Request #4379 was integrated: "Push-down-method-on-right-owner" Pull request url: https://github.com/pharo-project/pharo/pull/4379 Issue Url: https://github.com/pharo-project/pharo/issues/Push Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #659: Use stack instead of recursion in MCScanner>>next

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #659 was: SUCCESS. The Pull Request #4310 was integrated: "Use stack instead of recursion in MCScanner>>next" Pull request url: https://github.com/pharo-project/pharo/pull/4310 Issue Url: https://github.com/pharo-project/pharo/issues/MCScanner_next Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[ANN] Pharo Consortium New Bronze Member: Object Guild

by Marcus Denker

The Pharo Consortium is very happy to announce that the Object Guild has joined the Consortium as a Bronze Member. Object Guild Simply Revolutionary High fidelity software solutions for values-driven organisations. We help you to help the world become a better place. Object Guild differentiates itself as a custom software design and development shop in the following ways: - by a commitment to use technology and software to make the world a better place; - by seeking and serving clients who are equally committed to social and environmental enhancement; - by focusing on "Software that Fits," that seamlessly integrates with and enhances the complex system where it is deployed; - by our commitment to Pharo and Smalltalk development, including expanding and enhancing Pharo; - by a focus on education and training, internal and for clients, that advances the "state-of-the-practice" of software development. https://objectguild.com The goal of the Pharo Consortium is to allow companies and institutions to support the ongoing development and future of Pharo. http://consortium.pharo.org Individuals can support Pharo via the Pharo Association. http://association.pharo.org

Aug. 22, 2019

[Pharo 7.0] Build #169: 4282-Backport-Pharo7-trying-to-add-an-ivar-to-UndefinedObject-crashes-the-VM-4017

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #169 was: FAILURE. The Pull Request #4378 was integrated: "4282-Backport-Pharo7-trying-to-add-an-ivar-to-UndefinedObject-crashes-the-VM-4017" Pull request url: https://github.com/pharo-project/pharo/pull/4378 Issue Url: https://pharo.fogbugz.com/f/cases/4282 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #658: 4365-Reintroduce-separator

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #658 was: FAILURE. The Pull Request #4366 was integrated: "4365-Reintroduce-separator" Pull request url: https://github.com/pharo-project/pharo/pull/4366 Issue Url: https://github.com/pharo-project/pharo/issues/4365 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 22, 2019

[Pharo 8.0] Build #657: CodeGenWeakClassVar

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #657 was: FAILURE. The Pull Request #4382 was integrated: "CodeGenWeakClassVar" Pull request url: https://github.com/pharo-project/pharo/pull/4382 Issue Url: https://github.com/pharo-project/pharo/issues/CodeGenWeakClassVar Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 21, 2019

[Pharo 8.0] Build #656: FormCanvas-has-wrong-lazy-initialization

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #656 was: FAILURE. The Pull Request #4390 was integrated: "FormCanvas-has-wrong-lazy-initialization" Pull request url: https://github.com/pharo-project/pharo/pull/4390 Issue Url: https://github.com/pharo-project/pharo/issues/FormCanvas Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 21, 2019

Question on Behavior>>superclass:

by Jordi Delgado

Hi, This example in the slides of Pharo MOOC, week 7, is broken in Pharo 7.0 (the variable newClass is not used, thus it has been removed): | behavior model | behavior := Behavior new. behavior superclass: Model. behavior setFormat: Model format. model := Model new. model primitiveChangeClassTo: behavior new. self assert: model class = behavior. self assert: model class superclass = Model. behavior compile: 'foo ^ 2'. self assert: model foo = 2. self should: [Model new foo] raise: MessageNotUnderstood (slide 14 in http://rmod-pharo-mooc.lille.inria.fr/MOOC/Slides/Week7/C019-W7S04-OtherRef…) The code is broken because there is no method Behavior>>classInstaller, and the message classInstaller is sent to self in Behavior>>superclass:. Adding a Behavior>>superclass2: to Pharo 7.0, copied from Pharo 6.1 Behavior>>superclass:, and using Behavior>>superclass2: in the example: | behavior model | behavior := Behavior new. behavior superclass2: Model. "<-------" behavior setFormat: Model format. model := Model new. model primitiveChangeClassTo: behavior new. self assert: model class = behavior. self assert: model class superclass = Model. behavior compile: 'foo ^ 2'. self assert: model foo = 2. self should: [Model new foo] raise: MessageNotUnderstood the code works again and the example is good. However, this is only an ugly workaround. Thus: I do not know why Behavior>>superclass: was changed in Pharo 7.0 but I guess it was not an accident. I assume it has to do with deep changes in the low level structure of the implementation of the language, having to do with slots, etc. I have browsed Pharo issues in github but I did not find anything related. Also, I'm not sure this problem qualifies as an "issue". So, my question is. Is it possible to easily adapt the example to the new Pharo 7.0? (with no silly workarounds, I mean). Thanks in advance and, as usual, apologies if the question is trivial and/or stupid. Bests, Jordi PS: Any Pharoer in CCCamp? -- Jordi Delgado Computer Science Department - Universitat PolitÃ¨cnica de Catalunya Campus Nord, Omega building, Office S115 c/Jordi Girona Salgado, 1-3 08034 Barcelona, Spain. Phone: +34.93.413.40.18 Public Key: https://pgp.mit.edu/pks/lookup?op=get&search=0xB7911543AD9E79A8

Aug. 21, 2019

[Pharo 8.0] Build #655: 4272 Fix Spelling of Responsability

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #655 was: FAILURE. The Pull Request #4376 was integrated: "4272 Fix Spelling of Responsability" Pull request url: https://github.com/pharo-project/pharo/pull/4376 Issue Url: https://github.com/pharo-project/pharo/issues/4272 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 21, 2019

[ExternalBrowser][Ring] I'm looking for a replacement of RingChunkImporter

by ClÃ©ment Dutriez

I'm working on the migration of the ExternalBrowser that using RingChunkImporter and it's deprecated in Pharo. What I can use to replace it? -- Dutriez ClÃ©ment dutriezcle(a)gmail.com 0605199489 [image: www.linkedin.com/in/clÃ©ment-dutriez-407275173] <http://www.linkedin.com/in/clÃ©ment-dutriez-407275173>

Aug. 21, 2019

[Pharo 8.0] Build #654: SUCCESS

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #654 was: SUCCESS. Could not extract further issue information from commit message: Point to pharo-project Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 21, 2019

[ANN] Pharo Newsletter August 2019

by Marcus Denker

The Pharo Newsletter August 2019 has been sent to subscribers one week ago. https://mailchi.mp/pharo/pharo-newsletter-august-2019 To get it as soon as it is released, please subscribe!

Aug. 21, 2019

Re: [Pharo-dev] Epicea Feedback

by ducasse

Are you in P8? Stef > On 18 Aug 2019, at 21:21, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > Not complaining at all and appreciate everyone's hard (mostly-unpaid) work, > but providing raw feedback in case it's helpful... > > - Browser awkward: filters disappear whenever left selection changed; no > multi-select of sessions, which led to a host of difficulties described > below. > - What is the heuristic to find API access points? Epicea package has no > comment, 'Browser' tag doesn't seem to have an XyzBrowser class, no > particular class in the 'Model' tag jumps out at me as an access point; as > above Browser about text not set. I finally bring up Morphic halos on the > browser and after flopping around, find subclasses of EpLogNode; I browse it > and find EpLogNodeGraphModel, which sounds interesting and turns out to be a > spec. I figure out how to list the log files, but not how to get the entries > - I was expecting a term like that and the relevant method (#log it turns > out) has no comment to indicate it's what I'm looking for. Now that I'm > starting to understand the project organization, back to the browser to > explore EpUnifiedBrowserModel. After a bit of poking around, I suspect > (correctly) that #log is what I'm after. > > Based on code I extract from the browsers and a bit of experimenting in GT, > I come up with the following seemingly very complex script: > > nodes := EpFileLogNode fromAllLogsIn: EpMonitor current sessionStore > baseLocator. > nodes do: [ :node | node populateReferencedNodesWith: nodes ]. > nodes flatCollect: [ :n | n log events select: [ :e | e affectedPackageName > beginsWith: 'Magritte' ] ] > > I now run into a series of problems because, although EpCodeChange declares > #affectedPackageName as an abstract method, not all events are > EpCodeChanges. I exclude EpUndos. Easy enough. Now I come to an > EpGenericRefactoring. This one is harder because > > p.s. <rant>Code names for internal projects seem extremely > counterproductive. Hiedra tells me absolutely nothing about functionality. > It might as well be called XyzWidgetThing</rant> > > > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >

Aug. 21, 2019

Re: [Pharo-dev] Epicea Feedback

by ducasse

Thanks sean for the feedback Now pay attention that we cannot digest fast non PRs because we are super busy with P8 alpha. Can you open an issue so that martin can get an idea of what should be improved? Stef > On 18 Aug 2019, at 21:41, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > In case it helps anyone in the future, here is the "poor man's" browser I > hacked together to find all Magritte changes that needed to be rescued from > an image where those changes got out-of-sync so I couldn't use Iceberg: > > nodes := EpFileLogNode fromAllLogsIn: EpMonitor current sessionStore > baseLocator. > relevantNodes := nodes reject: [ :n | (n globalName endsWith: 'g3') or: [ n > globalName endsWith: 'ng' ] ]. > relevantNodes do: [ :node | node populateReferencedNodesWith: relevantNodes > ]. > entries := relevantNodes flatCollect: [ :n | n log entries ]. > filter := EpAndFilter withAll: { > EpImpactCodeChangeFilter new environment: self class environment; yourself. > EpPluggableFilter new condition: [ :e | > e content isCodeChange and: [ > e content affectedPackageName beginsWith: 'Magritte' ] ]. > EpPluggableFilter noTriggerFilter }. > filteredEntries := entries select: [ :e | filter accepts: e ]. > filteredEntries sort: [ :a :b | (a tagAt: #time) > (b tagAt: #time) ]. > groups := filteredEntries groupedBy: [ :e | (e content respondsTo: > #methodAffected) ifFalse: [ '?' ] ifTrue: [ e content methodAffected ] ]. > events := groups collect: [ :col | col first content ] as: > OrderedCollection. > events collect: [ :e | "{ e." DiffModel new > showOptions: true; > leftText: (e accept: EpOldStateVisitor new); > rightText: (e accept: EpNewStateVisitor new); > contextClass: e class; > buildWithSpec "}" ]. > > > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >

Aug. 21, 2019

[Pharo 8.0] Build #653: 4080-remove-the-class-instance-var-in-NECController

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #653 was: FAILURE. The Pull Request #4368 was integrated: "4080-remove-the-class-instance-var-in-NECController" Pull request url: https://github.com/pharo-project/pharo/pull/4368 Issue Url: https://github.com/pharo-project/pharo/issues/4080 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 21, 2019

[Pharo 8.0] Build #652: Traits-tests-should-work-with-slots-definitions

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #652 was: FAILURE. The Pull Request #4375 was integrated: "Traits-tests-should-work-with-slots-definitions" Pull request url: https://github.com/pharo-project/pharo/pull/4375 Issue Url: https://github.com/pharo-project/pharo/issues/Traits Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 21, 2019

Code Completion: GSoC project summary

by Myroslava Romaniuk

Hi i just published a summary of my work on code completion during Google Summer of Code, for those who are interested. It's a 5 min overview of the progress that was made and some further plans (i do intend to continue working on it, as there's still cool things to be done). Here's a link to the blog post: https://medium.com/@myroslavarm/code-completion-in-pharo-gsoc-project-summa…, and the tweet: https://twitter.com/myroslavarm/status/1164059233073147905, if anyone feels like spreading the word. Thanks so much, Myroslava PS there's going to be a talk at ESUG Marcus and I are doing, please come!

Aug. 21, 2019

[Pharo 8.0] Build #651: Smaller Initial World Extent for osWindow World

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #651 was: FAILURE. The Pull Request #4369 was integrated: "Smaller Initial World Extent for osWindow World" Pull request url: https://github.com/pharo-project/pharo/pull/4369 Issue Url: https://github.com/pharo-project/pharo/issues/smaller Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 20, 2019

[Pharo 8.0] Build #650: Add command for inline all senders of a method

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #650 was: FAILURE. The Pull Request #4362 was integrated: "Add command for inline all senders of a method" Pull request url: https://github.com/pharo-project/pharo/pull/4362 Issue Url: https://github.com/pharo-project/pharo/issues/AddCommandInlineSenders Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 19, 2019

[Pharo 8.0] Build #649: 4335-DateAndTime-comments-could-take-advantage-of-executable-comments

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #649 was: FAILURE. The Pull Request #4336 was integrated: "4335-DateAndTime-comments-could-take-advantage-of-executable-comments" Pull request url: https://github.com/pharo-project/pharo/pull/4336 Issue Url: https://github.com/pharo-project/pharo/issues/4335 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 19, 2019

[Pharo 8.0] Build #648: 4306-Add-comment-why-name-cache-in-SystemDictionary-is-sorted

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #648 was: SUCCESS. The Pull Request #4359 was integrated: "4306-Add-comment-why-name-cache-in-SystemDictionary-is-sorted" Pull request url: https://github.com/pharo-project/pharo/pull/4359 Issue Url: https://github.com/pharo-project/pharo/issues/4306 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 19, 2019

[Pharo 8.0] Build #647: Fixing change detection of traits

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #647 was: SUCCESS. The Pull Request #4360 was integrated: "Fixing change detection of traits" Pull request url: https://github.com/pharo-project/pharo/pull/4360 Issue Url: https://github.com/pharo-project/pharo/issues/fixing Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 19, 2019

[Pharo 8.0] Build #646: code-completion-context-tests

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #646 was: FAILURE. The Pull Request #4332 was integrated: "code-completion-context-tests" Pull request url: https://github.com/pharo-project/pharo/pull/4332 Issue Url: https://github.com/pharo-project/pharo/issues/code Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 19, 2019

[Pharo 8.0] Build #645: 4355-ProfStef-has-some-dead-class-comments-and-needs-more-love-

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #645 was: FAILURE. The Pull Request #4356 was integrated: "4355-ProfStef-has-some-dead-class-comments-and-needs-more-love-" Pull request url: https://github.com/pharo-project/pharo/pull/4356 Issue Url: https://github.com/pharo-project/pharo/issues/4355 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 19, 2019

[Pharo 8.0] Build #644: Fix asDate executable comments

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #644 was: FAILURE. The Pull Request #4358 was integrated: "Fix asDate executable comments" Pull request url: https://github.com/pharo-project/pharo/pull/4358 Issue Url: https://github.com/pharo-project/pharo/issues/bottomWithSeb Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 19, 2019

Re: [Pharo-dev] Epicea Feedback

by Sean P. DeNigris

In case it helps anyone in the future, here is the "poor man's" browser I hacked together to find all Magritte changes that needed to be rescued from an image where those changes got out-of-sync so I couldn't use Iceberg: nodes := EpFileLogNode fromAllLogsIn: EpMonitor current sessionStore baseLocator. relevantNodes := nodes reject: [ :n | (n globalName endsWith: 'g3') or: [ n globalName endsWith: 'ng' ] ]. relevantNodes do: [ :node | node populateReferencedNodesWith: relevantNodes ]. entries := relevantNodes flatCollect: [ :n | n log entries ]. filter := EpAndFilter withAll: { EpImpactCodeChangeFilter new environment: self class environment; yourself. EpPluggableFilter new condition: [ :e | e content isCodeChange and: [ e content affectedPackageName beginsWith: 'Magritte' ] ]. EpPluggableFilter noTriggerFilter }. filteredEntries := entries select: [ :e | filter accepts: e ]. filteredEntries sort: [ :a :b | (a tagAt: #time) > (b tagAt: #time) ]. groups := filteredEntries groupedBy: [ :e | (e content respondsTo: #methodAffected) ifFalse: [ '?' ] ifTrue: [ e content methodAffected ] ]. events := groups collect: [ :col | col first content ] as: OrderedCollection. events collect: [ :e | "{ e." DiffModel new showOptions: true; leftText: (e accept: EpOldStateVisitor new); rightText: (e accept: EpNewStateVisitor new); contextClass: e class; buildWithSpec "}" ]. ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 18, 2019

Epicea Feedback

by Sean P. DeNigris

Not complaining at all and appreciate everyone's hard (mostly-unpaid) work, but providing raw feedback in case it's helpful... - Browser awkward: filters disappear whenever left selection changed; no multi-select of sessions, which led to a host of difficulties described below. - What is the heuristic to find API access points? Epicea package has no comment, 'Browser' tag doesn't seem to have an XyzBrowser class, no particular class in the 'Model' tag jumps out at me as an access point; as above Browser about text not set. I finally bring up Morphic halos on the browser and after flopping around, find subclasses of EpLogNode; I browse it and find EpLogNodeGraphModel, which sounds interesting and turns out to be a spec. I figure out how to list the log files, but not how to get the entries - I was expecting a term like that and the relevant method (#log it turns out) has no comment to indicate it's what I'm looking for. Now that I'm starting to understand the project organization, back to the browser to explore EpUnifiedBrowserModel. After a bit of poking around, I suspect (correctly) that #log is what I'm after. Based on code I extract from the browsers and a bit of experimenting in GT, I come up with the following seemingly very complex script: nodes := EpFileLogNode fromAllLogsIn: EpMonitor current sessionStore baseLocator. nodes do: [ :node | node populateReferencedNodesWith: nodes ]. nodes flatCollect: [ :n | n log events select: [ :e | e affectedPackageName beginsWith: 'Magritte' ] ] I now run into a series of problems because, although EpCodeChange declares #affectedPackageName as an abstract method, not all events are EpCodeChanges. I exclude EpUndos. Easy enough. Now I come to an EpGenericRefactoring. This one is harder because p.s. <rant>Code names for internal projects seem extremely counterproductive. Hiedra tells me absolutely nothing about functionality. It might as well be called XyzWidgetThing</rant> ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 18, 2019

[Pharo 8.0] Build #643: Remove-dependency-between-FileSystem-Core-and-Deprecated-file-package

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #643 was: SUCCESS. The Pull Request #4340 was integrated: "Remove-dependency-between-FileSystem-Core-and-Deprecated-file-package" Pull request url: https://github.com/pharo-project/pharo/pull/4340 Issue Url: https://github.com/pharo-project/pharo/issues/Remove Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 18, 2019

[Pharo 8.0] Build #642: Remove-PNGReader-test-missing-resources

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #642 was: FAILURE. The Pull Request #4345 was integrated: "Remove-PNGReader-test-missing-resources" Pull request url: https://github.com/pharo-project/pharo/pull/4345 Issue Url: https://github.com/pharo-project/pharo/issues/Remove Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 18, 2019

[Pharo 8.0] Build #641: Calypso-should-not-depend-on-deprecated-streams

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #641 was: FAILURE. The Pull Request #4342 was integrated: "Calypso-should-not-depend-on-deprecated-streams" Pull request url: https://github.com/pharo-project/pharo/pull/4342 Issue Url: https://github.com/pharo-project/pharo/issues/Calypso Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 18, 2019

[Pharo 8.0] Build #640: StartupPreferences-should-not-depend-on-deprecated-streams

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #640 was: FAILURE. The Pull Request #4348 was integrated: "StartupPreferences-should-not-depend-on-deprecated-streams" Pull request url: https://github.com/pharo-project/pharo/pull/4348 Issue Url: https://github.com/pharo-project/pharo/issues/StartupPreferences Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 18, 2019

fosdem

by ducasse

FOSDEM We now invite proposals for main track presentations, developer rooms, stands and lightning talks. FOSDEM offers open source and free software developers a place to meet, share ideas and collaborate. Renowned for being highly developer- oriented, the event brings together some 8000+ geeks from all over the world. The twentieth edition will take place on Saturday 1st and Sunday 2nd February 2020 at the usual location: ULB Campus Solbosch in Brussels. So any ideas how to coordinate efforts? Stef

Aug. 17, 2019

[Pharo 8.0] Build #639: Ensure-all-class-creation-methods-have-package-equivalent-instead-of-category

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #639 was: FAILURE. The Pull Request #4338 was integrated: "Ensure-all-class-creation-methods-have-package-equivalent-instead-of-category" Pull request url: https://github.com/pharo-project/pharo/pull/4338 Issue Url: https://github.com/pharo-project/pharo/issues/Ensure Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 17, 2019

Re: [Pharo-dev] possible Windows Update "1903" Iceberg problem

by ducasse

> On 17 Aug 2019, at 12:50, Ben Coman <btc(a)openinworld.com> wrote: > > hi Stef, > I feel you missed my point. Probably I wasn't clear this has already been tested with latest Pharo 8 launched by PharoLauncher. > The problem occurs with Pharo 7.0.3(64 bit) and with Pharo8.0-SNAPSHOT-build.635(64 bit) > after Microsoft Windows Update 1903... > https://www.computerworld.com/article/3409621/microsoft-starts-windows-10s-… <https://www.computerworld.com/article/3409621/microsoft-starts-windows-10s-…> > > If indeed 1903 is the cause, with this update now being *forced* down on people, this will potentially soon impact more and more Windows users. > But my guess that 1903 is the culprit needs to be confirmed. > So I am requesting someone with access to multiple Windows machines directly compare a 1903 machine with a pre-1903 machine. indeed I misunderstood you :) > > cheers -ben > > On Sat, 17 Aug 2019 at 12:58, ducasse <stepharo(a)netcourrier.com <mailto:stepharo@netcourrier.com>> wrote: > Hi ben > > in the pharo launcher if you click on P8.0 (development version) you get access to all the builds. > > Stef > >> On 16 Aug 2019, at 16:02, Ben Coman <btc(a)openinworld.com <mailto:btc@openinworld.com>> wrote: >> >> IThis morning the May 2019 Windows Update "1903" forced itself onto my computer and now 64-bits Pharo seems to have a problem with git_remote_fetch() FFI callout. I no longer have a non-1903 machine to directly compare behaviour before "1903". Can someone familiar with this area with both "pre-1903" and "1903" machines triage whether "1903" is indeed the cause? >> >> A few other recent reports are noted here... >> https://github.com/pharo-project/pharo/issues/3418 <https://github.com/pharo-project/pharo/issues/3418> >> >> cheers -ben >

Aug. 17, 2019

Re: [Pharo-dev] possible Windows Update "1903" Iceberg problem

by Ben Coman

hi Stef, I feel you missed my point. Probably I wasn't clear this has already been tested with latest Pharo 8 launched by PharoLauncher. The problem occurs with Pharo 7.0.3(64 bit) and with Pharo8.0-SNAPSHOT-build.635(64 bit) after Microsoft Windows Update 1903... https://www.computerworld.com/article/3409621/microsoft-starts-windows-10s-… If indeed 1903 is the cause, with this update now being *forced* down on people, this will potentially soon impact more and more Windows users. But my guess that 1903 is the culprit needs to be confirmed. So I am requesting someone with access to multiple Windows machines directly compare a 1903 machine with a pre-1903 machine. cheers -ben On Sat, 17 Aug 2019 at 12:58, ducasse <stepharo(a)netcourrier.com> wrote: > Hi ben > > in the pharo launcher if you click on P8.0 (development version) you get > access to all the builds. > > Stef > > On 16 Aug 2019, at 16:02, Ben Coman <btc(a)openinworld.com> wrote: > > IThis morning the May 2019 Windows Update "1903" forced itself onto my > computer and now 64-bits Pharo seems to have a problem with > git_remote_fetch() FFI callout. I no longer have a non-1903 machine to > directly compare behaviour before "1903". Can someone familiar with this > area with both "pre-1903" and "1903" machines triage whether "1903" is > indeed the cause? > > A few other recent reports are noted here... > https://github.com/pharo-project/pharo/issues/3418 > > cheers -ben > > >

Aug. 17, 2019

[Pharo 8.0] Build #638: 4314-Cannot-use-slot-as-class-variable-Raise-explicit-error

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #638 was: FAILURE. The Pull Request #4331 was integrated: "4314-Cannot-use-slot-as-class-variable-Raise-explicit-error" Pull request url: https://github.com/pharo-project/pharo/pull/4331 Issue Url: https://github.com/pharo-project/pharo/issues/4314 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 17, 2019

[Pharo 8.0] Build #637: Revert "4204-Should-SystemDictionary-sort-classes-by-name"

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #637 was: FAILURE. The Pull Request #4333 was integrated: "Revert "4204-Should-SystemDictionary-sort-classes-by-name"" Pull request url: https://github.com/pharo-project/pharo/pull/4333 Issue Url: https://github.com/pharo-project/pharo/issues/revert Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 17, 2019

Re: [Pharo-dev] possible Windows Update "1903" Iceberg problem

by ducasse

Hi ben in the pharo launcher if you click on P8.0 (development version) you get access to all the builds. Stef > On 16 Aug 2019, at 16:02, Ben Coman <btc(a)openinworld.com> wrote: > > IThis morning the May 2019 Windows Update "1903" forced itself onto my computer and now 64-bits Pharo seems to have a problem with git_remote_fetch() FFI callout. I no longer have a non-1903 machine to directly compare behaviour before "1903". Can someone familiar with this area with both "pre-1903" and "1903" machines triage whether "1903" is indeed the cause? > > A few other recent reports are noted here... > https://github.com/pharo-project/pharo/issues/3418 <https://github.com/pharo-project/pharo/issues/3418> > > cheers -ben

Aug. 17, 2019

possible Windows Update "1903" Iceberg problem

by Ben Coman

IThis morning the May 2019 Windows Update "1903" forced itself onto my computer and now 64-bits Pharo seems to have a problem with git_remote_fetch() FFI callout. I no longer have a non-1903 machine to directly compare behaviour before "1903". Can someone familiar with this area with both "pre-1903" and "1903" machines triage whether "1903" is indeed the cause? A few other recent reports are noted here... https://github.com/pharo-project/pharo/issues/3418 cheers -ben

Aug. 16, 2019

[Pharo 8.0] Build #636: code-completion-refactoring-changes

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #636 was: FAILURE. The Pull Request #4330 was integrated: "code-completion-refactoring-changes" Pull request url: https://github.com/pharo-project/pharo/pull/4330 Issue Url: https://github.com/pharo-project/pharo/issues/code Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 16, 2019

[Pharo 8.0] Build #635: Adding a variation of trait sequence composition that has preference for one of the members.

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #635 was: FAILURE. The Pull Request #4163 was integrated: "Adding a variation of trait sequence composition that has preference for one of the members." Pull request url: https://github.com/pharo-project/pharo/pull/4163 Issue Url: https://github.com/pharo-project/pharo/issues/extending Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 15, 2019

[Pharo 8.0] Build #634: Move Abstract refactoring command to SystemCommands-VariableCommands package

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #634 was: FAILURE. The Pull Request #4328 was integrated: "Move Abstract refactoring command to SystemCommands-VariableCommands package" Pull request url: https://github.com/pharo-project/pharo/pull/4328 Issue Url: https://github.com/pharo-project/pharo/issues/FixAbstractRefactoringCommand Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Aug. 15, 2019

Re: [Pharo-dev] machine learning for code completion

by Myroslava Romaniuk

Hi Mariano Yeah, that was probably the first thing i have ever looked at in regards to code completion because the beginning of this journey for me was figuring out the difference between regular and OCompletion (NEC, that used to be the default until a month and a half ago, & NOC, as they are called). The funny thing is, the code for OCompletion was actually still in Pharo until we removed it like a month ago, but using it was disabled by default. I don't think i've ever really used it myself but i understand the concerns :) There was some brainstorming for it, but mostly last summer. This summer we focused on making the replacement for NEC work well, and so working on OCompletion got pushed back super far because we haven't thought there'd be so many things to fix. So i don't really have a good answer for you at the moment but hopefully will have something more to say sometime not too far in the future. We still want to work on it :) The thing to remember is that both NEC and NOC implementations were complex to the point of being horrible, so there's a chance if we just simplify NOC too and impose some limits for storing the results, as well as do proper caching, it might not be horrible after all. But it needs work. On Thu, 15 Aug 2019 at 19:53, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > Hi Myroslava, > > That sounds very interesting. I guess you did take a look to Romain Robbes > work on OCompletion, right? > I have used it for a long time, many years ago, and AFAIR we had to remove > it from Pharo. It had lots of issues with the memory used to keep track of > your "history" in order to be "smart". There were memory leaks and some > other stuff. And at the end of the day, from what I remember, it was never > really "smart"... > Have you thought how to address that correctly? > > > On Thu, Aug 15, 2019 at 12:52 PM Christopher Fuhrman < > christopher.fuhrman(a)gmail.com> wrote: > >> +1 for the completion of framework (spec) constructs. >> >> https://tabnine.com/blog/deep >> >> On Thu, Aug 15, 2019, 12:33 Tudor Girba <tudor(a)tudorgirba.com> wrote: >> >>> Hi, >>> >>> It certainly would be interesting! >>> >>> The other thing to look for are completion of larger constructs. For >>> example, in the context of Spec, I am sure you can complete larger >>> templates for various methods. >>> >>> Cheers, >>> Doru >>> >>> >>> >>> > On Aug 15, 2019, at 8:48 AM, ducasse <stepharo(a)netcourrier.com> wrote: >>> > >>> > hello miroslava >>> > >>> > you take a NLP approach and I do not know if it will be working >>> > Now people like proksch and mezini took a statiscal approach. >>> > I would really like to see if we can apply the same technics to Pharo >>> completion and >>> > measure the difference. It could be a really nice master (even from a >>> data scientist point of view) >>> > >>> > <Recommander-a3-proksch.pdf> >>> > >>> >> On 15 Aug 2019, at 00:01, Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> >>> wrote: >>> >> >>> >> >>> >> From: Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> >>> >> Subject: machine learning for code completion >>> >> Date: 15 August 2019 at 00:01:23 CEST >>> >> To: Pharo Development List <pharo-dev(a)lists.pharo.org> >>> >> >>> >> >>> >> for anyone interested, made a blog post about researching some of the >>> existing approaches of combining ML to improve code completion. in pharo we >>> want to try training the n-gram model. have a slight idea of how it might >>> be implemented in practice but mostly still trying to figure it out, so if >>> anyone else has some suggestions/ideas/tips that would be great >>> >> >>> >> link for the blog post : >>> https://medium.com/@myroslavarm/machine-learning-for-code-completion-258379… >>> >> >>> >> cheers, >>> >> myroslava >>> >> >>> >> >>> > >>> >>> -- >>> feenk.com >>> >>> "Innovation comes in the least expected form. >>> That is, if it is expected, it already happened." >>> >>> >>> > > -- > Mariano Martinez Peck > Email: marianopeck(a)gmail.com > Twitter: @MartinezPeck > LinkedIn: www.linkedin.com/in/mariano-martinez-peck > <https://www.linkedin.com/in/mariano-mart%C3%ADnez-peck/> > Blog: https://marianopeck.wordpress.com/ > -- Ð Ð¿Ð¾Ð²Ð°Ð³Ð¾Ñ, ÐÐ¸ÑÐ¾ÑÐ»Ð°Ð²Ð° Ð Ð¾Ð¼Ð°Ð½ÑÐº.

Aug. 15, 2019

Re: [Pharo-dev] machine learning for code completion

by Mariano Martinez Peck

Hi Myroslava, That sounds very interesting. I guess you did take a look to Romain Robbes work on OCompletion, right? I have used it for a long time, many years ago, and AFAIR we had to remove it from Pharo. It had lots of issues with the memory used to keep track of your "history" in order to be "smart". There were memory leaks and some other stuff. And at the end of the day, from what I remember, it was never really "smart"... Have you thought how to address that correctly? On Thu, Aug 15, 2019 at 12:52 PM Christopher Fuhrman < christopher.fuhrman(a)gmail.com> wrote: > +1 for the completion of framework (spec) constructs. > > https://tabnine.com/blog/deep > > On Thu, Aug 15, 2019, 12:33 Tudor Girba <tudor(a)tudorgirba.com> wrote: > >> Hi, >> >> It certainly would be interesting! >> >> The other thing to look for are completion of larger constructs. For >> example, in the context of Spec, I am sure you can complete larger >> templates for various methods. >> >> Cheers, >> Doru >> >> >> >> > On Aug 15, 2019, at 8:48 AM, ducasse <stepharo(a)netcourrier.com> wrote: >> > >> > hello miroslava >> > >> > you take a NLP approach and I do not know if it will be working >> > Now people like proksch and mezini took a statiscal approach. >> > I would really like to see if we can apply the same technics to Pharo >> completion and >> > measure the difference. It could be a really nice master (even from a >> data scientist point of view) >> > >> > <Recommander-a3-proksch.pdf> >> > >> >> On 15 Aug 2019, at 00:01, Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> >> wrote: >> >> >> >> >> >> From: Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> >> >> Subject: machine learning for code completion >> >> Date: 15 August 2019 at 00:01:23 CEST >> >> To: Pharo Development List <pharo-dev(a)lists.pharo.org> >> >> >> >> >> >> for anyone interested, made a blog post about researching some of the >> existing approaches of combining ML to improve code completion. in pharo we >> want to try training the n-gram model. have a slight idea of how it might >> be implemented in practice but mostly still trying to figure it out, so if >> anyone else has some suggestions/ideas/tips that would be great >> >> >> >> link for the blog post : >> https://medium.com/@myroslavarm/machine-learning-for-code-completion-258379… >> >> >> >> cheers, >> >> myroslava >> >> >> >> >> > >> >> -- >> feenk.com >> >> "Innovation comes in the least expected form. >> That is, if it is expected, it already happened." >> >> >> -- Mariano Martinez Peck Email: marianopeck(a)gmail.com Twitter: @MartinezPeck LinkedIn: www.linkedin.com/in/mariano-martinez-peck <https://www.linkedin.com/in/mariano-mart%C3%ADnez-peck/> Blog: https://marianopeck.wordpress.com/

Aug. 15, 2019

Re: [Pharo-dev] machine learning for code completion

by Myroslava Romaniuk

Hi Stef, thanks for the paper, i'll check it out. I agree that there's many cool things that can be still done statistically, but the ML/NLP approach should be worth trying out, too. Maybe it will give good results, maybe it will turn out to be not applicable to Pharo for whatever reason... But the point is that now the code completion architecture is definitely simpler and more scalable, and especially because of the sorter plugin it will be easy to work on any sorting strategy and then make it one of the options. There's indeed a lot of work that can be done in measuring different strategies and seeing what works better as there's still not *that* much research on the topic. Tudor and Cris, yeah i haven't really worked with Spec in a while but i get what you mean. I agree it would be great to have that! There's still tons and tons of improvements that could be made, as you say, regarding completing larger templates, but also doing convenient tab usage for jumping between parts of larger templates or even for things like ifTrue:ifFalse:, possible snippet (method name shorthand) completion, etc etc. I'm always happy to extend the todo list haha. Oh and FYI, at ESUG on friday at noon Marcus and i will be doing a presentation about what's been done and also what we want to do in the nearest future so i hope some people stick around even though it's the last day :) Best, Myroslava On Thu, 15 Aug 2019 at 18:52, Christopher Fuhrman < christopher.fuhrman(a)gmail.com> wrote: > +1 for the completion of framework (spec) constructs. > > https://tabnine.com/blog/deep > > On Thu, Aug 15, 2019, 12:33 Tudor Girba <tudor(a)tudorgirba.com> wrote: > >> Hi, >> >> It certainly would be interesting! >> >> The other thing to look for are completion of larger constructs. For >> example, in the context of Spec, I am sure you can complete larger >> templates for various methods. >> >> Cheers, >> Doru >> >> >> >> > On Aug 15, 2019, at 8:48 AM, ducasse <stepharo(a)netcourrier.com> wrote: >> > >> > hello miroslava >> > >> > you take a NLP approach and I do not know if it will be working >> > Now people like proksch and mezini took a statiscal approach. >> > I would really like to see if we can apply the same technics to Pharo >> completion and >> > measure the difference. It could be a really nice master (even from a >> data scientist point of view) >> > >> > <Recommander-a3-proksch.pdf> >> > >> >> On 15 Aug 2019, at 00:01, Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> >> wrote: >> >> >> >> >> >> From: Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> >> >> Subject: machine learning for code completion >> >> Date: 15 August 2019 at 00:01:23 CEST >> >> To: Pharo Development List <pharo-dev(a)lists.pharo.org> >> >> >> >> >> >> for anyone interested, made a blog post about researching some of the >> existing approaches of combining ML to improve code completion. in pharo we >> want to try training the n-gram model. have a slight idea of how it might >> be implemented in practice but mostly still trying to figure it out, so if >> anyone else has some suggestions/ideas/tips that would be great >> >> >> >> link for the blog post : >> https://medium.com/@myroslavarm/machine-learning-for-code-completion-258379… >> >> >> >> cheers, >> >> myroslava >> >> >> >> >> > >> >> -- >> feenk.com >> >> "Innovation comes in the least expected form. >> That is, if it is expected, it already happened." >> >> >> -- Ð Ð¿Ð¾Ð²Ð°Ð³Ð¾Ñ, ÐÐ¸ÑÐ¾ÑÐ»Ð°Ð²Ð° Ð Ð¾Ð¼Ð°Ð½ÑÐº.

Aug. 15, 2019

Re: [Pharo-dev] machine learning for code completion

by Christopher Fuhrman

+1 for the completion of framework (spec) constructs. https://tabnine.com/blog/deep On Thu, Aug 15, 2019, 12:33 Tudor Girba <tudor(a)tudorgirba.com> wrote: > Hi, > > It certainly would be interesting! > > The other thing to look for are completion of larger constructs. For > example, in the context of Spec, I am sure you can complete larger > templates for various methods. > > Cheers, > Doru > > > > > On Aug 15, 2019, at 8:48 AM, ducasse <stepharo(a)netcourrier.com> wrote: > > > > hello miroslava > > > > you take a NLP approach and I do not know if it will be working > > Now people like proksch and mezini took a statiscal approach. > > I would really like to see if we can apply the same technics to Pharo > completion and > > measure the difference. It could be a really nice master (even from a > data scientist point of view) > > > > <Recommander-a3-proksch.pdf> > > > >> On 15 Aug 2019, at 00:01, Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> > wrote: > >> > >> > >> From: Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> > >> Subject: machine learning for code completion > >> Date: 15 August 2019 at 00:01:23 CEST > >> To: Pharo Development List <pharo-dev(a)lists.pharo.org> > >> > >> > >> for anyone interested, made a blog post about researching some of the > existing approaches of combining ML to improve code completion. in pharo we > want to try training the n-gram model. have a slight idea of how it might > be implemented in practice but mostly still trying to figure it out, so if > anyone else has some suggestions/ideas/tips that would be great > >> > >> link for the blog post : > https://medium.com/@myroslavarm/machine-learning-for-code-completion-258379… > >> > >> cheers, > >> myroslava > >> > >> > > > > -- > feenk.com > > "Innovation comes in the least expected form. > That is, if it is expected, it already happened." > > >

Aug. 15, 2019

Re: [Pharo-dev] machine learning for code completion

by Tudor Girba

Hi, It certainly would be interesting! The other thing to look for are completion of larger constructs. For example, in the context of Spec, I am sure you can complete larger templates for various methods. Cheers, Doru > On Aug 15, 2019, at 8:48 AM, ducasse <stepharo(a)netcourrier.com> wrote: > > hello miroslava > > you take a NLP approach and I do not know if it will be working > Now people like proksch and mezini took a statiscal approach. > I would really like to see if we can apply the same technics to Pharo completion and > measure the difference. It could be a really nice master (even from a data scientist point of view) > > <Recommander-a3-proksch.pdf> > >> On 15 Aug 2019, at 00:01, Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> wrote: >> >> >> From: Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> >> Subject: machine learning for code completion >> Date: 15 August 2019 at 00:01:23 CEST >> To: Pharo Development List <pharo-dev(a)lists.pharo.org> >> >> >> for anyone interested, made a blog post about researching some of the existing approaches of combining ML to improve code completion. in pharo we want to try training the n-gram model. have a slight idea of how it might be implemented in practice but mostly still trying to figure it out, so if anyone else has some suggestions/ideas/tips that would be great >> >> link for the blog post : https://medium.com/@myroslavarm/machine-learning-for-code-completion-258379… >> >> cheers, >> myroslava >> >> > -- feenk.com "Innovation comes in the least expected form. That is, if it is expected, it already happened."

Aug. 15, 2019