July 2019 - Pharo-dev - lists.pharo.org

[Pharo 8.0] Build #445: 2943-ToolRegistry-should-drop-support-for-completion

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #445 was: SUCCESS. The Pull Request #3804 was integrated: "2943-ToolRegistry-should-drop-support-for-completion" Pull request url: https://github.com/pharo-project/pharo/pull/3804 Issue Url: https://github.com/pharo-project/pharo/issues/2943 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 6, 2019

Re: [Pharo-dev] Pharo source code formatting guide

by Chris Muller

I think of Beck's Rectangular Block as like a textual representation of Scratch tiles. It's about presenting the code-structure, rather than aligning text on tabs. However, I do think his Indented Control Flow actually preserves _horizontal_ space at the expense of vertical space. I've found myself eschewing that particular pattern more and more in my last couple of years of coding. Spreading (1 to: 10) across two lines seems kinda crazy. But that book is a must-read for newcomers interested in writing quality Smalltalk, IMO. Not even for the formatting chapter, but the other ones which teach the "shoulds" and "should nots" that may not be obvious to a student, like avoiding different super send. - Chris > > On Thu, Jul 4, 2019 at 11:58 PM Norbert Hartl <norbert(a)hartl.name> wrote: > >> Sometimes I wonder when I change a piece of code in pharo if there is an >> official formatting guide line. Is the formatter in calypso the incarnation >> of it or how code is supposed to be formatted in the offical image? >> >> I just see tons of occurrences where caret immediately follows a token >> and such which I donât like at all. >> > > There are many styles, many opinions. Kent Beck presents a well argued > set of rules that work for visual thinkers like me; the main thing I like > is rectangular blocks. > > Kent Beck Best Practice Patters > <http://stephane.ducasse.free.fr/FreeBooks/BestSmalltalkPractices/Draft-Smal…> p > 126 onwards > > As Kent says > > "The priorities of these patterns are: > 1. To make the gross structure of the method apparent at a glance. Complex > messages and blocks, in particular, should jump out at the reader. > > 2. To preserve vertical space. There is a huge difference between reading > a method that fits into the text pane of a browser and reading one that > forces you to scroll. Keeping methods compact vertically lets you have > smaller browsers and still be able to read methods without scrolling. This > reduces window management overhead and leaves more screen space for other > programming tools." > > _,,,^..^,,,_ > best, Eliot >

July 6, 2019

Re: [Pharo-dev] Pharo source code formatting guide

by Eliot Miranda

On Thu, Jul 4, 2019 at 11:58 PM Norbert Hartl <norbert(a)hartl.name> wrote: > Sometimes I wonder when I change a piece of code in pharo if there is an > official formatting guide line. Is the formatter in calypso the incarnation > of it or how code is supposed to be formatted in the offical image? > > I just see tons of occurrences where caret immediately follows a token and > such which I donât like at all. > There are many styles, many opinions. Kent Beck presents a well argued set of rules that work for visual thinkers like me; the main thing I like is rectangular blocks. Kent Beck Best Practice Patters <http://stephane.ducasse.free.fr/FreeBooks/BestSmalltalkPractices/Draft-Smal…> p 126 onwards As Kent says "The priorities of these patterns are: 1. To make the gross structure of the method apparent at a glance. Complex messages and blocks, in particular, should jump out at the reader. 2. To preserve vertical space. There is a huge difference between reading a method that fits into the text pane of a browser and reading one that forces you to scroll. Keeping methods compact vertically lets you have smaller browsers and still be able to read methods without scrolling. This reduces window management overhead and leaves more screen space for other programming tools." _,,,^..^,,,_ best, Eliot

July 6, 2019

[Pharo 8.0] Build #444: 3775-checkForSlips-should-not-use-methodReference

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #444 was: FAILURE. The Pull Request #3776 was integrated: "3775-checkForSlips-should-not-use-methodReference" Pull request url: https://github.com/pharo-project/pharo/pull/3776 Issue Url: https://github.com/pharo-project/pharo/issues/3775 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 6, 2019

[Pharo 8.0] Build #443: Fix mistake from PR3768

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #443 was: FAILURE. The Pull Request #3800 was integrated: "Fix mistake from PR3768" Pull request url: https://github.com/pharo-project/pharo/pull/3800 Issue Url: https://github.com/pharo-project/pharo/issues/3799 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 5, 2019

[Pharo 8.0] Build #442: Lint review Tests in UnifiedFFI-Tests

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #442 was: FAILURE. The Pull Request #3797 was integrated: "Lint review Tests in UnifiedFFI-Tests" Pull request url: https://github.com/pharo-project/pharo/pull/3797 Issue Url: https://github.com/pharo-project/pharo/issues/3796 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 5, 2019

[Pharo 8.0] Build #441: Cleanup Polymorph-Widgets

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #441 was: FAILURE. The Pull Request #3784 was integrated: "Cleanup Polymorph-Widgets" Pull request url: https://github.com/pharo-project/pharo/pull/3784 Issue Url: https://github.com/pharo-project/pharo/issues/3783 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 5, 2019

Re: [Pharo-dev] Pharo source code formatting guide

by ducasse

> On 5 Jul 2019, at 17:09, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > Hi, > >> On 5 Jul 2019, at 08:57, Norbert Hartl <norbert(a)hartl.name> wrote: >> >> Sometimes I wonder when I change a piece of code in pharo if there is an official formatting guide line. Is the formatter in calypso the incarnation of it or how code is supposed to be formatted in the offical image? We are working on an enh of the formatter. - more tests (it was easy there was only one) - cleaning the settings/describing the settings - the goal is to be able to reformat all the code of the image Now in Pharo by example I have some examples. > We need a code style guide, yes. > But no, definitively the code formatter available should not be the canonical formatting (since its ugly and some times even illegible). > > Esteban > >> >> I just see tons of occurrences where caret immediately follows a token and such which I donât like at all. >> >> Norbert >> >> > >

July 5, 2019

[Pharo 8.0] Build #440: Cleanup HTTPProgress example

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #440 was: FAILURE. The Pull Request #3780 was integrated: "Cleanup HTTPProgress example" Pull request url: https://github.com/pharo-project/pharo/pull/3780 Issue Url: https://github.com/pharo-project/pharo/issues/3779 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 5, 2019

[Pharo 8.0] Build #439: Improve Athens-Cairo-Tests

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #439 was: FAILURE. The Pull Request #3793 was integrated: "Improve Athens-Cairo-Tests" Pull request url: https://github.com/pharo-project/pharo/pull/3793 Issue Url: https://github.com/pharo-project/pharo/issues/3791 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 5, 2019