March 2019 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] How to download a patched file?

by Eliot Miranda

Hi Gabriel, On Thu, Mar 21, 2019 at 1:15 PM Gabriel Cotelli <g.cotelli(a)gmail.com> wrote: > > https://raw.githubusercontent.com/OpenSmalltalk/opensmalltalk-vm/1a09bae437… > and save as ? > great. This works (provided one selects "Page Source"). But how did you get to that link? > > On Thu, Mar 21, 2019 at 5:01 PM Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > >> Hi GitHub mavens, >> >> how does one download a specific patched file from GitHub? I want >> to test Pablo's fix here: >> >> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 >> platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m >> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> >> >> I don't want to go through "View File", or clone, or anything else. I >> just want the file itself. How do I get it? >> >> _,,,^..^,,,_ >> best, Eliot >> > -- _,,,^..^,,,_ best, Eliot

March 21, 2019

Re: [Pharo-dev] How to download a patched file?

by Gabriel Cotelli

https://raw.githubusercontent.com/OpenSmalltalk/opensmalltalk-vm/1a09bae437… and save as ? On Thu, Mar 21, 2019 at 5:01 PM Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > Hi GitHub mavens, > > how does one download a specific patched file from GitHub? I want to > test Pablo's fix here: > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 > platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m > <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> > > I don't want to go through "View File", or clone, or anything else. I > just want the file itself. How do I get it? > > _,,,^..^,,,_ > best, Eliot >

March 21, 2019

How to download a patched file?

by Eliot Miranda

Hi GitHub mavens, how does one download a specific patched file from GitHub? I want to test Pablo's fix here: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> I don't want to go through "View File", or clone, or anything else. I just want the file itself. How do I get it? _,,,^..^,,,_ best, Eliot

March 21, 2019

Re: [Pharo-dev] Questions about DebugSession>>isContextPostMortem:

by Eliot Miranda

Hi Thomas, Hi Max, On Thu, Mar 21, 2019 at 3:35 AM Max Leske <maxleske(a)gmail.com> wrote: > On 21 Mar 2019, at 11:06, Thomas Dupriez wrote: > > Hi Thomas, > > > Hello, > > > > While looking at the DebugSession>>isContextPostMortem: method (code > > below), I got three questions: > > > > 1) There is a check for whether the suspendedContext (top context) of > > the process is nil. Does it even make sense for a process not to have > > any top context? > > Yes, only suspended processes have a suspendedContext. Also, the process > might have been terminated already. > > > > > 2) It seems that all the last 3 lines are doing is to check whether > > selectedContext is in the context chain of the process. Could they be > > rewritten into this simpler one-liner? `|^ (suspendedContext > > hasContext: selectedContext) not`| > > Yes, I think that would work. > > > > > 3) Overall, this method says that a context C is "post mortem" if the > > process controlled by the DebugSession has a top context and C is not > > in its context chain. That's the practical definition. Could someone > > shed some light on the high-level definition of "post mortem"? Because > > "post mortem" is like "after death", but the death of what? A context > > that merely belongs to another context chain would be considered "post > > mortem" by the practical definition, but there's no death in this > > case... > > || > > > > You can create a copy of a process' stack. That stack will behave like a > process in the debugger but it can't run, as the VM doesn't have a > process to which the context are attached, hence it's considered > post-mortem. > > > > > ``` > > > > |DebugSession>>isContextPostMortem: selectedContext "return whether > > we're inspecting a frozen exception without a process attached" | > > suspendedContext | suspendedContext := interruptedProcess > > suspendedContext. suspendedContext ifNil: [ ^ false ]. > > (suspendedContext == selectedContext) ifTrue: [ ^ false ]. ^ > > (suspendedContext findContextSuchThat: [:c | c sender == > > selectedContext]) isNil ``` | > In addition a context is post-mortem if its pc is nil, which at least in Squeak is answered by the Context>>isDead method. So I might look at writing that method as DebugSession>>isContextPostMortem: selectedContext "Answer if we're inspecting a frozen exception without a process attached." ^selectedContext isDead or: [(interruptedProcess suspendedContext hasContext: selectedContext) not] > > > > Does someone know the answer to some (or all) of these questions? > > > > Thomas > > > Hope that helps. > > Max > > -- _,,,^..^,,,_ best, Eliot

March 21, 2019

Re: [Pharo-dev] Missing tests for FFI in CI

by ducasse

Hello Stefan Can you report the exact call you were doing? I talked with G and Pablo and the bug they fixed is not the same. Now they would like to experiment and write tests for all the platform. Stef > On 21 Mar 2019, at 08:00, Stephan Eggermont <stephan(a)stack.nl> wrote: > > Yesterday, we tracked down a serious issue in 64 bit FFI. After giving up > with our own code, we made a fresh start with the latest base image and > OSWindows. We were finally able to figure out what went wrong with two > simple tests that were failing in 64 bit that worked correctly in 32 bit. > > FFIConstantHandleType externalType is the wrong size > > After confirming that and making it work, we were told that a number of FFI > fixes were done by Nicolas and Eliot in Squeak that did not get integrated > in Pharo. Applying the changes from the latest Squeak FFI resolved the > problem, and a few that we were unaware of. > > Stephan > > > >

March 21, 2019

Re: [Pharo-dev] Missing tests for FFI in CI

by ducasse

> On 21 Mar 2019, at 13:46, Tim Mackinnon <tim(a)testit.works> wrote: > > That is awesome - great work chasing all of that! > > Any idea of what kinds of things would have been impacted that we can all keep an eye out for or retest? > > Also, Is there anything useful we can add to our process to try and avoid this in the future? tests :) tests are the only way. >> On 21 Mar 2019, at 07:00, Stephan Eggermont <stephan(a)stack.nl> wrote: >> >> Yesterday, we tracked down a serious issue in 64 bit FFI. After giving up >> with our own code, we made a fresh start with the latest base image and >> OSWindows. We were finally able to figure out what went wrong with two >> simple tests that were failing in 64 bit that worked correctly in 32 bit. >> >> FFIConstantHandleType externalType is the wrong size >> >> After confirming that and making it work, we were told that a number of FFI >> fixes were done by Nicolas and Eliot in Squeak that did not get integrated >> in Pharo. Applying the changes from the latest Squeak FFI resolved the >> problem, and a few that we were unaware of. >> >> Stephan >> >> >> >> > >

March 21, 2019

[Pharo 8.0] Build #168: FAILURE

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #168 was: FAILURE. Could not extract further issue information from commit message: Update stale.yml lower stale period for issues: one month is enough Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

March 21, 2019

[Pharo 8.0] Build #167: Remove flaky test

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #167 was: SUCCESS. The Pull Request #2952 was integrated: "Remove flaky test" Pull request url: https://github.com/pharo-project/pharo/pull/2952 Issue Url: https://pharo.fogbugz.com/f/cases/patch Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

March 21, 2019

Re: [Pharo-dev] Missing tests for FFI in CI

by Tim Mackinnon

That is awesome - great work chasing all of that! Any idea of what kinds of things would have been impacted that we can all keep an eye out for or retest? Also, Is there anything useful we can add to our process to try and avoid this in the future? Tim Sent from my iPhone > On 21 Mar 2019, at 07:00, Stephan Eggermont <stephan(a)stack.nl> wrote: > > Yesterday, we tracked down a serious issue in 64 bit FFI. After giving up > with our own code, we made a fresh start with the latest base image and > OSWindows. We were finally able to figure out what went wrong with two > simple tests that were failing in 64 bit that worked correctly in 32 bit. > > FFIConstantHandleType externalType is the wrong size > > After confirming that and making it work, we were told that a number of FFI > fixes were done by Nicolas and Eliot in Squeak that did not get integrated > in Pharo. Applying the changes from the latest Squeak FFI resolved the > problem, and a few that we were unaware of. > > Stephan > > > >

March 21, 2019

Re: [Pharo-dev] About a better filedialog

by ducasse

> On 21 Mar 2019, at 10:14, Hilaire <hilaire(a)drgeo.eu> wrote: > > Peter's FileDialog looks so much better than FileList :) :) Stef > > Le 20/03/2019 Ã 20:09, ducasse a Ã©crit : >> I was thinking the FileList. >> Now I will look at the FileDialogWindow :) >> >> Stef > > -- > Dr. Geo > http://drgeo.eu > > >

March 21, 2019