June 2018 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] About the infinite debugger

by Ben Coman

On 29 June 2018 at 22:48, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > Hi all, > > during today's sprint we have been working with lots of people on the > infinite debugger problem (https://pharo.fogbugz.com/f/cases/22085/) We > have checked the emails sent in the latest month. Then, together with > Quentin, Pablo, Pavel, Yoan we have been discussing and testing hypothesis > all day. We have been also comparing the debuggers code between pharo 3/4 > (where the bug was is present) and pharo 7, but this was not necessarily > straight forward as the code is not the same and there is no easy diff... > > AAAAND, we have found that the problem may come from a wrong pragma > marker. Just removing that pragma gives us back the same behaviour as in > Pharo 3/4. :D > > https://github.com/pharo-project/pharo/pull/1621 > > I know that the exception handling/debugging has been modified several > times in the latest years (some refactorings, hiding contexts...), we > unfortunately don't have tests for it, so I'd like some more pair of eyes > on it. Ben, Martin could you take a look? > > Thanks all for the fish, > Guille > I'm just about to fly out for a family vacation, so I'm not sure when I'll get a chance to have a good look. But I read the issue on Fogbugz and it echos some things I've been thinking recently, though I hadn't come close to that particular fix. I think my following comments are probably unrelated, but just sharing some thoughts that crossed my mind when I was looking into my own similar trouble. This is an area I'm not clear on and would like to understand better... When the UI thread (UI1) needs to be debugged (e.g. code run from Playground, or a test) and is suspended and a new UI thread (UI2) is started, which thread does the debugger run in? I guess it must run in UI2 but sometimes I got the vague feeling some parts of it were caught in UI1 and affected by UI1 being suspended. But perhaps I got the wrong impression - its a complex interplay to follow. The other vague notion I had was when thread UI1 is resumed, it seems to replace thread UI2 where the World keeps its, and wondered if <StepOver> on the suspended-debug-UI1 thread somehow made it "resume" and so replace UI2 as the main thread, but then UI1 gets suspended again and the display freezes. Thanks for everyones efforts on this. cheers -ben

June 29, 2018

Re: [Pharo-dev] [rmod] About the infinite debugger

by ClÃ©ment Bera

Hi, Normally the pull request should break the exception tests, especially the ones with nested handler, since they are the reason 199 marked signalling contexts were introduced. Looking quickly this test in latest Pharo 7 for example: ExceptionTests>>testHandlerContext fails with the pull request. Since the pull request changes a green test into a red test, I don't understand why you say "we unfortunately don't have tests for it". I don't understand either why you say this pragma is "wrong", so I can't help with that either. Best, On Fri, Jun 29, 2018 at 4:48 PM, Guillermo Polito <guillermopolito(a)gmail.com > wrote: > Hi all, > > during today's sprint we have been working with lots of people on the > infinite debugger problem (https://pharo.fogbugz.com/f/cases/22085/) We > have checked the emails sent in the latest month. Then, together with > Quentin, Pablo, Pavel, Yoan we have been discussing and testing hypothesis > all day. We have been also comparing the debuggers code between pharo 3/4 > (where the bug was is present) and pharo 7, but this was not necessarily > straight forward as the code is not the same and there is no easy diff... > > AAAAND, we have found that the problem may come from a wrong pragma > marker. Just removing that pragma gives us back the same behaviour as in > Pharo 3/4. :D > > https://github.com/pharo-project/pharo/pull/1621 > > I know that the exception handling/debugging has been modified several > times in the latest years (some refactorings, hiding contexts...), we > unfortunately don't have tests for it, so I'd like some more pair of eyes > on it. Ben, Martin could you take a look? > > Thanks all for the fish, > Guille > -- ClÃ©ment BÃ©ra https://clementbera.github.io/ https://clementbera.wordpress.com/

June 29, 2018

[Pharo 7.0-dev] Build #1104: 22174-Remove-FileDoesNotExistExceptiondefaultAction

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1104 was: SUCCESS. The Pull Request #1573 was integrated: "22174-Remove-FileDoesNotExistExceptiondefaultAction" Pull request url: https://github.com/pharo-project/pharo/pull/1573 Issue Url: https://pharo.fogbugz.com/f/cases/22174 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 29, 2018

About the infinite debugger

by Guillermo Polito

Hi all, during today's sprint we have been working with lots of people on the infinite debugger problem (https://pharo.fogbugz.com/f/cases/22085/) We have checked the emails sent in the latest month. Then, together with Quentin, Pablo, Pavel, Yoan we have been discussing and testing hypothesis all day. We have been also comparing the debuggers code between pharo 3/4 (where the bug was is present) and pharo 7, but this was not necessarily straight forward as the code is not the same and there is no easy diff... AAAAND, we have found that the problem may come from a wrong pragma marker. Just removing that pragma gives us back the same behaviour as in Pharo 3/4. :D https://github.com/pharo-project/pharo/pull/1621 I know that the exception handling/debugging has been modified several times in the latest years (some refactorings, hiding contexts...), we unfortunately don't have tests for it, so I'd like some more pair of eyes on it. Ben, Martin could you take a look? Thanks all for the fish, Guille

June 29, 2018

[Pharo 7.0-dev] Build #1103: 22112-Remove-code-related-to-HostSystemMenus

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1103 was: FAILURE. The Pull Request #1518 was integrated: "22112-Remove-code-related-to-HostSystemMenus" Pull request url: https://github.com/pharo-project/pharo/pull/1518 Issue Url: https://pharo.fogbugz.com/f/cases/22112 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 29, 2018

[Pharo 7.0-dev] Build #1102: 21844-Window-fullscreen-size-should-be-dependent-on-world-size

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1102 was: SUCCESS. The Pull Request #1617 was integrated: "21844-Window-fullscreen-size-should-be-dependent-on-world-size" Pull request url: https://github.com/pharo-project/pharo/pull/1617 Issue Url: https://pharo.fogbugz.com/f/cases/21844 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 29, 2018

[Pharo 7.0-dev] Build #1101: 20579-Ring-Core-Containers-seems-to-be-loaded-twice

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1101 was: SUCCESS. The Pull Request #1615 was integrated: "20579-Ring-Core-Containers-seems-to-be-loaded-twice" Pull request url: https://github.com/pharo-project/pharo/pull/1615 Issue Url: https://pharo.fogbugz.com/f/cases/20579 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 29, 2018

[Pharo 7.0-dev] Build #1100: 22058-TabMorph-should-handle-wheel-click-and-close-itself-like-in-most-software-as-web-browsers

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1100 was: SUCCESS. The Pull Request #1482 was integrated: "22058-TabMorph-should-handle-wheel-click-and-close-itself-like-in-most-software-as-web-browsers" Pull request url: https://github.com/pharo-project/pharo/pull/1482 Issue Url: https://pharo.fogbugz.com/f/cases/22058 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 29, 2018

[Pharo 7.0-dev] Build #1099: 22228-Class-copy-and-duplicateClassWithNewName-should-be-correctly-implemented

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1099 was: SUCCESS. The Pull Request #1613 was integrated: "22228-Class-copy-and-duplicateClassWithNewName-should-be-correctly-implemented" Pull request url: https://github.com/pharo-project/pharo/pull/1613 Issue Url: https://pharo.fogbugz.com/f/cases/22228 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 29, 2018

[Pharo 7.0-dev] Build #1098: 22196 Cleanup TraitsV2-Tests

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1098 was: SUCCESS. The Pull Request #1588 was integrated: "22196 Cleanup TraitsV2-Tests" Pull request url: https://github.com/pharo-project/pharo/pull/1588 Issue Url: https://pharo.fogbugz.com/f/cases/22196 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 29, 2018